coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3292 discussions

[XS] Change in coreboot[main]: util/crossgcc: Update ACPICA from 20230628 to 20240321
by Felix Singer (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81671?usp=email ) Change subject: util/crossgcc: Update ACPICA from 20230628 to 20240321 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Blocking until 24.05 release -- To view, visit https://review.coreboot.org/c/coreboot/+/81671?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I41f56ba58af51b1ec1d7554fb35a49ccf9e778f6 Gerrit-Change-Number: 81671 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 13:40:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update ACPICA from 20230628 to 20240321
by Felix Singer (Code Review) 04 Apr '24

04 Apr '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81671?usp=email ) Change subject: util/crossgcc: Update ACPICA from 20230628 to 20240321 ...................................................................... util/crossgcc: Update ACPICA from 20230628 to 20240321 Change-Id: I41f56ba58af51b1ec1d7554fb35a49ccf9e778f6 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/crossgcc/buildgcc D util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum A util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/81671/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 3b64356..ae03d8a 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -40,7 +40,7 @@ MPC_VERSION=1.3.1 GCC_VERSION=13.2.0 BINUTILS_VERSION=2.42 -IASL_VERSION="20230628" +IASL_VERSION="20240321" # CLANG version number CLANG_VERSION=17.0.6 CMAKE_VERSION=3.28.3 @@ -74,7 +74,7 @@ MPC_BASE_URL="https://ftpmirror.gnu.org/mpc" GCC_BASE_URL="https://ftpmirror.gnu.org/gcc/gcc-${GCC_VERSION}" BINUTILS_BASE_URL="https://ftpmirror.gnu.org/binutils" -IASL_BASE_URL="https://downloadmirror.intel.com/783534" +IASL_BASE_URL="https://downloadmirror.intel.com/819451" # CLANG toolchain archive locations LLVM_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" CLANG_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" diff --git a/util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum b/util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum deleted file mode 100644 index 9b676bb..0000000 --- a/util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -3b893fb771cf3fbd3531de3036e1a5bfc624c9d2 tarballs/acpica-unix-20230628.tar.gz diff --git a/util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum b/util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum new file mode 100644 index 0000000..e7b7afe --- /dev/null +++ b/util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum @@ -0,0 +1 @@ +19f5b03de6de059a95432d17ed24095262a97aba tarballs/acpica-unix-20240321.tar.gz -- To view, visit https://review.coreboot.org/c/coreboot/+/81671?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I41f56ba58af51b1ec1d7554fb35a49ccf9e778f6 Gerrit-Change-Number: 81671 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: mb/google/brya: Create trulo variant
by Subrata Banik (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varshit Pandya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81627?usp=email ) Change subject: mb/google/brya: Create trulo variant ...................................................................... Patch Set 10: (4 comments) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/81627/comment/99893f84_280a5f10 : PS10, Line 498: select BOARD_GOOGLE_BASEBOARD_TRULO select SOC_INTEL_TWINLAKE File src/mainboard/google/brya/variants/trulo/memory/Makefile.mk: https://review.coreboot.org/c/coreboot/+/81627/comment/527bbbe3_88a42462 : PS10, Line 7: SPD_SOURCES += spd/lp5/set-0/spd-2.hex # ID = 0(0b0000) Parts = MT62F1G32D4DR-031 WT:B : SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 1(0b0001) Parts = MT62F512M32D2DR-031 WT:B empty File src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt: https://review.coreboot.org/c/coreboot/+/81627/comment/fd13648e_ad6b0373 : PS10, Line 7: MT62F1G32D4DR-031 WT:B 0 (0000) : MT62F512M32D2DR-031 WT:B 1 (0001) should be empty File src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt: https://review.coreboot.org/c/coreboot/+/81627/comment/ed2bfd8c_c743b315 : PS10, Line 12: MT62F1G32D4DR-031 WT:B : MT62F512M32D2DR-031 WT:B empty -- To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Gerrit-Change-Number: 81627 Gerrit-PatchSet: 10 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Apr 2024 13:09:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/brya: Add new baseboard trulo
by Subrata Banik (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varshit Pandya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email ) Change subject: mb/google/brya: Add new baseboard trulo ...................................................................... Patch Set 10: (4 comments) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/81626/comment/686af233_b59a3ef1 : PS10, Line 656: chromeos-nissa-16MiB-debugfsp.fmd chromeos-16MiB-debugfsp.fmd https://review.coreboot.org/c/coreboot/+/81626/comment/7b3f2ff6_04f151db : PS10, Line 657: chromeos-nissa-16MiB chromeos-16MiB.fmd https://review.coreboot.org/c/coreboot/+/81626/comment/0612e8bb_5c7851b4 : PS10, Line 658: default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-nissa-32MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_NISSA && BOARD_ROMSIZE_KB_32768 we can drop this https://review.coreboot.org/c/coreboot/+/81626/comment/4139d1a4_8f0e5e73 : PS10, Line 659: default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-16MiB-debugfsp.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_16384 && BUILDING_WITH_DEBUG_FSP : default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-16MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_16384 : default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-32MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_32768 do we really need yet another layout ? can't we use the same nissa layout. we can always drop `nissa` keyword from the file name -- To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Gerrit-Change-Number: 81626 Gerrit-PatchSet: 10 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Apr 2024 13:07:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/smmstore/ramstage.c: retry smmstore init up 5 times
by Patrick Rudolph (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Paul Menzel, Tim Crawford. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73981?usp=email ) Change subject: drivers/smmstore/ramstage.c: retry smmstore init up 5 times ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Alternative approach: https://review.coreboot.org/c/coreboot/+/79738 -- To view, visit https://review.coreboot.org/c/coreboot/+/73981?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab Gerrit-Change-Number: 73981 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 12:58:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: acpi: Move acpigen_write_OSC_pci_domain to Xeon-SP
by Lean Sheng Tan (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Jonathan Zhang, Lance Zhao, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81652?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: acpi: Move acpigen_write_OSC_pci_domain to Xeon-SP ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: will this also be used for AMD or arm server in the future? this is not Intel specific right? -- To view, visit https://review.coreboot.org/c/coreboot/+/81652?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia297e0a828f25b751032f18de04ec76f10131076 Gerrit-Change-Number: 81652 Gerrit-PatchSet: 1 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 12:54:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: acpi: Move acpigen_write_OSC_pci_domain to Xeon-SP
by Felix Held (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu, Tim Wawrzynczak. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81652?usp=email ) Change subject: acpi: Move acpigen_write_OSC_pci_domain to Xeon-SP ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > > since the acpi code seems to be part of the acpi spec […] good point -- To view, visit https://review.coreboot.org/c/coreboot/+/81652?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia297e0a828f25b751032f18de04ec76f10131076 Gerrit-Change-Number: 81652 Gerrit-PatchSet: 1 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 12:51:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp: Use default soc_get_ioapic_info
by Felix Held (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Shuo Liu. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81628?usp=email ) Change subject: soc/intel/xeon_sp: Use default soc_get_ioapic_info ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/xeon_sp/acpi.c: https://review.coreboot.org/c/coreboot/+/81628/comment/f2f02181_b79d40e7 : PS3, Line 93: #if CONFIG(XEON_SP_HAVE_IIO_IOAPIC) i'd say that moving the code inside the #if block into a separate c file and conditionally add that to the build that depending on CONFIG_XEON_SP_HAVE_IIO_IOAPIC would be a bit cleaner solution -- To view, visit https://review.coreboot.org/c/coreboot/+/81628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ecfba49cd9b4dfbb3f11d58d04d07ea1752a131 Gerrit-Change-Number: 81628 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 12:49:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/smmstore/ramstage.c: retry smmstore init up 5 times
by Michał Kopeć (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Krystian Hebel, Michał Żygowski, Patrick Rudolph, Paul Menzel, Tim Crawford. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73981?usp=email ) Change subject: drivers/smmstore/ramstage.c: retry smmstore init up 5 times ...................................................................... Patch Set 2: (1 comment) File src/drivers/smmstore/ramstage.c: https://review.coreboot.org/c/coreboot/+/73981/comment/6b7a4395_df146c50 : PS1, Line 79: } while (retry--); > Thank you. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73981?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab Gerrit-Change-Number: 73981 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 12:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/smmstore/ramstage.c: retry smmstore init up 5 times
by Paul Menzel (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Patrick Rudolph, Tim Crawford. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73981?usp=email ) Change subject: drivers/smmstore/ramstage.c: retry smmstore init up 5 times ...................................................................... Patch Set 2: (1 comment) File src/drivers/smmstore/ramstage.c: https://review.coreboot.org/c/coreboot/+/73981/comment/0613301e_40a01dfa : PS1, Line 79: } while (retry--); > @Paul I added info on how many retries were done to the error message. Thank you. Please feel free to mark comments as resolved yourself, once you think you addressed them. -- To view, visit https://review.coreboot.org/c/coreboot/+/73981?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab Gerrit-Change-Number: 73981 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 12:44:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024