coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3292 discussions

[XS] Change in coreboot[main]: arch/x86/bootblock.ld: Account for the .data section
by Arthur Heymans (Code Review) 04 Apr '24

04 Apr '24

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81434?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch/x86/bootblock.ld: Account for the .data section ...................................................................... arch/x86/bootblock.ld: Account for the .data section commit b7832de026 (x86: Add .data section support for pre-memory stages) added a data section to the bootblock. This needs to be accounted for in the linker script. Change-Id: I39abe499e5e9edbdacb1697c0a0fc347af3ef9c4 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81434 Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/arch/x86/bootblock.ld 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Jérémy Compostella: Looks good to me, approved diff --git a/src/arch/x86/bootblock.ld b/src/arch/x86/bootblock.ld index 6547985..73a3d18 100644 --- a/src/arch/x86/bootblock.ld +++ b/src/arch/x86/bootblock.ld @@ -26,7 +26,7 @@ INCLUDE "bootblock/lib/program.ld" - PROGRAM_SZ = SIZEOF(.text); + PROGRAM_SZ = SIZEOF(.text) + SIZEOF(.data); . = MIN(_ECFW_PTR, MIN(_ID_SECTION, _FIT_POINTER)) - EARLYASM_SZ; . = CONFIG(SIPI_VECTOR_IN_ROM) ? ALIGN(4096) : ALIGN(16); -- To view, visit https://review.coreboot.org/c/coreboot/+/81434?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39abe499e5e9edbdacb1697c0a0fc347af3ef9c4 Gerrit-Change-Number: 81434 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3
by Arthur Heymans (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Felix Singer, Martin L Roth, Zebreus. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80314?usp=email ) Change subject: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3 ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > Arthur, could you have a look on the Jenkins issues? https://review.coreboot.org/c/coreboot/+/81434 is likely needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/80314?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I03a44e0c23a925396f614f282882405dc886ba58 Gerrit-Change-Number: 80314 Gerrit-PatchSet: 9 Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 15:11:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update ACPICA from 20230628 to 20240321
by Felix Singer (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Martin L Roth. Hello Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81671?usp=email to look at the new patch set (#2). Change subject: util/crossgcc: Update ACPICA from 20230628 to 20240321 ...................................................................... util/crossgcc: Update ACPICA from 20230628 to 20240321 Change-Id: I41f56ba58af51b1ec1d7554fb35a49ccf9e778f6 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix-20240321_iasl.patch D util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum A util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum 4 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/81671/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81671?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I41f56ba58af51b1ec1d7554fb35a49ccf9e778f6 Gerrit-Change-Number: 81671 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y
by Benjamin Doron (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Angel Pons, Arthur Heymans, Paul Menzel. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81072?usp=email ) Change subject: soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81072/comment/6ebf0498_057cff45 : PS1, Line 7: Fix DEBUG_SMI compilation error > Yes. Thank you. Sure. Thanks, done. https://review.coreboot.org/c/coreboot/+/81072/comment/b872920c_39c2f1e4 : PS1, Line 10: addressing and initialising the SoC-specific UART. > Therefore, add uart. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7c6f2346d5f9ffb371d51d1de6f0b695acedf10 Gerrit-Change-Number: 81072 Gerrit-PatchSet: 2 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 04 Apr 2024 14:50:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y
by Benjamin Doron (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron. Hello Angel Pons, Arthur Heymans, Lean Sheng Tan, Marvin Drees, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81072?usp=email to look at the new patch set (#2). Change subject: soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y ...................................................................... soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y When DEBUG_SMI is selected, common code may use these helpers to handle addressing and initialising the SoC-specific UART. Therefore, add uart.c to be compiled into SMM. Change-Id: If7c6f2346d5f9ffb371d51d1de6f0b695acedf10 Signed-off-by: Benjamin Doron <benjamin.doron(a)9elements.com> --- M src/soc/amd/genoa_poc/Makefile.mk 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/81072/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7c6f2346d5f9ffb371d51d1de6f0b695acedf10 Gerrit-Change-Number: 81072 Gerrit-PatchSet: 2 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3
by Felix Singer (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Arthur Heymans, Martin L Roth, Zebreus. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80314?usp=email ) Change subject: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3 ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: Arthur, could you have a look on the Jenkins issues? -- To view, visit https://review.coreboot.org/c/coreboot/+/80314?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I03a44e0c23a925396f614f282882405dc886ba58 Gerrit-Change-Number: 80314 Gerrit-PatchSet: 9 Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Comment-Date: Thu, 04 Apr 2024 14:35:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya: Create trulo variant
by Dinesh Gehlot (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Varshit Pandya. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81627?usp=email ) Change subject: mb/google/brya: Create trulo variant ...................................................................... Patch Set 13: (4 comments) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/81627/comment/8ac4b779_b8a9636e : PS10, Line 498: select BOARD_GOOGLE_BASEBOARD_TRULO > select SOC_INTEL_TWINLAKE Acknowledged File src/mainboard/google/brya/variants/trulo/memory/Makefile.mk: https://review.coreboot.org/c/coreboot/+/81627/comment/da2daf59_6e45bbae : PS10, Line 7: SPD_SOURCES += spd/lp5/set-0/spd-2.hex # ID = 0(0b0000) Parts = MT62F1G32D4DR-031 WT:B : SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 1(0b0001) Parts = MT62F512M32D2DR-031 WT:B > empty Acknowledged File src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt: https://review.coreboot.org/c/coreboot/+/81627/comment/8b862d43_d5661c59 : PS10, Line 7: MT62F1G32D4DR-031 WT:B 0 (0000) : MT62F512M32D2DR-031 WT:B 1 (0001) > should be empty Acknowledged File src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt: https://review.coreboot.org/c/coreboot/+/81627/comment/6ec3a18d_a6b8aaf2 : PS10, Line 12: MT62F1G32D4DR-031 WT:B : MT62F512M32D2DR-031 WT:B > empty Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Gerrit-Change-Number: 81627 Gerrit-PatchSet: 13 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 04 Apr 2024 14:25:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya: Create trulo variant
by Dinesh Gehlot (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varshit Pandya. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81627?usp=email to look at the new patch set (#13). Change subject: mb/google/brya: Create trulo variant ...................................................................... mb/google/brya: Create trulo variant This patch adds a new variant trulo for the baseboard trulo. TEST=abuild -a -x -p none -t google/brya Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/trulo/include/variant/ec.h A src/mainboard/google/brya/variants/trulo/include/variant/gpio.h A src/mainboard/google/brya/variants/trulo/memory/Makefile.mk A src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/trulo/overridetree.cb 8 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/81627/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Gerrit-Change-Number: 81627 Gerrit-PatchSet: 13 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: util/crossgcc: Link libLLVM dynamically reducing build time with ccache
by Felix Singer (Code Review) 04 Apr '24

04 Apr '24

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81673?usp=email ) Change subject: util/crossgcc: Link libLLVM dynamically reducing build time with ccache ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/81673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I62d4e3fd8ce7f54bd12b1e62eca4beb1259c3da8 Gerrit-Change-Number: 81673 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[main]: mb/google/brya: Create trulo variant
by Dinesh Gehlot (Code Review) 04 Apr '24

04 Apr '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varshit Pandya. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81627?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/brya: Create trulo variant ...................................................................... mb/google/brya: Create trulo variant This patch adds a new variant trulo for the baseboard trulo. TEST=abuild -a -x -p none -t google/brya Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/trulo/include/variant/ec.h A src/mainboard/google/brya/variants/trulo/include/variant/gpio.h A src/mainboard/google/brya/variants/trulo/memory/Makefile.mk A src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/trulo/overridetree.cb 8 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/81627/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Gerrit-Change-Number: 81627 Gerrit-PatchSet: 12 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024