Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81560?usp=email )
Change subject: mb/google/screebo: Add FW_CONFIG and device for VPU
......................................................................
mb/google/screebo: Add FW_CONFIG and device for VPU
BUG=b:332488817
TEST=set and unset bit20 in HW_CONFIG and check if VPU(0b.0)
is enabled when bit20 is set, and disabled when cleared
Change-Id: I6d7b35dbf8ac9b0abb42f64a947b4bb94f3c6b0f
Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81560
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Subrata Banik <subratabanik(a)google.com>
Reviewed-by: Varshit Pandya <pandyavarshit(a)gmail.com>
Reviewed-by: Daniel Kang <daniel.h.kang(a)intel.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Subrata Banik: Looks good to me, approved
build bot (Jenkins): Verified
Varshit Pandya: Looks good to me, but someone else must approve
Daniel Kang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb
index c66b5cb..fdfe984 100644
--- a/src/mainboard/google/rex/variants/screebo/overridetree.cb
+++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb
@@ -30,6 +30,10 @@
option WIFI_SAR_ID_0 0
option WIFI_SAR_ID_1 1
end
+ field VPU 22
+ option VPU_DIS 0
+ option VPU_EN 1
+ end
end
chip soc/intel/meteorlake
@@ -598,5 +602,8 @@
end
end
end
+ device ref vpu on
+ probe VPU VPU_EN
+ end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/81560?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6d7b35dbf8ac9b0abb42f64a947b4bb94f3c6b0f
Gerrit-Change-Number: 81560
Gerrit-PatchSet: 3
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Daniel Kang <daniel.h.kang(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: YH Lin <yueherngl(a)google.com>
Gerrit-MessageType: merged
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81673?usp=email )
Change subject: util/crossgcc: Link libLLVM dynamically reducing build time with ccache
......................................................................
util/crossgcc: Link libLLVM dynamically reducing build time with ccache
When coreboot is built with Clang and ccache enabled, the build time is
incredibly long and it feels like that an existing cache is not used for
the build. This is not the case though since the statistics created by
ccache proof that the cache is used.
While tracking down the issue, it led to our configuration of the build
system, which configures the ccache option `CCACHE_COMPILERCHECK` and
sets it to `content`. Enabling this option makes ccache including the
state of the compiler binary in the hash in some way. While the default
configuration (`mtime`) only includes the modification time and file
size, the mode `content` hashes the compiler binary instead. Depending
on its file size, the time to calculate the hash might vary a lot.
Looking at the current sizes of the compiler binaries, it's 1.4 MB for
GCC and 155 MB for Clang.
However, the huge file size for the Clang binary originates from that
libLLVM is linked statically. Linking libLLVM dynamically reduces the
file size of the Clang binary to 195 KB.
The build times compared without and with this patch using Clang as
compiler with ccache enabled and QEMU Q35 with payload disabled:
Static, no cache (first build)
real 1m45.128s
user 0m42.828s
sys 1m2.428s
Static, with cache (second build)
real 1m17.927s
user 0m22.290s
sys 0m55.842s
Dynamic, no cache (first build)
real 0m32.648s
user 0m24.244s
sys 0m8.609s
Dynamic, with cache (second build)
real 0m3.635s
user 0m2.250s
sys 0m1.630s
Change-Id: I62d4e3fd8ce7f54bd12b1e62eca4beb1259c3da8
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/crossgcc/buildgcc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81673/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index b1cb02c..3dd8d63 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -890,6 +890,7 @@
-DLLVM_INCLUDE_EXAMPLES="OFF" \
-DCMAKE_BUILD_TYPE=Release \
-DLLVM_TARGETS_TO_BUILD="AArch64;ARM;PowerPC;RISCV;X86" \
+ -DLLVM_LINK_LLVM_DYLIB="ON" \
../llvm || touch .failed
# shellcheck disable=SC2086
$MAKE $JOBS || touch .failed
--
To view, visit https://review.coreboot.org/c/coreboot/+/81673?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I62d4e3fd8ce7f54bd12b1e62eca4beb1259c3da8
Gerrit-Change-Number: 81673
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: newchange
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varshit Pandya.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81627?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/brya: Create trulo variant
......................................................................
mb/google/brya: Create trulo variant
This patch adds a new variant trulo for the baseboard trulo.
TEST=abuild -a -x -p none -t google/brya
Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
A src/mainboard/google/brya/variants/trulo/include/variant/ec.h
A src/mainboard/google/brya/variants/trulo/include/variant/gpio.h
A src/mainboard/google/brya/variants/trulo/memory/Makefile.mk
A src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt
A src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
A src/mainboard/google/brya/variants/trulo/overridetree.cb
8 files changed, 59 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/81627/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d
Gerrit-Change-Number: 81627
Gerrit-PatchSet: 11
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varshit Pandya.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81626?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/brya: Add new baseboard trulo
......................................................................
mb/google/brya: Add new baseboard trulo
This patch adds a new baseboard trulo. This commit is a stub which
only adds the minimum code needed for a successful build.
TEST=abuild -a -x -p none -t google/brya
Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/mainboard/google/brya/Kconfig
R src/mainboard/google/brya/chromeos-16MiB-debugfsp.fmd
R src/mainboard/google/brya/chromeos-16MiB.fmd
R src/mainboard/google/brya/chromeos-32MiB.fmd
A src/mainboard/google/brya/variants/baseboard/trulo/Makefile.mk
A src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb
A src/mainboard/google/brya/variants/baseboard/trulo/gpio.c
A src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/ec.h
A src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h
A src/mainboard/google/brya/variants/baseboard/trulo/memory.c
10 files changed, 134 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/81626/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d
Gerrit-Change-Number: 81626
Gerrit-PatchSet: 11
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81672?usp=email )
Change subject: util/crossgcc: Update CMake from 3.28.3 to 3.29.1
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Blocking until release 24.05
--
To view, visit https://review.coreboot.org/c/coreboot/+/81672?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf2d4f579d987fbfd4187ae41c1be5cec55e0e8e
Gerrit-Change-Number: 81672
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 04 Apr 2024 13:44:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Hello Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81672?usp=email
to look at the new patch set (#2).
Change subject: util/crossgcc: Update CMake from 3.28.3 to 3.29.1
......................................................................
util/crossgcc: Update CMake from 3.28.3 to 3.29.1
Change-Id: Iaf2d4f579d987fbfd4187ae41c1be5cec55e0e8e
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.28.3.tar.gz.cksum
A util/crossgcc/sum/cmake-3.29.1.tar.gz.cksum
3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/81672/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81672?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf2d4f579d987fbfd4187ae41c1be5cec55e0e8e
Gerrit-Change-Number: 81672
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Zebreus.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80314?usp=email )
Change subject: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
Blocking until 24.05 release
--
To view, visit https://review.coreboot.org/c/coreboot/+/80314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03a44e0c23a925396f614f282882405dc886ba58
Gerrit-Change-Number: 80314
Gerrit-PatchSet: 9
Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Comment-Date: Thu, 04 Apr 2024 13:40:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80314?usp=email )
Change subject: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/80314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03a44e0c23a925396f614f282882405dc886ba58
Gerrit-Change-Number: 80314
Gerrit-PatchSet: 9
Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 04 Apr 2024 13:40:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment