coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[S] Change in coreboot[main]: MAINTAINERS: sort INTEL SoC alphabetically
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81677?usp=email ) Change subject: MAINTAINERS: sort INTEL SoC alphabetically ...................................................................... MAINTAINERS: sort INTEL SoC alphabetically Place METEORLAKE SoC in alphabetical order. Change-Id: Ic04163e746ee3e450e58563abbf994e6aa44e69d Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81677 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M MAINTAINERS 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Elyes Haouas: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index 49160c1..1f2458f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -884,16 +884,6 @@ S: Odd Fixes F: src/soc/amd/stoneyridge/ -INTEL METEORLAKE SOC -M: Subrata Banik <subratabanik(a)google.com> -M: Tarun Tuli <tstuli(a)gmail.com> -M: Kapil Porwal <kapilporwal(a)google.com> -M: Jakub Czapiga <czapiga(a)google.com> -M: Eran Mitrani <mitrani(a)google.com> -M: Dinesh Gehlot <digehlot(a)google.com> -S: Maintained -F: src/soc/intel/meteorlake/ - INTEL ALDERLAKE SOC M: Subrata Banik <subratabanik(a)google.com> M: Nick Vaccaro <nvaccaro(a)chromium.org> @@ -931,6 +921,16 @@ S: Maintained F: src/soc/intel/elkhartlake/ +INTEL METEORLAKE SOC +M: Subrata Banik <subratabanik(a)google.com> +M: Tarun Tuli <tstuli(a)gmail.com> +M: Kapil Porwal <kapilporwal(a)google.com> +M: Jakub Czapiga <czapiga(a)google.com> +M: Eran Mitrani <mitrani(a)google.com> +M: Dinesh Gehlot <digehlot(a)google.com> +S: Maintained +F: src/soc/intel/meteorlake/ + INTEL TIGERLAKE SOC M: Subrata Banik <subratabanik(a)google.com> M: Nick Vaccaro <nvaccaro(a)chromium.org> -- To view, visit https://review.coreboot.org/c/coreboot/+/81677?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic04163e746ee3e450e58563abbf994e6aa44e69d Gerrit-Change-Number: 81677 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: drivers/acpi/thermal_zone: Correct Kelvin constant used for conversion
by Nicholas Sudsgaard (Code Review) 06 Apr '24

06 Apr '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81197?usp=email to look at the new patch set (#2). Change subject: drivers/acpi/thermal_zone: Correct Kelvin constant used for conversion ...................................................................... drivers/acpi/thermal_zone: Correct Kelvin constant used for conversion As 0C is 273.15K you could argue that 2731 and 2732 are both correct. However, 2732 is deemed as correct both throughout the codebase and in the ACPI specification[1]. [1]: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/11_Thermal_Management/thermal… Change-Id: I845bc750681c7ae6f2d1342b32983b990ce6d296 Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> --- M src/drivers/acpi/thermal_zone/thermal_zone.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/81197/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I845bc750681c7ae6f2d1342b32983b990ce6d296 Gerrit-Change-Number: 81197 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81642?usp=email ) Change subject: scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond ...................................................................... scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond Change-Id: I5aa097bf1098be31ad829209a6f4aa5e050a0c19 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/81642/1 diff --git a/Makefile.mk b/Makefile.mk index d7110a9..7aa92af 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -500,13 +500,12 @@ CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie CFLAGS_common += -Wstring-compare ifeq ($(CONFIG_COMPILER_GCC),y) -CFLAGS_common += -Wold-style-declaration +CFLAGS_common += -Wold-style-declaration -Wnull-dereference -Wlogical-op -Wduplicated-cond # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) CFLAGS_common += -Wno-packed-not-aligned CFLAGS_common += -fconserve-stack -CFLAGS_common += -Wnull-dereference -CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wno-array-compare +CFLAGS_common += -Wno-array-compare endif endif -- To view, visit https://review.coreboot.org/c/coreboot/+/81642?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5aa097bf1098be31ad829209a6f4aa5e050a0c19 Gerrit-Change-Number: 81642 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: util/crossgcc: Update GCC from 13.2 to 14-20240331
by Felix Singer (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Elyes Haouas, Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81683?usp=email ) Change subject: util/crossgcc: Update GCC from 13.2 to 14-20240331 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > GCC 14 has not been released yet You are right, but the release is planned for April. So I've just marked it with the release tag so that it's not forgotten. -- To view, visit https://review.coreboot.org/c/coreboot/+/81683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf5912d1fcdfabab7fe006b7e0cd4ebd25c07d09 Gerrit-Change-Number: 81683 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 06 Apr 2024 07:07:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/crossgcc: Update GCC from 13.2 to 14-20240331
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81683?usp=email ) Change subject: util/crossgcc: Update GCC from 13.2 to 14-20240331 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: > Blocking until 24. […] GCC 14 has not been released yet -- To view, visit https://review.coreboot.org/c/coreboot/+/81683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf5912d1fcdfabab7fe006b7e0cd4ebd25c07d09 Gerrit-Change-Number: 81683 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Apr 2024 07:03:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/crossgcc: Update GCC from 13.2 to 14-20240331
by Felix Singer (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81683?usp=email ) Change subject: util/crossgcc: Update GCC from 13.2 to 14-20240331 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Blocking until 24.05 release -- To view, visit https://review.coreboot.org/c/coreboot/+/81683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf5912d1fcdfabab7fe006b7e0cd4ebd25c07d09 Gerrit-Change-Number: 81683 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Apr 2024 07:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: lib/program.ld: Account for large code model sections
by Felix Singer (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81675?usp=email ) Change subject: lib/program.ld: Account for large code model sections ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81675?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib755673dfa9e71172bbef0a5aec075154c89a97b Gerrit-Change-Number: 81675 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 06 Apr 2024 06:41:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/intel/fsp2_0: Introduce fsp print helper macros
by Subrata Banik (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Andrey Petrov, Appukuttan V K, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Ronak Kanabar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81630?usp=email ) Change subject: drivers/intel/fsp2_0: Introduce fsp print helper macros ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Done. I am still verifying changes in the MTL x32 and x64 please rebase after you have tested wisely using 32-bit and 64-bit recipe. -- To view, visit https://review.coreboot.org/c/coreboot/+/81630?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If6342c4d40c76b702351070e424797c21138a4a9 Gerrit-Change-Number: 81630 Gerrit-PatchSet: 5 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 06 Apr 2024 06:39:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86: Link page tables in stage if possible
by Subrata Banik (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Arthur Heymans. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80337?usp=email ) Change subject: cpu/x86: Link page tables in stage if possible ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: > Thankyou @arthur. Above mentioned patch was not part of the build as it is not yet mirrored to the chromium repo. Tried adding it still failed. Then added a fixed number as suggested then it is building. https://review.coreboot.org/c/coreboot/+/81680 we have filled an internal bug as well b/332445618 to follow on the fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/80337?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied54b66b930187cba5fbc578a81ed5859a616562 Gerrit-Change-Number: 80337 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 06 Apr 2024 06:32:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile: Enable Warray-bounds command option
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81640?usp=email ) Change subject: Makefile: Enable Warray-bounds command option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/81640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I827c23dd08fb42348d1b5eadba360561662fc330 Gerrit-Change-Number: 81640 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024