coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[L] Change in coreboot[main]: mb/dell/optiplex_9020: Implement late HWM initialization
by Máté Kukri (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Varshit Pandya. Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email ) Change subject: mb/dell/optiplex_9020: Implement late HWM initialization ...................................................................... Patch Set 3: (1 comment) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/81529/comment/27a06f32_ada6a705 : PS1, Line 10: > This patch isn't yet enough and is WIP This was now corrected and tested with prime 95 stress test on my OptiPlex 7020 SFF. The fans ramp up as expected. -- To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Gerrit-Change-Number: 81529 Gerrit-PatchSet: 3 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Apr 2024 22:14:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com> Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81642?usp=email ) Change subject: scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Did you test this with scan-build? yes, build tested for QEMU x86 q35/ich9 However, with and without current patch we have this error: error: unknown target CPU 'i686' note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, rocketlake, icelake-server, tigerlake, sapphirerapids, alderlake, raptorlake, meteorlake, arrowlake, arrowlake-s, lunarlake, gracemont, pantherlake, sierraforest, grandridge, graniterapids, graniterapids-d, emeraldrapids, clearwaterforest, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, znver4, x86-64, x86-64-v2, x86-64-v3, x86-64-v4 -- To view, visit https://review.coreboot.org/c/coreboot/+/81642?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5aa097bf1098be31ad829209a6f4aa5e050a0c19 Gerrit-Change-Number: 81642 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Apr 2024 21:09:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: lenovo/haswell: enable ONBOARD_VGA_IS_PRIMARY
by Leah Rowe (Code Review) 06 Apr '24

06 Apr '24

Leah Rowe has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81645?usp=email ) Change subject: lenovo/haswell: enable ONBOARD_VGA_IS_PRIMARY ...................................................................... lenovo/haswell: enable ONBOARD_VGA_IS_PRIMARY Haswell ThinkPads have Nvidia Optimus wired in on some models. With recent coreboot changes, legacy VGA decode is now disabled on the iGPU, and the iGPU itself is disabled, when a dGPU is present. This is a problem on Optimus laptops, because it means that the Intel GPU would be effectively disabled, when it is the one that has to handle the framebuffer. On these boards, you can enable ONBOARD_VGA_IS_PRIMARY so that coreboot does not disable the iGPU. This is because on Optimus laptops, the Nvidia GPU is only used for offloaded rendering. Enable ONBOARD_VGA_IS_PRIMARY by default on these boards. Change-Id: I8f1e0ca2861d1cc9a9ad41e7c9257aeca1a62a31 Signed-off-by: Leah Rowe <info(a)minifree.org> --- M src/mainboard/lenovo/haswell/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/81645/1 diff --git a/src/mainboard/lenovo/haswell/Kconfig b/src/mainboard/lenovo/haswell/Kconfig index b874452..a5c8054 100644 --- a/src/mainboard/lenovo/haswell/Kconfig +++ b/src/mainboard/lenovo/haswell/Kconfig @@ -60,6 +60,10 @@ default "ThinkPad T440p" if BOARD_LENOVO_THINKPAD_T440P default "ThinkPad W541" if BOARD_LENOVO_THINKPAD_W541 +config ONBOARD_VGA_IS_PRIMARY + bool + default y + config VGA_BIOS_ID string default "8086,0416" if BOARD_LENOVO_THINKPAD_T440P -- To view, visit https://review.coreboot.org/c/coreboot/+/81645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f1e0ca2861d1cc9a9ad41e7c9257aeca1a62a31 Gerrit-Change-Number: 81645 Gerrit-PatchSet: 1 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: nb/haswell: Fully disable iGPU when dGPU is used
by Leah Rowe (Code Review) 06 Apr '24

06 Apr '24

Leah Rowe has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81644?usp=email ) Change subject: nb/haswell: Fully disable iGPU when dGPU is used ...................................................................... nb/haswell: Fully disable iGPU when dGPU is used My earlier patch disabled decode *and* disabled the iGPU itself, but a subsequent revision disabled only VGA decode. Upon revisiting, I found that, actually, yes, you also need to disable the iGPU entirely. Tested on Dell 9020 SFF using broadwell MRC, with both iGPU and dGPU. With this patch, the iGPU is completely disabled when you install a graphics card, but the iGPU is available to use when no graphics card is present. For more context, see: Author: Leah Rowe <info(a)minifree.org> Date: Fri Feb 23 13:33:31 2024 +0000 nb/haswell: Disable iGPU when dGPU is used And now, look at the Gerrit comments for explanation: https://review.coreboot.org/c/coreboot/+/80717/ So, my original submission on change 80717 was actually correct. This patch fixes the issue. I tested on iGPU and dGPU, with both broadwell and haswell mrc.bin. Change-Id: I944123d41ba0e69d74de424e655de33691089c85 Signed-off-by: Leah Rowe <info(a)minifree.org> --- M src/northbridge/intel/haswell/gma.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/81644/1 diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 48a0ba5..f0b8488 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -465,6 +465,9 @@ { /* Disable VGA decode */ pci_or_config16(pcidev_on_root(0, 0), GGC, 1 << 1); + + /* Required or else the graphics card doesn't work */ + dev->enabled = 0; } static struct device_operations gma_func0_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/81644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I944123d41ba0e69d74de424e655de33691089c85 Gerrit-Change-Number: 81644 Gerrit-PatchSet: 1 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond
by Felix Singer (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Elyes Haouas, Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81642?usp=email ) Change subject: scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Did you test this with scan-build? -- To view, visit https://review.coreboot.org/c/coreboot/+/81642?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5aa097bf1098be31ad829209a6f4aa5e050a0c19 Gerrit-Change-Number: 81642 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 06 Apr 2024 10:14:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: device: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81454?usp=email ) Change subject: device: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81454?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f9495057c046b8de5b5f699f5bf38bb8e2795e4 Gerrit-Change-Number: 81454 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: lib: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81456?usp=email ) Change subject: lib: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81456?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94ee6bf38ecfcb620255a5a44edb2543fb519736 Gerrit-Change-Number: 81456 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: sb: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81464?usp=email ) Change subject: sb: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81464?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib7fcca7dcf7daec0254f687b2a8e9a908f28a1aa Gerrit-Change-Number: 81464 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: nb: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81458?usp=email ) Change subject: nb: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia926daa46cba120bc659db8f3dd3df75b0e7ed44 Gerrit-Change-Number: 81458 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: mb/intel: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81483?usp=email ) Change subject: mb/intel: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81483?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5c713c7a83dfbf1beee1ea6b30e6245dfedc0eb1 Gerrit-Change-Number: 81483 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024