coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XS] Change in coreboot[main]: ec/starlabs: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81481?usp=email ) Change subject: ec/starlabs: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81481?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia80d6894cf8d20f67fa94bff92de21d917431d27 Gerrit-Change-Number: 81481 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: mb/protectli: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81486?usp=email ) Change subject: mb/protectli: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81486?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa0655acda0482bb219145ba149d962e06017d9e Gerrit-Change-Number: 81486 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: soc/samsung: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81471?usp=email ) Change subject: soc/samsung: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81471?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0df5d5fb7ad4b11acedc963d7658b6c9c68aca7 Gerrit-Change-Number: 81471 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: soc/nvidia: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81490?usp=email ) Change subject: soc/nvidia: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I81bc764821b8bc5cb731bf18eebcb6f7c9c9be73 Gerrit-Change-Number: 81490 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: soc/sifive: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81491?usp=email ) Change subject: soc/sifive: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81491?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2820a02bb97c22042349bdd0241b95a6d51e5f79 Gerrit-Change-Number: 81491 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: mb/siemens: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81487?usp=email ) Change subject: mb/siemens: Remove blank lines before '}' and after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81487?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibcb3cbb81616fc2449303ae2477daf939cd65fb6 Gerrit-Change-Number: 81487 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: util/intelp2m: Avoid adding blank line after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81547?usp=email ) Change subject: util/intelp2m: Avoid adding blank line after '{' ...................................................................... Abandoned see #81455 -- To view, visit https://review.coreboot.org/c/coreboot/+/81547?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8105734b1b4776d0eb01b13c80e21e130719fe83 Gerrit-Change-Number: 81547 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[main]: tree: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Christian Walter, Elyes Haouas, Uwe Poeche. Hello Christian Walter, Uwe Poeche, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81455?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Uwe Poeche, Verified+1 by build bot (Jenkins) Change subject: tree: Remove blank lines before '}' and after '{' ...................................................................... tree: Remove blank lines before '}' and after '{' Change-Id: I46a362270f69d0a4a28e5bb9c954f34d632815ff Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/device/mmio.c M src/device/pci_device.c M src/device/resource_allocator_v4.c M src/drivers/efi/efivars.c M src/drivers/i2c/ptn3460/chip.h M src/drivers/i2c/tpm/cr50.c M src/drivers/i2c/tpm/tpm.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/smmstore/store.c M src/ec/starlabs/merlin/ite.c M src/lib/coreboot_table.c M src/lib/edid.c M src/lib/hardwaremain.c M src/lib/memrange.c M src/lib/region_file.c M src/lib/stack.c M src/mainboard/intel/adlrvp/gpio.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c M src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/memory.c M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c M src/mainboard/intel/kblrvp/ramstage.c M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/hda_verb.h M src/mainboard/intel/kunimitsu/spd/spd_util.c M src/mainboard/intel/mtlrvp/fw_config.c M src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/tglrvp/romstage_fsp_params.c M src/mainboard/protectli/vault_bsw/gpio.c M src/mainboard/protectli/vault_cml/gpio.c M src/mainboard/protectli/vault_ehl/gpio.h M src/mainboard/siemens/fa_ehl/variants/fa_ehl/gpio.c M src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c M src/mainboard/siemens/mc_apl1/variants/mc_apl1/gpio.c M src/mainboard/siemens/mc_apl1/variants/mc_apl2/gpio.c M src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c M src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c M src/mainboard/siemens/mc_apl1/variants/mc_apl6/gpio.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl1/memory.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/gpio.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/memory.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl3/gpio.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl3/memory.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl4/memory.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl5/gpio.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl5/memory.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/gm45/memmap.c M src/northbridge/intel/haswell/acpi.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/i440bx/memmap.c M src/northbridge/intel/i440bx/raminit.c M src/northbridge/intel/i945/early_init.c M src/northbridge/intel/i945/gma.c M src/northbridge/intel/i945/raminit.c M src/northbridge/intel/i945/rcven.c M src/northbridge/intel/ironlake/northbridge.c M src/northbridge/intel/ironlake/raminit.c M src/northbridge/intel/pineview/memmap.c M src/northbridge/intel/sandybridge/raminit.c M src/northbridge/intel/sandybridge/raminit_common.c M src/northbridge/intel/sandybridge/raminit_mrc.c M src/northbridge/intel/sandybridge/raminit_native.c M src/northbridge/intel/x4x/raminit.c M src/soc/nvidia/tegra/dc.h M src/soc/nvidia/tegra124/dp.c M src/soc/nvidia/tegra124/include/soc/sdram_param.h M src/soc/nvidia/tegra124/sor.c M src/soc/nvidia/tegra210/addressmap.c M src/soc/nvidia/tegra210/dp.c M src/soc/nvidia/tegra210/include/soc/funitcfg.h M src/soc/nvidia/tegra210/include/soc/sdram_param.h M src/soc/nvidia/tegra210/mipi-phy.c M src/soc/nvidia/tegra210/sdram.c M src/soc/nvidia/tegra210/sor.c M src/soc/samsung/exynos5250/clock_init.c M src/soc/samsung/exynos5250/dp-reg.c M src/soc/samsung/exynos5420/dmc_init_ddr3.c M src/soc/samsung/exynos5420/dp.c M src/soc/sifive/fu540/ux00ddr.h M src/southbridge/intel/common/pciehp.c M src/southbridge/intel/common/smbus.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/i82371eb/fadt.c M src/southbridge/intel/i82801gx/sata.c M src/southbridge/intel/i82801ix/pcie.c M src/southbridge/intel/i82801jx/pcie.c M src/southbridge/intel/i82870/pcibridge.c M src/southbridge/intel/lynxpoint/pcie.c M src/southbridge/ricoh/rl5c476/rl5c476.c M src/southbridge/ti/pci1x2x/pci1x2x.c M util/intelp2m/parser/parser.go 96 files changed, 3 insertions(+), 132 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/81455/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46a362270f69d0a4a28e5bb9c954f34d632815ff Gerrit-Change-Number: 81455 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: drivers/acpi/thermal_zone: Correct Kelvin constant used for conversion
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Nicholas Sudsgaard. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81197?usp=email ) Change subject: drivers/acpi/thermal_zone: Correct Kelvin constant used for conversion ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Regarding the BIPM (https://www.bipm.org) the t/°C = T/K − 273.15 :p -- To view, visit https://review.coreboot.org/c/coreboot/+/81197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I845bc750681c7ae6f2d1342b32983b990ce6d296 Gerrit-Change-Number: 81197 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Comment-Date: Sat, 06 Apr 2024 09:13:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond
by Elyes Haouas (Code Review) 06 Apr '24

06 Apr '24

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81642?usp=email ) Change subject: scan-build: Don't skip Wnull-dereference Wlogical-op Wduplicated-cond ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/81642?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5aa097bf1098be31ad829209a6f4aa5e050a0c19 Gerrit-Change-Number: 81642 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Apr 2024 09:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024