coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XS] Change in coreboot[main]: mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
by Yang Wu (Code Review) 08 Apr '24

08 Apr '24

Yang Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81752?usp=email ) Change subject: mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP ...................................................................... mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP Set orientation of KD_KD101NE3_40TI to LB_FB_ORIENTATION_RIGHT_UP to align the volume up/down direction with menu up/down in FW screen. BUG=b:331870701 TEST=emerge-staryu coreboot chromeos-bootimage BRANCH=corsola Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/panel_wugtrio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/81752/1 diff --git a/src/mainboard/google/corsola/panel_wugtrio.c b/src/mainboard/google/corsola/panel_wugtrio.c index 3405c0d..d1cfbcd 100644 --- a/src/mainboard/google/corsola/panel_wugtrio.c +++ b/src/mainboard/google/corsola/panel_wugtrio.c @@ -32,7 +32,7 @@ .power_on = mipi_panel_power_on, .name = "KD_KD101NE3_40TI", .disp_path = DISP_PATH_MIPI, - .orientation = LB_FB_ORIENTATION_LEFT_UP, + .orientation = LB_FB_ORIENTATION_RIGHT_UP, }, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/81752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb Gerrit-Change-Number: 81752 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Add iio_ioapic.c
by Patrick Rudolph (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81681?usp=email ) Change subject: soc/intel/xeon_sp: Add iio_ioapic.c ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/xeon_sp/iio_ioapic.c: https://review.coreboot.org/c/coreboot/+/81681/comment/699fc26d_e4017b73 : PS1, Line 30: XEON_SP_HAVE_IIO_IOAPIC condition is always false -- To view, visit https://review.coreboot.org/c/coreboot/+/81681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I59022b7685539491604724ef3b550da1cfd53f13 Gerrit-Change-Number: 81681 Gerrit-PatchSet: 1 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 07:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y
by Felix Held (Code Review) 07 Apr '24

07 Apr '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81072?usp=email ) Change subject: soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y ...................................................................... soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y When DEBUG_SMI is selected, common code may use these helpers to handle addressing and initialising the SoC-specific UART. Therefore, add uart.c to be compiled into SMM. Change-Id: If7c6f2346d5f9ffb371d51d1de6f0b695acedf10 Signed-off-by: Benjamin Doron <benjamin.doron(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81072 Reviewed-by: Marvin Drees <marvin.drees(a)9elements.com> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/amd/genoa_poc/Makefile.mk 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Angel Pons: Looks good to me, approved Felix Held: Looks good to me, approved build bot (Jenkins): Verified Marvin Drees: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved diff --git a/src/soc/amd/genoa_poc/Makefile.mk b/src/soc/amd/genoa_poc/Makefile.mk index 01bbe7b..94cee34 100644 --- a/src/soc/amd/genoa_poc/Makefile.mk +++ b/src/soc/amd/genoa_poc/Makefile.mk @@ -22,6 +22,7 @@ ramstage-y += mca.c smm-y += smihandler.c +smm-$(CONFIG_DEBUG_SMI) += uart.c CPPFLAGS_common += -I$(src)/soc/amd/genoa_poc/acpi CPPFLAGS_common += -I$(src)/soc/amd/genoa_poc/include -- To view, visit https://review.coreboot.org/c/coreboot/+/81072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7c6f2346d5f9ffb371d51d1de6f0b695acedf10 Gerrit-Change-Number: 81072 Gerrit-PatchSet: 4 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: MAINTAINERS: take Genoa/Onyx rename into account
by Felix Held (Code Review) 07 Apr '24

07 Apr '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81679?usp=email ) Change subject: MAINTAINERS: take Genoa/Onyx rename into account ...................................................................... MAINTAINERS: take Genoa/Onyx rename into account When soc/amd/genoa was renamed to soc/amd/genoa_poc and mb/amd/onyx was renamed to mb/amd/onyx_poc, the MAINTAINERS file wasn't updated, so no reviewers were added automatically to patches on Gerrit that change things in soc/amd/genoa_poc or mb/amd/onyx_poc. Fix this by updating the folder names in the MAINTAINERS file too. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ib52781ebc98bd2ce9df495526cfaf9d884aace50 Reviewed-on: https://review.coreboot.org/c/coreboot/+/81679 Reviewed-by: Varshit Pandya <pandyavarshit(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M MAINTAINERS 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Varshit Pandya: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index 1f2458f..2963ab4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -154,7 +154,7 @@ M: Martin Roth <gaumless(a)gmail.com> M: Varshit Pandya <pandyavarshit(a)gmail.com> S: Maintained -F: src/mainboard/amd/onyx/ +F: src/mainboard/amd/onyx_poc/ AMD reference boards outside of family 17h and 19h S: Odd Fixes @@ -840,12 +840,12 @@ S: Maintained F: src/soc/amd/common/ -AMD Genoa +AMD Genoa Proof of Concept M: Felix Held <felix-coreboot(a)felixheld.de> M: Martin Roth <gaumless(a)gmail.com> M: Varshit Pandya <pandyavarshit(a)gmail.com> S: Maintained -F: src/soc/amd/genoa/ +F: src/soc/amd/genoa_poc/ AMD Mendocino M: Felix Held <felix-coreboot(a)felixheld.de> -- To view, visit https://review.coreboot.org/c/coreboot/+/81679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib52781ebc98bd2ce9df495526cfaf9d884aace50 Gerrit-Change-Number: 81679 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Only write register on Ivy Bridge
by Felix Held (Code Review) 07 Apr '24

07 Apr '24

Attention is currently required from: Angel Pons, Patrick Rudolph, Paul Menzel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79761?usp=email ) Change subject: nb/intel/sandybridge/raminit: Only write register on Ivy Bridge ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79761?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie14ea06d744b1a8368d32803c6c1ccfb1262532e Gerrit-Change-Number: 79761 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 07 Apr 2024 11:29:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: lenovo/haswell: enable ONBOARD_VGA_IS_PRIMARY
by Nico Huber (Code Review) 07 Apr '24

07 Apr '24

Attention is currently required from: Alexander Couzens, Leah Rowe. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81645?usp=email ) Change subject: lenovo/haswell: enable ONBOARD_VGA_IS_PRIMARY ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Maybe worth mentioning: the dGPU is only not considered onboard because it isn't mentioned in the devicetree. Otherwise, both GPUs would be onboard and we couldn't say which one would be chosen. -- To view, visit https://review.coreboot.org/c/coreboot/+/81645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f1e0ca2861d1cc9a9ad41e7c9257aeca1a62a31 Gerrit-Change-Number: 81645 Gerrit-PatchSet: 1 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 07 Apr 2024 10:04:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Add iio_ioapic.c
by Patrick Rudolph (Code Review) 07 Apr '24

07 Apr '24

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81681?usp=email ) Change subject: soc/intel/xeon_sp: Add iio_ioapic.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I59022b7685539491604724ef3b550da1cfd53f13 Gerrit-Change-Number: 81681 Gerrit-PatchSet: 1 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 07 Apr 2024 10:03:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: nb/haswell: Fully disable iGPU when dGPU is used
by Patrick Rudolph (Code Review) 07 Apr '24

07 Apr '24

Attention is currently required from: Angel Pons, Leah Rowe. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81644?usp=email ) Change subject: nb/haswell: Fully disable iGPU when dGPU is used ...................................................................... Patch Set 1: (1 comment) File src/northbridge/intel/haswell/gma.c: https://review.coreboot.org/c/coreboot/+/81644/comment/7b5b5fba_29cb5cee : PS1, Line 469: Required It works when it's disabled? That might need additional context. -- To view, visit https://review.coreboot.org/c/coreboot/+/81644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I944123d41ba0e69d74de424e655de33691089c85 Gerrit-Change-Number: 81644 Gerrit-PatchSet: 1 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Comment-Date: Sun, 07 Apr 2024 10:03:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/*: Drop unused header file console/console.h
by cong yang (Code Review) 07 Apr '24

07 Apr '24

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, Yu-Ping Wu. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81685?usp=email ) Change subject: mb/google/*: Drop unused header file console/console.h ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If3689afe532b63384b7905116c44c598e5fa13ee Gerrit-Change-Number: 81685 Gerrit-PatchSet: 1 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sun, 07 Apr 2024 08:03:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/mediatek/common/include/soc: Include header file for check_member
by cong yang (Code Review) 07 Apr '24

07 Apr '24

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, Yu-Ping Wu. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81684?usp=email ) Change subject: soc/mediatek/common/include/soc: Include header file for check_member ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I266571686e452e2b7514afee42ff0a48f8891831 Gerrit-Change-Number: 81684 Gerrit-PatchSet: 1 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sun, 07 Apr 2024 08:02:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024