coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3667 discussions

[XS] Change in coreboot[main]: arch/x86: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 30 Mar '24

30 Mar '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81453?usp=email ) Change subject: arch/x86: Remove blank lines before '}' and after '{' ...................................................................... arch/x86: Remove blank lines before '}' and after '{' Change-Id: I1bb4a052a4e74850660944b687c21e817eb437b2 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81453 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> --- M src/arch/x86/exception.c M src/arch/x86/include/arch/cpu.h M src/arch/x86/include/arch/smp/spinlock.h M src/arch/x86/ioapic.c M src/arch/x86/memmove_32.c M src/arch/x86/pirq_routing.c 6 files changed, 0 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Jérémy Compostella: Looks good to me, but someone else must approve diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c index e2d585f..b8f0583 100644 --- a/src/arch/x86/exception.c +++ b/src/arch/x86/exception.c @@ -369,7 +369,6 @@ stub_flush(); } while ((stub_getc() & 0x7f) != '+'); - } #endif /* CONFIG_GDB_STUB */ diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index cfffac0..430d1de 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -213,7 +213,6 @@ c->x86 += (tfms >> 20) & 0xff; if (c->x86 >= 0x6) c->x86_model += ((tfms >> 16) & 0xF) << 4; - } /* REP NOP (PAUSE) is a good thing to insert into busy-wait loops. */ diff --git a/src/arch/x86/include/arch/smp/spinlock.h b/src/arch/x86/include/arch/smp/spinlock.h index cb25531..3819c8f 100644 --- a/src/arch/x86/include/arch/smp/spinlock.h +++ b/src/arch/x86/include/arch/smp/spinlock.h @@ -55,7 +55,6 @@ /* Switching contexts while holding a spinlock will lead to deadlocks */ thread_coop_disable(); - } static __always_inline void spin_unlock(spinlock_t *lock) diff --git a/src/arch/x86/ioapic.c b/src/arch/x86/ioapic.c index 863317f..5bb2adb5 100644 --- a/src/arch/x86/ioapic.c +++ b/src/arch/x86/ioapic.c @@ -140,7 +140,6 @@ for (i = 0; i < 3; i++) printk(BIOS_SPEW, " reg 0x%04x: 0x%08x\n", i, io_apic_read(ioapic_base, i)); - } u8 get_ioapic_id(uintptr_t ioapic_base) diff --git a/src/arch/x86/memmove_32.c b/src/arch/x86/memmove_32.c index 387a77e..7c2529d 100644 --- a/src/arch/x86/memmove_32.c +++ b/src/arch/x86/memmove_32.c @@ -196,5 +196,4 @@ : "memory"); return ret; - } diff --git a/src/arch/x86/pirq_routing.c b/src/arch/x86/pirq_routing.c index 7244536..e6f3b80 100644 --- a/src/arch/x86/pirq_routing.c +++ b/src/arch/x86/pirq_routing.c @@ -125,7 +125,6 @@ /* Set PCI IRQs. */ for (i = 0; i < num_entries; i++) { - u8 bus = pirq_tbl->slots[i].bus; u8 devfn = pirq_tbl->slots[i].devfn; @@ -133,7 +132,6 @@ devfn >> 3, pirq_tbl->slots[i].slot); for (intx = 0; intx < MAX_INTX_ENTRIES; intx++) { - int link = pirq_tbl->slots[i].irq[intx].link; int bitmap = pirq_tbl->slots[i].irq[intx].bitmap; int irq = 0; @@ -142,7 +140,6 @@ 'A' + intx, link, bitmap); if (!bitmap || !link || link > CONFIG_MAX_PIRQ_LINKS) { - printk(BIOS_DEBUG, "not routed\n"); irq_slot[intx] = irq; continue; -- To view, visit https://review.coreboot.org/c/coreboot/+/81453?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1bb4a052a4e74850660944b687c21e817eb437b2 Gerrit-Change-Number: 81453 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: security/tpm: replace CONFIG(TPMx) checks with runtime check
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Sergii Dmytruk. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69161?usp=email ) Change subject: security/tpm: replace CONFIG(TPMx) checks with runtime check ...................................................................... Patch Set 36: (1 comment) File src/drivers/tpm/ppi.c: https://review.coreboot.org/c/coreboot/+/69161/comment/8bee93cc_0a154090 : PS36, Line 574: BIOS_WARN > How does this even compile? BIOS_WARN isn't defined. https://review.coreboot.org/c/coreboot/+/81590 -- To view, visit https://review.coreboot.org/c/coreboot/+/69161?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id9cc25aad8d1d7bfad12b7a92059b1b3641bbfa9 Gerrit-Change-Number: 69161 Gerrit-PatchSet: 36 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jan Samek <samekh(a)email.cz> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sat, 30 Mar 2024 06:43:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/tpm: Make it compile again
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Patrick Rudolph has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/81590?usp=email ) Change subject: drivers/tpm: Make it compile again ...................................................................... drivers/tpm: Make it compile again Fix regression introduced in 47e9e8cde1810ee9f249027b14ee9f82a7a52d84 "security/tpm: replace CONFIG(TPMx) checks with runtime check": Replace BIOS_WARN with BIOS_WARNING. Change-Id: Id23cda2f5403effd2a4bda3852f0f300d0e62cdf Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/drivers/tpm/ppi.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/81590/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81590?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id23cda2f5403effd2a4bda3852f0f300d0e62cdf Gerrit-Change-Number: 81590 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: configs: Build test CONFIG_TPM_PPI
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81591?usp=email ) Change subject: configs: Build test CONFIG_TPM_PPI ...................................................................... configs: Build test CONFIG_TPM_PPI Add build test for CONFIG_TPM_PPI. Change-Id: I191c501d31c564b1a5dcfba79459f63ca84984d0 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M configs/config.msi_ms7d25_ddr5 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/81591/1 diff --git a/configs/config.msi_ms7d25_ddr5 b/configs/config.msi_ms7d25_ddr5 index e26e99e..f0e6704 100644 --- a/configs/config.msi_ms7d25_ddr5 +++ b/configs/config.msi_ms7d25_ddr5 @@ -17,5 +17,6 @@ CONFIG_EDK2_SD_MMC_TIMEOUT=1000 CONFIG_TPM2=y CONFIG_TPM_MEASURED_BOOT=y +CONFIG_TPM_PPI=y CONFIG_DRIVERS_GENERIC_CBFS_SERIAL=y CONFIG_DRIVERS_GENERIC_CBFS_UUID=y -- To view, visit https://review.coreboot.org/c/coreboot/+/81591?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I191c501d31c564b1a5dcfba79459f63ca84984d0 Gerrit-Change-Number: 81591 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: drivers/tpm: Make it compile again
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81590?usp=email ) Change subject: drivers/tpm: Make it compile again ...................................................................... drivers/tpm: Make it compile again Replace BIOS_WARN with BIOS_WARNING. Change-Id: Id23cda2f5403effd2a4bda3852f0f300d0e62cdf Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/drivers/tpm/ppi.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/81590/1 diff --git a/src/drivers/tpm/ppi.c b/src/drivers/tpm/ppi.c index d63b8f8..2ce1d07 100644 --- a/src/drivers/tpm/ppi.c +++ b/src/drivers/tpm/ppi.c @@ -571,7 +571,7 @@ enum tpm_family family = tlcl_get_family(); if (family == TPM_UNKNOWN) { - printk(BIOS_WARN, "PPI: %s: aborting, because no TPM detected\n", __func__); + printk(BIOS_WARNING, "PPI: %s: aborting, because no TPM detected\n", __func__); return; } @@ -726,7 +726,7 @@ family = tlcl_get_family(); if (family == TPM_UNKNOWN) { - printk(BIOS_WARN, "PPI: %s: aborting, because no TPM detected\n", __func__); + printk(BIOS_WARNING, "PPI: %s: aborting, because no TPM detected\n", __func__); return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/81590?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id23cda2f5403effd2a4bda3852f0f300d0e62cdf Gerrit-Change-Number: 81590 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: security/tpm: replace CONFIG(TPMx) checks with runtime check
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Sergii Dmytruk. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69161?usp=email ) Change subject: security/tpm: replace CONFIG(TPMx) checks with runtime check ...................................................................... Patch Set 36: (1 comment) File src/drivers/tpm/ppi.c: https://review.coreboot.org/c/coreboot/+/69161/comment/bd271097_dfbdfa7e : PS36, Line 574: BIOS_WARN How does this even compile? BIOS_WARN isn't defined. -- To view, visit https://review.coreboot.org/c/coreboot/+/69161?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id9cc25aad8d1d7bfad12b7a92059b1b3641bbfa9 Gerrit-Change-Number: 69161 Gerrit-PatchSet: 36 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jan Samek <samekh(a)email.cz> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sat, 30 Mar 2024 06:33:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Angel Pons, Paul Menzel. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79784?usp=email ) Change subject: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/sandybridge/raminit_common.c: https://review.coreboot.org/c/coreboot/+/79784/comment/7429776d_be5d6edd : PS1, Line 787: srt = dimm->flags.ext_temp_refresh && !dimm->flags.asr; > As the assignment is the same, use only one if branch? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79784?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id2773d3ae8c6c48193a23174086f62617335a7af Gerrit-Change-Number: 79784 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 30 Mar 2024 06:12:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG to match MRC.bin
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Angel Pons, Arthur Heymans, Felix Singer, Maximilian Brune, Paul Menzel. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79759?usp=email ) Change subject: nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG to match MRC.bin ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79759/comment/f37883f9_2ea3c669 : PS1, Line 7: Update PM_DLL_CONFIG > … to match MRC. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79759?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf6334814c5748e5a3691a572213f433c79f382d Gerrit-Change-Number: 79759 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 30 Mar 2024 06:12:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Angel Pons, Patrick Rudolph. Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79784?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge ...................................................................... nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge On Sandy Bridge the MRC.bin sets bit SRT in register TC_MR2_SHADOW as well as it's currently done on Ivy Bridge. Tested on Lenovo X220: Still boots and works fine. Change-Id: Id2773d3ae8c6c48193a23174086f62617335a7af Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/79784/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79784?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id2773d3ae8c6c48193a23174086f62617335a7af Gerrit-Change-Number: 79784 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG to match MRC.bin
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Angel Pons, Arthur Heymans, Felix Singer, Maximilian Brune, Patrick Rudolph, Paul Menzel. Hello Angel Pons, Arthur Heymans, Felix Singer, Maximilian Brune, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79759?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Verified+1 by build bot (Jenkins) Change subject: nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG to match MRC.bin ...................................................................... nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG to match MRC.bin A register dump between native and MRC.bin raminit showed a difference in the PM_DLL_CONFIG register. Use the same value as MRC.bin uses. Tested on Lenovo X220: Still boots and works fine. Change-Id: Iaf6334814c5748e5a3691a572213f433c79f382d Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/79759/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79759?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf6334814c5748e5a3691a572213f433c79f382d Gerrit-Change-Number: 79759 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024