coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: acpi: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 30 Mar '24

30 Mar '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81452?usp=email ) Change subject: acpi: Remove blank lines before '}' and after '{' ...................................................................... acpi: Remove blank lines before '}' and after '{' Change-Id: I9ba061fe0b1396ccc1597e26685a6b4e312e3549 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81452 Tested-by: build bot (Jenkins) <no-… [View More]reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/acpi/acpi.c M src/acpi/acpigen.c M src/acpi/device.c M src/acpi/gnvs.c 4 files changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 30a07bf..c33d195 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1506,7 +1506,6 @@ */ for (int i = 0; existing_rsdt->entry[i]; i++) acpi_add_table(rsdp, (void *)(uintptr_t)existing_rsdt->entry[i]); - } /* Add BOOT0000 for Linux google firmware driver */ diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 257bd52..9c04e84 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -1880,7 +1880,6 @@ acpigen_write_return_singleton_buffer(0x0); acpigen_write_if_end(); /* If (LEqual (Local0, ToUUID(uuid))) */ - } /* diff --git a/src/acpi/device.c b/src/acpi/device.c index 368b86c..7fe5a37 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -1158,7 +1158,6 @@ acpi_dp_add_array(dp, gpio); return gpio; - } diff --git a/src/acpi/gnvs.c b/src/acpi/gnvs.c index 827cd2d..1e5d746 100644 --- a/src/acpi/gnvs.c +++ b/src/acpi/gnvs.c @@ -30,7 +30,6 @@ if (dnvs_size) dnvs = (char *)gnvs + gnvs_size; - } BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_EXIT, acpi_create_gnvs, NULL); -- To view, visit https://review.coreboot.org/c/coreboot/+/81452?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ba061fe0b1396ccc1597e26685a6b4e312e3549 Gerrit-Change-Number: 81452 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged [View Less]

1 0

[XS] Change in coreboot[main]: arch/x86: Remove blank lines before '}' and after '{'
by Elyes Haouas (Code Review) 30 Mar '24

30 Mar '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81453?usp=email ) Change subject: arch/x86: Remove blank lines before '}' and after '{' ...................................................................... arch/x86: Remove blank lines before '}' and after '{' Change-Id: I1bb4a052a4e74850660944b687c21e817eb437b2 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81453 Tested-by: build bot (Jenkins) &… [View More]lt;no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> --- M src/arch/x86/exception.c M src/arch/x86/include/arch/cpu.h M src/arch/x86/include/arch/smp/spinlock.h M src/arch/x86/ioapic.c M src/arch/x86/memmove_32.c M src/arch/x86/pirq_routing.c 6 files changed, 0 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Jérémy Compostella: Looks good to me, but someone else must approve diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c index e2d585f..b8f0583 100644 --- a/src/arch/x86/exception.c +++ b/src/arch/x86/exception.c @@ -369,7 +369,6 @@ stub_flush(); } while ((stub_getc() & 0x7f) != '+'); - } #endif /* CONFIG_GDB_STUB */ diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index cfffac0..430d1de 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -213,7 +213,6 @@ c->x86 += (tfms >> 20) & 0xff; if (c->x86 >= 0x6) c->x86_model += ((tfms >> 16) & 0xF) << 4; - } /* REP NOP (PAUSE) is a good thing to insert into busy-wait loops. */ diff --git a/src/arch/x86/include/arch/smp/spinlock.h b/src/arch/x86/include/arch/smp/spinlock.h index cb25531..3819c8f 100644 --- a/src/arch/x86/include/arch/smp/spinlock.h +++ b/src/arch/x86/include/arch/smp/spinlock.h @@ -55,7 +55,6 @@ /* Switching contexts while holding a spinlock will lead to deadlocks */ thread_coop_disable(); - } static __always_inline void spin_unlock(spinlock_t *lock) diff --git a/src/arch/x86/ioapic.c b/src/arch/x86/ioapic.c index 863317f..5bb2adb5 100644 --- a/src/arch/x86/ioapic.c +++ b/src/arch/x86/ioapic.c @@ -140,7 +140,6 @@ for (i = 0; i < 3; i++) printk(BIOS_SPEW, " reg 0x%04x: 0x%08x\n", i, io_apic_read(ioapic_base, i)); - } u8 get_ioapic_id(uintptr_t ioapic_base) diff --git a/src/arch/x86/memmove_32.c b/src/arch/x86/memmove_32.c index 387a77e..7c2529d 100644 --- a/src/arch/x86/memmove_32.c +++ b/src/arch/x86/memmove_32.c @@ -196,5 +196,4 @@ : "memory"); return ret; - } diff --git a/src/arch/x86/pirq_routing.c b/src/arch/x86/pirq_routing.c index 7244536..e6f3b80 100644 --- a/src/arch/x86/pirq_routing.c +++ b/src/arch/x86/pirq_routing.c @@ -125,7 +125,6 @@ /* Set PCI IRQs. */ for (i = 0; i < num_entries; i++) { - u8 bus = pirq_tbl->slots[i].bus; u8 devfn = pirq_tbl->slots[i].devfn; @@ -133,7 +132,6 @@ devfn >> 3, pirq_tbl->slots[i].slot); for (intx = 0; intx < MAX_INTX_ENTRIES; intx++) { - int link = pirq_tbl->slots[i].irq[intx].link; int bitmap = pirq_tbl->slots[i].irq[intx].bitmap; int irq = 0; @@ -142,7 +140,6 @@ 'A' + intx, link, bitmap); if (!bitmap || !link || link > CONFIG_MAX_PIRQ_LINKS) { - printk(BIOS_DEBUG, "not routed\n"); irq_slot[intx] = irq; continue; -- To view, visit https://review.coreboot.org/c/coreboot/+/81453?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1bb4a052a4e74850660944b687c21e817eb437b2 Gerrit-Change-Number: 81453 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged [View Less]

1 0

[M] Change in coreboot[main]: security/tpm: replace CONFIG(TPMx) checks with runtime check
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Sergii Dmytruk. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69161?usp=email ) Change subject: security/tpm: replace CONFIG(TPMx) checks with runtime check ...................................................................... Patch Set 36: (1 comment) File src/drivers/tpm/ppi.c: https://review.coreboot.org/c/coreboot/+/69161/comment/8bee93cc_0a154090 : PS36, Line 574: BIOS_WARN > How does this … [View More]

1 0

[XS] Change in coreboot[main]: drivers/tpm: Make it compile again
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Patrick Rudolph has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/81590?usp=email ) Change subject: drivers/tpm: Make it compile again ...................................................................... drivers/tpm: Make it compile again Fix regression introduced in 47e9e8cde1810ee9f249027b14ee9f82a7a52d84 "security/tpm: replace CONFIG(TPMx) checks with runtime check": Replace BIOS_WARN with BIOS_WARNING. Change-Id: Id23cda2f5403effd2a4bda3852f0f300d0e62cdf … [View More]

1 0

[XS] Change in coreboot[main]: configs: Build test CONFIG_TPM_PPI
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81591?usp=email ) Change subject: configs: Build test CONFIG_TPM_PPI ...................................................................... configs: Build test CONFIG_TPM_PPI Add build test for CONFIG_TPM_PPI. Change-Id: I191c501d31c564b1a5dcfba79459f63ca84984d0 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M configs/config.msi_ms7d25_ddr5 1 file changed, 1 insertion(… [View More]

1 0

[XS] Change in coreboot[main]: drivers/tpm: Make it compile again
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81590?usp=email ) Change subject: drivers/tpm: Make it compile again ...................................................................... drivers/tpm: Make it compile again Replace BIOS_WARN with BIOS_WARNING. Change-Id: Id23cda2f5403effd2a4bda3852f0f300d0e62cdf Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/drivers/tpm/ppi.c 1 file changed, 2 insertions(+), 2 … [View More]

1 0

[M] Change in coreboot[main]: security/tpm: replace CONFIG(TPMx) checks with runtime check
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Sergii Dmytruk. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69161?usp=email ) Change subject: security/tpm: replace CONFIG(TPMx) checks with runtime check ...................................................................... Patch Set 36: (1 comment) File src/drivers/tpm/ppi.c: https://review.coreboot.org/c/coreboot/+/69161/comment/bd271097_dfbdfa7e : PS36, Line 574: BIOS_WARN How does this even … [View More]

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Angel Pons, Paul Menzel. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79784?usp=email ) Change subject: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/sandybridge/raminit_common.c: https://review.coreboot.org/c/coreboot/+/79784/comment/7429776d_be5d6edd : PS1, Line 787: … [View More]

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG to match MRC.bin
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Angel Pons, Arthur Heymans, Felix Singer, Maximilian Brune, Paul Menzel. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79759?usp=email ) Change subject: nb/intel/sandybridge/raminit: Update PM_DLL_CONFIG to match MRC.bin ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79759/comment/f37883f9_2ea3c669 … [View More]

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge
by Patrick Rudolph (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Angel Pons, Patrick Rudolph. Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79784?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge ...................................................................... nb/intel/… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024