coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Add tCPDED corner case
by Paul Menzel (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Angel Pons, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79762?usp=email ) Change subject: nb/intel/sandybridge/raminit: Add tCPDED corner case ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79762/comment/89ce8cda_5fe4289a : PS2, Line 9: SandyBridge Sandy Bridge https://review.coreboot.org/c/coreboot/+/79762/comment/d34ed1ba_f55a6612 : PS2, Line 10: Does this fix a bug, or did you just notice it reading some spec? Maybe document this? -- To view, visit https://review.coreboot.org/c/coreboot/+/79762?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5294173c02f06c601fdb13ed785ee33d7a4e3eca Gerrit-Change-Number: 79762 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 30 Mar 2024 10:51:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/crossgcc: Also build LLVM LD
by Felix Singer (Code Review) 30 Mar '24

30 Mar '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80732?usp=email ) Change subject: util/crossgcc: Also build LLVM LD ...................................................................... util/crossgcc: Also build LLVM LD When doing LTO the clang linker frontend needs to use LLD or gold. Build LLD as that is the configuration that is best tested. Change-Id: I3242585f8b5c3426fc6568d3dc47300164d56e3a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80732 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M util/crossgcc/buildgcc A util/crossgcc/sum/libunwind-17.0.6.src.tar.xz.cksum A util/crossgcc/sum/lld-17.0.6.src.tar.xz.cksum 3 files changed, 16 insertions(+), 5 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 9470fe3..0a0462e 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,11 +54,13 @@ BINUTILS_ARCHIVE="binutils-${BINUTILS_VERSION}.tar.xz" IASL_ARCHIVE="${IASL_VERSION}.tar.gz" # CLANG toolchain FILE locations +LLD_ARCHIVE="lld-${CLANG_VERSION}.src.tar.xz" LLVM_ARCHIVE="llvm-${CLANG_VERSION}.src.tar.xz" CLANG_ARCHIVE="clang-${CLANG_VERSION}.src.tar.xz" CRT_ARCHIVE="compiler-rt-${CLANG_VERSION}.src.tar.xz" CTE_ARCHIVE="clang-tools-extra-${CLANG_VERSION}.src.tar.xz" LLVMCMAKE_ARCHIVE="cmake-${CLANG_VERSION}.src.tar.xz" +LIBUNWIND_ARCHIVE="libunwind-${CLANG_VERSION}.src.tar.xz" CMAKE_ARCHIVE="cmake-${CMAKE_VERSION}.tar.gz" NASM_ARCHIVE="nasm-${NASM_VERSION}.tar.bz2" @@ -79,13 +81,16 @@ CRT_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" CTE_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" LLVMCMAKE_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" +LLD_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" +LIBUNWIND_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" CMAKE_BASE_URL="https://cmake.org/files/v${CMAKE_VERSION%.*}" NASM_BASE_URL="https://www.nasm.us/pub/nasm/releasebuilds/${NASM_VERSION}" ALL_ARCHIVES="$GMP_BASE_URL/$GMP_ARCHIVE $MPFR_BASE_URL/$MPFR_ARCHIVE $MPC_BASE_URL/$MPC_ARCHIVE \ $GCC_BASE_URL/$GCC_ARCHIVE $BINUTILS_BASE_URL/$BINUTILS_ARCHIVE $IASL_BASE_URL/$IASL_ARCHIVE \ - $LLVM_BASE_URL/$LLVM_ARCHIVE $CLANG_BASE_URL/$CLANG_ARCHIVE $LLVMCMAKE_BASE_URL/$LLVMCMAKE_ARCHIVE \ - $CRT_BASE_URL/$CRT_ARCHIVE $CTE_BASE_URL/$CTE_ARCHIVE $CMAKE_BASE_URL/$CMAKE_ARCHIVE $NASM_BASE_URL/$NASM_ARCHIVE" + $LLD_BASE_URL/$LLD_ARCHIVE $LLVM_BASE_URL/$LLVM_ARCHIVE $CLANG_BASE_URL/$CLANG_ARCHIVE \ + $LLVMCMAKE_BASE_URL/$LLVMCMAKE_ARCHIVE $CRT_BASE_URL/$CRT_ARCHIVE $CTE_BASE_URL/$CTE_ARCHIVE \ + $LIBUNWIND_BASE_URL/$LIBUNWIND_ARCHIVE $CMAKE_BASE_URL/$CMAKE_ARCHIVE $NASM_BASE_URL/$NASM_ARCHIVE" # GCC toolchain directories GMP_DIR="gmp-${GMP_VERSION}" @@ -97,11 +102,13 @@ BINUTILS_DIR="binutils-${BINUTILS_VERSION}" IASL_DIR="acpica-${IASL_VERSION}" # CLANG toolchain directories +LLD_DIR="lld-${CLANG_VERSION}.src" LLVM_DIR="llvm-${CLANG_VERSION}.src" CLANG_DIR="clang-${CLANG_VERSION}.src" CRT_DIR="compiler-rt-${CLANG_VERSION}.src" CTE_DIR="clang-tools-extra-${CLANG_VERSION}.src" LLVMCMAKE_DIR="cmake-${CLANG_VERSION}.src" +LIBUNWIND_DIR="libunwind-${CLANG_VERSION}.src" CMAKE_DIR="cmake-${CMAKE_VERSION}" NASM_DIR="nasm-${NASM_VERSION}" @@ -866,16 +873,18 @@ build_LLVM() { + ln -nsf "$LLD_DIR" ../lld ln -nsf "$LLVM_DIR" ../llvm ln -nsf "$CLANG_DIR" ../clang ln -nsf "$CTE_DIR" ../clang-tools-extra ln -nsf "$CRT_DIR" ../compiler-rt ln -nsf "$LLVMCMAKE_DIR" ../cmake + ln -nsf "$LIBUNWIND_DIR" ../libunwind $CMAKE -G "Unix Makefiles" \ -DCMAKE_INSTALL_PREFIX="$DESTDIR$TARGETDIR" \ -DCLANG_VENDOR="coreboot toolchain v$CROSSGCC_VERSION - " \ - -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt" \ + -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt;lld" \ -DLLVM_INCLUDE_BENCHMARKS="OFF" \ -DLLVM_INCLUDE_TESTS="OFF" \ -DLLVM_INCLUDE_EXAMPLES="OFF" \ @@ -886,7 +895,7 @@ $MAKE $JOBS || touch .failed $MAKE install || touch .failed - rm -f ../llvm ../clang ../clang-tools-extra ../compiler-rt ../cmake + rm -f ../llvm ../clang ../clang-tools-extra ../compiler-rt ../cmake ../lld ../libunwind cp -a ../$CLANG_DIR/tools/scan-build/* "$DESTDIR$TARGETDIR/bin" cp -a ../$CLANG_DIR/tools/scan-view/* "$DESTDIR$TARGETDIR/bin" @@ -1023,7 +1032,7 @@ CLANG|clang) NAME="LLVM clang" LLVM_VERSION=${CLANG_VERSION} - PACKAGES="CMAKE LLVM CLANG CRT CTE LLVMCMAKE" + PACKAGES="CMAKE LLVM CLANG CRT CTE LLVMCMAKE LLD LIBUNWIND" CMAKE=${DESTDIR}${TARGETDIR}/bin/cmake ;; IASL|iasl) diff --git a/util/crossgcc/sum/libunwind-17.0.6.src.tar.xz.cksum b/util/crossgcc/sum/libunwind-17.0.6.src.tar.xz.cksum new file mode 100644 index 0000000..e54b574 --- /dev/null +++ b/util/crossgcc/sum/libunwind-17.0.6.src.tar.xz.cksum @@ -0,0 +1 @@ +336b82602ec25a02bb987f44bd5ed990cb4c7f4a tarballs/libunwind-17.0.6.src.tar.xz diff --git a/util/crossgcc/sum/lld-17.0.6.src.tar.xz.cksum b/util/crossgcc/sum/lld-17.0.6.src.tar.xz.cksum new file mode 100644 index 0000000..0979dbd --- /dev/null +++ b/util/crossgcc/sum/lld-17.0.6.src.tar.xz.cksum @@ -0,0 +1 @@ +abe5d45ebea2b9994a5e6ed31268a2114f4fa14f tarballs/lld-17.0.6.src.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/80732?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3242585f8b5c3426fc6568d3dc47300164d56e3a Gerrit-Change-Number: 80732 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: util/crossgcc: Also build LLVM LD
by Felix Singer (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Arthur Heymans, Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80732?usp=email ) Change subject: util/crossgcc: Also build LLVM LD ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80732?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3242585f8b5c3426fc6568d3dc47300164d56e3a Gerrit-Change-Number: 80732 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 30 Mar 2024 10:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/xcompile: Use a more complete clang target
by Felix Singer (Code Review) 30 Mar '24

30 Mar '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80730?usp=email ) Change subject: util/xcompile: Use a more complete clang target ...................................................................... util/xcompile: Use a more complete clang target When the compiler is used as a linker frontend clang tries to match the target string with what it supports internally. If it's not sufficiently complete it will forward linking to GCC which is not desirable. This is necessary when doing LTO with clang. Change-Id: Ie9356a2bc0f5b77e934cc16482d6ccb1961195dc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80730 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/xcompile/xcompile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 68b3705..ad4361d 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -466,7 +466,7 @@ for clang_arch in $TCLIST invalid; do for clang_prefix in $search $XGCCPATH "$GENERIC_COMPILER_PREFIX"; do - testcc "${clang_prefix}clang" "-target ${clang_arch}-$TABI -c" && break 2 + testcc "${clang_prefix}clang" "-target ${clang_arch}-none-unknown-${TABI} -c" && break 2 done done @@ -475,7 +475,7 @@ # but that's more of a clang limitation. Let's be optimistic # that this will change in the future. CLANG="${clang_prefix}clang" - CLANG_TARGET="-target ${clang_arch}-${TABI}" + CLANG_TARGET="-target ${clang_arch}-none-unknown-${TABI}" CFLAGS_CLANG="$CLANG_TARGET $CFLAGS_CLANG" CPPFLAGS_CLANG="$CLANG_TARGET $CPPFLAGS_CLANG" fi -- To view, visit https://review.coreboot.org/c/coreboot/+/80730?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9356a2bc0f5b77e934cc16482d6ccb1961195dc Gerrit-Change-Number: 80730 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: util/xcompile: Use a more complete clang target
by Felix Singer (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Arthur Heymans, Martin L Roth, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80730?usp=email ) Change subject: util/xcompile: Use a more complete clang target ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80730?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9356a2bc0f5b77e934cc16482d6ccb1961195dc Gerrit-Change-Number: 80730 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 30 Mar 2024 10:13:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: security/tpm: replace CONFIG(TPMx) checks with runtime check
by Sergii Dmytruk (Code Review) 30 Mar '24

30 Mar '24

Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69161?usp=email ) Change subject: security/tpm: replace CONFIG(TPMx) checks with runtime check ...................................................................... Patch Set 36: (1 comment) File src/drivers/tpm/ppi.c: https://review.coreboot.org/c/coreboot/+/69161/comment/b0e36e99_a290f47a : PS36, Line 574: BIOS_WARN > https://review.coreboot. […] Thanks for fixing this. `tlcl_get_family()` could be evaluated in compile-time which is probably the reason why it wasn't caught. -- To view, visit https://review.coreboot.org/c/coreboot/+/69161?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id9cc25aad8d1d7bfad12b7a92059b1b3641bbfa9 Gerrit-Change-Number: 69161 Gerrit-PatchSet: 36 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jan Samek <samekh(a)email.cz> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Sat, 30 Mar 2024 09:59:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/gfx: Remove unnecessary line continuations
by Elyes Haouas (Code Review) 30 Mar '24

30 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81594?usp=email ) Change subject: drivers/gfx: Remove unnecessary line continuations ...................................................................... drivers/gfx: Remove unnecessary line continuations Change-Id: Ic71516ae73d61c9f13876a5acc071645bbe8e866 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/drivers/gfx/generic/generic.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/81594/1 diff --git a/src/drivers/gfx/generic/generic.c b/src/drivers/gfx/generic/generic.c index 0714565..f07a471 100644 --- a/src/drivers/gfx/generic/generic.c +++ b/src/drivers/gfx/generic/generic.c @@ -119,8 +119,8 @@ if (!config->device[i].addr && config->device[i].type) /* Though not strictly necessary, set the display index and port attachment to the device index, to ensure uniqueness */ - config->device[i].addr = DOD_DID_STD | DOD_FW_DETECT | \ - (config->device[i].type << 8) | \ + config->device[i].addr = DOD_DID_STD | DOD_FW_DETECT | + (config->device[i].type << 8) | (i << 4) | (i); acpigen_write_dword(config->device[i].addr); } -- To view, visit https://review.coreboot.org/c/coreboot/+/81594?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic71516ae73d61c9f13876a5acc071645bbe8e866 Gerrit-Change-Number: 81594 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/samsung: Move 'inline' between storage class and type
by Elyes Haouas (Code Review) 30 Mar '24

30 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81593?usp=email ) Change subject: soc/samsung: Move 'inline' between storage class and type ...................................................................... soc/samsung: Move 'inline' between storage class and type Change-Id: Iccdb4770890751b7f9d1b35248fe57993342fd50 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/samsung/exynos5420/smp.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/81593/1 diff --git a/src/soc/samsung/exynos5420/smp.c b/src/soc/samsung/exynos5420/smp.c index 13e9489..92c5175 100644 --- a/src/soc/samsung/exynos5420/smp.c +++ b/src/soc/samsung/exynos5420/smp.c @@ -64,14 +64,14 @@ * switching), we are not sure if the destination is Thumb or ARM mode. * So a BX command is required. */ -inline static void jump_bx(void *address) +static inline void jump_bx(void *address) { asm volatile ("bx %0" : : "r"(address)); /* never returns. */ } /* Extracts arbitrary bits from a 32-bit unsigned int. */ -inline static uint32_t get_bits(uint32_t value, uint32_t start, uint32_t len) +static inline uint32_t get_bits(uint32_t value, uint32_t start, uint32_t len) { return ((value << (sizeof(value) * 8 - len - start)) >> (sizeof(value) * 8 - len)); -- To view, visit https://review.coreboot.org/c/coreboot/+/81593?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iccdb4770890751b7f9d1b35248fe57993342fd50 Gerrit-Change-Number: 81593 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: lib/thread.c: Move 'asmlinkage' before type 'void'
by Elyes Haouas (Code Review) 30 Mar '24

30 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81592?usp=email ) Change subject: lib/thread.c: Move 'asmlinkage' before type 'void' ...................................................................... lib/thread.c: Move 'asmlinkage' before type 'void' Change-Id: Ibd35bef4182ea075ef5fa153e2e47678ffce171b Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/lib/thread.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/81592/1 diff --git a/src/lib/thread.c b/src/lib/thread.c index a0d4311..944c75e 100644 --- a/src/lib/thread.c +++ b/src/lib/thread.c @@ -143,7 +143,7 @@ schedule(NULL); } -static void asmlinkage call_wrapper(void *unused) +static asmlinkage void call_wrapper(void *unused) { struct thread *current = current_thread(); enum cb_err error; @@ -159,7 +159,7 @@ }; /* Block the provided state until thread is complete. */ -static void asmlinkage call_wrapper_block_state(void *arg) +static asmlinkage void call_wrapper_block_state(void *arg) { struct block_boot_state *bbs = arg; struct thread *current = current_thread(); -- To view, visit https://review.coreboot.org/c/coreboot/+/81592?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd35bef4182ea075ef5fa153e2e47678ffce171b Gerrit-Change-Number: 81592 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: util/xcompile: Use a more complete clang target
by Arthur Heymans (Code Review) 30 Mar '24

30 Mar '24

Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80730?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/xcompile: Use a more complete clang target ...................................................................... util/xcompile: Use a more complete clang target When the compiler is used as a linker frontend clang tries to match the target string with what it supports internally. If it's not sufficiently complete it will forward linking to GCC which is not desirable. This is necessary when doing LTO with clang. Change-Id: Ie9356a2bc0f5b77e934cc16482d6ccb1961195dc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/xcompile/xcompile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/80730/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/80730?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9356a2bc0f5b77e934cc16482d6ccb1961195dc Gerrit-Change-Number: 80730 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
367
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024