Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70542?usp=email
to look at the new patch set (#15).
Change subject: util/intelp2m: Add logger
......................................................................
util/intelp2m: Add logger
Add logging to a file, ./logs.txt by default. --logs option is used to
override this path. Error messages are duplicated to the console.
Change-Id: I97aba146b6d8866a7fa46bac80c27c0896b26cf7
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/.gitignore
M util/intelp2m/cli/options.go
M util/intelp2m/config/p2m/config.go
A util/intelp2m/logs/logs.go
M util/intelp2m/main.go
M util/intelp2m/version.txt
6 files changed, 67 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/70542/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/70542?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97aba146b6d8866a7fa46bac80c27c0896b26cf7
Gerrit-Change-Number: 70542
Gerrit-PatchSet: 15
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70543?usp=email
to look at the new patch set (#21).
Change subject: util/intelp2m: Rewrite parser
......................................................................
util/intelp2m: Rewrite parser
- Split the parser code into several packages to make its testing of its
functions more convenient and detailed. This also makes embedding the
parser in third-party applications more flexible - there is no need to
use all the functionality of the parser.
- Clean up code and remove unnecessary objects to make intelp2m simpler
and more readable.
- Change the common macro format to be consistent with the new parser.
- Rename the results directory containing gpio.h to output to avoid
confusion with the generator package directory.
- At the moment there is no mechanism for setting the Ownership flag.
This will be added in later versions.
Tests:
- make test = PASS
- gpio.h for Apollo Lake before and after the patch is the same
Change-Id: I9a29322dd31faf9ae100165f08f207360cbf9f80
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/Makefile
M util/intelp2m/cli/options.go
M util/intelp2m/config/p2m/config.go
A util/intelp2m/generator/generator.go
A util/intelp2m/generator/generator_test.go
A util/intelp2m/generator/header/header.go
A util/intelp2m/generator/printer/printer.go
A util/intelp2m/generator/testsuites/i0nocomments.go
A util/intelp2m/generator/testsuites/i1comments.go
A util/intelp2m/generator/testsuites/i2AutoCheck.go
A util/intelp2m/generator/testsuites/i3Uncheck.go
A util/intelp2m/generator/testsuites/i4ExcludeUnusedCbFlds.go
M util/intelp2m/main.go
M util/intelp2m/parser/parser.go
M util/intelp2m/parser/parser_test.go
D util/intelp2m/parser/template.go
A util/intelp2m/parser/template/template.go
R util/intelp2m/parser/template/template_test.go
A util/intelp2m/parser/test/suite.go
R util/intelp2m/parser/testlog/inteltool_test.log
M util/intelp2m/platforms/common/macro.go
A util/intelp2m/platforms/interfaces.go
22 files changed, 1,014 insertions(+), 365 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/70543/21
--
To view, visit https://review.coreboot.org/c/coreboot/+/70543?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a29322dd31faf9ae100165f08f207360cbf9f80
Gerrit-Change-Number: 70543
Gerrit-PatchSet: 21
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Benjamin Doron, Matt DeVillier, Michael Niewöhner, Paul Menzel.
Hello Angel Pons, Benjamin Doron, Matt DeVillier, Michael Niewöhner, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56887?usp=email
to look at the new patch set (#18).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m: Drop non-DWx register analysis support
......................................................................
util/intelp2m: Drop non-DWx register analysis support
The utility can parse the value of non-DWx registers, if they are
present in the inteltool dump. However, the functions that allow the
inteltool utility to print the value of such registers have not been
added to the master branch, and it makes no sense to support such
functions in intelp2m, besides, their implementation is far from ideal.
Remove this unused functionality. This will be restored in the future in
a different form and after corresponding changes in inteltool.
TEST: make test = PASS
Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/parser/parser.go
M util/intelp2m/parser/template.go
M util/intelp2m/platforms/adl/template.go
M util/intelp2m/platforms/apl/template.go
M util/intelp2m/platforms/cnl/template.go
M util/intelp2m/platforms/ebg/macro.go
M util/intelp2m/platforms/ebg/template.go
M util/intelp2m/platforms/jsl/template.go
M util/intelp2m/platforms/lbg/template.go
M util/intelp2m/platforms/mtl/template.go
M util/intelp2m/platforms/snr/template.go
M util/intelp2m/platforms/tgl/template.go
M util/intelp2m/version.txt
13 files changed, 40 insertions(+), 216 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/56887/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/56887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00
Gerrit-Change-Number: 56887
Gerrit-PatchSet: 18
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70543?usp=email
to look at the new patch set (#20).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m: Rewrite parser
......................................................................
util/intelp2m: Rewrite parser
- Split the parser code into several packages to make its testing of its
functions more convenient and detailed. This also makes embedding the
parser in third-party applications more flexible - there is no need to
use all the functionality of the parser.
- Clean up code and remove unnecessary objects to make intelp2m simpler
and more readable.
- Change the common macro format to be consistent with the new parser.
- Rename the results directory containing gpio.h to output to avoid
confusion with the generator package directory.
- At the moment there is no mechanism for setting the Ownership flag.
This will be added in later versions.
Tests:
- make test = PASS
- gpio.h for Apollo Lake before and after the patch is the same
Change-Id: I9a29322dd31faf9ae100165f08f207360cbf9f80
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/Makefile
M util/intelp2m/cli/options.go
M util/intelp2m/config/p2m/config.go
A util/intelp2m/generator/generator.go
A util/intelp2m/generator/generator_test.go
A util/intelp2m/generator/header/header.go
A util/intelp2m/generator/printer/printer.go
A util/intelp2m/generator/testsuites/i0nocomments.go
A util/intelp2m/generator/testsuites/i1comments.go
A util/intelp2m/generator/testsuites/i2AutoCheck.go
A util/intelp2m/generator/testsuites/i3Uncheck.go
A util/intelp2m/generator/testsuites/i4ExcludeUnusedCbFlds.go
M util/intelp2m/main.go
M util/intelp2m/parser/parser.go
M util/intelp2m/parser/parser_test.go
D util/intelp2m/parser/template.go
A util/intelp2m/parser/template/template.go
R util/intelp2m/parser/template/template_test.go
A util/intelp2m/parser/test/suite.go
R util/intelp2m/parser/testlog/inteltool_test.log
M util/intelp2m/platforms/common/macro.go
A util/intelp2m/platforms/interfaces.go
22 files changed, 1,024 insertions(+), 365 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/70543/20
--
To view, visit https://review.coreboot.org/c/coreboot/+/70543?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a29322dd31faf9ae100165f08f207360cbf9f80
Gerrit-Change-Number: 70543
Gerrit-PatchSet: 20
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70542?usp=email
to look at the new patch set (#14).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m: Add logger
......................................................................
util/intelp2m: Add logger
Add logging to a file, ./logs.txt by default. --logs option is used to
override this path. Error messages are duplicated to the console.
Change-Id: I97aba146b6d8866a7fa46bac80c27c0896b26cf7
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/.gitignore
M util/intelp2m/cli/options.go
M util/intelp2m/config/p2m/config.go
A util/intelp2m/logs/logs.go
M util/intelp2m/main.go
M util/intelp2m/version.txt
6 files changed, 72 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/70542/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/70542?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97aba146b6d8866a7fa46bac80c27c0896b26cf7
Gerrit-Change-Number: 70542
Gerrit-PatchSet: 14
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: David Hendricks.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71167?usp=email
to look at the new patch set (#13).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m: Rework platforms and fields packages
......................................................................
util/intelp2m: Rework platforms and fields packages
- Add the base platform interface to be able to reuse its methods.
- The macro structure is excluded from the platform structure.
- Instead of a global macro instance, create a new local structure for
each generated macro.
TEST:
1) 'make test' = PASS
2) './intelp2m -p cnl -iiii -file inteltool.log' = gpio.h before and
after the commit is the same.
Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/fields/cb/cb.go
M util/intelp2m/fields/cb/cb_test.go
M util/intelp2m/fields/fields.go
M util/intelp2m/fields/fsp/fsp.go
M util/intelp2m/fields/fsp/fsp_test.go
M util/intelp2m/fields/raw/raw.go
M util/intelp2m/fields/raw/raw_test.go
M util/intelp2m/fields/test/suite.go
M util/intelp2m/parser/parser.go
M util/intelp2m/platforms/adl/adl_test.go
M util/intelp2m/platforms/adl/macro.go
M util/intelp2m/platforms/adl/template.go
M util/intelp2m/platforms/apl/apl_test.go
M util/intelp2m/platforms/apl/macro.go
M util/intelp2m/platforms/apl/template.go
M util/intelp2m/platforms/cnl/cnl_test.go
M util/intelp2m/platforms/cnl/macro.go
M util/intelp2m/platforms/cnl/template.go
A util/intelp2m/platforms/common/common.go
D util/intelp2m/platforms/common/macro.go
A util/intelp2m/platforms/common/macros/macros.go
A util/intelp2m/platforms/common/register/helper.go
M util/intelp2m/platforms/ebg/ebg_test.go
M util/intelp2m/platforms/ebg/macro.go
M util/intelp2m/platforms/ebg/template.go
D util/intelp2m/platforms/interfaces.go
M util/intelp2m/platforms/jsl/jsl_test.go
M util/intelp2m/platforms/jsl/macro.go
M util/intelp2m/platforms/jsl/template.go
M util/intelp2m/platforms/lbg/lbg_test.go
M util/intelp2m/platforms/lbg/macro.go
M util/intelp2m/platforms/lbg/template.go
M util/intelp2m/platforms/mtl/macro.go
M util/intelp2m/platforms/mtl/mtl_test.go
M util/intelp2m/platforms/mtl/template.go
A util/intelp2m/platforms/platforms.go
M util/intelp2m/platforms/snr/macro.go
M util/intelp2m/platforms/snr/snr_test.go
M util/intelp2m/platforms/snr/template.go
M util/intelp2m/platforms/test/suite.go
M util/intelp2m/platforms/tgl/macro.go
M util/intelp2m/platforms/tgl/template.go
M util/intelp2m/platforms/tgl/tgl_test.go
43 files changed, 1,369 insertions(+), 1,660 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/71167/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/71167?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9
Gerrit-Change-Number: 71167
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70308?usp=email
to look at the new patch set (#13).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m/config: Rework configuration package
......................................................................
util/intelp2m/config: Rework configuration package
- Reduce the number of methods for updating settings and redefine types
to make the code cleaner and more readable.
- Move the configuration to the p2m package to add settings from new
utilities based on the intelp2m code.
- Make some code style fixes.
TEST: make test = PASS
Change-Id: Ia1b19ae3122bcf6ec740ae4683d62f31570670b1
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
D util/intelp2m/config/config.go
A util/intelp2m/config/p2m/config.go
M util/intelp2m/fields/cb/cb.go
M util/intelp2m/fields/fields.go
M util/intelp2m/main.go
M util/intelp2m/parser/parser.go
M util/intelp2m/parser/parser_test.go
M util/intelp2m/platforms/apl/macro.go
M util/intelp2m/platforms/cnl/macro.go
M util/intelp2m/platforms/common/macro.go
M util/intelp2m/platforms/common/register.go
M util/intelp2m/platforms/snr/macro.go
M util/intelp2m/platforms/test/suite.go
13 files changed, 306 insertions(+), 359 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/70308/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/70308?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia1b19ae3122bcf6ec740ae4683d62f31570670b1
Gerrit-Change-Number: 70308
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70309?usp=email
to look at the new patch set (#13).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m/register: Rework package code
......................................................................
util/intelp2m/register: Rework package code
Split all methods between DW0 and DW1 to avoid the mistake of using any
DW0 method with DW1 receiver and make the code safer. Also make some
code style fixes.
TEST: make test = PASS
Change-Id: Id64e2a5e29f1d561597004ac83d32e3c80c16ebd
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/fields/cb/cb.go
M util/intelp2m/fields/fsp/fsp.go
M util/intelp2m/fields/raw/raw.go
M util/intelp2m/fields/test/suite.go
M util/intelp2m/parser/template.go
M util/intelp2m/parser/template_test.go
M util/intelp2m/platforms/adl/adl_test.go
M util/intelp2m/platforms/adl/macro.go
M util/intelp2m/platforms/apl/macro.go
M util/intelp2m/platforms/cnl/cnl_test.go
M util/intelp2m/platforms/cnl/macro.go
M util/intelp2m/platforms/common/macro.go
D util/intelp2m/platforms/common/register.go
A util/intelp2m/platforms/common/register/bits/bits.go
A util/intelp2m/platforms/common/register/dw0.go
A util/intelp2m/platforms/common/register/dw1.go
A util/intelp2m/platforms/common/register/register.go
M util/intelp2m/platforms/ebg/ebg_test.go
M util/intelp2m/platforms/ebg/macro.go
M util/intelp2m/platforms/jsl/jsl_test.go
M util/intelp2m/platforms/jsl/macro.go
M util/intelp2m/platforms/lbg/macro.go
M util/intelp2m/platforms/mtl/macro.go
M util/intelp2m/platforms/mtl/mtl_test.go
M util/intelp2m/platforms/snr/macro.go
M util/intelp2m/platforms/tgl/macro.go
M util/intelp2m/platforms/tgl/tgl_test.go
27 files changed, 779 insertions(+), 732 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/70309/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/70309?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id64e2a5e29f1d561597004ac83d32e3c80c16ebd
Gerrit-Change-Number: 70309
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>