Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84787?usp=email )
Change subject: util/crossgcc: Update ACPICA from 20230628 to 20241212
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> The CI failed downloading the source tarball. For some reason the build job still passed. […]
I've verified that the link used by the CI works. So the issue relies somewhere else.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84787?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ae7073e46084024360ac0dd44e0df666cb32269
Gerrit-Change-Number: 84787
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 17 Dec 2024 01:52:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84787?usp=email )
Change subject: util/crossgcc: Update ACPICA from 20230628 to 20241212
......................................................................
Patch Set 4: -Code-Review
(1 comment)
Patchset:
PS4:
The CI failed downloading the source tarball. For some reason the build job still passed.
```
* acpica-unix-20241212.tar.gz (downloading from https://github.com/acpica/acpica/releases/download/R2024_12_12/acpica-unix-…)... 0%... Failed to download acpica-unix-20241212.tar.gz.
make[2]: *** [Makefile:24: build_iasl] Error 1
make[1]: *** [Makefile:12: all] Error 2
make: *** [util/crossgcc/Makefile.mk:25: crossgcc] Error 2
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/84787?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ae7073e46084024360ac0dd44e0df666cb32269
Gerrit-Change-Number: 84787
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 17 Dec 2024 01:50:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85169?usp=email )
Change subject: util/crossgcc: Update LLVM from 18.1.8 to 19.1.5
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS6:
> Please upgrad to 19.1. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a392b472b7450685343e1343c7b84c78b0cad3d
Gerrit-Change-Number: 85169
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 16 Dec 2024 22:20:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Felix Singer, Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85169?usp=email
to look at the new patch set (#8).
Change subject: util/crossgcc: Update LLVM from 18.1.8 to 19.1.5
......................................................................
util/crossgcc: Update LLVM from 18.1.8 to 19.1.5
Change-Id: I4a392b472b7450685343e1343c7b84c78b0cad3d
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/clang-19.1.5.src_x86_baremetal.patch
D util/crossgcc/sum/clang-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/clang-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/cmake-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/cmake-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/compiler-rt-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/libunwind-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/libunwind-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/lld-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/lld-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/llvm-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/llvm-19.1.5.src.tar.xz.cksum
16 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/85169/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/85169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a392b472b7450685343e1343c7b84c78b0cad3d
Gerrit-Change-Number: 85169
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Felix Singer, Martin L Roth.
Hello Elyes Haouas, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85168?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/crossgcc: Update CMake from 3.30.2 to 3.31.2
......................................................................
util/crossgcc: Update CMake from 3.30.2 to 3.31.2
Change-Id: I573dace3b752a0d3c4614ece9c0845f8334e2857
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.30.2.tar.gz.cksum
A util/crossgcc/sum/cmake-3.31.2.tar.gz.cksum
3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/85168/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/85168?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I573dace3b752a0d3c4614ece9c0845f8334e2857
Gerrit-Change-Number: 85168
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Felix Singer, Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85169?usp=email
to look at the new patch set (#7).
Change subject: util/crossgcc: Update LLVM from 18.1.8 to 19.1.5
......................................................................
util/crossgcc: Update LLVM from 18.1.8 to 19.1.5
Change-Id: I4a392b472b7450685343e1343c7b84c78b0cad3d
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/clang-19.1.5.src_x86_baremetal.patch
D util/crossgcc/sum/clang-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/clang-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/cmake-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/cmake-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/compiler-rt-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/libunwind-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/libunwind-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/lld-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/lld-19.1.5.src.tar.xz.cksum
D util/crossgcc/sum/llvm-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/llvm-19.1.5.src.tar.xz.cksum
16 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/85169/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/85169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a392b472b7450685343e1343c7b84c78b0cad3d
Gerrit-Change-Number: 85169
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84787?usp=email )
Change subject: util/crossgcc: Update ACPICA from 20230628 to 20241212
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84787?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ae7073e46084024360ac0dd44e0df666cb32269
Gerrit-Change-Number: 84787
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 16 Dec 2024 21:26:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )
Change subject: util/crossgcc: Add libstdcxx target
......................................................................
Patch Set 13:
(4 comments)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/85275/comment/09ed81be_5fa973d2?us… :
PS12, Line 840: $@
> ```suggestion […]
Fix applied.
https://review.coreboot.org/c/coreboot/+/85275/comment/d0a87140_7923e6b1?us… :
PS12, Line 844: configure_GCC
> The script isn't running with `-e`, so we need to chain the commands. […]
Fix applied.
https://review.coreboot.org/c/coreboot/+/85275/comment/586ce4e1_8ce047f8?us… :
PS12, Line 864: configure_GCC "--with-gxx-include-dir=\"${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/\"
: --with-sysroot=\"${LIBSTDCXX_INCLUDE_PATH}/\""
> ```suggestion […]
Fix applied.
https://review.coreboot.org/c/coreboot/+/85275/comment/73ce49ed_6db3f623?us… :
PS12, Line 870: || touch .failed
> You don't want to build libstdc++ if libgcc failed. […]
Fix applied.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed
Gerrit-Change-Number: 85275
Gerrit-PatchSet: 13
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 21:15:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>