coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[L] Change in coreboot[main]: util/intelp2m: Update cli options
by Maxim (Code Review) 16 Dec '24

16 Dec '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70310?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m: Update cli options ...................................................................... util/intelp2m: Update cli options - Redesign the options format. - Add automatic completion of arguments for bash. [complete -C `pwd`/intelp2m ./intelp2m] to enable TEST: make test = PASS Change-Id: I08ff379b99b018b1099aa5d70fea47026bc84045 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A util/intelp2m/cli/completion.go A util/intelp2m/cli/options.go M util/intelp2m/config/p2m/config.go M util/intelp2m/main.go M util/intelp2m/version.txt 5 files changed, 268 insertions(+), 81 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/70310/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/70310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I08ff379b99b018b1099aa5d70fea47026bc84045 Gerrit-Change-Number: 70310 Gerrit-PatchSet: 14 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: intelp2m/patform/mtl: Add unit tests
by Maxim (Code Review) 16 Dec '24

16 Dec '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85551?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: intelp2m/patform/mtl: Add unit tests ...................................................................... intelp2m/patform/mtl: Add unit tests 1) Siding one in nibble: DW = 0001 0001 0001 0001 <- <- <- <- 2) Siding zero in nibble: DW = 1110 1110 1110 1110 <- <- <- <- 3) Siding one one in nibble: DW = 0011 0011 0011 0011 <- <- <- <- Change-Id: I5965f2362626c0ca1f51bf5f4dbe275b76c392ea Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A util/intelp2m/platforms/mtl/mtl_test.go 1 file changed, 110 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/85551/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85551?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5965f2362626c0ca1f51bf5f4dbe275b76c392ea Gerrit-Change-Number: 85551 Gerrit-PatchSet: 2 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XL] Change in coreboot[main]: util/intelp2m: Rework platforms and fields packages
by Maxim (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: David Hendricks. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71167?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m: Rework platforms and fields packages ...................................................................... util/intelp2m: Rework platforms and fields packages - Add the base platform interface to be able to reuse its methods. - The macro structure is excluded from the platform structure. - Instead of a global macro instance, create a new local structure for each generated macro. TEST: 1) 'make test' = PASS 2) './intelp2m -p cnl -iiii -file inteltool.log' = gpio.h before and after the commit is the same. Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/fields/cb/cb.go M util/intelp2m/fields/cb/cb_test.go M util/intelp2m/fields/fields.go M util/intelp2m/fields/fsp/fsp.go M util/intelp2m/fields/fsp/fsp_test.go M util/intelp2m/fields/raw/raw.go M util/intelp2m/fields/raw/raw_test.go M util/intelp2m/fields/test/suite.go M util/intelp2m/parser/parser.go M util/intelp2m/platforms/adl/adl_test.go M util/intelp2m/platforms/adl/macro.go M util/intelp2m/platforms/adl/template.go M util/intelp2m/platforms/apl/apl_test.go M util/intelp2m/platforms/apl/macro.go M util/intelp2m/platforms/apl/template.go M util/intelp2m/platforms/cnl/cnl_test.go M util/intelp2m/platforms/cnl/macro.go M util/intelp2m/platforms/cnl/template.go A util/intelp2m/platforms/common/common.go D util/intelp2m/platforms/common/macro.go A util/intelp2m/platforms/common/macros/macros.go A util/intelp2m/platforms/common/register/helper.go M util/intelp2m/platforms/ebg/ebg_test.go M util/intelp2m/platforms/ebg/macro.go M util/intelp2m/platforms/ebg/template.go D util/intelp2m/platforms/interfaces.go M util/intelp2m/platforms/jsl/jsl_test.go M util/intelp2m/platforms/jsl/macro.go M util/intelp2m/platforms/jsl/template.go M util/intelp2m/platforms/lbg/lbg_test.go M util/intelp2m/platforms/lbg/macro.go M util/intelp2m/platforms/lbg/template.go M util/intelp2m/platforms/mtl/macro.go M util/intelp2m/platforms/mtl/mtl_test.go M util/intelp2m/platforms/mtl/template.go A util/intelp2m/platforms/platforms.go M util/intelp2m/platforms/snr/macro.go M util/intelp2m/platforms/snr/snr_test.go M util/intelp2m/platforms/snr/template.go M util/intelp2m/platforms/test/suite.go M util/intelp2m/platforms/tgl/macro.go M util/intelp2m/platforms/tgl/template.go M util/intelp2m/platforms/tgl/tgl_test.go 43 files changed, 1,369 insertions(+), 1,660 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/71167/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/71167?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9 Gerrit-Change-Number: 71167 Gerrit-PatchSet: 13 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>

1 0

[XL] Change in coreboot[main]: util/intelp2m: Rewrite parser
by Maxim (Code Review) 16 Dec '24

16 Dec '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70543?usp=email to look at the new patch set (#20). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m: Rewrite parser ...................................................................... util/intelp2m: Rewrite parser - Split the parser code into several packages to make its testing of its functions more convenient and detailed. This also makes embedding the parser in third-party applications more flexible - there is no need to use all the functionality of the parser. - Clean up code and remove unnecessary objects to make intelp2m simpler and more readable. - Change the common macro format to be consistent with the new parser. - Rename the results directory containing gpio.h to output to avoid confusion with the generator package directory. - At the moment there is no mechanism for setting the Ownership flag. This will be added in later versions. Tests: - make test = PASS - gpio.h for Apollo Lake before and after the patch is the same Change-Id: I9a29322dd31faf9ae100165f08f207360cbf9f80 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/Makefile M util/intelp2m/cli/options.go M util/intelp2m/config/p2m/config.go A util/intelp2m/generator/generator.go A util/intelp2m/generator/generator_test.go A util/intelp2m/generator/header/header.go A util/intelp2m/generator/printer/printer.go A util/intelp2m/generator/testsuites/i0nocomments.go A util/intelp2m/generator/testsuites/i1comments.go A util/intelp2m/generator/testsuites/i2AutoCheck.go A util/intelp2m/generator/testsuites/i3Uncheck.go A util/intelp2m/generator/testsuites/i4ExcludeUnusedCbFlds.go M util/intelp2m/main.go M util/intelp2m/parser/parser.go M util/intelp2m/parser/parser_test.go D util/intelp2m/parser/template.go A util/intelp2m/parser/template/template.go R util/intelp2m/parser/template/template_test.go A util/intelp2m/parser/test/suite.go R util/intelp2m/parser/testlog/inteltool_test.log M util/intelp2m/platforms/common/macro.go A util/intelp2m/platforms/interfaces.go 22 files changed, 1,024 insertions(+), 365 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/70543/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/70543?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9a29322dd31faf9ae100165f08f207360cbf9f80 Gerrit-Change-Number: 70543 Gerrit-PatchSet: 20 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: intelp2m/patform/cnl: Add unit tests
by Maxim (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Alicja Michalska, David Hendricks. Hello Alicja Michalska, David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85548?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: intelp2m/patform/cnl: Add unit tests ...................................................................... intelp2m/patform/cnl: Add unit tests 1) Siding one in nibble: DW = 0001 0001 0001 0001 <- <- <- <- 2) Siding zero in nibble: DW = 1110 1110 1110 1110 <- <- <- <- 3) Siding one one in nibble: DW = 0011 0011 0011 0011 <- <- <- <- Change-Id: Icb0b6506a07b96903e6bc7994e5f97d483d0a330 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A util/intelp2m/platforms/cnl/cnl_test.go 1 file changed, 107 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/85548/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85548?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb0b6506a07b96903e6bc7994e5f97d483d0a330 Gerrit-Change-Number: 85548 Gerrit-PatchSet: 2 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>

1 0

[M] Change in coreboot[main]: util/intelp2m: Add logger
by Maxim (Code Review) 16 Dec '24

16 Dec '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70542?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m: Add logger ...................................................................... util/intelp2m: Add logger Add logging to a file, ./logs.txt by default. --logs option is used to override this path. Error messages are duplicated to the console. Change-Id: I97aba146b6d8866a7fa46bac80c27c0896b26cf7 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/.gitignore M util/intelp2m/cli/options.go M util/intelp2m/config/p2m/config.go A util/intelp2m/logs/logs.go M util/intelp2m/main.go M util/intelp2m/version.txt 6 files changed, 72 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/70542/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/70542?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I97aba146b6d8866a7fa46bac80c27c0896b26cf7 Gerrit-Change-Number: 70542 Gerrit-PatchSet: 14 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: util/intelp2m: Drop non-DWx register analysis support
by Maxim (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Benjamin Doron, Matt DeVillier, Michael Niewöhner, Paul Menzel. Hello Angel Pons, Benjamin Doron, Matt DeVillier, Michael Niewöhner, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56887?usp=email to look at the new patch set (#18). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m: Drop non-DWx register analysis support ...................................................................... util/intelp2m: Drop non-DWx register analysis support The utility can parse the value of non-DWx registers, if they are present in the inteltool dump. However, the functions that allow the inteltool utility to print the value of such registers have not been added to the master branch, and it makes no sense to support such functions in intelp2m, besides, their implementation is far from ideal. Remove this unused functionality. This will be restored in the future in a different form and after corresponding changes in inteltool. TEST: make test = PASS Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/parser/parser.go M util/intelp2m/parser/template.go M util/intelp2m/platforms/adl/template.go M util/intelp2m/platforms/apl/template.go M util/intelp2m/platforms/cnl/template.go M util/intelp2m/platforms/ebg/macro.go M util/intelp2m/platforms/ebg/template.go M util/intelp2m/platforms/jsl/template.go M util/intelp2m/platforms/lbg/template.go M util/intelp2m/platforms/mtl/template.go M util/intelp2m/platforms/snr/template.go M util/intelp2m/platforms/tgl/template.go M util/intelp2m/version.txt 13 files changed, 40 insertions(+), 216 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/56887/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/56887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00 Gerrit-Change-Number: 56887 Gerrit-PatchSet: 18 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>

1 0

[XS] Change in coreboot[main]: mb/google/brox: Apply ISH_FW_VERSION in Kconfig
by Karthik Ramasubramanian (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: David Wu, Marx Wang, Ren Kuo. Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/85580?usp=email ) Change subject: mb/google/brox: Apply ISH_FW_VERSION in Kconfig ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85580?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I31db0925a81b6ec68ee6afcb262e540ba7db206a Gerrit-Change-Number: 85580 Gerrit-PatchSet: 4 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 16 Dec 2024 16:58:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: drivers/amd/nova: Add Nova Card common driver
by Felix Held (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Paul Menzel. Felix Held has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84776?usp=email ) Change subject: drivers/amd/nova: Add Nova Card common driver ...................................................................... Patch Set 7: (5 comments) File Makefile.mk: https://review.coreboot.org/c/coreboot/+/84776/comment/4d158f70_bace3a9c?us… : PS7, Line 121: subdirs-y += src/mainboard/$(MAINBOARDDIR) $(wildcard src/mainboard/*/common) probably no longer needed after the code was moved to the driver directory File src/drivers/amd/nova/Kconfig: https://review.coreboot.org/c/coreboot/+/84776/comment/1933bca6_1b4f4e50?us… : PS5, Line 4: def_bool n > It can be, I wasn`t sure if all mainboards have a nova card the AMD mainboard with a slot for a nova card should select this kconfig directly and not via the defconfig File src/drivers/amd/nova/chip.h: https://review.coreboot.org/c/coreboot/+/84776/comment/e45255a7_ae50b552?us… : PS7, Line 9: #define NOVA_CARD_EEPROM_CONNECTOR_TYPE_OFFSET 2 i'd move this define into the c file that uses this, since it's not needed outside of that c file https://review.coreboot.org/c/coreboot/+/84776/comment/d02f6e69_42e08259?us… : PS7, Line 10: #define NOVA_CARD_EEPROM_I2C_BUS 2 : #define NOVA_CARD_EEPROM_I2C_ADDRESS 0x55 those two are mainboard-dependend. sure most boards will use a similar setup, but it's not something i'd rely on File src/drivers/amd/nova/nova_card.c: https://review.coreboot.org/c/coreboot/+/84776/comment/aebe7ea7_02ac17ad?us… : PS7, Line 9: #include <soc/amd/phoenix/chip_opensil.h> i'd like to avoid soc-specific code in a common driver -- To view, visit https://review.coreboot.org/c/coreboot/+/84776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e9ded2090d6a5865e3330408f490e59fbf480f4 Gerrit-Change-Number: 84776 Gerrit-PatchSet: 7 Gerrit-Owner: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Comment-Date: Mon, 16 Dec 2024 16:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anand Vaikar <a.vaikar2021(a)gmail.com> Comment-In-Reply-To: Ana Carolina Cabral

1 0

[S] Change in coreboot[main]: mb/trulo/var/uldrenite: Configure Network
by Kapil Porwal (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Nick Vaccaro, Paul Menzel, Subrata Banik. Kapil Porwal has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85583?usp=email ) Change subject: mb/trulo/var/uldrenite: Configure Network ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85583?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fd292550700817f15813dabfbaf9ccab3a907d8 Gerrit-Change-Number: 85583 Gerrit-PatchSet: 4 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 16 Dec 2024 15:59:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024