coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Felix Singer (Code Review) 16 Dec '24

16 Dec '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85610?usp=email ) Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... 3rdparty/fsp: Update submodule to upstream master Updating from commit id 851f7105d803: 2024-11-22 14:59:29 +0800 - (NEX TGL IPU 2025.1 (7341_01) FSP) to commit id 909cf43ad6cc: 2024-12-09 14:08:48 +0800 - (IoT ADL-N IPU25.1 (5354_00)) This brings in 2 new commits: 909cf43ad6cc IoT ADL-N IPU25.1 (5354_00) 5d25d0b9b6c7 IoT RPL-PS MR1 (5274_42) FSP Change-Id: I13e5a1f0f8e16af46693174541bc666363bc0e71 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/85610/1 diff --git a/3rdparty/fsp b/3rdparty/fsp index 851f710..909cf43 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 851f7105d803672e17202bc2f598a5a4dbf659d3 +Subproject commit 909cf43ad6ccebb6adee482bc0a4f098c32c9a6d -- To view, visit https://review.coreboot.org/c/coreboot/+/85610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13e5a1f0f8e16af46693174541bc666363bc0e71 Gerrit-Change-Number: 85610 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[S] Change in coreboot[main]: util/crossgcc: Add libstdcxx target
by Raul Rangel (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Felix Singer, Jon Murphy, Karthik Ramasubramanian, Martin L Roth. Raul Rangel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email ) Change subject: util/crossgcc: Add libstdcxx target ...................................................................... Patch Set 12: (4 comments) File util/crossgcc/buildgcc: https://review.coreboot.org/c/coreboot/+/85275/comment/e03cad19_3da219ba?us… : PS12, Line 840: $@ ```suggestion "$@" ``` https://review.coreboot.org/c/coreboot/+/85275/comment/e47231c5_55557708?us… : PS12, Line 844: configure_GCC The script isn't running with `-e`, so we need to chain the commands. ```suggestion configure_GCC && \ ``` https://review.coreboot.org/c/coreboot/+/85275/comment/19f4ec2d_b8c942ad?us… : PS12, Line 864: configure_GCC "--with-gxx-include-dir=\"${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/\" : --with-sysroot=\"${LIBSTDCXX_INCLUDE_PATH}/\"" ```suggestion configure_GCC \ --with-gxx-include-dir="${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/" \ --with-sysroot="${LIBSTDCXX_INCLUDE_PATH}/" && \ ``` https://review.coreboot.org/c/coreboot/+/85275/comment/af2ec73e_2cf529e5?us… : PS12, Line 870: || touch .failed You don't want to build libstdc++ if libgcc failed. ```suggestion $MAKE install-target-libgcc DESTDIR=$DESTDIR && \ ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Gerrit-Change-Number: 85275 Gerrit-PatchSet: 12 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 16 Dec 2024 21:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Felix Singer (Code Review) 16 Dec '24

16 Dec '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85295?usp=email ) Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... 3rdparty/fsp: Update submodule to upstream master Updating from commit id d7931859bfb1: 2024-10-14 15:15:03 +0800 - (NEX MTL-UH_MTL-PS MR1 (4053_58) FSP) to commit id 851f7105d803: 2024-11-22 14:59:29 +0800 - (NEX TGL IPU 2025.1 (7341_01) FSP) This brings in 8 new commits: 851f7105d803 NEX TGL IPU 2025.1 (7341_01) FSP d9d0cfbdf26b NEX RPL-S MR5/RPL-S Refresh MR3 (5401_01) FSP 360733f79a2f NEX RPL-P MR3 (5401_01) FSP 51caa72d5df6 NEX ADL-PS IPU 2025.1 (5401_01) FSP fea3c6643c2f NEX ADL-S IPU 2025.1 (5401_01) FSP 507145c279de NEX ADL-P IPU 2025.1 (5401_01) FSP bd5df1993f52 Merge branch 'master' of https://github.com/intel/FSP e26be9c400db Elkhart Lake IPU2025.1 FSP Change-Id: I56f0179301af7894ed854ed87a4b7a09a8cf11cc Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85295 Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Sean Rhodes: Looks good to me, approved Elyes Haouas: Looks good to me, approved diff --git a/3rdparty/fsp b/3rdparty/fsp index d793185..851f710 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit d7931859bfb1f7949bb455d53b9494dd731e9642 +Subproject commit 851f7105d803672e17202bc2f598a5a4dbf659d3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56f0179301af7894ed854ed87a4b7a09a8cf11cc Gerrit-Change-Number: 85295 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/topton/adl: Disable mapped SATA port
by Alicja Michalska (Code Review) 16 Dec '24

16 Dec '24

Alicja Michalska has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/85609?usp=email ) Change subject: mb/topton/adl: Disable mapped SATA port ...................................................................... mb/topton/adl: Disable mapped SATA port According to Intel mFIT tool, SATA Port 0 is mapped as RP11 (PCI-E). Disable SATA mapping on that port. Change-Id: I9556383952d163a145ac73cb846740a4ce67a1e1 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M src/mainboard/topton/adl/devicetree.cb M src/mainboard/topton/adl/gpio.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/85609/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85609?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9556383952d163a145ac73cb846740a4ce67a1e1 Gerrit-Change-Number: 85609 Gerrit-PatchSet: 2 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>

1 0

[S] Change in coreboot[main]: util/crossgcc: Add libstdcxx target
by Jon Murphy (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel. Hello Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85275?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/crossgcc: Add libstdcxx target ...................................................................... util/crossgcc: Add libstdcxx target Add target for building libstdcxx for a cross compile target using the GCC source downloaded for a cross compiler build and linking against a specified libc implementation. BUG=NONE TEST=Build libstdc++ for cross compilers, link against generated library ./util/crossgcc/buildgcc -t -p arm-eabi -P libstdcxx -l c,c++ -j128 \ --libstdcxx_include /tmp/picolibc Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M util/crossgcc/.gitignore M util/crossgcc/buildgcc 2 files changed, 40 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/85275/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Gerrit-Change-Number: 85275 Gerrit-PatchSet: 12 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[M] Change in coreboot[main]: util/crossgcc: Add libstdcxx target
by Jon Murphy (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel. Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email ) Change subject: util/crossgcc: Add libstdcxx target ...................................................................... Patch Set 11: (3 comments) File util/crossgcc/buildgcc: https://review.coreboot.org/c/coreboot/+/85275/comment/6298449f_d4adf191?us… : PS11, Line 841: ${EXTRA_ARGS} > Can we drop the EXTRA_ARGS and just pass `$@` here? Done https://review.coreboot.org/c/coreboot/+/85275/comment/361261d7_c91f4660?us… : PS11, Line 845: set -- "" : EXTRA_ARGS="$@" > Doesn't this set `EXTRA_ARGS=""`? Yes, was trying to keep the style aligned between functions https://review.coreboot.org/c/coreboot/+/85275/comment/ff7b0c5a_95a579b1?us… : PS11, Line 867: set -- "--with-gxx-include-dir=\"${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/\" : --with-sysroot=\"${LIBSTDCXX_INCLUDE_PATH}/\"" : EXTRA_ARGS="$@" : configure_GCC "${EXTRA_ARGS}" > ```suggestion […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Gerrit-Change-Number: 85275 Gerrit-PatchSet: 11 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 16 Dec 2024 20:57:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>

1 0

[XS] Change in coreboot[main]: mb/topton/adl: Disable mapped SATA port
by Alicja Michalska (Code Review) 16 Dec '24

16 Dec '24

Alicja Michalska has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85609?usp=email ) Change subject: mb/topton/adl: Disable mapped SATA port ...................................................................... mb/topton/adl: Disable mapped SATA port According to Intel mFIT tool, SATA Port 0 is mapped as RP11 (PCI-E). Disable SATA mapping on that port. Change-Id: I9556383952d163a145ac73cb846740a4ce67a1e1 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M src/mainboard/topton/adl/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/85609/1 diff --git a/src/mainboard/topton/adl/devicetree.cb b/src/mainboard/topton/adl/devicetree.cb index f21687a..216589d 100644 --- a/src/mainboard/topton/adl/devicetree.cb +++ b/src/mainboard/topton/adl/devicetree.cb @@ -44,9 +44,9 @@ device ref shared_sram on end # Not working, resource conflict(?) + # Port 0 is configured as PCI-E in FIT (RP11) device ref sata on register "sata_ports_enable" = "{ - [0] = 1, [1] = 1, }" end -- To view, visit https://review.coreboot.org/c/coreboot/+/85609?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9556383952d163a145ac73cb846740a4ce67a1e1 Gerrit-Change-Number: 85609 Gerrit-PatchSet: 1 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>

1 0

[M] Change in coreboot[main]: ec/google/chromeec: Publish LPC GMR address range via CREC _CRS
by Caveh Jalali (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Boris Mittelberg, Gwendal Grignou, Kapil Porwal, Subrata Banik. Caveh Jalali has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85603?usp=email ) Change subject: ec/google/chromeec: Publish LPC GMR address range via CREC _CRS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85603?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib3ea3e2a482f9eceaa8c15e38b7e708b156bc978 Gerrit-Change-Number: 85603 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Mon, 16 Dec 2024 19:53:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: util/intelp2m: Drop non-DWx register analysis support
by Angel Pons (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Benjamin Doron, Maxim, Michael Niewöhner, Paul Menzel. Angel Pons has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/56887?usp=email ) Change subject: util/intelp2m: Drop non-DWx register analysis support ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00 Gerrit-Change-Number: 56887 Gerrit-PatchSet: 19 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 16 Dec 2024 18:01:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: util/intelp2m: Drop non-DWx register analysis support
by Matt DeVillier (Code Review) 16 Dec '24

16 Dec '24

Attention is currently required from: Benjamin Doron, Maxim, Michael Niewöhner, Paul Menzel. Matt DeVillier has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/56887?usp=email ) Change subject: util/intelp2m: Drop non-DWx register analysis support ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00 Gerrit-Change-Number: 56887 Gerrit-PatchSet: 19 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 16 Dec 2024 17:59:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024