coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
2521 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/rull: Add Fn key scancode
by Lei Cao (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou. Lei Cao has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85014?usp=email ) Change subject: mb/google/nissa/var/rull: Add Fn key scancode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85014?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb02d7013fa78233abff556bc6fa1d224c434338 Gerrit-Change-Number: 85014 Gerrit-PatchSet: 1 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lei Cao <caolei6(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 06 Nov 2024 05:39:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: via: Start template for VIA C7 w/ CX700 northbridge
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Nico Huber. Elyes Haouas has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82765?usp=email ) Change subject: via: Start template for VIA C7 w/ CX700 northbridge ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82765/comment/6ef853e8_70959156?us… : PS2, Line 19: > Add links: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I66f678fae0d5a27bb09c0c6c702440900998e574 Gerrit-Change-Number: 82765 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 05:06:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>

1 0

[M] Change in coreboot[main]: via: Start template for VIA C7 w/ CX700 northbridge
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Elyes Haouas has uploaded a new patch set (#4) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82765?usp=email ) Change subject: via: Start template for VIA C7 w/ CX700 northbridge ...................................................................... via: Start template for VIA C7 w/ CX700 northbridge The first steps to bring C7 and CX700 support back mainline. Most is skeleton copied from the `min86' example. The romstage entry is placed in the northbridge code, as that's where we'll perform raminit. Support to read the FSB frequency is added right away, same for a reset function (using CF9 reset), as both are required for a minimal build test. A mainboard VIA EPIA-EX is also introduced for build testing, and in later stages boot testing as well. Links: DS: https://theretroweb.com/chip/documentation/via-cx700-datasheet-feb06-666c8b… PM: https://web.archive.org/web/20180616220857/http://linux.via.com.tw/support/… Change-Id: I66f678fae0d5a27bb09c0c6c702440900998e574 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/cpu/Makefile.mk A src/cpu/via/Kconfig A src/cpu/via/Makefile.mk A src/cpu/via/c7/Kconfig A src/cpu/via/c7/Makefile.mk A src/cpu/via/car/cache_as_ram.S A src/cpu/via/car/exit_car.S A src/mainboard/via/Kconfig A src/mainboard/via/Kconfig.name A src/mainboard/via/epia-ex/Kconfig A src/mainboard/via/epia-ex/Kconfig.name A src/mainboard/via/epia-ex/board_info.txt A src/mainboard/via/epia-ex/devicetree.cb A src/northbridge/via/cx700/Kconfig A src/northbridge/via/cx700/Makefile.mk A src/northbridge/via/cx700/chip.c A src/northbridge/via/cx700/chipset.cb A src/northbridge/via/cx700/clock.c A src/northbridge/via/cx700/reset.c A src/northbridge/via/cx700/romstage.c 20 files changed, 207 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/82765/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/82765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I66f678fae0d5a27bb09c0c6c702440900998e574 Gerrit-Change-Number: 82765 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Suppress stack-usage LTO link warning
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84044?usp=email ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Makefile.mk: Suppress stack-usage LTO link warning ...................................................................... Makefile.mk: Suppress stack-usage LTO link warning Suppress the following warning during linking with gcc: src/drivers/spi/spi_flash.c: In function 'spi_flash_cmd_write': src/drivers/spi/spi_flash.c:138:5: error: stack usage might be unbounded [-Werror=stack-usage=] 138 | int spi_flash_cmd_write(const struct spi_slave *spi, const u8 *cmd, Change-Id: If08d6d543a4fcff07003af8d1f8dd59ab79f42f8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84044 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M Makefile.mk 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Angel Pons: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Makefile.mk b/Makefile.mk index 18ec01a..ca79d05 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -1339,12 +1339,14 @@ fi endif # CONFIG_CBFS_VERIFICATION +LTO_LINK_CFLAGS := -Wno-stack-usage + define link_stage # $1 stage name ifeq ($(CONFIG_LTO),y) $$(objcbfs)/$(1).debug: $$$$($(1)-libs) $$$$($(1)-objs) @printf " LINK $$(subst $$(obj)/,,$$(@))\n" - $$(CC_$(1)) $$(CPPFLAGS_$(1)) $$(CFLAGS_$(1)) $$(LDFLAGS_$(1):%=-Wl,%) -o $$@ -L$$(obj) $$(COMPILER_RT_FLAGS_$(1):%=-Wl,%) -Wl,--whole-archive -Wl,--start-group $$(filter-out %.ld,$$($(1)-objs)) $$($(1)-libs) -Wl,--no-whole-archive $$(COMPILER_RT_$(1)) -Wl,--end-group -T $(call src-to-obj,$(1),$(CONFIG_MEMLAYOUT_LD_FILE)) + $$(CC_$(1)) $$(CPPFLAGS_$(1)) $$(CFLAGS_$(1)) $$(LDFLAGS_$(1):%=-Wl,%) $(LTO_LINK_CFLAGS) -o $$@ -L$$(obj) $$(COMPILER_RT_FLAGS_$(1):%=-Wl,%) -Wl,--whole-archive -Wl,--start-group $$(filter-out %.ld,$$($(1)-objs)) $$($(1)-libs) -Wl,--no-whole-archive $$(COMPILER_RT_$(1)) -Wl,--end-group -T $(call src-to-obj,$(1),$(CONFIG_MEMLAYOUT_LD_FILE)) else $$(objcbfs)/$(1).debug: $$$$($(1)-libs) $$$$($(1)-objs) @printf " LINK $$(subst $$(obj)/,,$$(@))\n" -- To view, visit https://review.coreboot.org/c/coreboot/+/84044?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If08d6d543a4fcff07003af8d1f8dd59ab79f42f8 Gerrit-Change-Number: 84044 Gerrit-PatchSet: 16 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

[S] Change in coreboot[main]: util/cbfstool: Deal with how lld organizes loadable segments
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84043?usp=email ) ( 15 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: util/cbfstool: Deal with how lld organizes loadable segments ...................................................................... util/cbfstool: Deal with how lld organizes loadable segments LLD deals with loadable segments in a different manner than BFD. The MemSiz of the .text loadable section is padded till the virtaddr of the .car.data section. Since .text is not loaded in ENV_CAR this does not matter. Change-Id: I1a0541c8ea3dfbebfba83d505d84b6db12000723 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84043 Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/cbfstool/cbfs-mkstage.c 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/cbfstool/cbfs-mkstage.c b/util/cbfstool/cbfs-mkstage.c index a72b387..cdd353e 100644 --- a/util/cbfstool/cbfs-mkstage.c +++ b/util/cbfstool/cbfs-mkstage.c @@ -311,12 +311,21 @@ } phdrs[size - 2] = cur; - if (prev && (prev->p_paddr + prev->p_memsz != cur->p_paddr || - prev->p_filesz != prev->p_memsz)) { - ERROR("Loadable segments physical addresses should " - "be consecutive\n"); - free(phdrs); - return NULL; + if (prev) { + const bool bfd_is_consecutive = prev->p_paddr + prev->p_memsz == cur->p_paddr + && prev->p_filesz == prev->p_memsz; + /* + * lld pads the memsz of the .text vaddr till the vaddr of car.data. + * Since we don't load XIP stages at runtime, we don't care. + */ + const bool lld_is_consecutive = prev->p_vaddr + prev->p_memsz == cur->p_vaddr; + + if (!bfd_is_consecutive && !lld_is_consecutive) { + ERROR("Loadable segments physical addresses should " + "be consecutive\n"); + free(phdrs); + return NULL; + } } prev = cur; } -- To view, visit https://review.coreboot.org/c/coreboot/+/84043?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1a0541c8ea3dfbebfba83d505d84b6db12000723 Gerrit-Change-Number: 84043 Gerrit-PatchSet: 17 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: tests: Build test using C23
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84890?usp=email ) Change subject: tests: Build test using C23 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/84890?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iefa80b6ba2fdfa91eb23b854f79ea95abf3ec2e1 Gerrit-Change-Number: 84890 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: bn/intel/i945: Correct intel_gma_init_lvds returned value
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83858?usp=email ) Change subject: bn/intel/i945: Correct intel_gma_init_lvds returned value ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/83858?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad9657a4ad44d8b3ad17812397429f04b75d4fa9 Gerrit-Change-Number: 83858 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: tree: Add kconfig option for C23 dialect
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84489?usp=email ) Change subject: tree: Add kconfig option for C23 dialect ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/84489?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6fbfb1bd3ca2ae0e216023f54de792f7cbd5f50c Gerrit-Change-Number: 84489 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>

1 0

[XS] Change in coreboot[main]: [only for test]util/nvidia: Build test using C23
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84891?usp=email ) Change subject: [only for test]util/nvidia: Build test using C23 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/84891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia751873f15a23bad0b951c9ef8ff2d9ba36a7d84 Gerrit-Change-Number: 84891 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: [only for test] lz4/lib; Build test using C23
by Elyes Haouas (Code Review) 06 Nov '24

06 Nov '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84892?usp=email ) Change subject: [only for test] lz4/lib; Build test using C23 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/84892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3dae74eca85b41d15ebfd4015631bb7efc5dbf75 Gerrit-Change-Number: 84892 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024