coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
2521 discussions

[XL] Change in coreboot[main]: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
by Felix Singer (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Angel Pons, Elyes Haouas, Frans Hendriks, Jérémy Compostella, Shuo Liu, Vasiliy Khoruzhick, yuchi.chen(a)intel.com. Felix Singer has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email ) Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC ...................................................................... Patch Set 49: (1 comment) File src/soc/intel/snowridge/acpi/pcie.asl: https://review.coreboot.org/c/coreboot/+/83321/comment/021f364e_b49de4ef?us… : PS28, Line 5: /* Interrupt Map INTA->INTA, INTB->INTB, INTC->INTC, INTD->INTD */ : Name (IQAA, Package() { : Package() { 0x0000ffff, 0, 0, 16 }, : Package() { 0x0000ffff, 1, 0, 17 }, : Package() { 0x0000ffff, 2, 0, 18 }, : Package() { 0x0000ffff, 3, 0, 19 } }) : Name (IQAP, Package() { : Package() { 0x0000ffff, 0, \_SB.LNKA, 0 }, : Package() { 0x0000ffff, 1, \_SB.LNKB, 0 }, : Package() { 0x0000ffff, 2, \_SB.LNKC, 0 }, : Package() { 0x0000ffff, 3, \_SB.LNKD, 0 } }) : : /* Interrupt Map INTA->INTB, INTB->INTC, INTC->INTD, INTD->INTA */ : Name (IQBA, Package() { : Package() { 0x0000ffff, 0, 0, 17 }, : Package() { 0x0000ffff, 1, 0, 18 }, : Package() { 0x0000ffff, 2, 0, 19 }, : Package() { 0x0000ffff, 3, 0, 16 } }) : Name (IQBP, Package() { : Package() { 0x0000ffff, 0, \_SB.LNKB, 0 }, : Package() { 0x0000ffff, 1, \_SB.LNKC, 0 }, : Package() { 0x0000ffff, 2, \_SB.LNKD, 0 }, : Package() { 0x0000ffff, 3, \_SB.LNKA, 0 } }) : : /* Interrupt Map INTA->INTC, INTB->INTD, INTC->INTA, INTD->INTB */ : Name (IQCA, Package() { : Package() { 0x0000ffff, 0, 0, 18 }, : Package() { 0x0000ffff, 1, 0, 19 }, : Package() { 0x0000ffff, 2, 0, 16 }, : Package() { 0x0000ffff, 3, 0, 17 } }) : Name (IQCP, Package() { : Package() { 0x0000ffff, 0, \_SB.LNKC, 0 }, : Package() { 0x0000ffff, 1, \_SB.LNKD, 0 }, : Package() { 0x0000ffff, 2, \_SB.LNKA, 0 }, : Package() { 0x0000ffff, 3, \_SB.LNKB, 0 } }) : : /* Interrupt Map INTA->INTD, INTB->INTA, INTC->INTB, INTD->INTC */ : Name (IQDA, Package() { : Package() { 0x0000ffff, 0, 0, 19 }, : Package() { 0x0000ffff, 1, 0, 16 }, : Package() { 0x0000ffff, 2, 0, 17 }, : Package() { 0x0000ffff, 3, 0, 18 } }) : Name (IQDP, Package() { : Package() { 0x0000ffff, 0, \_SB.LNKD, 0 }, : Package() { 0x0000ffff, 1, \_SB.LNKA, 0 }, : Package() { 0x0000ffff, 2, \_SB.LNKB, 0 }, : Package() { 0x0000ffff, 3, \_SB.LNKC, 0 } }) : : /* Interrupt Map INTA->INTE, INTB->INTF, INTC->INTG, INTD->INTH */ : Name (IQEA, Package() { : Package() { 0x0000ffff, 0, 0, 20 }, : Package() { 0x0000ffff, 1, 0, 21 }, : Package() { 0x0000ffff, 2, 0, 22 }, : Package() { 0x0000ffff, 3, 0, 23 } }) : Name (IQEP, Package() { : Package() { 0x0000ffff, 0, \_SB.LNKE, 0 }, : Package() { 0x0000ffff, 1, \_SB.LNKF, 0 }, : Package() { 0x0000ffff, 2, \_SB.LNKG, 0 }, : Package() { 0x0000ffff, 3, \_SB.LNKH, 0 } }) : : /* Interrupt Map INTA->INTF, INTB->INTG, INTC->INTH, INTD->INTE */ : Name (IQFA, Package() { : Package() { 0x0000ffff, 0, 0, 21 }, : Package() { 0x0000ffff, 1, 0, 22 }, : Package() { 0x0000ffff, 2, 0, 23 }, : Package() { 0x0000ffff, 3, 0, 20 } }) : Name (IQFP, Package() { : Package() { 0x0000ffff, 0, \_SB.LNKF, 0 }, : Package() { 0x0000ffff, 1, \_SB.LNKG, 0 }, : Package() { 0x0000ffff, 2, \_SB.LNKH, 0 }, : Package() { 0x0000ffff, 3, \_SB.LNKE, 0 } }) : : /* Interrupt Map INTA->INTG, INTB->INTH, INTC->INTE, INTD->INTF */ : Name (IQGA, Package() { : Package() { 0x0000ffff, 0, 0, 22 }, : Package() { 0x0000ffff, 1, 0, 23 }, : Package() { 0x0000ffff, 2, 0, 20 }, : Package() { 0x0000ffff, 3, 0, 21 } }) : Name (IQGP, Package() { : Package() { 0x0000ffff, 0, \_SB.LNKG, 0 }, : Package() { 0x0000ffff, 1, \_SB.LNKH, 0 }, : Package() { 0x0000ffff, 2, \_SB.LNKE, 0 }, : Package() { 0x0000ffff, 3, \_SB.LNKF, 0 } }) : : /* Interrupt Map INTA->INTH, INTB->INTE, INTC->INTF, INTD->INTG */ : Name (IQHA, Package() { : Package() { 0x0000ffff, 0, 0, 23 }, : Package() { 0x0000ffff, 1, 0, 20 }, : Package() { 0x0000ffff, 2, 0, 21 }, : Package() { 0x0000ffff, 3, 0, 22 } }) : Name (IQHP, Package() { : Package() { 0x0000ffff, 0, \_SB.LNKH, 0 }, : Package() { 0x0000ffff, 1, \_SB.LNKE, 0 }, : Package() { 0x0000ffff, 2, \_SB.LNKF, 0 }, : Package() { 0x0000ffff, 3, \_SB.LNKG, 0 } }) > Done Very sad. -- To view, visit https://review.coreboot.org/c/coreboot/+/83321?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32ad836dfaaff0d1816eac41e5a7d19ece11080f Gerrit-Change-Number: 83321 Gerrit-PatchSet: 49 Gerrit-Owner: yuchi.chen(a)intel.com Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Vasiliy Khoruzhick <vasilykh(a)arista.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Vasiliy Khoruzhick <vasilykh(a)arista.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 06 Nov 2024 12:52:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: yuchi.chen(a)intel.com Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config
by Subrata Banik (Code Review) 06 Nov '24

06 Nov '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81034?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config ...................................................................... soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config This patch removes the SOC_INTEL_GFX_MBUS_JOIN configuration option. Support for fast modeset joining has been added to the mainline i915 kernel driver (https://patchwork.freedesktop.org/series/130480/), making this coreboot-specific workaround unnecessary. BUG=b:291885733 TEST=Successful build and boot of google/screebo with single and dual displays, no redundant boot splash. Change-Id: Ifb0416df53a453ce16815f9fd52ec6b53fade5e2 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81034 Reviewed-by: Dinesh Gehlot <digehlot(a)google.com> Reviewed-by: YH Lin <yueherngl(a)google.com> Reviewed-by: Paz Zcharya <pazz(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Paz Zcharya: Looks good to me, but someone else must approve Dinesh Gehlot: Looks good to me, approved YH Lin: Looks good to me, but someone else must approve diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index efb49f6..4dc6082 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -94,7 +94,6 @@ select SOC_INTEL_CSE_SEND_EOP_LATE if !MAINBOARD_HAS_CHROMEOS select SOC_INTEL_CSE_SET_EOP select SOC_INTEL_IOE_DIE_SUPPORT - select SOC_INTEL_GFX_MBUS_JOIN if MAINBOARD_HAS_CHROMEOS && BMP_LOGO select SOC_INTEL_GFX_NON_PREFETCHABLE_MMIO select SOC_INTEL_MEM_MAPPED_PM_CONFIGURATION select SSE2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81034?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb0416df53a453ce16815f9fd52ec6b53fade5e2 Gerrit-Change-Number: 81034 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config
by Subrata Banik (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Paul Menzel, Tarun. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/81034?usp=email ) Change subject: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config ...................................................................... Patch Set 4: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/81034?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb0416df53a453ce16815f9fd52ec6b53fade5e2 Gerrit-Change-Number: 81034 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 12:47:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config
by Subrata Banik (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Paul Menzel, Tarun. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/81034?usp=email ) Change subject: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81034?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb0416df53a453ce16815f9fd52ec6b53fade5e2 Gerrit-Change-Number: 81034 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 12:47:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config
by Subrata Banik (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Paul Menzel, Tarun. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/81034?usp=email ) Change subject: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > We have seen some regression hence, will hold this CL for now. okay to land now. -- To view, visit https://review.coreboot.org/c/coreboot/+/81034?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb0416df53a453ce16815f9fd52ec6b53fade5e2 Gerrit-Change-Number: 81034 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 10:54:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config
by Subrata Banik (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Paul Menzel, Tarun. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/81034?usp=email ) Change subject: soc/intel/meteorlake: Remove SOC_INTEL_GFX_MBUS_JOIN config ...................................................................... Patch Set 3: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/81034?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb0416df53a453ce16815f9fd52ec6b53fade5e2 Gerrit-Change-Number: 81034 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 10:53:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/intel/coffeelake_rvp/cml_u: Correct number of jacks in hda_verb.c
by Felix Singer (Code Review) 06 Nov '24

06 Nov '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84487?usp=email ) Change subject: mb/intel/coffeelake_rvp/cml_u: Correct number of jacks in hda_verb.c ...................................................................... mb/intel/coffeelake_rvp/cml_u: Correct number of jacks in hda_verb.c This was found due to the `_Static_assert()` from CB:84360 failing. As I do not own this board, I cannot test whether is change is "functionally correct". However, I believe it is more likely that the original authors forgot to update the verb table size, rather than them adding additional verb data which was not meant to be used. TEST=`_Static_assert()` mentioned above does not fail anymore. Change-Id: I8df44e056bc841bfb344749ba214e6fb71a1955b Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84487 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c index 01012dd..3adda00 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c @@ -6,7 +6,7 @@ /* ALC 700 */ 0x10EC0700, 0xFFFFFFFF, - 0x00000023, + 161, AZALIA_SUBVENDOR(0, 0x10EC10F2), AZALIA_PIN_CFG(0, 0x01, 0x00000000), -- To view, visit https://review.coreboot.org/c/coreboot/+/84487?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8df44e056bc841bfb344749ba214e6fb71a1955b Gerrit-Change-Number: 84487 Gerrit-PatchSet: 5 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/intel/coffeelake_rvp/cml_u: Correct number of jacks in hda_verb.c
by Felix Singer (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Nicholas Sudsgaard. Felix Singer has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/84487?usp=email ) Change subject: mb/intel/coffeelake_rvp/cml_u: Correct number of jacks in hda_verb.c ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84487?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8df44e056bc841bfb344749ba214e6fb71a1955b Gerrit-Change-Number: 84487 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 10:33:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/ifdtool: Fix invalid pointer dereference
by Subrata Banik (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Yu-Ping Wu. Subrata Banik has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/85016?usp=email ) Change subject: util/ifdtool: Fix invalid pointer dereference ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85016?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic9557d8fc8ae9e4c12114ee170bfc90d5e149df9 Gerrit-Change-Number: 85016 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 08:58:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/ifdtool: Fix invalid pointer dereference
by Yu-Ping Wu (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Subrata Banik. Hello Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85016?usp=email to look at the new patch set (#2). Change subject: util/ifdtool: Fix invalid pointer dereference ...................................................................... util/ifdtool: Fix invalid pointer dereference When calculating the GPR0 protection range, currently the offsets of "CSE data partition offset" and FPT are not checked. Invalid pointer dereference may lead to segmentation fault. Ensure the offset is within the image size before accessing the pointer. Change-Id: Ic9557d8fc8ae9e4c12114ee170bfc90d5e149df9 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M util/ifdtool/ifdtool.c 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/85016/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85016?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic9557d8fc8ae9e4c12114ee170bfc90d5e149df9 Gerrit-Change-Number: 85016 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024