coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
2521 discussions

[M] Change in coreboot[main]: drivers/spi: add RPMC info to spi_flash struct
by Matt DeVillier (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Felix Held. Matt DeVillier has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/85009?usp=email ) Change subject: drivers/spi: add RPMC info to spi_flash struct ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a8332bffe93e1691f6fc87c3936025f158f3ab9 Gerrit-Change-Number: 85009 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 21:20:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/asrock: Add Asrock Industrial IMB-1222 motherboard
by Maxim (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Elyes Haouas, Maxim. Hello Elyes Haouas, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83107?usp=email to look at the new patch set (#32). Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard ...................................................................... mb/asrock: Add Asrock Industrial IMB-1222 motherboard ASRock IMB-1222 Intel Comet Lake-S Q470E industrial thin mini-ITX motherboard [1]. Working: - Dual Channel DDR4 2933/2666/2400 MHz; - Intel UHD Graphics (VGA Option ROM, libgfxinit, GOP driver); - DP (both), HDMI; - PCIe x16 Slot (Gen3); - SATA ports; - USB 2.0 ports; - USB 3.2 ports; - M.2 Key-E 2230 slot for Wireless (PCIe x1, USB 2.0 and CNVi); - M.2 Key-B 3042/3052 slot for 4G/5G modem (PCIe x1); - M.2 Key-M 2242/2260/2280 for SSD/NVMe (PCIE x4, SATA3); - LAN1 Intel I225LM/I225V, 10/100/1000/2500 Mbps; - LAN2 Intel I219LM, 10/100/1000 Mbps; - Realtek ALC887 HD Audio (line-out, mic-in); - COM 1/2/3/4 ports; - onboard speaker; - HWM/FANs control (fintek f81966); - S3 suspend and wake; - TPM; - disabling ME with me_cleaner [2]; Payload: - Linux as payload; - LinuxBoot; - SeaBIOS; - edk2 [3]. Bootable OS: - Ubuntu 22.04 (Linux 6.5.0-15-generic); - Ubuntu 24.04 (Linux 6.8.0-41-generic); - Microsoft Windows 10 Pro (10.0.19045.4780, 22H2 2022); - Andoid 13, Bliss OS x86_64 (16.9.7, Linux 6.1.112-gloria-xanmod1). Unknown/untested: - USB3.0 in M.2 Key-B 3042/3052 slot; - eDP/LVDS; - PCIe riser cards; - SPDIF. There is no schematic/boardview, reverse engineering only. This port is based on system76/bonw14 because it has a similar topology. [1] https://web.archive.org/web/20220924171403/https:// www.asrockind.com/en-gb/IMB-1222 [2] XutaxKamay's me_cleaner fork, https://github.com/XutaxKamay/me_cleaner, v1.2-9-gf20532d [3] MrChromebox's edk2 fork, https://github.com/mrchromebox/edk2 uefipayload_2408 branch Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A Documentation/mainboard/asrock/imb-1222.md M Documentation/mainboard/index.md A src/mainboard/asrock/imb-1222/Kconfig A src/mainboard/asrock/imb-1222/Kconfig.name A src/mainboard/asrock/imb-1222/Makefile.mk A src/mainboard/asrock/imb-1222/acpi/mainboard.asl A src/mainboard/asrock/imb-1222/acpi/sleep.asl A src/mainboard/asrock/imb-1222/beep.c A src/mainboard/asrock/imb-1222/board_info.txt A src/mainboard/asrock/imb-1222/bootblock.c A src/mainboard/asrock/imb-1222/cmos.default A src/mainboard/asrock/imb-1222/cmos.layout A src/mainboard/asrock/imb-1222/data.vbt A src/mainboard/asrock/imb-1222/devicetree.cb A src/mainboard/asrock/imb-1222/dsdt.asl A src/mainboard/asrock/imb-1222/gma-mainboard.ads A src/mainboard/asrock/imb-1222/gpio.c A src/mainboard/asrock/imb-1222/hda_verb.c A src/mainboard/asrock/imb-1222/include/mainboard/beep.h A src/mainboard/asrock/imb-1222/include/mainboard/gpio.h A src/mainboard/asrock/imb-1222/include/mainboard/superio.h A src/mainboard/asrock/imb-1222/panic.c A src/mainboard/asrock/imb-1222/ramstage.c A src/mainboard/asrock/imb-1222/romstage.c A src/mainboard/asrock/imb-1222/superio.c 25 files changed, 1,372 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/83107/32 -- To view, visit https://review.coreboot.org/c/coreboot/+/83107?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8 Gerrit-Change-Number: 83107 Gerrit-PatchSet: 32 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XL] Change in coreboot[main]: mb/asrock: Add Asrock Industrial IMB-1222 motherboard
by Maxim (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Elyes Haouas, Maxim. Hello Elyes Haouas, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83107?usp=email to look at the new patch set (#31). Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard ...................................................................... mb/asrock: Add Asrock Industrial IMB-1222 motherboard ASRock IMB-1222 Intel Comet Lake-S Q470E industrial thin mini-ITX motherboard [1]. Working: - Dual Channel DDR4 2933/2666/2400 MHz; - Intel UHD Graphics (VGA Option ROM, libgfxinit, GOP driver); - DP (both), HDMI; - PCIe x16 Slot (Gen3); - SATA ports; - USB 2.0 ports; - USB 3.2 ports; - M.2 Key-E 2230 slot for Wireless (PCIe x1, USB 2.0 and CNVi); - M.2 Key-B 3042/3052 slot for 4G/5G modem (PCIe x1); - M.2 Key-M 2242/2260/2280 for SSD/NVMe (PCIE x4, SATA3); - LAN1 Intel I225LM/I225V, 10/100/1000/2500 Mbps; - LAN2 Intel I219LM, 10/100/1000 Mbps; - Realtek ALC887 HD Audio (line-out, mic-in); - COM 1/2/3/4 ports; - onboard speaker; - HWM/FANs control (fintek f81966); - S3 suspend and wake; - TPM; - disabling ME with me_cleaner [2]; Payload: - Linux as payload; - LinuxBoot; - SeaBIOS; - edk2 [3]. Bootable OS: - Ubuntu 22.04 (Linux 6.5.0-15-generic); - Ubuntu 24.04 (Linux 6.8.0-41-generic); - Microsoft Windows 10 Pro (10.0.19045.4780, 22H2 2022); - Andoid 13, Bliss OS x86_64 (16.9.7, Linux 6.1.112-gloria-xanmod1). Unknown/untested: - USB3.0 in M.2 Key-B 3042/3052 slot; - eDP/LVDS; - PCIe riser cards; - SPDIF. There is no schematic/boardview, reverse engineering only. This port is based on system76/bonw14 because it has a similar topology. [1] https://web.archive.org/web/20220924171403/https:// www.asrockind.com/en-gb/IMB-1222 [2] XutaxKamay's me_cleaner fork, https://github.com/XutaxKamay/me_cleaner, v1.2-9-gf20532d [3] MrChromebox's edk2 fork, https://github.com/mrchromebox/edk2 uefipayload_2408 branch Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A Documentation/mainboard/asrock/imb-1222.md M Documentation/mainboard/index.md A src/mainboard/asrock/imb-1222/Kconfig A src/mainboard/asrock/imb-1222/Kconfig.name A src/mainboard/asrock/imb-1222/Makefile.mk A src/mainboard/asrock/imb-1222/acpi/mainboard.asl A src/mainboard/asrock/imb-1222/acpi/sleep.asl A src/mainboard/asrock/imb-1222/beep.c A src/mainboard/asrock/imb-1222/board_info.txt A src/mainboard/asrock/imb-1222/bootblock.c A src/mainboard/asrock/imb-1222/cmos.default A src/mainboard/asrock/imb-1222/cmos.layout A src/mainboard/asrock/imb-1222/data.vbt A src/mainboard/asrock/imb-1222/devicetree.cb A src/mainboard/asrock/imb-1222/dsdt.asl A src/mainboard/asrock/imb-1222/gma-mainboard.ads A src/mainboard/asrock/imb-1222/gpio.c A src/mainboard/asrock/imb-1222/hda_verb.c A src/mainboard/asrock/imb-1222/include/mainboard/beep.h A src/mainboard/asrock/imb-1222/include/mainboard/gpio.h A src/mainboard/asrock/imb-1222/include/mainboard/superio.h A src/mainboard/asrock/imb-1222/panic.c A src/mainboard/asrock/imb-1222/ramstage.c A src/mainboard/asrock/imb-1222/romstage.c A src/mainboard/asrock/imb-1222/superio.c 25 files changed, 1,454 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/83107/31 -- To view, visit https://review.coreboot.org/c/coreboot/+/83107?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8 Gerrit-Change-Number: 83107 Gerrit-PatchSet: 31 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XL] Change in coreboot[main]: mb/asrock: Add Asrock Industrial IMB-1222 motherboard
by Maxim (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Elyes Haouas, Maxim. Hello Elyes Haouas, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83107?usp=email to look at the new patch set (#30). The following approvals got outdated and were removed: Code-Review+1 by Elyes Haouas, Verified+1 by build bot (Jenkins) Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard ...................................................................... mb/asrock: Add Asrock Industrial IMB-1222 motherboard ASRock IMB-1222 Intel Comet Lake-S Q470E industrial thin mini-ITX motherboard [1]. Working: - Dual Channel DDR4 2933/2666/2400 MHz; - Intel UHD Graphics (VGA Option ROM, libgfxinit, GOP driver); - DP (both), HDMI; - PCIe x16 Slot (Gen3); - SATA ports; - USB 2.0 ports; - USB 3.2 ports; - M.2 Key-E 2230 slot for Wireless (PCIe x1, USB 2.0 and CNVi); - M.2 Key-B 3042/3052 slot for 4G/5G modem (PCIe x1); - M.2 Key-M 2242/2260/2280 for SSD/NVMe (PCIE x4, SATA3); - LAN1 Intel I225LM/I225V, 10/100/1000/2500 Mbps; - LAN2 Intel I219LM, 10/100/1000 Mbps; - Realtek ALC887 HD Audio (line-out, mic-in); - COM 1/2/3/4 ports; - onboard speaker; - HWM/FANs control (fintek f81966); - S3 suspend and wake; - TPM; - disabling ME with me_cleaner [2]; Payload: - Linux as payload; - LinuxBoot; - SeaBIOS; - edk2 [3]. Bootable OS: - Ubuntu 22.04 (Linux 6.5.0-15-generic); - Ubuntu 24.04 (Linux 6.8.0-41-generic); - Microsoft Windows 10 Pro (10.0.19045.4780, 22H2 2022); - Andoid 13, Bliss OS x86_64 (16.9.7, Linux 6.1.112-gloria-xanmod1). Unknown/untested: - USB3.0 in M.2 Key-B 3042/3052 slot; - eDP/LVDS; - PCIe riser cards; - SPDIF. There is no schematic/boardview, reverse engineering only. This port is based on system76/bonw14 because it has a similar topology. [1] https://web.archive.org/web/20220924171403/https:// www.asrockind.com/en-gb/IMB-1222 [2] XutaxKamay's me_cleaner fork, https://github.com/XutaxKamay/me_cleaner, v1.2-9-gf20532d [3] MrChromebox's edk2 fork, https://github.com/mrchromebox/edk2 uefipayload_2408 branch Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A Documentation/mainboard/asrock/imb-1222.md M Documentation/mainboard/index.md A src/mainboard/asrock/imb-1222/Kconfig A src/mainboard/asrock/imb-1222/Kconfig.name A src/mainboard/asrock/imb-1222/Makefile.mk A src/mainboard/asrock/imb-1222/acpi/mainboard.asl A src/mainboard/asrock/imb-1222/acpi/sleep.asl A src/mainboard/asrock/imb-1222/beep.c A src/mainboard/asrock/imb-1222/board_info.txt A src/mainboard/asrock/imb-1222/bootblock.c A src/mainboard/asrock/imb-1222/cmos.default A src/mainboard/asrock/imb-1222/cmos.layout A src/mainboard/asrock/imb-1222/data.vbt A src/mainboard/asrock/imb-1222/devicetree.cb A src/mainboard/asrock/imb-1222/dsdt.asl A src/mainboard/asrock/imb-1222/gma-mainboard.ads A src/mainboard/asrock/imb-1222/gpio.c A src/mainboard/asrock/imb-1222/hda_verb.c A src/mainboard/asrock/imb-1222/include/mainboard/beep.h A src/mainboard/asrock/imb-1222/include/mainboard/gpio.h A src/mainboard/asrock/imb-1222/include/mainboard/superio.h A src/mainboard/asrock/imb-1222/panic.c A src/mainboard/asrock/imb-1222/ramstage.c A src/mainboard/asrock/imb-1222/romstage.c A src/mainboard/asrock/imb-1222/superio.c 25 files changed, 1,454 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/83107/30 -- To view, visit https://review.coreboot.org/c/coreboot/+/83107?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8 Gerrit-Change-Number: 83107 Gerrit-PatchSet: 30 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: mb/asus/p5qc: Add ASUS P5Q-E as a variant
by Martin L Roth (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Name of user not set #1004033, Paul Menzel, Stefan Ott. Martin L Roth has posted comments on this change by Name of user not set #1004033. ( https://review.coreboot.org/c/coreboot/+/60011?usp=email ) Change subject: mb/asus/p5qc: Add ASUS P5Q-E as a variant ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60011/comment/72d07b72_a1aec5cd?us… : PS1, Line 10: yhaenggi > It’d be great if you added your full name here. To get this moving, we're going to ignore this issue. File src/mainboard/asus/p5qc/variants/p5q_e/devicetree.cb: https://review.coreboot.org/c/coreboot/+/60011/comment/5a78cbad_4d5526f6?us… : PS1, Line 100: SMbus > SMBus This is minor and can be fixed in a follow-on patch if desired. -- To view, visit https://review.coreboot.org/c/coreboot/+/60011?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3e8415fe88a421c529308279381aa62e2160e171 Gerrit-Change-Number: 60011 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1004033 Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Name of user not set #1004033 Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XL] Change in coreboot[main]: mb/teleplatforms/D4E4S16P8: Add CRB using intel/denverton_ns
by Martin L Roth (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Angel Pons, Dmitry Ponamorev, King Sumo, Kyösti Mälkki, Mariusz Szafrański, Michal Motyl, Patrick Rudolph, Suresh Bellampalli, Vanessa Eusebio. Martin L Roth has posted comments on this change by Dmitry Ponamorev. ( https://review.coreboot.org/c/coreboot/+/57194?usp=email ) Change subject: mb/teleplatforms/D4E4S16P8: Add CRB using intel/denverton_ns ...................................................................... Patch Set 26: (1 comment) Patchset: PS26: Anyone interested in working on this? Can anyone test this? -- To view, visit https://review.coreboot.org/c/coreboot/+/57194?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If654fc7a391643b50f2e52755fd7c11a37bfd188 Gerrit-Change-Number: 57194 Gerrit-PatchSet: 26 Gerrit-Owner: Dmitry Ponamorev <dponamorev(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dmitry Ponamorev <dponamorev(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: King Sumo <kingsumos(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Dmitry Ponamorev <dponamorev(a)gmail.com> Gerrit-Attention: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Attention: King Sumo <kingsumos(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:40:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/teleplatforms/D4E4S16P8: Remove extra highspeed pad configurations
by Martin L Roth (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Angel Pons, Kyösti Mälkki. Martin L Roth has posted comments on this change by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/60092?usp=email ) Change subject: mb/teleplatforms/D4E4S16P8: Remove extra highspeed pad configurations ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: Needs a manual rebase, but looks fine to me otherwise so long as the 20-lane sku is all it's used on. -- To view, visit https://review.coreboot.org/c/coreboot/+/60092?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64a705ed3cb1d787031818e50c3f9dd8d7f1d8ed Gerrit-Change-Number: 60092 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dmitry Ponamorev <dponamorev(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:38:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/denverton_ns/cpu: Get CPU frequencies for SMBIOS type 4
by Martin L Roth (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Mariusz Szafrański, Michal Motyl, Name of user not set #1004162, Patrick Rudolph, Suresh Bellampalli, Vanessa Eusebio. Martin L Roth has posted comments on this change by Name of user not set #1004162. ( https://review.coreboot.org/c/coreboot/+/62270?usp=email ) Change subject: soc/intel/denverton_ns/cpu: Get CPU frequencies for SMBIOS type 4 ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6249b0f74b34ec5ca73351eda00604089b7c3581 Gerrit-Change-Number: 62270 Gerrit-PatchSet: 9 Gerrit-Owner: Name of user not set #1004162 Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: King Sumo <kingsumos(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Name of user not set #1004162 Gerrit-Attention: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:35:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: Documentation: Update Protectli fw6b documentations
by Martin L Roth (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Felix Singer, Paul Menzel, Xue Yao. Martin L Roth has posted comments on this change by Xue Yao. ( https://review.coreboot.org/c/coreboot/+/63016?usp=email ) Change subject: Documentation: Update Protectli fw6b documentations ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63016?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4938d81d57fc8172fefcc00222806fff0735d503 Gerrit-Change-Number: 63016 Gerrit-PatchSet: 5 Gerrit-Owner: Xue Yao <xueyao(a)xyte.ch> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Xue Yao <xueyao(a)xyte.ch> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: apple/macbook21: configure the clockgen and add C3 CPU state
by Martin L Roth (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Arthur Heymans, Felix Held, Ferass El Hafidi, Nico Huber, Paul Menzel. Martin L Roth has posted comments on this change by Ferass El Hafidi. ( https://review.coreboot.org/c/coreboot/+/63587?usp=email ) Change subject: apple/macbook21: configure the clockgen and add C3 CPU state ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: Can anyone test this? -- To view, visit https://review.coreboot.org/c/coreboot/+/63587?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib97f95599fbdf66aa55e936bdcb9cc0cd69b3824 Gerrit-Change-Number: 63587 Gerrit-PatchSet: 11 Gerrit-Owner: Ferass El Hafidi <vitali64pmemail(a)protonmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Ferass El Hafidi <vitali64pmemail(a)protonmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:31:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024