coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
2521 discussions

[XS] Change in coreboot[main]: device/device.h: Remove static.h include
by Felix Singer (Code Review) 10 Nov '24

10 Nov '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84590?usp=email ) Change subject: device/device.h: Remove static.h include ...................................................................... device/device.h: Remove static.h include As per commit 865173153760 ("sconfig: Move config_of_soc from device.h to static.h") and commit 05a13e7ed9b9 ("sconfig: Move (WEAK_)DEV_PTR from device.h to static.h"), sources that require access to the devicetree should directly include static.h. This allows static.h to be removed from device.h, eliminating many unnecessary dependencies on the devicetree for objects that only need the device types and function declarations. Now that static.h has been included throughout the tree where necessary, it can be removed from device.h. Change-Id: Ie72840c71ffca2ada82456dda6a2c813f6a6c3ad Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84590 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/include/device/device.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/include/device/device.h b/src/include/device/device.h index 6b4f64c..f28a46b 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -9,7 +9,6 @@ #include <device/pci_type.h> #include <device/resource.h> /* IWYU pragma: export */ #include <smbios.h> -#include <static.h> #include <stdlib.h> #include <types.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/84590?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie72840c71ffca2ada82456dda6a2c813f6a6c3ad Gerrit-Change-Number: 84590 Gerrit-PatchSet: 13 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: device/device.h: Remove static.h include
by Felix Singer (Code Review) 10 Nov '24

10 Nov '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84590?usp=email ) Change subject: device/device.h: Remove static.h include ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84590?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie72840c71ffca2ada82456dda6a2c813f6a6c3ad Gerrit-Change-Number: 84590 Gerrit-PatchSet: 12 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Nov 2024 19:12:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: tree: Include static.h for remaining devicetree usages
by Felix Singer (Code Review) 10 Nov '24

10 Nov '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84591?usp=email ) Change subject: tree: Include static.h for remaining devicetree usages ...................................................................... tree: Include static.h for remaining devicetree usages As per commit 865173153760 ("sconfig: Move config_of_soc from device.h to static.h") and commit 05a13e7ed9b9 ("sconfig: Move (WEAK_)DEV_PTR from device.h to static.h"), sources that use code generated from the devicetree should directly include static.h. This allows static.h to be removed from device.h, eliminating many unnecessary dependencies on the devicetree for objects that only need the device types and function declarations. Add static.h to the includes of all remaining files that require static devicetree access through config_of_soc(), the sconfig generated names, or DEV_PTR(). Change-Id: I1d35ff2ac22f9ff5e0aa38b7ad707619e50387f3 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84591 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/cpu/intel/model_206ax/model_206ax_init.c M src/mainboard/starlabs/starfighter/variants/rpl/devtree.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/soc/intel/common/block/systemagent/systemagent.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c 6 files changed, 6 insertions(+), 0 deletions(-) Approvals: Angel Pons: Looks good to me, approved build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/cpu/intel/model_206ax/model_206ax_init.c b/src/cpu/intel/model_206ax/model_206ax_init.c index 4fa8cef..23310a3 100644 --- a/src/cpu/intel/model_206ax/model_206ax_init.c +++ b/src/cpu/intel/model_206ax/model_206ax_init.c @@ -18,6 +18,7 @@ #include <cpu/intel/common/common.h> #include <smbios.h> #include <smp/node.h> +#include <static.h> #include <types.h> /* Convert time in seconds to POWER_LIMIT_1_TIME MSR value */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devtree.c b/src/mainboard/starlabs/starfighter/variants/rpl/devtree.c index 5d2b8f6..9d4bb69 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devtree.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devtree.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h> diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 1be9421..5507443 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -11,6 +11,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> +#include <static.h> #include <string.h> #include <stdlib.h> #include <cpu/x86/mp.h> diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index b358202..098c3c4 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -15,6 +15,7 @@ #include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/systemagent.h> +#include <static.h> #include <types.h> #include "systemagent_def.h" diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index 0adc1b9..9c26e2c 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -21,6 +21,7 @@ #include <southbridge/intel/common/pmutil.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/rcba_pirq.h> +#include <static.h> #define NMI_OFF 0 diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c index 0a3e26f..a955dfe 100644 --- a/src/southbridge/intel/i82801jx/lpc.c +++ b/src/southbridge/intel/i82801jx/lpc.c @@ -22,6 +22,7 @@ #include <southbridge/intel/common/pmutil.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/rcba_pirq.h> +#include <static.h> #define NMI_OFF 0 -- To view, visit https://review.coreboot.org/c/coreboot/+/84591?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d35ff2ac22f9ff5e0aa38b7ad707619e50387f3 Gerrit-Change-Number: 84591 Gerrit-PatchSet: 13 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: tree: Include static.h for remaining devicetree usages
by Felix Singer (Code Review) 10 Nov '24

10 Nov '24

Attention is currently required from: Nicholas Chin, Sean Rhodes. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84591?usp=email ) Change subject: tree: Include static.h for remaining devicetree usages ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84591?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d35ff2ac22f9ff5e0aa38b7ad707619e50387f3 Gerrit-Change-Number: 84591 Gerrit-PatchSet: 12 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Nov 2024 19:12:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/*: Explicitly include static.h for DEV_PTR
by Felix Singer (Code Review) 10 Nov '24

10 Nov '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84678?usp=email ) Change subject: mb/google/*: Explicitly include static.h for DEV_PTR ...................................................................... mb/google/*: Explicitly include static.h for DEV_PTR As per commit 05a13e7ed9b9 ("sconfig: Move (WEAK_)DEV_PTR from device.h to static.h"), sources that require access to devicetree static devices should directly include static.h. This allows static.h to be removed from device.h, eliminating unnecessary dependencies on the devicetree for objects that only need the device types and function declarations. The DEV_PTR macro resolves to names declared in static_devices.h, which is then included in static.h, so include the header whenever the macro is used. Change-Id: I05662e601af00866b7f26f4c6c6794b491bf676e Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84678 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Jayvik Desai <jayvik(a)google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brox/variants/brox/fw_config.c M src/mainboard/google/brox/variants/brox/ramstage.c M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/agah/variant.c M src/mainboard/google/brya/variants/aurash/ramstage.c M src/mainboard/google/brya/variants/craask/variant.c M src/mainboard/google/brya/variants/craaskov/variant.c M src/mainboard/google/brya/variants/hades/variant.c M src/mainboard/google/brya/variants/joxer/variant.c M src/mainboard/google/brya/variants/kinox/ramstage.c M src/mainboard/google/brya/variants/moli/ramstage.c M src/mainboard/google/brya/variants/primus/variant.c M src/mainboard/google/brya/variants/quandiso/variant.c M src/mainboard/google/brya/variants/vell/variant.c M src/mainboard/google/brya/variants/yaviks/variant.c M src/mainboard/google/brya/variants/yavilla/variant.c M src/mainboard/google/guybrush/mainboard.c M src/mainboard/google/guybrush/port_descriptors.c M src/mainboard/google/guybrush/variants/guybrush/variant.c M src/mainboard/google/guybrush/variants/nipperkin/ramstage.c M src/mainboard/google/hatch/variants/jinlon/mainboard.c M src/mainboard/google/rex/mainboard.c M src/mainboard/google/skyrim/mainboard.c M src/mainboard/google/volteer/mainboard.c M src/mainboard/google/volteer/variants/collis/variant.c M src/mainboard/google/volteer/variants/copano/variant.c M src/mainboard/google/volteer/variants/delbin/variant.c M src/mainboard/google/volteer/variants/drobit/variant.c M src/mainboard/google/volteer/variants/volteer2/variant.c M src/mainboard/google/zork/variants/berknip/variant.c M src/mainboard/google/zork/variants/ezkinil/variant.c M src/mainboard/google/zork/variants/morphius/variant.c 32 files changed, 32 insertions(+), 0 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Jayvik Desai: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brox/variants/brox/fw_config.c b/src/mainboard/google/brox/variants/brox/fw_config.c index 8599706..28afd3a 100644 --- a/src/mainboard/google/brox/variants/brox/fw_config.c +++ b/src/mainboard/google/brox/variants/brox/fw_config.c @@ -4,6 +4,7 @@ #include <drivers/intel/ish/chip.h> #include <fw_config.h> #include <gpio.h> +#include <static.h> #define ISH_FIRMWARE_NAME "brox_ish.bin" diff --git a/src/mainboard/google/brox/variants/brox/ramstage.c b/src/mainboard/google/brox/variants/brox/ramstage.c index aef7a00..83d7996 100644 --- a/src/mainboard/google/brox/variants/brox/ramstage.c +++ b/src/mainboard/google/brox/variants/brox/ramstage.c @@ -5,6 +5,7 @@ #include <device/pci_ids.h> #include <ec/google/chromeec/ec.h> #include <intelblocks/power_limit.h> +#include <static.h> /* * SKU_ID, TDP (Watts), pl1_min (milliWatts), pl1_max (milliWatts), diff --git a/src/mainboard/google/brya/mainboard.c b/src/mainboard/google/brya/mainboard.c index 07aa4b5..3d33f6f 100644 --- a/src/mainboard/google/brya/mainboard.c +++ b/src/mainboard/google/brya/mainboard.c @@ -11,6 +11,7 @@ #include <security/tpm/tss.h> #include <soc/gpio.h> #include <soc/ramstage.h> +#include <static.h> #include <stdio.h> WEAK_DEV_PTR(rp6_wwan); diff --git a/src/mainboard/google/brya/variants/agah/variant.c b/src/mainboard/google/brya/variants/agah/variant.c index 9acee54..0372033 100644 --- a/src/mainboard/google/brya/variants/agah/variant.c +++ b/src/mainboard/google/brya/variants/agah/variant.c @@ -7,6 +7,7 @@ #include <delay.h> #include <device/pci.h> #include <gpio.h> +#include <static.h> #include <timer.h> #include <types.h> diff --git a/src/mainboard/google/brya/variants/aurash/ramstage.c b/src/mainboard/google/brya/variants/aurash/ramstage.c index 700d173..b8845d9 100644 --- a/src/mainboard/google/brya/variants/aurash/ramstage.c +++ b/src/mainboard/google/brya/variants/aurash/ramstage.c @@ -11,6 +11,7 @@ #include <fw_config.h> #include <intelblocks/power_limit.h> #include <drivers/intel/dptf/chip.h> +#include <static.h> const struct cpu_power_limits limits[] = { /* SKU_ID, TDP (Watts), pl1_min, pl1_max, pl2_min, pl2_max, pl4 */ diff --git a/src/mainboard/google/brya/variants/craask/variant.c b/src/mainboard/google/brya/variants/craask/variant.c index 24d7e00..5f6076e 100644 --- a/src/mainboard/google/brya/variants/craask/variant.c +++ b/src/mainboard/google/brya/variants/craask/variant.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <fw_config.h> #include <sar.h> +#include <static.h> const char *get_wifi_sar_cbfs_filename(void) { diff --git a/src/mainboard/google/brya/variants/craaskov/variant.c b/src/mainboard/google/brya/variants/craaskov/variant.c index 4a06f10..406d604 100644 --- a/src/mainboard/google/brya/variants/craaskov/variant.c +++ b/src/mainboard/google/brya/variants/craaskov/variant.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <fw_config.h> #include <sar.h> +#include <static.h> const char *get_wifi_sar_cbfs_filename(void) { diff --git a/src/mainboard/google/brya/variants/hades/variant.c b/src/mainboard/google/brya/variants/hades/variant.c index 48e2652..7a258fb 100644 --- a/src/mainboard/google/brya/variants/hades/variant.c +++ b/src/mainboard/google/brya/variants/hades/variant.c @@ -7,6 +7,7 @@ #include <delay.h> #include <device/pci.h> #include <gpio.h> +#include <static.h> #include <timer.h> #include <types.h> diff --git a/src/mainboard/google/brya/variants/joxer/variant.c b/src/mainboard/google/brya/variants/joxer/variant.c index e371ada..1f2ea9f 100644 --- a/src/mainboard/google/brya/variants/joxer/variant.c +++ b/src/mainboard/google/brya/variants/joxer/variant.c @@ -8,6 +8,7 @@ #include <fw_config.h> #include <soc/bootblock.h> #include <sar.h> +#include <static.h> WEAK_DEV_PTR(dptf_policy); diff --git a/src/mainboard/google/brya/variants/kinox/ramstage.c b/src/mainboard/google/brya/variants/kinox/ramstage.c index 3063c62..c343c04 100644 --- a/src/mainboard/google/brya/variants/kinox/ramstage.c +++ b/src/mainboard/google/brya/variants/kinox/ramstage.c @@ -9,6 +9,7 @@ #include <drivers/intel/dptf/chip.h> #include <ec/google/chromeec/ec.h> #include <intelblocks/power_limit.h> +#include <static.h> WEAK_DEV_PTR(dptf_policy); diff --git a/src/mainboard/google/brya/variants/moli/ramstage.c b/src/mainboard/google/brya/variants/moli/ramstage.c index 2be75e4..af26697 100644 --- a/src/mainboard/google/brya/variants/moli/ramstage.c +++ b/src/mainboard/google/brya/variants/moli/ramstage.c @@ -13,6 +13,7 @@ #include <drivers/intel/dptf/chip.h> #include <boardid.h> #include <soc/intel/common/block/pcie/rtd3/chip.h> +#include <static.h> #include <acpi/acpi_device.h> static void devtree_update_emmc_rtd3(void) diff --git a/src/mainboard/google/brya/variants/primus/variant.c b/src/mainboard/google/brya/variants/primus/variant.c index e78dfdc..c1ea39e 100644 --- a/src/mainboard/google/brya/variants/primus/variant.c +++ b/src/mainboard/google/brya/variants/primus/variant.c @@ -6,6 +6,7 @@ #include <drivers/i2c/hid/chip.h> #include <fw_config.h> #include <gpio.h> +#include <static.h> static void devtree_update_emmc_rtd3(uint32_t board_ver) { diff --git a/src/mainboard/google/brya/variants/quandiso/variant.c b/src/mainboard/google/brya/variants/quandiso/variant.c index 9140eb0..4f6ebb8 100644 --- a/src/mainboard/google/brya/variants/quandiso/variant.c +++ b/src/mainboard/google/brya/variants/quandiso/variant.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <fw_config.h> #include <sar.h> +#include <static.h> void variant_devtree_update(void) { diff --git a/src/mainboard/google/brya/variants/vell/variant.c b/src/mainboard/google/brya/variants/vell/variant.c index 216de3c9..ce75438 100644 --- a/src/mainboard/google/brya/variants/vell/variant.c +++ b/src/mainboard/google/brya/variants/vell/variant.c @@ -4,6 +4,7 @@ #include <boardid.h> #include <sar.h> #include <soc/pci_devs.h> +#include <static.h> const char *get_wifi_sar_cbfs_filename(void) { diff --git a/src/mainboard/google/brya/variants/yaviks/variant.c b/src/mainboard/google/brya/variants/yaviks/variant.c index 5c0c9ff..97691f7 100644 --- a/src/mainboard/google/brya/variants/yaviks/variant.c +++ b/src/mainboard/google/brya/variants/yaviks/variant.c @@ -7,6 +7,7 @@ #include <drivers/intel/gma/opregion.h> #include <fw_config.h> #include <sar.h> +#include <static.h> const char *get_wifi_sar_cbfs_filename(void) { diff --git a/src/mainboard/google/brya/variants/yavilla/variant.c b/src/mainboard/google/brya/variants/yavilla/variant.c index 9140eb0..4f6ebb8 100644 --- a/src/mainboard/google/brya/variants/yavilla/variant.c +++ b/src/mainboard/google/brya/variants/yavilla/variant.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <fw_config.h> #include <sar.h> +#include <static.h> void variant_devtree_update(void) { diff --git a/src/mainboard/google/guybrush/mainboard.c b/src/mainboard/google/guybrush/mainboard.c index 49a80e7..b803450 100644 --- a/src/mainboard/google/guybrush/mainboard.c +++ b/src/mainboard/google/guybrush/mainboard.c @@ -12,6 +12,7 @@ #include <device/device.h> #include <drivers/i2c/tpm/chip.h> #include <gpio.h> +#include <static.h> #include <variant/ec.h> #define BACKLIGHT_GPIO GPIO_129 diff --git a/src/mainboard/google/guybrush/port_descriptors.c b/src/mainboard/google/guybrush/port_descriptors.c index a056a19..8d09985 100644 --- a/src/mainboard/google/guybrush/port_descriptors.c +++ b/src/mainboard/google/guybrush/port_descriptors.c @@ -5,6 +5,7 @@ #include <device/pci_def.h> #include <gpio.h> #include <soc/platform_descriptors.h> +#include <static.h> #include <types.h> /* All PCIe Resets are handled in coreboot */ diff --git a/src/mainboard/google/guybrush/variants/guybrush/variant.c b/src/mainboard/google/guybrush/variants/guybrush/variant.c index 394270c..ea39b66 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/variant.c +++ b/src/mainboard/google/guybrush/variants/guybrush/variant.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <amdblocks/cpu.h> #include <gpio.h> +#include <static.h> bool variant_has_pcie_wwan(void) { diff --git a/src/mainboard/google/guybrush/variants/nipperkin/ramstage.c b/src/mainboard/google/guybrush/variants/nipperkin/ramstage.c index 247c132..613b78a 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/ramstage.c +++ b/src/mainboard/google/guybrush/variants/nipperkin/ramstage.c @@ -6,6 +6,7 @@ #include <drivers/i2c/tpm/chip.h> #include <drivers/uart/acpi/chip.h> #include <gpio.h> +#include <static.h> static void cr50_devtree_update(void) { diff --git a/src/mainboard/google/hatch/variants/jinlon/mainboard.c b/src/mainboard/google/hatch/variants/jinlon/mainboard.c index 009a6ad..60a7b76 100644 --- a/src/mainboard/google/hatch/variants/jinlon/mainboard.c +++ b/src/mainboard/google/hatch/variants/jinlon/mainboard.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <ec/google/chromeec/ec.h> #include <device/device.h> +#include <static.h> #include <variant/sku.h> static bool eps_sku(uint32_t sku_id) diff --git a/src/mainboard/google/rex/mainboard.c b/src/mainboard/google/rex/mainboard.c index 9157abb..66e1e69 100644 --- a/src/mainboard/google/rex/mainboard.c +++ b/src/mainboard/google/rex/mainboard.c @@ -9,6 +9,7 @@ #include <ec/ec.h> #include <fw_config.h> #include <soc/ramstage.h> +#include <static.h> #include <stdio.h> #include <stdlib.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/skyrim/mainboard.c b/src/mainboard/google/skyrim/mainboard.c index 5925f29..ebd373a 100644 --- a/src/mainboard/google/skyrim/mainboard.c +++ b/src/mainboard/google/skyrim/mainboard.c @@ -9,6 +9,7 @@ #include <cpu/x86/smm.h> #include <device/device.h> #include <drivers/i2c/tpm/chip.h> +#include <static.h> #include <variant/ec.h> /* The IRQ mapping in fch_irq_map ends up getting written to the indirect address space that is diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c index ae7519e..4d62ed6 100644 --- a/src/mainboard/google/volteer/mainboard.c +++ b/src/mainboard/google/volteer/mainboard.c @@ -12,6 +12,7 @@ #include <intelblocks/tcss.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> +#include <static.h> #include <stdio.h> #include <variant/gpio.h> #include <vb2_api.h> diff --git a/src/mainboard/google/volteer/variants/collis/variant.c b/src/mainboard/google/volteer/variants/collis/variant.c index cdb165d..a7f7a38 100644 --- a/src/mainboard/google/volteer/variants/collis/variant.c +++ b/src/mainboard/google/volteer/variants/collis/variant.c @@ -4,6 +4,7 @@ #include <fw_config.h> #include <drivers/i2c/hid/chip.h> #include <device/device.h> +#include <static.h> static void audio_codec_update(void) { diff --git a/src/mainboard/google/volteer/variants/copano/variant.c b/src/mainboard/google/volteer/variants/copano/variant.c index cdb165d..a7f7a38 100644 --- a/src/mainboard/google/volteer/variants/copano/variant.c +++ b/src/mainboard/google/volteer/variants/copano/variant.c @@ -4,6 +4,7 @@ #include <fw_config.h> #include <drivers/i2c/hid/chip.h> #include <device/device.h> +#include <static.h> static void audio_codec_update(void) { diff --git a/src/mainboard/google/volteer/variants/delbin/variant.c b/src/mainboard/google/volteer/variants/delbin/variant.c index cdb165d..a7f7a38 100644 --- a/src/mainboard/google/volteer/variants/delbin/variant.c +++ b/src/mainboard/google/volteer/variants/delbin/variant.c @@ -4,6 +4,7 @@ #include <fw_config.h> #include <drivers/i2c/hid/chip.h> #include <device/device.h> +#include <static.h> static void audio_codec_update(void) { diff --git a/src/mainboard/google/volteer/variants/drobit/variant.c b/src/mainboard/google/volteer/variants/drobit/variant.c index cdb165d..a7f7a38 100644 --- a/src/mainboard/google/volteer/variants/drobit/variant.c +++ b/src/mainboard/google/volteer/variants/drobit/variant.c @@ -4,6 +4,7 @@ #include <fw_config.h> #include <drivers/i2c/hid/chip.h> #include <device/device.h> +#include <static.h> static void audio_codec_update(void) { diff --git a/src/mainboard/google/volteer/variants/volteer2/variant.c b/src/mainboard/google/volteer/variants/volteer2/variant.c index c9129b2..f3c21cb 100644 --- a/src/mainboard/google/volteer/variants/volteer2/variant.c +++ b/src/mainboard/google/volteer/variants/volteer2/variant.c @@ -3,6 +3,7 @@ #include <baseboard/variants.h> #include <soc/pci_devs.h> #include <acpi/acpi_device.h> +#include <static.h> /* * This function runs only on the volteer_ti50 variant, which has the GSC on a diff --git a/src/mainboard/google/zork/variants/berknip/variant.c b/src/mainboard/google/zork/variants/berknip/variant.c index 1810a66..1b35c5c 100644 --- a/src/mainboard/google/zork/variants/berknip/variant.c +++ b/src/mainboard/google/zork/variants/berknip/variant.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> +#include <static.h> void variant_devtree_update(void) { diff --git a/src/mainboard/google/zork/variants/ezkinil/variant.c b/src/mainboard/google/zork/variants/ezkinil/variant.c index 142aa21..7e61690 100644 --- a/src/mainboard/google/zork/variants/ezkinil/variant.c +++ b/src/mainboard/google/zork/variants/ezkinil/variant.c @@ -4,6 +4,7 @@ #include <device/device.h> #include <soc/pci_devs.h> #include <ec/google/chromeec/ec.h> +#include <static.h> void variant_devtree_update(void) { diff --git a/src/mainboard/google/zork/variants/morphius/variant.c b/src/mainboard/google/zork/variants/morphius/variant.c index 864d73b..b5ee902 100644 --- a/src/mainboard/google/zork/variants/morphius/variant.c +++ b/src/mainboard/google/zork/variants/morphius/variant.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <baseboard/variants.h> +#include <static.h> #define MORPHIUS_SKU_1 0x5A010010 #define MORPHIUS_SKU_2 0x5A010011 -- To view, visit https://review.coreboot.org/c/coreboot/+/84678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05662e601af00866b7f26f4c6c6794b491bf676e Gerrit-Change-Number: 84678 Gerrit-PatchSet: 10 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/*: Explicitly include static.h for DEV_PTR
by Felix Singer (Code Review) 10 Nov '24

10 Nov '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Jason Nien, Kapil Porwal, Martin Roth, Nicholas Chin, Nick Vaccaro, Subrata Banik, Tarun. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84678?usp=email ) Change subject: mb/google/*: Explicitly include static.h for DEV_PTR ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05662e601af00866b7f26f4c6c6794b491bf676e Gerrit-Change-Number: 84678 Gerrit-PatchSet: 9 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Nov 2024 19:12:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/*: Explicitly include static.h for DEV_PTR
by Felix Singer (Code Review) 10 Nov '24

10 Nov '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84677?usp=email ) Change subject: soc/*: Explicitly include static.h for DEV_PTR ...................................................................... soc/*: Explicitly include static.h for DEV_PTR As per commit 05a13e7ed9b9 ("sconfig: Move (WEAK_)DEV_PTR from device.h to static.h"), sources that require access to devicetree static devices should directly include static.h. This allows static.h to be removed from device.h, eliminating unnecessary dependencies on the devicetree for objects that only need the device types and function declarations. The DEV_PTR macro resolves to names declared in static_devices.h, which is then included in static.h, so include the header whenever the macro is used. Change-Id: Ie281e9a9c015b19bfc96b83021a6e3afd98abcc3 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84677 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Jayvik Desai <jayvik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/amd/cezanne/include/soc/xhci.h M src/soc/amd/common/pi/agesawrapper.c M src/soc/amd/mendocino/include/soc/xhci.h M src/soc/amd/mendocino/xhci.c M src/soc/amd/phoenix/include/soc/xhci.h M src/soc/amd/stoneyridge/BiosCallOuts.c M src/soc/amd/stoneyridge/fch.c M src/soc/amd/stoneyridge/fch_agesa.c M src/soc/amd/stoneyridge/northbridge.c M src/soc/intel/alderlake/retimer.c M src/soc/intel/meteorlake/retimer.c M src/soc/intel/pantherlake/retimer.c M src/soc/intel/tigerlake/retimer.c 13 files changed, 14 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved Jayvik Desai: Looks good to me, but someone else must approve diff --git a/src/soc/amd/cezanne/include/soc/xhci.h b/src/soc/amd/cezanne/include/soc/xhci.h index c590195..a7fe53b 100644 --- a/src/soc/amd/cezanne/include/soc/xhci.h +++ b/src/soc/amd/cezanne/include/soc/xhci.h @@ -3,7 +3,7 @@ #ifndef AMD_CEZANNE_XHCI_H #define AMD_CEZANNE_XHCI_H -#include <device/device.h> +#include <static.h> #define SOC_XHCI_0 DEV_PTR(xhci_0) #define SOC_XHCI_1 DEV_PTR(xhci_1) diff --git a/src/soc/amd/common/pi/agesawrapper.c b/src/soc/amd/common/pi/agesawrapper.c index 8ad1e0e..a828d24 100644 --- a/src/soc/amd/common/pi/agesawrapper.c +++ b/src/soc/amd/common/pi/agesawrapper.c @@ -10,6 +10,7 @@ #include <soc/pci_devs.h> #include <soc/northbridge.h> #include <soc/cpu.h> +#include <static.h> #include <string.h> void __weak SetMemParams(AMD_POST_PARAMS *PostParams) {} diff --git a/src/soc/amd/mendocino/include/soc/xhci.h b/src/soc/amd/mendocino/include/soc/xhci.h index b554c98..1d45893 100644 --- a/src/soc/amd/mendocino/include/soc/xhci.h +++ b/src/soc/amd/mendocino/include/soc/xhci.h @@ -3,6 +3,8 @@ #ifndef AMD_MENDOCINO_XHCI_H #define AMD_MENDOCINO_XHCI_H +#include <static.h> + #define SOC_XHCI_0 DEV_PTR(xhci_0) #define SOC_XHCI_1 DEV_PTR(xhci_1) #define SOC_XHCI_2 DEV_PTR(xhci_2) diff --git a/src/soc/amd/mendocino/xhci.c b/src/soc/amd/mendocino/xhci.c index 8f46374..ed8be75 100644 --- a/src/soc/amd/mendocino/xhci.c +++ b/src/soc/amd/mendocino/xhci.c @@ -11,6 +11,7 @@ #include <drivers/usb/pci_xhci/pci_xhci.h> #include <soc/pci_devs.h> #include <soc/smi.h> +#include <static.h> static const struct sci_source xhci_sci_sources[] = { { diff --git a/src/soc/amd/phoenix/include/soc/xhci.h b/src/soc/amd/phoenix/include/soc/xhci.h index 5b7d6eb..72e03cc 100644 --- a/src/soc/amd/phoenix/include/soc/xhci.h +++ b/src/soc/amd/phoenix/include/soc/xhci.h @@ -3,7 +3,7 @@ #ifndef AMD_PHOENIX_XHCI_H #define AMD_PHOENIX_XHCI_H -#include <device/device.h> +#include <static.h> #define SOC_XHCI_0 DEV_PTR(xhci_0) #define SOC_XHCI_1 DEV_PTR(xhci_1) diff --git a/src/soc/amd/stoneyridge/BiosCallOuts.c b/src/soc/amd/stoneyridge/BiosCallOuts.c index 1aebddb..fa0eb20 100644 --- a/src/soc/amd/stoneyridge/BiosCallOuts.c +++ b/src/soc/amd/stoneyridge/BiosCallOuts.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <soc/southbridge.h> #include <soc/pci_devs.h> +#include <static.h> #include <amdblocks/agesawrapper.h> #include <amdblocks/dimm_spd.h> #include <amdblocks/car.h> diff --git a/src/soc/amd/stoneyridge/fch.c b/src/soc/amd/stoneyridge/fch.c index 3013500..8729a14 100644 --- a/src/soc/amd/stoneyridge/fch.c +++ b/src/soc/amd/stoneyridge/fch.c @@ -20,6 +20,7 @@ #include <soc/acpi.h> #include <soc/aoac_defs.h> #include <soc/nvs.h> +#include <static.h> #include <types.h> /* diff --git a/src/soc/amd/stoneyridge/fch_agesa.c b/src/soc/amd/stoneyridge/fch_agesa.c index 179999a..5031971 100644 --- a/src/soc/amd/stoneyridge/fch_agesa.c +++ b/src/soc/amd/stoneyridge/fch_agesa.c @@ -3,6 +3,7 @@ #include <amdblocks/agesawrapper.h> #include <device/device.h> #include <soc/pci_devs.h> +#include <static.h> static int is_sata_config(void) { diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index 9519713..b6ebf4d 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -25,6 +25,7 @@ #include <soc/northbridge.h> #include <soc/pci_devs.h> #include <soc/iomap.h> +#include <static.h> #include <stdint.h> #include <string.h> diff --git a/src/soc/intel/alderlake/retimer.c b/src/soc/intel/alderlake/retimer.c index 3fd9c2d..fd047dd 100644 --- a/src/soc/intel/alderlake/retimer.c +++ b/src/soc/intel/alderlake/retimer.c @@ -4,6 +4,7 @@ #include <device/device.h> #include <drivers/intel/usb4/retimer/retimer.h> #include <intelblocks/tcss.h> +#include <static.h> int retimer_get_index_for_typec(uint8_t typec_port) { diff --git a/src/soc/intel/meteorlake/retimer.c b/src/soc/intel/meteorlake/retimer.c index 269620d..a559cfc 100644 --- a/src/soc/intel/meteorlake/retimer.c +++ b/src/soc/intel/meteorlake/retimer.c @@ -4,6 +4,7 @@ #include <device/device.h> #include <drivers/intel/usb4/retimer/retimer.h> #include <intelblocks/tcss.h> +#include <static.h> int retimer_get_index_for_typec(uint8_t typec_port) { diff --git a/src/soc/intel/pantherlake/retimer.c b/src/soc/intel/pantherlake/retimer.c index c14c044..d55cd7d 100644 --- a/src/soc/intel/pantherlake/retimer.c +++ b/src/soc/intel/pantherlake/retimer.c @@ -4,6 +4,7 @@ #include <device/device.h> #include <drivers/intel/usb4/retimer/retimer.h> #include <intelblocks/tcss.h> +#include <static.h> int retimer_get_index_for_typec(uint8_t typec_port) { diff --git a/src/soc/intel/tigerlake/retimer.c b/src/soc/intel/tigerlake/retimer.c index 32cb828..4a2ed6a 100644 --- a/src/soc/intel/tigerlake/retimer.c +++ b/src/soc/intel/tigerlake/retimer.c @@ -4,6 +4,7 @@ #include <device/device.h> #include <drivers/intel/usb4/retimer/retimer.h> #include <intelblocks/tcss.h> +#include <static.h> #include <stdint.h> int retimer_get_index_for_typec(uint8_t typec_port) -- To view, visit https://review.coreboot.org/c/coreboot/+/84677?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie281e9a9c015b19bfc96b83021a6e3afd98abcc3 Gerrit-Change-Number: 84677 Gerrit-PatchSet: 9 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/*: Explicitly include static.h for DEV_PTR
by Felix Singer (Code Review) 10 Nov '24

10 Nov '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Kapil Porwal, Matt DeVillier, Nicholas Chin, Nick Vaccaro, Pranava Y N, Subrata Banik, Tarun. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84677?usp=email ) Change subject: soc/*: Explicitly include static.h for DEV_PTR ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84677?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie281e9a9c015b19bfc96b83021a6e3afd98abcc3 Gerrit-Change-Number: 84677 Gerrit-PatchSet: 8 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 10 Nov 2024 19:11:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: device/device.h: Remove static.h include
by Angel Pons (Code Review) 10 Nov '24

10 Nov '24

Attention is currently required from: Nicholas Chin. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84590?usp=email ) Change subject: device/device.h: Remove static.h include ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84590?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie72840c71ffca2ada82456dda6a2c813f6a6c3ad Gerrit-Change-Number: 84590 Gerrit-PatchSet: 12 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Nov 2024 19:01:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: tree: Include static.h for remaining devicetree usages
by Angel Pons (Code Review) 10 Nov '24

10 Nov '24

Attention is currently required from: Nicholas Chin, Sean Rhodes. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84591?usp=email ) Change subject: tree: Include static.h for remaining devicetree usages ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84591?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d35ff2ac22f9ff5e0aa38b7ad707619e50387f3 Gerrit-Change-Number: 84591 Gerrit-PatchSet: 12 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 10 Nov 2024 19:01:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024