Attention is currently required from: Felix Singer, Matt DeVillier.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80059?usp=email )
Change subject: soc/intel/commonlake: Re-add SATA to soc_api_name() list
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80059?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I134058f5ef78f419dc5538452614125ad44bf29d
Gerrit-Change-Number: 80059
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 02:37:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Matt DeVillier.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80058?usp=email )
Change subject: soc/intel/common/block/sata: Add ACPI stub for SATA device
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80058?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I951c62d09609ed73079fe97ea9ce49fdee333272
Gerrit-Change-Number: 80058
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 02:36:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Matt DeVillier.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80057?usp=email )
Change subject: Revert "soc/intel/cannonlake: Add missing min sleep state for thermal device"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80057?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2dfe76d5f72cde7742cee338fa24eaafb84c4604
Gerrit-Change-Number: 80057
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 02:35:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Simon Yang, Subrata Banik.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80001?usp=email )
Change subject: mb/google/nissa/var/anraggar: Enable BT audio offload
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e6731c8ceaad6ee58b525d4246fa769bfe1b0c7
Gerrit-Change-Number: 80001
Gerrit-PatchSet: 5
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 02:06:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Simon Yang, Subrata Banik, Weimin Wu.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80001?usp=email )
Change subject: mb/google/nissa/var/anraggar: Enable BT audio offload
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS3:
> Do you need vGpio change for this too?
We need to configure vGPIO for this base on [322290550:comment#4](https://partnerissuetracker.corp.google.com/issues/322…
--
To view, visit https://review.coreboot.org/c/coreboot/+/80001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e6731c8ceaad6ee58b525d4246fa769bfe1b0c7
Gerrit-Change-Number: 80001
Gerrit-PatchSet: 5
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 02:04:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Derek Huang, Eric Lai, Jamie Chen, Kapil Porwal, Nick Vaccaro, Paul Menzel.
Ivan Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80152?usp=email )
Change subject: mb/google/brya/var/omniknight: Add WIFI SAR table
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/omnigul/variant.c:
https://review.coreboot.org/c/coreboot/+/80152/comment/7001d620_9a1ef2ae :
PS10, Line 11: _1
> Could we get better names, than just adding numbers?
The number is auto generated by config builder based on wifi sar fw_config.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80152?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70e79577612b3d5c4dc0f92211f87cbea0532d5d
Gerrit-Change-Number: 80152
Gerrit-PatchSet: 10
Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 26 Jan 2024 01:46:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79895?usp=email )
Change subject: mb/google/brox: Enable Touchscreen
......................................................................
Patch Set 24:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79895?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f528b0d778c8c4a4e83774d5c167ccb2d6afd9a
Gerrit-Change-Number: 79895
Gerrit-PatchSet: 24
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 01:28:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment