coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[XS] Change in coreboot[main]: tests: Rename Makefiles from .inc to .mk
by Felix Held (Code Review) 26 Jan '24

26 Jan '24

Attention is currently required from: Felix Singer, Jakub Czapiga, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80122?usp=email ) Change subject: tests: Rename Makefiles from .inc to .mk ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id09eafd293a54198aab87281f529749325df8b07 Gerrit-Change-Number: 80122 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 11:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/autoport: Update Makefile.inc generation to Makefile.mk
by Felix Held (Code Review) 26 Jan '24

26 Jan '24

Attention is currently required from: Felix Singer, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80127?usp=email ) Change subject: util/autoport: Update Makefile.inc generation to Makefile.mk ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80127?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib77cb3a0852092ac414fe0160fe10d6e58fcf660 Gerrit-Change-Number: 80127 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 11:56:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: Documentation: Update Makefile .inc references to .mk
by Felix Held (Code Review) 26 Jan '24

26 Jan '24

Attention is currently required from: Felix Singer, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80128?usp=email ) Change subject: Documentation: Update Makefile .inc references to .mk ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I464170e60a22f39225044c6794d091455d931e9c Gerrit-Change-Number: 80128 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 11:56:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: src, util: Update toolchain.inc references to .mk
by Felix Held (Code Review) 26 Jan '24

26 Jan '24

Attention is currently required from: Felix Singer, Julius Werner, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80129?usp=email ) Change subject: src, util: Update toolchain.inc references to .mk ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80129?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieaf7894f49a90f562b164924cc025e3eab5a3f7f Gerrit-Change-Number: 80129 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 26 Jan 2024 11:55:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: lib/smbios: Add 32 bit entry point if below 4G
by Lean Sheng Tan (Code Review) 26 Jan '24

26 Jan '24

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76911?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: lib/smbios: Add 32 bit entry point if below 4G ...................................................................... lib/smbios: Add 32 bit entry point if below 4G If the smbios table is not below 4G there is no need to have a 32 bit entry point. Even worse it could cause the payload to try to use the entry point. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I4cb426bb0c45282ed03ff4c65d15004b7f985dab Reviewed-on: https://review.coreboot.org/c/coreboot/+/76911 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> --- M src/lib/smbios.c 1 file changed, 22 insertions(+), 17 deletions(-) Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, but someone else must approve diff --git a/src/lib/smbios.c b/src/lib/smbios.c index 51f1593..c6cfb05 100644 --- a/src/lib/smbios.c +++ b/src/lib/smbios.c @@ -1203,7 +1203,7 @@ unsigned long smbios_write_tables(unsigned long current) { - struct smbios_entry *se; + struct smbios_entry *se = NULL; struct smbios_entry30 *se3; unsigned long tables; int len = 0; @@ -1213,9 +1213,12 @@ current = ALIGN_UP(current, 16); printk(BIOS_DEBUG, "%s: %08lx\n", __func__, current); - se = (struct smbios_entry *)current; - current += sizeof(*se); - current = ALIGN_UP(current, 16); + // only add a 32 bit entry point if SMBIOS table is below 4G + if (current < UINT32_MAX) { + se = (struct smbios_entry *)current; + current += sizeof(*se); + current = ALIGN_UP(current, 16); + } se3 = (struct smbios_entry30 *)current; current += sizeof(*se3); @@ -1253,21 +1256,23 @@ update_max(len, max_struct_size, smbios_write_type127(&current, handle++)); - /* Install SMBIOS 2.1 entry point */ - memset(se, 0, sizeof(*se)); - memcpy(se->anchor, "_SM_", 4); - se->length = sizeof(*se); - se->major_version = 3; - se->minor_version = 0; - se->max_struct_size = max_struct_size; - se->struct_count = handle; - memcpy(se->intermediate_anchor_string, "_DMI_", 5); + if (se) { + /* Install SMBIOS 2.1 entry point */ + memset(se, 0, sizeof(*se)); + memcpy(se->anchor, "_SM_", 4); + se->length = sizeof(*se); + se->major_version = 3; + se->minor_version = 0; + se->max_struct_size = max_struct_size; + se->struct_count = handle; + memcpy(se->intermediate_anchor_string, "_DMI_", 5); - se->struct_table_address = (u32)tables; - se->struct_table_length = len; + se->struct_table_address = (u32)tables; + se->struct_table_length = len; - se->intermediate_checksum = smbios_checksum((u8 *)se + 0x10, sizeof(*se) - 0x10); - se->checksum = smbios_checksum((u8 *)se, sizeof(*se)); + se->intermediate_checksum = smbios_checksum((u8 *)se + 0x10, sizeof(*se) - 0x10); + se->checksum = smbios_checksum((u8 *)se, sizeof(*se)); + } /* Install SMBIOS 3.0 entry point */ memset(se3, 0, sizeof(*se3)); -- To view, visit https://review.coreboot.org/c/coreboot/+/76911?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4cb426bb0c45282ed03ff4c65d15004b7f985dab Gerrit-Change-Number: 76911 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: device: Add a helper function to add a downstream bus
by Shuo Liu (Code Review) 26 Jan '24

26 Jan '24

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Jincheng Li, Johnny Lin, Nico Huber, Patrick Rudolph, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80210?usp=email ) Change subject: device: Add a helper function to add a downstream bus ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80210?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic898189b92997b93304fcbf47c73e2bb5ec09023 Gerrit-Change-Number: 80210 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 11:30:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Initial support for PCI multi segment groups
by Shuo Liu (Code Review) 26 Jan '24

26 Jan '24

Attention is currently required from: Annie Chen, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Naresh Solanki, Nill Ge, Patrick Rudolph, TangYiwei, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79878?usp=email ) Change subject: soc/intel/xeon_sp: Initial support for PCI multi segment groups ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/soc/intel/xeon_sp/chip_common.c: https://review.coreboot.org/c/coreboot/+/79878/comment/86683aef_00bf2edc : PS4, Line 33: return hob->PlatformData.CpuQpiInfo[dn.socket].PcieSegment; > correct. […] LGTM -- To view, visit https://review.coreboot.org/c/coreboot/+/79878?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0ba5e426123234979d746d3bdfc1ddfbd71c3447 Gerrit-Change-Number: 79878 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: TangYiwei Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 11:15:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Attach more stacks
by Shuo Liu (Code Review) 26 Jan '24

26 Jan '24

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Nico Huber, Patrick Rudolph, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80091?usp=email ) Change subject: soc/intel/xeon_sp: Attach more stacks ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: good catch -- To view, visit https://review.coreboot.org/c/coreboot/+/80091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f9d52dd117364a42de1c73d39cc86dafeaf2678 Gerrit-Change-Number: 80091 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 11:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya: alphabetize model configs
by Felix Held (Code Review) 26 Jan '24

26 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80162?usp=email ) Change subject: mb/google/brya: alphabetize model configs ...................................................................... mb/google/brya: alphabetize model configs Alphabetize the ordering of model configs and selects in Kconfig and Kconfig.name BUG=None BRANCH=None TEST='emerge-brya coreboot' and verify it builds. Change-Id: Id9347421337d451ce72fcf3984489b06f372f70c Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80162 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 29 insertions(+), 29 deletions(-) Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 7b0d587..dae3f16 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -123,6 +123,17 @@ select HAVE_PCIE_WWAN select HAVE_WWAN_POWER_SEQUENCE +config BOARD_GOOGLE_ANRAGGAR + select BOARD_GOOGLE_BASEBOARD_NISSA + select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_BAYHUB_LV2 + select DRIVERS_GENERIC_GPIO_KEYS + select INTEL_GMA_HAVE_VBT + select DRIVERS_INTEL_MIPI_CAMERA + select HAVE_WWAN_POWER_SEQUENCE + select DRIVERS_GFX_GENERIC + select CHROMEOS_WIFI_SAR if CHROMEOS + config BOARD_GOOGLE_AURASH select BOARD_GOOGLE_BASEBOARD_BRASK select INTEL_GMA_HAVE_VBT @@ -180,6 +191,12 @@ select INTEL_GMA_HAVE_VBT select SOC_INTEL_RAPTORLAKE +config BOARD_GOOGLE_DOCHI + select BOARD_GOOGLE_BASEBOARD_BRYA + select SOC_INTEL_RAPTORLAKE + select DRIVERS_INTEL_ISH + select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS + config BOARD_GOOGLE_FELWINTER select BOARD_GOOGLE_BASEBOARD_BRYA select CHROMEOS_WIFI_SAR if CHROMEOS @@ -303,6 +320,9 @@ select DRIVERS_GENERIC_GPIO_KEYS select INTEL_GMA_HAVE_VBT +config BOARD_GOOGLE_NOKRIS + select BOARD_GOOGLE_BASEBOARD_NISSA + config BOARD_GOOGLE_OMNIGUL select BOARD_GOOGLE_BASEBOARD_BRYA select CHROMEOS_WIFI_SAR if CHROMEOS @@ -487,26 +507,6 @@ select SOC_INTEL_COMMON_BLOCK_IPU select SOC_INTEL_RAPTORLAKE -config BOARD_GOOGLE_NOKRIS - select BOARD_GOOGLE_BASEBOARD_NISSA - -config BOARD_GOOGLE_DOCHI - select BOARD_GOOGLE_BASEBOARD_BRYA - select SOC_INTEL_RAPTORLAKE - select DRIVERS_INTEL_ISH - select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS - -config BOARD_GOOGLE_ANRAGGAR - select BOARD_GOOGLE_BASEBOARD_NISSA - select BOARD_ROMSIZE_KB_16384 - select DRIVERS_GENERIC_BAYHUB_LV2 - select DRIVERS_GENERIC_GPIO_KEYS - select INTEL_GMA_HAVE_VBT - select DRIVERS_INTEL_MIPI_CAMERA - select HAVE_WWAN_POWER_SEQUENCE - select DRIVERS_GFX_GENERIC - select CHROMEOS_WIFI_SAR if CHROMEOS - if BOARD_GOOGLE_BRYA_COMMON config BASEBOARD_DIR diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 9c3baf0..dcdf3c7 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -9,6 +9,9 @@ config BOARD_GOOGLE_ANAHERA4ES bool "-> Anahera4ES" +config BOARD_GOOGLE_ANRAGGAR + bool "-> Anraggar" + config BOARD_GOOGLE_AURASH bool "-> Aurash" @@ -33,6 +36,9 @@ config BOARD_GOOGLE_CROTA bool "-> Crota" +config BOARD_GOOGLE_DOCHI + bool "-> Dochi" + config BOARD_GOOGLE_FELWINTER bool "-> Felwinter" @@ -84,6 +90,9 @@ config BOARD_GOOGLE_NEREID bool "-> Nereid" +config BOARD_GOOGLE_NOKRIS + bool "-> Nokris" + config BOARD_GOOGLE_OMNIGUL bool "-> Omnigul" @@ -144,14 +153,5 @@ config BOARD_GOOGLE_ZYDRON bool "-> Zydron" -config BOARD_GOOGLE_NOKRIS - bool "-> Nokris" - -config BOARD_GOOGLE_DOCHI - bool "-> Dochi" - -config BOARD_GOOGLE_ANRAGGAR - bool "-> Anraggar" - config BOARD_GOOGLE_XOL bool "-> Xol" -- To view, visit https://review.coreboot.org/c/coreboot/+/80162?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id9347421337d451ce72fcf3984489b06f372f70c Gerrit-Change-Number: 80162 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: [Test] Follow rex0 setting
by Tyler Wang (Code Review) 26 Jan '24

26 Jan '24

Tyler Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80215?usp=email ) Change subject: [Test] Follow rex0 setting ...................................................................... [Test] Follow rex0 setting BUG=none TEST=none Change-Id: Id23a2cfe0639f2d423980db9badc16c1477434d1 --- M src/mainboard/google/rex/variants/karis/fw_config.c 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/80215/1 diff --git a/src/mainboard/google/rex/variants/karis/fw_config.c b/src/mainboard/google/rex/variants/karis/fw_config.c index 6dbf31d..c209295 100644 --- a/src/mainboard/google/rex/variants/karis/fw_config.c +++ b/src/mainboard/google/rex/variants/karis/fw_config.c @@ -35,14 +35,6 @@ }; static const struct pad_config cnvi_bt_disable_pads[] = { - /* GPP_F00 : [] ==> CNV_BRI_DT_R */ - PAD_NC(GPP_F00, NONE), - /* GPP_F01 : [] ==> CNV_BRI_RSP */ - PAD_NC(GPP_F01, NONE), - /* GPP_F02 : [] ==> CNV_RGI_DT_Rl */ - PAD_NC(GPP_F02, NONE), - /* GPP_F03 : [] ==> CNV_RGI_RSP */ - PAD_NC(GPP_F03, NONE), /* GPP_F04 : [] ==> CNV_RF_RST_L */ PAD_NC(GPP_F04, NONE), /* GPP_F05 : [] ==> CNV_CLKREQ */ @@ -54,8 +46,6 @@ PAD_NC(GPP_S01, NONE), /* GPP_S02 : [] ==> DMIC_SOC_CLK0_WLAN_PCM_OUT */ PAD_NC(GPP_S02, NONE), - /* GPP_D21 : [] ==> WLAN_CLKREQ_ODLl */ - PAD_NC(GPP_D21, NONE), }; static const struct pad_config bt_i2s_enable_pads[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/80215?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id23a2cfe0639f2d423980db9badc16c1477434d1 Gerrit-Change-Number: 80215 Gerrit-PatchSet: 1 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024