coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[L] Change in coreboot[main]: mb/google/poppy: Use chipset dt reference names
by Felix Singer (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Marvin Evers. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79439?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/poppy: Use chipset dt reference names ...................................................................... Patch Set 4: Code-Review+1 (4 comments) Patchset: PS4: I actually drafted comments but I forgot to send them. Sorry.. File src/mainboard/google/poppy/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/79439/comment/2d096435_23686235 : PS4, Line 254: The commit message doesn't suggest that lines are removed and no lines were removed from the other files. It doesn't make a difference here, since the configuration is identical to the chipset devicetree, but please add it again. https://review.coreboot.org/c/coreboot/+/79439/comment/e8f8da50_811417d3 : PS4, Line 379: device pci 1f.1 on end # P2SB : Same here. Please add these lines again. PS4: Please indent the on keyword with tabs, and also in the other files. See the previous patches. -- To view, visit https://review.coreboot.org/c/coreboot/+/79439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22bcde2dea726f47f8d64a762ca147efde0b610d Gerrit-Change-Number: 79439 Gerrit-PatchSet: 4 Gerrit-Owner: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 19:07:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: coreboot is awesome
by Felix Singer (Code Review) 05 Jan '24

05 Jan '24

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79300?usp=email ) Change subject: coreboot is awesome ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/79300?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I29a9fe845ce584d0acce6a426aa52b06958abce1 Gerrit-Change-Number: 79300 Gerrit-PatchSet: 1 Gerrit-Owner: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[L] Change in coreboot[main]: mb/google/guybrush: Update DXIO descriptor definition
by Raul Rangel (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79792?usp=email ) Change subject: mb/google/guybrush: Update DXIO descriptor definition ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/mainboard/google/guybrush/variants/baseboard/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/79792/comment/a2cd7530_c92bef81 : PS2, Line 29: variant_sd_aux_reset_gpio nit: line length. -- To view, visit https://review.coreboot.org/c/coreboot/+/79792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a61d6561304782de847f6b99c9a73292e12b33f Gerrit-Change-Number: 79792 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 18:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/guybrush: Update DDI descriptor definition
by Raul Rangel (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email ) Change subject: mb/google/guybrush: Update DDI descriptor definition ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File src/mainboard/google/guybrush/variants/nipperkin/variant.c: https://review.coreboot.org/c/coreboot/+/79793/comment/6fcbc476_a1a719d4 : PS3, Line 7: true > That was my thought as well, but I was trying to preserve the logic. […] SGTM. -- To view, visit https://review.coreboot.org/c/coreboot/+/79793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6 Gerrit-Change-Number: 79793 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 18:05:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/poppy: Use chipset dt reference names
by Martin L Roth (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Felix Singer, Marvin Evers. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79439?usp=email ) Change subject: mb/google/poppy: Use chipset dt reference names ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22bcde2dea726f47f8d64a762ca147efde0b610d Gerrit-Change-Number: 79439 Gerrit-PatchSet: 4 Gerrit-Owner: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 18:05:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/guybrush: Update DDI descriptor definition
by Jon Murphy (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jason Nien, Martin Roth, Raul Rangel. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email ) Change subject: mb/google/guybrush: Update DDI descriptor definition ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/guybrush/variants/dewatt/Makefile.inc: https://review.coreboot.org/c/coreboot/+/79793/comment/2d64435b_01c2f646 : PS3, Line 8: bootblock-y += variant.c > We definitely don't. Got a little copy/paste happy. I'll remove it. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6 Gerrit-Change-Number: 79793 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 18:04:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/guybrush: Update DDI descriptor definition
by Jon Murphy (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jason Nien, Martin Roth, Raul Rangel. Hello Jason Nien, Martin Roth, Raul Rangel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79793?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by Raul Rangel, Verified+1 by build bot (Jenkins) Change subject: mb/google/guybrush: Update DDI descriptor definition ...................................................................... mb/google/guybrush: Update DDI descriptor definition Update definition to be more intuitive and extensible. Port descriptors will be defined as individual entities and added to the descriptor list as such. BUG=b:281059446 TEST=builds Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M src/mainboard/google/guybrush/port_descriptors.c M src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/guybrush/variants/baseboard/port_descriptors.c M src/mainboard/google/guybrush/variants/dewatt/Makefile.inc M src/mainboard/google/guybrush/variants/dewatt/variant.c M src/mainboard/google/guybrush/variants/guybrush/variant.c M src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc A src/mainboard/google/guybrush/variants/nipperkin/variant.c 8 files changed, 71 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/79793/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6 Gerrit-Change-Number: 79793 Gerrit-PatchSet: 4 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/google/guybrush: Update DDI descriptor definition
by Jon Murphy (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jason Nien, Martin Roth, Raul Rangel. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email ) Change subject: mb/google/guybrush: Update DDI descriptor definition ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/guybrush/variants/nipperkin/variant.c: https://review.coreboot.org/c/coreboot/+/79793/comment/ac56d956_135a3269 : PS3, Line 7: true > I'm honestly surprised the same logic for guybrush and dewatt doesn't apply here. […] That was my thought as well, but I was trying to preserve the logic. We could go look at what was shipped and if it was applicable. It would be a lot cleaner to have the single function. -- To view, visit https://review.coreboot.org/c/coreboot/+/79793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6 Gerrit-Change-Number: 79793 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 18:04:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/guybrush: Update DDI descriptor definition
by Jon Murphy (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jason Nien, Martin Roth, Raul Rangel. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email ) Change subject: mb/google/guybrush: Update DDI descriptor definition ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/guybrush/variants/dewatt/Makefile.inc: https://review.coreboot.org/c/coreboot/+/79793/comment/ee241967_fa6b5681 : PS3, Line 8: bootblock-y += variant.c > Surprised we need this in bootblock. We definitely don't. Got a little copy/paste happy. I'll remove it. -- To view, visit https://review.coreboot.org/c/coreboot/+/79793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6 Gerrit-Change-Number: 79793 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 18:03:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/guybrush: Update DDI descriptor definition
by Raul Rangel (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email ) Change subject: mb/google/guybrush: Update DDI descriptor definition ...................................................................... Patch Set 3: Code-Review+2 (2 comments) File src/mainboard/google/guybrush/variants/dewatt/Makefile.inc: https://review.coreboot.org/c/coreboot/+/79793/comment/904958ce_66c8a8e3 : PS3, Line 8: bootblock-y += variant.c Surprised we need this in bootblock. File src/mainboard/google/guybrush/variants/nipperkin/variant.c: https://review.coreboot.org/c/coreboot/+/79793/comment/0ffef616_ee6243ec : PS3, Line 7: true I'm honestly surprised the same logic for guybrush and dewatt doesn't apply here. It seems to be an SoC limitation. We probably just got lucky because we didn't ship any of these lower powered SoCs? -- To view, visit https://review.coreboot.org/c/coreboot/+/79793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6 Gerrit-Change-Number: 79793 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 17:52:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024