coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[L] Change in coreboot[main]: Documentation/getting_started: Add a FAQ document
by Matt DeVillier (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Angel Pons, David Hendricks, Jakub Czapiga, Matt DeVillier, Nicholas Chin, Paul Menzel. Matt DeVillier has uploaded a new patch set (#5) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/79441?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Documentation/getting_started: Add a FAQ document ...................................................................... Documentation/getting_started: Add a FAQ document Signed-off-by: Martin Roth <gaumless(a)gmail.com> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: Ia324e4800bf9dfc7ad86f4f99272c87ac566304e --- A Documentation/getting_started/faq.md M Documentation/getting_started/index.md 2 files changed, 313 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/79441/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/79441?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia324e4800bf9dfc7ad86f4f99272c87ac566304e Gerrit-Change-Number: 79441 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/puff/var/*: Set WLAN device type back to pci
by David Ruth (Code Review) 05 Jan '24

05 Jan '24

David Ruth has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/79795?usp=email ) Change subject: mb/google/puff/var/*: Set WLAN device type back to pci ...................................................................... mb/google/puff/var/*: Set WLAN device type back to pci This mostly reverts commit 6c705e766f7f ("mb/google/puff/var/*: Set LAN/WLAN device type to generic"). Setting the WLAN device type to generic broke ACPI SSDT table definition, so set it back to pci. BUG=b:295544257 TEST=Untested. Change-Id: I574760f0f0a38eb74643382ecd162ca0a18fcc35 Signed-off-by: David Ruth <druth(a)chromium.org> --- M src/mainboard/google/puff/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/79795/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I574760f0f0a38eb74643382ecd162ca0a18fcc35 Gerrit-Change-Number: 79795 Gerrit-PatchSet: 2 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
by Mike Banon (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Mike Banon. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64873?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ...................................................................... csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems. Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful. It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD. Use restore_agesa.sh script to restore AMD AGESA boards before running. Please share your feedback and tell me about the other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included: 1) "board-specific": Lenovo G505S discrete GPU support, board-specific SeaBIOS options, known good AtomBIOS ROMs, good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards, example configs for G505S / AM1I-A / A88XM-E, and avoid the apu/amdfw wasting CBFS space. 2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, smbios_mptable_768; and also a floppies collection: KolibriOS, FreeDOS, MichalOS, Visopsys, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird. Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more usage info. Send all your questions/suggestions to [ mikebdp2 [at] gmail [d0t] c0m ] Change-Id: Ia392bad869a82707380d3a1e3c51b3e15f4f02f2 --- A csb_patcher.sh 1 file changed, 999 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/64873/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/64873?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia392bad869a82707380d3a1e3c51b3e15f4f02f2 Gerrit-Change-Number: 64873 Gerrit-PatchSet: 12 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/hp/z220_series: Rename to snb_ivb_desktops
by Felix Singer (Code Review) 05 Jan '24

05 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79434?usp=email ) Change subject: mb/hp/z220_series: Rename to snb_ivb_desktops ...................................................................... mb/hp/z220_series: Rename to snb_ivb_desktops In preparation for adding other similar boards under it as variants. Tested that z220_cmt still builds. Change-Id: I96dec173e0d97d8564bad14778333b8231684ef8 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79434 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- R src/mainboard/hp/snb_ivb_desktops/Kconfig R src/mainboard/hp/snb_ivb_desktops/Kconfig.name R src/mainboard/hp/snb_ivb_desktops/Makefile.inc R src/mainboard/hp/snb_ivb_desktops/acpi/ec.asl R src/mainboard/hp/snb_ivb_desktops/acpi/pci.asl R src/mainboard/hp/snb_ivb_desktops/acpi/platform.asl R src/mainboard/hp/snb_ivb_desktops/acpi/superio.asl R src/mainboard/hp/snb_ivb_desktops/board_info.txt R src/mainboard/hp/snb_ivb_desktops/cmos.default R src/mainboard/hp/snb_ivb_desktops/cmos.layout R src/mainboard/hp/snb_ivb_desktops/data.vbt R src/mainboard/hp/snb_ivb_desktops/devicetree.cb R src/mainboard/hp/snb_ivb_desktops/dsdt.asl R src/mainboard/hp/snb_ivb_desktops/early_init.c R src/mainboard/hp/snb_ivb_desktops/gma-mainboard.ads R src/mainboard/hp/snb_ivb_desktops/hda_verb.c R src/mainboard/hp/snb_ivb_desktops/mainboard.c R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/gpio.c R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/overridetree.cb R src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/gpio.c R src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/overridetree.cb 21 files changed, 5 insertions(+), 5 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/hp/z220_series/Kconfig b/src/mainboard/hp/snb_ivb_desktops/Kconfig similarity index 88% rename from src/mainboard/hp/z220_series/Kconfig rename to src/mainboard/hp/snb_ivb_desktops/Kconfig index 2db3f5a..4cbb5e2 100644 --- a/src/mainboard/hp/z220_series/Kconfig +++ b/src/mainboard/hp/snb_ivb_desktops/Kconfig @@ -1,4 +1,4 @@ -config BOARD_HP_Z220_SERIES_COMMON +config BOARD_HP_SNB_IVB_DESKTOPS_COMMON def_bool n select BOARD_ROMSIZE_KB_16384 select GFX_GMA_ANALOG_I2C_HDMI_B @@ -19,12 +19,12 @@ select USE_NATIVE_RAMINIT config BOARD_HP_Z220_CMT_WORKSTATION - select BOARD_HP_Z220_SERIES_COMMON + select BOARD_HP_SNB_IVB_DESKTOPS_COMMON config BOARD_HP_Z220_SFF_WORKSTATION - select BOARD_HP_Z220_SERIES_COMMON + select BOARD_HP_SNB_IVB_DESKTOPS_COMMON -if BOARD_HP_Z220_SERIES_COMMON +if BOARD_HP_SNB_IVB_DESKTOPS_COMMON config VBOOT select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC @@ -38,7 +38,7 @@ default 0x570000 config MAINBOARD_DIR - default "hp/z220_series" + default "hp/snb_ivb_desktops" config VARIANT_DIR default "z220_cmt_workstation" if BOARD_HP_Z220_CMT_WORKSTATION diff --git a/src/mainboard/hp/z220_series/Kconfig.name b/src/mainboard/hp/snb_ivb_desktops/Kconfig.name similarity index 100% rename from src/mainboard/hp/z220_series/Kconfig.name rename to src/mainboard/hp/snb_ivb_desktops/Kconfig.name diff --git a/src/mainboard/hp/z220_series/Makefile.inc b/src/mainboard/hp/snb_ivb_desktops/Makefile.inc similarity index 100% rename from src/mainboard/hp/z220_series/Makefile.inc rename to src/mainboard/hp/snb_ivb_desktops/Makefile.inc diff --git a/src/mainboard/hp/z220_series/acpi/ec.asl b/src/mainboard/hp/snb_ivb_desktops/acpi/ec.asl similarity index 100% rename from src/mainboard/hp/z220_series/acpi/ec.asl rename to src/mainboard/hp/snb_ivb_desktops/acpi/ec.asl diff --git a/src/mainboard/hp/z220_series/acpi/pci.asl b/src/mainboard/hp/snb_ivb_desktops/acpi/pci.asl similarity index 100% rename from src/mainboard/hp/z220_series/acpi/pci.asl rename to src/mainboard/hp/snb_ivb_desktops/acpi/pci.asl diff --git a/src/mainboard/hp/z220_series/acpi/platform.asl b/src/mainboard/hp/snb_ivb_desktops/acpi/platform.asl similarity index 100% rename from src/mainboard/hp/z220_series/acpi/platform.asl rename to src/mainboard/hp/snb_ivb_desktops/acpi/platform.asl diff --git a/src/mainboard/hp/z220_series/acpi/superio.asl b/src/mainboard/hp/snb_ivb_desktops/acpi/superio.asl similarity index 100% rename from src/mainboard/hp/z220_series/acpi/superio.asl rename to src/mainboard/hp/snb_ivb_desktops/acpi/superio.asl diff --git a/src/mainboard/hp/z220_series/board_info.txt b/src/mainboard/hp/snb_ivb_desktops/board_info.txt similarity index 100% rename from src/mainboard/hp/z220_series/board_info.txt rename to src/mainboard/hp/snb_ivb_desktops/board_info.txt diff --git a/src/mainboard/hp/z220_series/cmos.default b/src/mainboard/hp/snb_ivb_desktops/cmos.default similarity index 100% rename from src/mainboard/hp/z220_series/cmos.default rename to src/mainboard/hp/snb_ivb_desktops/cmos.default diff --git a/src/mainboard/hp/z220_series/cmos.layout b/src/mainboard/hp/snb_ivb_desktops/cmos.layout similarity index 100% rename from src/mainboard/hp/z220_series/cmos.layout rename to src/mainboard/hp/snb_ivb_desktops/cmos.layout diff --git a/src/mainboard/hp/z220_series/data.vbt b/src/mainboard/hp/snb_ivb_desktops/data.vbt similarity index 100% rename from src/mainboard/hp/z220_series/data.vbt rename to src/mainboard/hp/snb_ivb_desktops/data.vbt Binary files differ diff --git a/src/mainboard/hp/z220_series/devicetree.cb b/src/mainboard/hp/snb_ivb_desktops/devicetree.cb similarity index 100% rename from src/mainboard/hp/z220_series/devicetree.cb rename to src/mainboard/hp/snb_ivb_desktops/devicetree.cb diff --git a/src/mainboard/hp/z220_series/dsdt.asl b/src/mainboard/hp/snb_ivb_desktops/dsdt.asl similarity index 100% rename from src/mainboard/hp/z220_series/dsdt.asl rename to src/mainboard/hp/snb_ivb_desktops/dsdt.asl diff --git a/src/mainboard/hp/z220_series/early_init.c b/src/mainboard/hp/snb_ivb_desktops/early_init.c similarity index 100% rename from src/mainboard/hp/z220_series/early_init.c rename to src/mainboard/hp/snb_ivb_desktops/early_init.c diff --git a/src/mainboard/hp/z220_series/gma-mainboard.ads b/src/mainboard/hp/snb_ivb_desktops/gma-mainboard.ads similarity index 100% rename from src/mainboard/hp/z220_series/gma-mainboard.ads rename to src/mainboard/hp/snb_ivb_desktops/gma-mainboard.ads diff --git a/src/mainboard/hp/z220_series/hda_verb.c b/src/mainboard/hp/snb_ivb_desktops/hda_verb.c similarity index 100% rename from src/mainboard/hp/z220_series/hda_verb.c rename to src/mainboard/hp/snb_ivb_desktops/hda_verb.c diff --git a/src/mainboard/hp/z220_series/mainboard.c b/src/mainboard/hp/snb_ivb_desktops/mainboard.c similarity index 100% rename from src/mainboard/hp/z220_series/mainboard.c rename to src/mainboard/hp/snb_ivb_desktops/mainboard.c diff --git a/src/mainboard/hp/z220_series/variants/z220_cmt_workstation/gpio.c b/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/gpio.c similarity index 100% rename from src/mainboard/hp/z220_series/variants/z220_cmt_workstation/gpio.c rename to src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/gpio.c diff --git a/src/mainboard/hp/z220_series/variants/z220_cmt_workstation/overridetree.cb b/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/overridetree.cb similarity index 100% rename from src/mainboard/hp/z220_series/variants/z220_cmt_workstation/overridetree.cb rename to src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/overridetree.cb diff --git a/src/mainboard/hp/z220_series/variants/z220_sff_workstation/gpio.c b/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/gpio.c similarity index 100% rename from src/mainboard/hp/z220_series/variants/z220_sff_workstation/gpio.c rename to src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/gpio.c diff --git a/src/mainboard/hp/z220_series/variants/z220_sff_workstation/overridetree.cb b/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/overridetree.cb similarity index 100% rename from src/mainboard/hp/z220_series/variants/z220_sff_workstation/overridetree.cb rename to src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/overridetree.cb -- To view, visit https://review.coreboot.org/c/coreboot/+/79434?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I96dec173e0d97d8564bad14778333b8231684ef8 Gerrit-Change-Number: 79434 Gerrit-PatchSet: 4 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/hp/z220_series: Rename to snb_ivb_desktops
by Felix Singer (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Riku Viitanen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79434?usp=email ) Change subject: mb/hp/z220_series: Rename to snb_ivb_desktops ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79434?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I96dec173e0d97d8564bad14778333b8231684ef8 Gerrit-Change-Number: 79434 Gerrit-PatchSet: 3 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 20:53:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/puff/var/*: Set LAN device type back to pci
by David Ruth (Code Review) 05 Jan '24

05 Jan '24

David Ruth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79795?usp=email ) Change subject: mb/google/puff/var/*: Set LAN device type back to pci ...................................................................... mb/google/puff/var/*: Set LAN device type back to pci This mostly reverts commit 6c705e766f7f ("mb/google/puff/var/*: Set LAN/WLAN device type to generic"). Setting the WLAN device type to generic broke ACPI SSDT table definition, so set it back to pci. BUG=b:295544257 TEST=Untested. Change-Id: I574760f0f0a38eb74643382ecd162ca0a18fcc35 Signed-off-by: David Ruth <druth(a)chromium.org> --- M src/mainboard/google/puff/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/79795/1 diff --git a/src/mainboard/google/puff/variants/baseboard/devicetree.cb b/src/mainboard/google/puff/variants/baseboard/devicetree.cb index b7a9674..2e5d426 100644 --- a/src/mainboard/google/puff/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/puff/variants/baseboard/devicetree.cb @@ -323,7 +323,7 @@ device pci 1d.5 on chip drivers/wifi/generic register "wake" = "GPE0_DW1_01" - device generic 0 on end + device pcie 00.0 on end end register "PcieRpSlotImplemented[13]" = "1" end # PCI Express Port 14 (x4) -- To view, visit https://review.coreboot.org/c/coreboot/+/79795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I574760f0f0a38eb74643382ecd162ca0a18fcc35 Gerrit-Change-Number: 79795 Gerrit-PatchSet: 1 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/google/byra/var/*: Set WLAN device type back to pci
by Matt DeVillier (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: David Ruth, Eric Lai, Nick Vaccaro, Subrata Banik. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79794?usp=email ) Change subject: mb/google/byra/var/*: Set WLAN device type back to pci ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: if this is indeed necessary, then we need to figure out how to exclude these bogus device values from the LPI constraint list. _SB.PCI0.RP04.MCHC is not a valid ACPI device, and that's what gets generated due to the ACPI name lookup. -- To view, visit https://review.coreboot.org/c/coreboot/+/79794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5dad9deb040c8cb0c507e11726f0ba44ccb2909 Gerrit-Change-Number: 79794 Gerrit-PatchSet: 1 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Ruth <druth(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 05 Jan 2024 20:06:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/byra/var/*: Set WLAN device type back to pci
by David Ruth (Code Review) 05 Jan '24

05 Jan '24

David Ruth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79794?usp=email ) Change subject: mb/google/byra/var/*: Set WLAN device type back to pci ...................................................................... mb/google/byra/var/*: Set WLAN device type back to pci This partially reverts commit f493857c9bc1 ("mb/google/brya/var/*: Set dGPU/LAN/WLAN device type to generic"). Setting the WLAN device type to generic broke ACPI SSDT table definition, so set it back to pci. BUG=b:318576073 TEST=build/boot google/nissa (pujjo), verify WLAN ACPI SSDT tables contain the appropriate device entry. Change-Id: If5dad9deb040c8cb0c507e11726f0ba44ccb2909 Signed-off-by: David Ruth <druth(a)chromium.org> --- M src/mainboard/google/brya/variants/gothrax/overridetree.cb M src/mainboard/google/brya/variants/joxer/overridetree.cb M src/mainboard/google/brya/variants/kinox/overridetree.cb M src/mainboard/google/brya/variants/marasov/overridetree.cb M src/mainboard/google/brya/variants/nereid/overridetree.cb M src/mainboard/google/brya/variants/pujjo/overridetree.cb M src/mainboard/google/brya/variants/quandiso/overridetree.cb M src/mainboard/google/brya/variants/xivu/overridetree.cb M src/mainboard/google/brya/variants/yaviks/overridetree.cb M src/mainboard/google/brya/variants/yavilla/overridetree.cb 10 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/79794/1 diff --git a/src/mainboard/google/brya/variants/gothrax/overridetree.cb b/src/mainboard/google/brya/variants/gothrax/overridetree.cb index 14d9215..bb333aa 100644 --- a/src/mainboard/google/brya/variants/gothrax/overridetree.cb +++ b/src/mainboard/google/brya/variants/gothrax/overridetree.cb @@ -337,7 +337,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pcie_rp7 on diff --git a/src/mainboard/google/brya/variants/joxer/overridetree.cb b/src/mainboard/google/brya/variants/joxer/overridetree.cb index e06b778..7b43f86 100644 --- a/src/mainboard/google/brya/variants/joxer/overridetree.cb +++ b/src/mainboard/google/brya/variants/joxer/overridetree.cb @@ -330,7 +330,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pcie_rp7 off end # PCIE7 no SD card diff --git a/src/mainboard/google/brya/variants/kinox/overridetree.cb b/src/mainboard/google/brya/variants/kinox/overridetree.cb index 567f878..fcca3d8 100644 --- a/src/mainboard/google/brya/variants/kinox/overridetree.cb +++ b/src/mainboard/google/brya/variants/kinox/overridetree.cb @@ -247,7 +247,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end chip soc/intel/common/block/pcie/rtd3 register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B11)" diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb index 6c1f3f9..3ea7092 100644 --- a/src/mainboard/google/brya/variants/marasov/overridetree.cb +++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb @@ -328,7 +328,7 @@ }" chip drivers/wifi/generic register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pcie_rp8 off end diff --git a/src/mainboard/google/brya/variants/nereid/overridetree.cb b/src/mainboard/google/brya/variants/nereid/overridetree.cb index 5de5c1b..9d9b871 100644 --- a/src/mainboard/google/brya/variants/nereid/overridetree.cb +++ b/src/mainboard/google/brya/variants/nereid/overridetree.cb @@ -209,7 +209,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pch_espi on diff --git a/src/mainboard/google/brya/variants/pujjo/overridetree.cb b/src/mainboard/google/brya/variants/pujjo/overridetree.cb index 59ab871..51383e0 100644 --- a/src/mainboard/google/brya/variants/pujjo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjo/overridetree.cb @@ -673,7 +673,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pcie_rp7 on diff --git a/src/mainboard/google/brya/variants/quandiso/overridetree.cb b/src/mainboard/google/brya/variants/quandiso/overridetree.cb index de48f2d..c28cc0b 100644 --- a/src/mainboard/google/brya/variants/quandiso/overridetree.cb +++ b/src/mainboard/google/brya/variants/quandiso/overridetree.cb @@ -373,7 +373,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pcie_rp7 on diff --git a/src/mainboard/google/brya/variants/xivu/overridetree.cb b/src/mainboard/google/brya/variants/xivu/overridetree.cb index 2e781a2..be4d8df 100644 --- a/src/mainboard/google/brya/variants/xivu/overridetree.cb +++ b/src/mainboard/google/brya/variants/xivu/overridetree.cb @@ -376,7 +376,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb index 580181c..308ed10 100644 --- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb @@ -450,7 +450,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pcie_rp7 on diff --git a/src/mainboard/google/brya/variants/yavilla/overridetree.cb b/src/mainboard/google/brya/variants/yavilla/overridetree.cb index 4a96742..ee5a3b6 100644 --- a/src/mainboard/google/brya/variants/yavilla/overridetree.cb +++ b/src/mainboard/google/brya/variants/yavilla/overridetree.cb @@ -496,7 +496,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pcie_rp7 off end #PCIE7 no SD card -- To view, visit https://review.coreboot.org/c/coreboot/+/79794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5dad9deb040c8cb0c507e11726f0ba44ccb2909 Gerrit-Change-Number: 79794 Gerrit-PatchSet: 1 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: mb/google/brya/var/*: Set dGPU/LAN/WLAN device type to generic
by David Ruth (Code Review) 05 Jan '24

05 Jan '24

David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78873?usp=email ) Change subject: mb/google/brya/var/*: Set dGPU/LAN/WLAN device type to generic ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Note that the device entries in the case of WiFi devices are not "bogus". ACPI tables for PCIe WiFi cards aren't read properly in Linux without the device entries. -- To view, visit https://review.coreboot.org/c/coreboot/+/78873?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic997b5ad893853b99ae53a2e5c7acf58467ea4f1 Gerrit-Change-Number: 78873 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: David Ruth <druth(a)chromium.org> Gerrit-Comment-Date: Fri, 05 Jan 2024 19:26:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/poppy: Use chipset dt reference names
by Felix Singer (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Marvin Evers. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79439?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/poppy: Use chipset dt reference names ...................................................................... Patch Set 4: Code-Review+1 (4 comments) Patchset: PS4: I actually drafted comments but I forgot to send them. Sorry.. File src/mainboard/google/poppy/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/79439/comment/2d096435_23686235 : PS4, Line 254: The commit message doesn't suggest that lines are removed and no lines were removed from the other files. It doesn't make a difference here, since the configuration is identical to the chipset devicetree, but please add it again. https://review.coreboot.org/c/coreboot/+/79439/comment/e8f8da50_811417d3 : PS4, Line 379: device pci 1f.1 on end # P2SB : Same here. Please add these lines again. PS4: Please indent the on keyword with tabs, and also in the other files. See the previous patches. -- To view, visit https://review.coreboot.org/c/coreboot/+/79439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22bcde2dea726f47f8d64a762ca147efde0b610d Gerrit-Change-Number: 79439 Gerrit-PatchSet: 4 Gerrit-Owner: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 19:07:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024