coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[XS] Change in coreboot[master]: Makefile.inc: Enable Wold-style-declaration command option
by Elyes Haouas (Code Review) 06 Jan '24

06 Jan '24

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/71892?usp=email ) Change subject: Makefile.inc: Enable Wold-style-declaration command option ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/71892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida3fa59edb07e4105ef3cfb6a20cb29680699586 Gerrit-Change-Number: 71892 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

[S] Change in coreboot[main]: vc/intel/fsp/mtl: Update header files from 3424_88 to 3471.85
by Kapil Porwal (Code Review) 06 Jan '24

06 Jan '24

Attention is currently required from: Kilari Raasi, Ronak Kanabar, srinivas.kulkarni(a)intel.com. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79829?usp=email ) Change subject: vc/intel/fsp/mtl: Update header files from 3424_88 to 3471.85 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79829?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11c39fc2e3099d93a488e71d571ac1af02345fbd Gerrit-Change-Number: 79829 Gerrit-PatchSet: 2 Gerrit-Owner: srinivas.kulkarni(a)intel.com Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kilari Raasi <kilari.raasi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Kilari Raasi <kilari.raasi(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: srinivas.kulkarni(a)intel.com Gerrit-Comment-Date: Sat, 06 Jan 2024 11:46:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel: Add config to use S3 over S0ix
by Arthur Heymans (Code Review) 06 Jan '24

06 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Nick Vaccaro, Tarun, Tim Crawford. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79631?usp=email ) Change subject: soc/intel: Add config to use S3 over S0ix ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79631/comment/8d01d5cc_194cddd3 : PS2, Line 11: indicating to the OS that S3 : suspend is the preferred sleep method. Is this accurate? I think the bit indicates the S0ix capability. If you don't set it the OS cannot suspend that way. If so this would just disable s0ix? -- To view, visit https://review.coreboot.org/c/coreboot/+/79631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife98166338c5457fb2c7dad81a30e54f487495f6 Gerrit-Change-Number: 79631 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Jan 2024 11:30:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: Documentation/getting_started: Add a FAQ document
by Arthur Heymans (Code Review) 06 Jan '24

06 Jan '24

Attention is currently required from: Angel Pons, David Hendricks, Jakub Czapiga, Martin L Roth, Matt DeVillier, Nicholas Chin, Paul Menzel. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79441?usp=email ) Change subject: Documentation/getting_started: Add a FAQ document ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: Awesome! -- To view, visit https://review.coreboot.org/c/coreboot/+/79441?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia324e4800bf9dfc7ad86f4f99272c87ac566304e Gerrit-Change-Number: 79441 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Jan 2024 10:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vc/intel/fsp/mtl: Update header files from 3424_88 to 3471.85
by Subrata Banik (Code Review) 06 Jan '24

06 Jan '24

Attention is currently required from: Kilari Raasi, Ronak Kanabar, srinivas.kulkarni(a)intel.com. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79829?usp=email ) Change subject: vc/intel/fsp/mtl: Update header files from 3424_88 to 3471.85 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79829?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11c39fc2e3099d93a488e71d571ac1af02345fbd Gerrit-Change-Number: 79829 Gerrit-PatchSet: 2 Gerrit-Owner: srinivas.kulkarni(a)intel.com Gerrit-Reviewer: Kilari Raasi <kilari.raasi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Kilari Raasi <kilari.raasi(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: srinivas.kulkarni(a)intel.com Gerrit-Comment-Date: Sat, 06 Jan 2024 09:48:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: cpu/x86/smi_trigger: use call_smm
by Felix Held (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jérémy Compostella. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79828?usp=email ) Change subject: cpu/x86/smi_trigger: use call_smm ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/79828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iefbdb3d17932d6db6a17b5771436ede220c714fb Gerrit-Change-Number: 79828 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 22:42:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/include/smm: use pm_acpi_smi_cmd_port
by Felix Held (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79568?usp=email ) Change subject: arch/x86/include/smm: use pm_acpi_smi_cmd_port ...................................................................... Patch Set 5: (1 comment) This change is ready for review. File src/arch/x86/include/smm.h: https://review.coreboot.org/c/coreboot/+/79568/comment/06cd31fa_1627a774 : PS3, Line 17: "outb %b0, %3" > oh, if i had seen your comment before working on this, i'd have recycled this chage id for CB:79766. […] looked into this and now understood how things were working. thanks or the pointer and the explanation -- To view, visit https://review.coreboot.org/c/coreboot/+/79568?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb79c91cfcd75db760bd80cff7f3d0400d1f16cd Gerrit-Change-Number: 79568 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 05 Jan 2024 22:41:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage
by Felix Held (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Jérémy Compostella. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79827?usp=email ) Change subject: arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79827/comment/d3b28feb_1bfb4c7c : PS1, Line 10: easier : to understand > there's also some function difference in the different outb parameters Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I73837cab75429014897486b38a5c56f93a850f96 Gerrit-Change-Number: 79827 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 22:40:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT
by Felix Held (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Patrick Rudolph. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79566?usp=email ) Change subject: arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT ...................................................................... Patch Set 6: (2 comments) Patchset: PS1: > CB:79568 has some things that still need to be solved for this to be usable in the whole coreboot co […] Done File src/arch/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/79566/comment/5fcbd87b_60bc51e6 : PS3, Line 322: non-fixed APMC SMI command port > would it make things clearer when replacing 'non-fixed' with 'configurable'? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79566?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaceb61b0f2a630d7afe2e0780b6a2a9806ea62f9 Gerrit-Change-Number: 79566 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 05 Jan 2024 22:40:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT
by Felix Held (Code Review) 05 Jan '24

05 Jan '24

Attention is currently required from: Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Patrick Rudolph. Hello Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79566?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by Jérémy Compostella, Code-Review+2 by Patrick Rudolph, Verified+1 by build bot (Jenkins) Change subject: arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT ...................................................................... arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT Introduce the HAVE_CONFIGURABLE_APMC_SMI_PORT Kconfig option that when not selected will result in a default implementation of pm_acpi_smi_cmd_port to be included in the build that returns APM_CNT. SoCs that provide their own pm_acpi_smi_cmd_port implementation, need to select this Kconfig option. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Iaceb61b0f2a630d7afe2e0780b6a2a9806ea62f9 --- M src/arch/x86/Kconfig M src/arch/x86/Makefile.inc A src/arch/x86/apmc_smi_port.c M src/mainboard/emulation/qemu-q35/Makefile.inc D src/mainboard/emulation/qemu-q35/smi.c M src/soc/amd/common/block/smi/Kconfig 6 files changed, 22 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/79566/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/79566?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaceb61b0f2a630d7afe2e0780b6a2a9806ea62f9 Gerrit-Change-Number: 79566 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024