coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[M] Change in coreboot[main]: sb/intel/common: Get memory map from SPI controller
by Arthur Heymans (Code Review) 10 Jan '24

10 Jan '24

Arthur Heymans has uploaded a new patch set (#6). ( https://review.coreboot.org/c/coreboot/+/79880?usp=email ) Change subject: sb/intel/common: Get memory map from SPI controller ...................................................................... sb/intel/common: Get memory map from SPI controller Instead of always assuming that the top of a flash matches the top of 4G use the real memory map that's configured in the IFD and is reflected in the SPI registers. One possible use case is to cleanly generate images for some hacks rather than having to apply some 'dd' trickery: e.g. on HP Sure Start a part of the flash is checked by EC. UNTESTED. This might break some hacks people use to work around SPI locked images by modifying the IFD when booted with a recovery strap pulled. Those would also need a specifically crafted FMAP. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I5f31c175345ec3efab02255a7063054eb0ad29e4 --- M src/southbridge/intel/common/Kconfig.common M src/southbridge/intel/common/Makefile.inc M src/southbridge/intel/common/rcba.h A src/southbridge/intel/common/spi_memmap.c 4 files changed, 92 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/79880/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/79880?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5f31c175345ec3efab02255a7063054eb0ad29e4 Gerrit-Change-Number: 79880 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: soc/intel/common/tcss: Rename tcss_mux_init
by Sean Rhodes (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Matt DeVillier. Hello Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79874?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/common/tcss: Rename tcss_mux_init ...................................................................... soc/intel/common/tcss: Rename tcss_mux_init Rename tcss_mux_init to disconnect_tcss_devices to make it clear what this function is doing, as it doesn't initialise anything. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I5e43f0cca9d49bc30fc189663490a306efd71584 --- M src/soc/intel/common/block/tcss/tcss.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/79874/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79874?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e43f0cca9d49bc30fc189663490a306efd71584 Gerrit-Change-Number: 79874 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[NoOp] Change in coreboot[main]: arch/x86/include: rename smm.h to smm_call.h
by Felix Held (Code Review) 10 Jan '24

10 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79833?usp=email ) Change subject: arch/x86/include: rename smm.h to smm_call.h ...................................................................... arch/x86/include: rename smm.h to smm_call.h Rename smm.h to smm_call.h to make including this file look less ambiguous. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ia907ad92459e835feeddf7eb4743a38f99549179 Reviewed-on: https://review.coreboot.org/c/coreboot/+/79833 Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- R src/arch/x86/include/smm_call.h 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Jérémy Compostella: Looks good to me, but someone else must approve Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/arch/x86/include/smm.h b/src/arch/x86/include/smm_call.h similarity index 100% rename from src/arch/x86/include/smm.h rename to src/arch/x86/include/smm_call.h -- To view, visit https://review.coreboot.org/c/coreboot/+/79833?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia907ad92459e835feeddf7eb4743a38f99549179 Gerrit-Change-Number: 79833 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage
by Felix Held (Code Review) 10 Jan '24

10 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79827?usp=email ) Change subject: arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage ...................................................................... arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage The call_smm function is currently unused and the inline assembly code for more or less the same functionality in drivers/smmstore/ramstage is both a bit easier to understand since it uses the register names in the 'outb' instruction instead of positional arguments, and also tells the compiler that this piece of code might change global memory. Having too much in the clobber list might only have some performance impact, which should however be negligible compared to the SMI handler being called, while missing something in the clobber list might cause hard to debug problems. This is a preparation to make drivers/smmstore/ramstage use call_smm instead of having its own inline assembly implementation for this. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I73837cab75429014897486b38a5c56f93a850f96 Reviewed-on: https://review.coreboot.org/c/coreboot/+/79827 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/arch/x86/include/smm.h 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/arch/x86/include/smm.h b/src/arch/x86/include/smm.h index e6db9dc..c0d96c0 100644 --- a/src/arch/x86/include/smm.h +++ b/src/arch/x86/include/smm.h @@ -13,8 +13,11 @@ { u32 res = 0; __asm__ __volatile__ ( - "outb %b0, %3" + "outb %%al, %%dx" : "=a" (res) - : "a" ((subcmd << 8) | cmd), "b" (arg), "i" (APM_CNT)); + : "a" ((subcmd << 8) | cmd), + "b" (arg), + "d" (APM_CNT) + : "memory"); return res; } -- To view, visit https://review.coreboot.org/c/coreboot/+/79827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I73837cab75429014897486b38a5c56f93a850f96 Gerrit-Change-Number: 79827 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: soc/amd/stoneyridge/acpi: use common AMD MADT code
by Matt DeVillier (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79885?usp=email ) Change subject: soc/amd/stoneyridge/acpi: use common AMD MADT code ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If4ce71a47827e144c4d4991152101650904901f2 Gerrit-Change-Number: 79885 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 20:34:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/include/smm_call: improve documentation of call_smm
by Matt DeVillier (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Felix Held, Jérémy Compostella. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79834?usp=email ) Change subject: arch/x86/include/smm_call: improve documentation of call_smm ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79834?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3566af191492ce00a3033335ff80e01c33e98e63 Gerrit-Change-Number: 79834 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 20:33:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/include/smm_call: use pm_acpi_smi_cmd_port
by Matt DeVillier (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Arthur Heymans, Felix Held, Jérémy Compostella. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79568?usp=email ) Change subject: arch/x86/include/smm_call: use pm_acpi_smi_cmd_port ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79568?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb79c91cfcd75db760bd80cff7f3d0400d1f16cd Gerrit-Change-Number: 79568 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 20:32:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/smmstore/ramstage: use call_smm
by Matt DeVillier (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79766?usp=email ) Change subject: drivers/smmstore/ramstage: use call_smm ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79766?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib14de0d120ae5c7db3bb7a529837ababe653e1a2 Gerrit-Change-Number: 79766 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 20:32:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in coreboot[main]: arch/x86/include: rename smm.h to smm_call.h
by Matt DeVillier (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79833?usp=email ) Change subject: arch/x86/include: rename smm.h to smm_call.h ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79833?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia907ad92459e835feeddf7eb4743a38f99549179 Gerrit-Change-Number: 79833 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 20:32:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage
by Matt DeVillier (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Felix Held, Jérémy Compostella. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79827?usp=email ) Change subject: arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I73837cab75429014897486b38a5c56f93a850f96 Gerrit-Change-Number: 79827 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 20:31:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024