coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[S] Change in coreboot[main]: mb/google/dedede/var/pirika: Add initial fw_config configuration setting
by Daniel Peng (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede/var/pirika: Add initial fw_config configuration setting ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79930/comment/4fd541da_6740b9f4 : PS7, Line 7: mb/google/dedede > Should the prefix also contain `/var/pirka`? Done https://review.coreboot.org/c/coreboot/+/79930/comment/8867c0a4_6da36c67 : PS7, Line 16: For Palutena project, the SKU ID segment of Palutena is set for : "0x350000~0x35FFFF". > But why these values? Because of NEW PROJECT. And this SKU ID is provided by Google SIE Shou-Chieh Hsu. -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 11:33:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede/var/pirika: Add initial fw_config configuration setting
by Daniel Peng (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu. Hello Anson Tseng, Karthik Ramasubramanian, Shou-Chieh Hsu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79930?usp=email to look at the new patch set (#8). Change subject: mb/google/dedede/var/pirika: Add initial fw_config configuration setting ...................................................................... mb/google/dedede/var/pirika: Add initial fw_config configuration setting 1. Describe the FW_CONFIG probe for the settings on marasov. - WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF - WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW 2. In contrast to the AW Wi-Fi module, the Intel Wi-Fi module needs to load a SAR table in dedede platform. 3. For Palutena project, the SKU ID segment of Palutena is set for "0x350000~0x35FFFF". BUG=b:319792428 BRANCH=firmware-dedede-13606.B TEST=build pass Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb M src/mainboard/google/dedede/variants/pirika/variant.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/79930/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/dedede: Add initial fw_config configuration setting
by Paul Menzel (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede: Add initial fw_config configuration setting ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79930/comment/e89c6714_08ae5ed0 : PS7, Line 7: mb/google/dedede Should the prefix also contain `/var/pirka`? https://review.coreboot.org/c/coreboot/+/79930/comment/d025711a_8a1f14ba : PS7, Line 16: For Palutena project, the SKU ID segment of Palutena is set for : "0x350000~0x35FFFF". But why these values? -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 11:28:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede: Add initial fw_config configuration setting
by Daniel Peng (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede: Add initial fw_config configuration setting ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File src/mainboard/google/dedede/variants/pirika/variant.c: https://review.coreboot.org/c/coreboot/+/79930/comment/ba084ebf_13028c12 : PS4, Line 14: 0x350000 > I am not allowed to access this page, so it’d be great if the information could be added to the comm […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 11:26:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede: Add initial fw_config configuration setting
by Daniel Peng (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu. Hello Anson Tseng, Karthik Ramasubramanian, Shou-Chieh Hsu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79930?usp=email to look at the new patch set (#7). Change subject: mb/google/dedede: Add initial fw_config configuration setting ...................................................................... mb/google/dedede: Add initial fw_config configuration setting 1. Describe the FW_CONFIG probe for the settings on marasov. - WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF - WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW 2. In contrast to the AW Wi-Fi module, the Intel Wi-Fi module needs to load a SAR table in dedede platform. 3. For Palutena project, the SKU ID segment of Palutena is set for "0x350000~0x35FFFF". BUG=b:319792428 BRANCH=firmware-dedede-13606.B TEST=build pass Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb M src/mainboard/google/dedede/variants/pirika/variant.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/79930/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/dedede: Add initial fw_config configuration setting
by Paul Menzel (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede: Add initial fw_config configuration setting ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/dedede/variants/pirika/variant.c: https://review.coreboot.org/c/coreboot/+/79930/comment/631bb4a2_3de2e6b4 : PS4, Line 14: 0x350000 > Please refer below link. Thanks. […] I am not allowed to access this page, so it’d be great if the information could be added to the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 11:23:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede: Add initial fw_config configuration setting
by Daniel Peng (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede: Add initial fw_config configuration setting ...................................................................... Patch Set 6: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79930/comment/38518796_30f96811 : PS4, Line 7: Initial fw_config configuration setting > Please make it a statement by using a verb (in imperative mood). Maybe: […] Done https://review.coreboot.org/c/coreboot/+/79930/comment/f892ac24_c883e2d2 : PS4, Line 9: 1.Describe > Please add a dot after the enumeration number(?). Done https://review.coreboot.org/c/coreboot/+/79930/comment/d5bb184a_32963322 : PS4, Line 10: - WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF : - WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW > As this belongs to item one, please indent by four spaces. Done File src/mainboard/google/dedede/variants/pirika/variant.c: https://review.coreboot.org/c/coreboot/+/79930/comment/934927b4_2709602e : PS4, Line 14: 0x350000 > Where is this number from? Please refer below link. Thanks. https://partnerissuetracker.corp.google.com/issues/319778219#comment3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 11:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede: Add initial fw_config configuration setting
by Daniel Peng (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu. Hello Anson Tseng, Karthik Ramasubramanian, Shou-Chieh Hsu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79930?usp=email to look at the new patch set (#6). Change subject: mb/google/dedede: Add initial fw_config configuration setting ...................................................................... mb/google/dedede: Add initial fw_config configuration setting 1. Describe the FW_CONFIG probe for the settings on marasov. - WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF - WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW 2. In contrast to the AW Wi-Fi module, the Intel Wi-Fi module needs to load a SAR table in dedede platform. BUG=b:319792428 BRANCH=firmware-dedede-13606.B TEST=build pass Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb M src/mainboard/google/dedede/variants/pirika/variant.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/79930/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/dedede: Initial fw_config configuration setting
by Paul Menzel (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede: Initial fw_config configuration setting ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79930/comment/09ad8046_327cf955 : PS4, Line 7: Initial fw_config configuration setting Please make it a statement by using a verb (in imperative mood). Maybe: > Configure … or > Add initial … https://review.coreboot.org/c/coreboot/+/79930/comment/82893159_4fe84fb7 : PS4, Line 9: 1.Describe Please add a dot after the enumeration number(?). https://review.coreboot.org/c/coreboot/+/79930/comment/13c77cb1_1f7d45bd : PS4, Line 10: - WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF : - WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW As this belongs to item one, please indent by four spaces. File src/mainboard/google/dedede/variants/pirika/variant.c: https://review.coreboot.org/c/coreboot/+/79930/comment/71756079_bec86700 : PS4, Line 14: 0x350000 Where is this number from? -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 11:16:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/dedede: Initial fw_config configuration setting
by Daniel Peng (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Shou-Chieh Hsu. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email ) Change subject: mb/google/dedede: Initial fw_config configuration setting ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4f38928d24c4398d90df226cfe0788a30075bf2 Gerrit-Change-Number: 79930 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 11:14:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024