coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[XS] Change in coreboot[main]: [WIP] device/device_util: TODO look into is_pci_dev_on_bus
by Patrick Rudolph (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Felix Held. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79928?usp=email ) Change subject: [WIP] device/device_util: TODO look into is_pci_dev_on_bus ...................................................................... Patch Set 3: (1 comment) File src/device/device_util.c: https://review.coreboot.org/c/coreboot/+/79928/comment/12a35217_5ce21997 : PS3, Line 985: is_pci_dev_on_bus looks like it's only used on platforms that expect 1 PCI segment group. -- To view, visit https://review.coreboot.org/c/coreboot/+/79928?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I74219f2db407c107e3e7dcae1ee11b2c91225fbf Gerrit-Change-Number: 79928 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Jan 2024 08:47:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: device: Add support for multiple PCI segment groups
by Patrick Rudolph (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Cliff Huang, Felix Held, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Tim Wawrzynczak. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79927?usp=email ) Change subject: device: Add support for multiple PCI segment groups ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79927?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied3313c41896362dd989ee2ab1b1bcdced840aa8 Gerrit-Change-Number: 79927 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Jan 2024 08:47:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
by Ruihai Zhou (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu, cong yang, ot_hao.han(a)mediatek.com. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78957?usp=email ) Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri ...................................................................... Patch Set 12: (1 comment) File src/mainboard/google/geralt/panel.c: https://review.coreboot.org/c/coreboot/+/78957/comment/76dac4ad_6c6ffbd9 : PS11, Line 72: mdelay(10); > We can move `mtk_i2c_bus_init` to the beginning to make power-on sequences more clear. […] Done, leave 2ms for the panel need >1ms. -- To view, visit https://review.coreboot.org/c/coreboot/+/78957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9 Gerrit-Change-Number: 78957 Gerrit-PatchSet: 12 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: ot_hao.han(a)mediatek.com <ot_hao.han(a)mediatek.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: ot_hao.han(a)mediatek.com <ot_hao.han(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 08:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: ot_hao.han(a)mediatek.com <ot_hao.han(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
by Ruihai Zhou (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Yidi Lin, Yu-Ping Wu, cong yang, ot_hao.han(a)mediatek.com. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang, ot_hao.han(a)mediatek.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78957?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Code-Review+1 by Yu-Ping Wu, Code-Review+1 by ot_hao.han(a)mediatek.com, Code-Review+2 by Yidi Lin, Verified+1 by build bot (Jenkins) Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri ...................................................................... mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri The MIPI panel BOE_NV110WUM_L60 will be used for Ciri, enable it. BUG=b:308968270 TEST=Boot to firmware screen BRANCH=None Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9 Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/Makefile.inc M src/mainboard/google/geralt/panel.c M src/mainboard/google/geralt/panel.h A src/mainboard/google/geralt/panel_ciri.c M src/mainboard/google/geralt/panel_geralt.c 6 files changed, 76 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/78957/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/78957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9 Gerrit-Change-Number: 78957 Gerrit-PatchSet: 12 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: ot_hao.han(a)mediatek.com <ot_hao.han(a)mediatek.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: ot_hao.han(a)mediatek.com <ot_hao.han(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: tree: Use accessor functions for struct region fields
by Felix Singer (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Jérémy Compostella, Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79904?usp=email ) Change subject: tree: Use accessor functions for struct region fields ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79904?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaae116a1ab2da3b2ea2a5ebcd0c300b238582834 Gerrit-Change-Number: 79904 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 08:31:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: lint/kconfig_lint: Remove SOUTH_BRIDGE_OPTIONS
by Elyes Haouas (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Martin L Roth. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79913?usp=email ) Change subject: lint/kconfig_lint: Remove SOUTH_BRIDGE_OPTIONS ...................................................................... lint/kconfig_lint: Remove SOUTH_BRIDGE_OPTIONS SOUTH_BRIDGE_OPTIONS Kconfig symbol is no longer used. Change-Id: I2380f1ce48afd191755d8b3dcab0b51909f5231f Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/kconfig_lint 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/79913/1 diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 523fa3e..e67aebd 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -46,7 +46,7 @@ my @collected_symbols; # my %selected_symbols; # list of symbols that are enabled by a select statement -my $exclude_unused = '_SPECIFIC_OPTIONS|SOUTH_BRIDGE_OPTIONS'; +my $exclude_unused = '_SPECIFIC_OPTIONS'; Main(); -- To view, visit https://review.coreboot.org/c/coreboot/+/79913?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2380f1ce48afd191755d8b3dcab0b51909f5231f Gerrit-Change-Number: 79913 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: tree: Remove duplicated includes
by Elyes Haouas (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Jonathon Hall. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79912?usp=email ) Change subject: tree: Remove duplicated includes ...................................................................... tree: Remove duplicated includes Change-Id: I09dd5871cb366ef95410efc1ca6c4337f23b52fd Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/dedede/variants/baseboard/ramstage.c M src/mainboard/purism/librem_l1um_v2/bootblock.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/79912/1 diff --git a/src/mainboard/google/dedede/variants/baseboard/ramstage.c b/src/mainboard/google/dedede/variants/baseboard/ramstage.c index d43d08f..e14e956 100644 --- a/src/mainboard/google/dedede/variants/baseboard/ramstage.c +++ b/src/mainboard/google/dedede/variants/baseboard/ramstage.c @@ -6,7 +6,6 @@ #include <drivers/usb/acpi/chip.h> #include <fw_config.h> #include <gpio.h> -#include <soc/pci_devs.h> #include <ec/google/chromeec/ec.h> #include <device/pci_ops.h> #include <intelblocks/power_limit.h> diff --git a/src/mainboard/purism/librem_l1um_v2/bootblock.c b/src/mainboard/purism/librem_l1um_v2/bootblock.c index d815669..58a22d2 100644 --- a/src/mainboard/purism/librem_l1um_v2/bootblock.c +++ b/src/mainboard/purism/librem_l1um_v2/bootblock.c @@ -12,7 +12,6 @@ #include "gpio.h" #include <gpio.h> #include <timer.h> -#include <delay.h> static int64_t bmc_ready_elapsed = 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/79912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I09dd5871cb366ef95410efc1ca6c4337f23b52fd Gerrit-Change-Number: 79912 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: lib/fw_config: Remove redundant stdbool and stdint
by Elyes Haouas (Code Review) 12 Jan '24

12 Jan '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79911?usp=email ) Change subject: lib/fw_config: Remove redundant stdbool and stdint ...................................................................... lib/fw_config: Remove redundant stdbool and stdint <types.h> already includes <stdbool.h> and <stdint.h> Change-Id: Ie8676769127d21a3b4693ed947a7231b94e99241 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/lib/fw_config.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/79911/1 diff --git a/src/lib/fw_config.c b/src/lib/fw_config.c index 6f35e94..10d283e 100644 --- a/src/lib/fw_config.c +++ b/src/lib/fw_config.c @@ -8,8 +8,6 @@ #include <ec/google/chromeec/ec.h> #include <fw_config.h> #include <lib.h> -#include <stdbool.h> -#include <stdint.h> #include <drivers/vpd/vpd.h> #include <types.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/79911?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8676769127d21a3b4693ed947a7231b94e99241 Gerrit-Change-Number: 79911 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: tree: Set <types.h> chain-include <inttypes.h>
by Elyes Haouas (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jason Nien, Jérémy Compostella, Martin Roth, Matt DeVillier. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79910?usp=email ) Change subject: tree: Set <types.h> chain-include <inttypes.h> ...................................................................... tree: Set <types.h> chain-include <inttypes.h> Change-Id: I7726e69dfe1d919970359f4f626f69322021a599 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/cpu/x86/smm/tseg_region.c M src/include/types.h M src/lib/coreboot_table.c M src/lib/fw_config.c M src/mainboard/google/zork/variants/baseboard/helpers.c M src/northbridge/intel/i945/raminit.c M src/soc/amd/common/block/smbus/smbus.c M src/soc/amd/common/block/xhci/elog.c M src/soc/intel/common/block/tcss/tcss.c 9 files changed, 6 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/79910/1 diff --git a/src/cpu/x86/smm/tseg_region.c b/src/cpu/x86/smm/tseg_region.c index 413d5fc..18c770f 100644 --- a/src/cpu/x86/smm/tseg_region.c +++ b/src/cpu/x86/smm/tseg_region.c @@ -6,7 +6,6 @@ #include <cpu/x86/smm.h> #include <stage_cache.h> #include <types.h> -#include <inttypes.h> /* * Subregions within SMM diff --git a/src/include/types.h b/src/include/types.h index ca45717..8ec8695 100644 --- a/src/include/types.h +++ b/src/include/types.h @@ -10,6 +10,7 @@ #include <stdbool.h> #include <stdint.h> #include <stddef.h> +#include <inttypes.h> /* IWYU pragma: end_exports */ /* diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index 800d2d4..f063b47 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -19,7 +19,6 @@ #include <cbmem.h> #include <bootmem.h> #include <bootsplash.h> -#include <inttypes.h> #include <spi_flash.h> #include <smmstore.h> #include <types.h> diff --git a/src/lib/fw_config.c b/src/lib/fw_config.c index 268be07..6f35e94 100644 --- a/src/lib/fw_config.c +++ b/src/lib/fw_config.c @@ -7,11 +7,11 @@ #include <device/device.h> #include <ec/google/chromeec/ec.h> #include <fw_config.h> -#include <inttypes.h> #include <lib.h> #include <stdbool.h> #include <stdint.h> #include <drivers/vpd/vpd.h> +#include <types.h> uint64_t fw_config_get(void) { diff --git a/src/mainboard/google/zork/variants/baseboard/helpers.c b/src/mainboard/google/zork/variants/baseboard/helpers.c index ed98177..9ce7201 100644 --- a/src/mainboard/google/zork/variants/baseboard/helpers.c +++ b/src/mainboard/google/zork/variants/baseboard/helpers.c @@ -1,9 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <console/console.h> -#include <inttypes.h> #include <baseboard/variants.h> #include <ec/google/chromeec/ec.h> +#include <types.h> /* Global definitions for FW_CONFIG values */ enum { diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index 2613b81..3e9447c 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -9,7 +9,6 @@ #include <device/pci_ops.h> #include <device/pci_type.h> #include <device/smbus_host.h> -#include <inttypes.h> #include <lib.h> #include <pc80/mc146818rtc.h> #include <spd.h> diff --git a/src/soc/amd/common/block/smbus/smbus.c b/src/soc/amd/common/block/smbus/smbus.c index 1a97e52..d95bfee 100644 --- a/src/soc/amd/common/block/smbus/smbus.c +++ b/src/soc/amd/common/block/smbus/smbus.c @@ -1,12 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <inttypes.h> #include <console/console.h> #include <device/mmio.h> #include <device/smbus_host.h> #include <amdblocks/acpimmio.h> #include <amdblocks/smbus.h> #include <soc/southbridge.h> +#include <types.h> /* * Between 1-10 seconds, We should never timeout normally diff --git a/src/soc/amd/common/block/xhci/elog.c b/src/soc/amd/common/block/xhci/elog.c index 64a2c48..969918d 100644 --- a/src/soc/amd/common/block/xhci/elog.c +++ b/src/soc/amd/common/block/xhci/elog.c @@ -9,8 +9,7 @@ #include <device/pci_type.h> #include <device/xhci.h> #include <elog.h> - -#include <inttypes.h> +#include <types.h> #define PORTSC_OFFSET 0x400 #define PORTSC_STRIDE 0x10 diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c index 7c58e3a..06ac280 100644 --- a/src/soc/intel/common/block/tcss/tcss.c +++ b/src/soc/intel/common/block/tcss/tcss.c @@ -10,12 +10,12 @@ #include <intelblocks/pmc_ipc.h> #include <intelblocks/systemagent.h> #include <intelblocks/tcss.h> -#include <inttypes.h> #include <lib.h> #include <security/vboot/vboot_common.h> #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/tcss.h> +#include <types.h> #include <drivers/intel/pmc_mux/conn/chip.h> #define BIAS_CTRL_VW_INDEX_SHIFT 16 -- To view, visit https://review.coreboot.org/c/coreboot/+/79910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7726e69dfe1d919970359f4f626f69322021a599 Gerrit-Change-Number: 79910 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: sb/intel/bd82x6x: Remove dummy SOUTH_BRIDGE_OPTIONS Kconfig symbol
by Elyes Haouas (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Nico Huber. Hello Felix Held, Felix Singer, Martin L Roth, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77532?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+1 by Felix Held, Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins) Change subject: sb/intel/bd82x6x: Remove dummy SOUTH_BRIDGE_OPTIONS Kconfig symbol ...................................................................... sb/intel/bd82x6x: Remove dummy SOUTH_BRIDGE_OPTIONS Kconfig symbol Change-Id: If4ae9c800325f5de8f170f8922bacffad1c9bb20 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/Kconfig 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/77532/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/77532?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If4ae9c800325f5de8f170f8922bacffad1c9bb20 Gerrit-Change-Number: 77532 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024