Attention is currently required from: Daniel Maslowski, Felix Singer, Iru Cai, Martin L Roth, Paul Menzel.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77534?usp=email )
Change subject: ec/dell/mec5035: Add command to control radio state
......................................................................
Patch Set 9:
(4 comments)
This change is ready for review.
Patchset:
PS6:
> Suggestion for a more human speak implementation: […]
Went with `mec5035_control_radio(enum ec_radio_dev dev, enum ec_radio_state state)`, so that something like `mec5035_control_radio(RADIO_WLAN, RADIO_ON)` could be used. I think this balances readability and avoiding duplicating code.
File src/ec/dell/mec5035/mec5035.h:
https://review.coreboot.org/c/coreboot/+/77534/comment/a8062af8_38bceed4 :
PS6, Line 19: EN
> So is this an Enable, or a toggle? The commit message suggests it might be a toggle.
The 0x2b command is used for both turning on and off the radio, with arguments to specify which device to target and whether to turn it on or off. The switch on the side is a slide switch with 2 positions, on and off. I've changed EN to CTRL
File src/ec/dell/mec5035/mec5035.c:
https://review.coreboot.org/c/coreboot/+/77534/comment/384bfe03_66701a8e :
PS6, Line 91: dev
> The compiler will probably do the right thing here, but it wouldn't hurt to cast this to a u8
Done
https://review.coreboot.org/c/coreboot/+/77534/comment/74803dba_2e3bab6a :
PS6, Line 92: 3
> I know the other commands in this file just use bare values, but could this maybe be `sizeof(buf)`? […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/77534?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I173dc197d63cda232dd7ede0cb798ab0a364482b
Gerrit-Change-Number: 77534
Gerrit-PatchSet: 9
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Maslowski <info(a)orangecms.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Comment-Date: Mon, 15 Jan 2024 05:32:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Daniel Maslowski <info(a)orangecms.org>
Gerrit-MessageType: comment
Attention is currently required from: Ian Feng, Nick Vaccaro, Paul Menzel, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79914?usp=email )
Change subject: mb/google/nissa/var/craaskov: Add Micron MT62F1G32D4DR-031 to mem_parts
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79914?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e54958490228beb7039d531c709d56ec244b9e7
Gerrit-Change-Number: 79914
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Jan 2024 01:54:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Nick Vaccaro.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79916?usp=email )
Change subject: mb/google/brya: Drop primus4es board
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79916?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0502b2eed6f80d648b422c8d1622d504a6c93822
Gerrit-Change-Number: 79916
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Jan 2024 01:53:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Nick Vaccaro, Paul Menzel.
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79891?usp=email )
Change subject: mb/google/volteer/eldrid: Decrease touchsreen reset time back to 30ms
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> I'm not sure reverting this upstream and breaking functionality under one OS is the answer to meetin […]
I might need Nick's help to see if we could revert this downstream only.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79891?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88432629d82ce0aee670f84cf0a3e65f4052b503
Gerrit-Change-Number: 79891
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Jan 2024 01:21:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Subrata Banik.
Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79914?usp=email )
Change subject: mb/google/nissa/var/craaskov: Add Micron MT62F1G32D4DR-031 to mem_parts
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79914/comment/791077d3_1f305d9c :
PS1, Line 7: Update RAM ID table
> Please be more specific. Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/79914/comment/eb1fc79e_d8e24348 :
PS1, Line 10:
> Please mention, that it’s ID 2 somewhere.
Done
https://review.coreboot.org/c/coreboot/+/79914/comment/64a859c6_b02b1a78 :
PS1, Line 11: DRAM Part Name ID to assign
: MT62F512M32D2DR-031 WT:B 0 (0000)
: H9JCNNNBK3MLYR-N6E 0 (0000)
: K3LKBKB0BM-MGCP 1 (0001)
: H9JCNNNCP3MLYR-N6E 2 (0010)
: MT62F1G32D4DR-031 WT:B 2 (0010)
> Why paste this?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79914?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e54958490228beb7039d531c709d56ec244b9e7
Gerrit-Change-Number: 79914
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Jan 2024 01:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Ian Feng, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Nick Vaccaro, Paul Menzel, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79914?usp=email
to look at the new patch set (#2).
Change subject: mb/google/nissa/var/craaskov: Add Micron MT62F1G32D4DR-031 to mem_parts
......................................................................
mb/google/nissa/var/craaskov: Add Micron MT62F1G32D4DR-031 to mem_parts
Add new memory Micron MT62F1G32D4DR-031 WT:B.
DRAM Part Name ID to assign
MT62F1G32D4DR-031 WT:B 2 (0010)
BUG=b:319778218
BRANCH=firmware-nissa-15217.B
TEST=emerge-nissa coreboot
Change-Id: I9e54958490228beb7039d531c709d56ec244b9e7
Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/craaskov/memory/Makefile.inc
M src/mainboard/google/brya/variants/craaskov/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/craaskov/memory/mem_parts_used.txt
3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/79914/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79914?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e54958490228beb7039d531c709d56ec244b9e7
Gerrit-Change-Number: 79914
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Naresh Solanki.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79972?usp=email )
Change subject: device_util: GIC V3 Path update
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79972/comment/79f3d5e0_34041613 :
PS1, Line 7: GIC V3 Path update
Make it a statement.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79972?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4004c1f1b854a54dfdf9eaa7f25583dec947302
Gerrit-Change-Number: 79972
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Comment-Date: Mon, 15 Jan 2024 00:11:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/67919?usp=email )
Change subject: Resolve GPI/GPIO dysphoria
......................................................................
Abandoned
Not touched for more than a year, abandoning.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67919?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I00fc9e3bfbba5b849d21651b08368fa897ccb1fb
Gerrit-Change-Number: 67919
Gerrit-PatchSet: 6
Gerrit-Owner: Brandon McDonnell <bamteck(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: abandon