coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[XL] Change in coreboot[main]: mb/arm/rdn2: Add support for Arm Neoverse N2
by Patrick Rudolph (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Angel Pons, Arthur Heymans, David Milosevic, Maximilian Brune, Naresh Solanki, Paul Menzel. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79103?usp=email ) Change subject: mb/arm/rdn2: Add support for Arm Neoverse N2 ...................................................................... Patch Set 5: (2 comments) File src/mainboard/arm/rdn2/acpi.c: https://review.coreboot.org/c/coreboot/+/79103/comment/baac55ce_60e65ca9 : PS5, Line 29: platform_get_gicd_base Why does it use GICv2 compatibility mode? https://review.coreboot.org/c/coreboot/+/79103/comment/3a688efa_77195f6d : PS5, Line 30: gicv only needed on GICv2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17908d3ce773d4a88924bafb1d0e9e2a043c7fbc Gerrit-Change-Number: 79103 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 08:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/galtic: Correct the Memory Part Name
by Derek Huang (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Daniel Peng, Karthik Ramasubramanian. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79976?usp=email ) Change subject: mb/google/dedede/var/galtic: Correct the Memory Part Name ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41 Gerrit-Change-Number: 79976 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 08:03:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/galtic: Correct the Memory Part Name
by Daniel Peng (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Derek Huang, Karthik Ramasubramanian. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79976?usp=email ) Change subject: mb/google/dedede/var/galtic: Correct the Memory Part Name ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79976/comment/5ddca145_251744a9 : PS2, Line 7: Re-factor the Memory Setting > Please make it in one line, probably `Correct the memory part name` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41 Gerrit-Change-Number: 79976 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 07:47:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Derek Huang <derekhuang(a)google.com> Comment-In-Reply-To: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/galtic: Correct the Memory Part Name
by Daniel Peng (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Daniel Peng, Karthik Ramasubramanian. Hello Derek Huang, Ivan Chen, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79976?usp=email to look at the new patch set (#4). Change subject: mb/google/dedede/var/galtic: Correct the Memory Part Name ...................................................................... mb/google/dedede/var/galtic: Correct the Memory Part Name Repo sync code recently, run command as memtion in TEST and found the changed for the auto-gen files. Then correct the memory typo from K4UBE3D4AA-MGCR to K4U6E3S4AA-MGCR, and no new for the used hex file. BUG=b:320181366 BRANCH=firmware-dedede-13606.B TEST=Run command "go run ./util/spd_tools/src/part_id_gen/\ part_id_gen.go JSL lp4x \ src/mainboard/google/dedede/variants/galtic/memory/ \ src/mainboard/google/dedede/variants/galtic/memory/\ mem_parts_used.txt" Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/galtic/memory/Makefile.inc M src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/79976/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41 Gerrit-Change-Number: 79976 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: arch/riscv/Makefile.inc: Fix OpenSBI compilation
by Patrick Rudolph (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79952?usp=email ) Change subject: arch/riscv/Makefile.inc: Fix OpenSBI compilation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic14fa77d2f223664b9faba048b759e03efffcde8 Gerrit-Change-Number: 79952 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 07:44:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/uart/sifive.c: Fix divisor calculation
by Patrick Rudolph (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Maximilian Brune. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79951?usp=email ) Change subject: drivers/uart/sifive.c: Fix divisor calculation ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/drivers/uart/sifive.c: https://review.coreboot.org/c/coreboot/+/79951/comment/857919a4_59f37e2b : PS1, Line 50: // according to FU740 manual: please use C style comments `/*` -- To view, visit https://review.coreboot.org/c/coreboot/+/79951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a0898ce9016a70c0f91dc8a99fc1cf9e46d20c4 Gerrit-Change-Number: 79951 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 07:38:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/galtic: Re-name the Memory Part Name K4U6E3S4AA-...
by Derek Huang (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Daniel Peng, Karthik Ramasubramanian. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79976?usp=email ) Change subject: mb/google/dedede/var/galtic: Re-name the Memory Part Name K4U6E3S4AA-MGCR ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79976/comment/8d53d07f_e2a02594 : PS2, Line 7: Re-factor the Memory Setting > Done Please make it in one line, probably `Correct the memory part name` -- To view, visit https://review.coreboot.org/c/coreboot/+/79976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41 Gerrit-Change-Number: 79976 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 07:36:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Derek Huang <derekhuang(a)google.com> Comment-In-Reply-To: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/riscv/boot.c: Add comment for clarity
by Patrick Rudolph (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79949?usp=email ) Change subject: arch/riscv/boot.c: Add comment for clarity ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/arch/riscv/boot.c: https://review.coreboot.org/c/coreboot/+/79949/comment/44b0f049_d1563ad7 : PS1, Line 35: // tell OpenSBI to switch to Supervisor mode before jumping to payload please use C style comments `/* ` -- To view, visit https://review.coreboot.org/c/coreboot/+/79949?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib62be0c2ff59361200df4c65f9aca5f7456a0ada Gerrit-Change-Number: 79949 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 07:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/riscv: Add OPENSBI_FW_DYNAMIC_BOOT_HART option
by Patrick Rudolph (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79948?usp=email ) Change subject: arch/riscv: Add OPENSBI_FW_DYNAMIC_BOOT_HART option ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79948?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id58bd6ae3b55a5ef3f1a5c97dfa07c79aa4c78d0 Gerrit-Change-Number: 79948 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 07:34:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: include/bootmem.h: Add comment
by Patrick Rudolph (Code Review) 15 Jan '24

15 Jan '24

Attention is currently required from: Maximilian Brune. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79947?usp=email ) Change subject: include/bootmem.h: Add comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79947?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f6752e887af8c1ceba56153e3da864abd040ffa Gerrit-Change-Number: 79947 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 07:31:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024