coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5261 discussions

[S] Change in coreboot[master]: payloads/edk2: Add Kconfig to enable UEFI Secure Boot support
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer. Hello build bot (Jenkins), Sean Rhodes, Martin L Roth, Paul Menzel, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74869 to look at the new patch set (#4). Change subject: payloads/edk2: Add Kconfig to enable UEFI Secure Boot support ...................................................................... payloads/edk2: Add Kconfig to enable UEFI Secure Boot support Now that MrChromebox's default edk2 branch supports Secure Boot, add a Kconfig to enable it, and do so by default when MrChromebox's branch is used and SMMSTORE_V2 is enabled (which is a prerequisite). TEST=build/boot google boards link, panther, lulu,reef, ampton, akemi, and banshee, verify Secure Boot options available in payload, Secure Boot status reported properly by Linux/Windows. Change-Id: I4be58c3315cabe08729d717c59203fdc6a3e2958 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M payloads/external/Makefile.inc M payloads/external/edk2/Kconfig M payloads/external/edk2/Makefile 3 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/74869/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4be58c3315cabe08729d717c59203fdc6a3e2958 Gerrit-Change-Number: 74869 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: payloads/edk2: Add Kconfig to enable UEFI Secure Boot support
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer. Hello build bot (Jenkins), Sean Rhodes, Martin L Roth, Paul Menzel, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74869 to look at the new patch set (#3). Change subject: payloads/edk2: Add Kconfig to enable UEFI Secure Boot support ...................................................................... payloads/edk2: Add Kconfig to enable UEFI Secure Boot support Now that MrChromebox's default edk2 branch supports Secure Boot, add a Kconfig to enable it, and do so by default when MrChromebox's branch is used and SMMSTORE_V2 is enabled (which is a prerequisite). TEST=build/boot google boards link, panther, lulu,reef, ampton, akemi, and banshee, verify Secure Boot options available in payload, Secure Boot status reported properly by Linux/Windows. Change-Id: I4be58c3315cabe08729d717c59203fdc6a3e2958 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M payloads/external/Makefile.inc M payloads/external/edk2/Kconfig M payloads/external/edk2/Makefile 3 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/74869/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4be58c3315cabe08729d717c59203fdc6a3e2958 Gerrit-Change-Number: 74869 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: payloads/edk2: Update default branch for MrChromebox repo to 2023-04
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin L Roth, Paul Menzel, Stefan Reinauer. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74868 ) Change subject: payloads/edk2: Update default branch for MrChromebox repo to 2023-04 ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74868/comment/3376124f_2e89249f PS2, Line 7: payloads/edk2: Update default branch for MrChromebox repo > … to 202304 […] Done https://review.coreboot.org/c/coreboot/+/74868/comment/440422e6_5a63c2a5 PS2, Line 11: SecureBoot > Secure Boot Done https://review.coreboot.org/c/coreboot/+/74868/comment/b422f30a_5926789a PS2, Line 15: TEST=build/boot various boards with edk2 payload selected. > It’d be nice if you named at least one of these boards. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I096eaa4e065db731a70ba238ba5a3bb49e5db867 Gerrit-Change-Number: 74868 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 May 2023 13:59:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Update default branch for MrChromebox repo to 2023-04
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer. Hello build bot (Jenkins), Sean Rhodes, Martin L Roth, Paul Menzel, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74868 to look at the new patch set (#3). Change subject: payloads/edk2: Update default branch for MrChromebox repo to 2023-04 ...................................................................... payloads/edk2: Update default branch for MrChromebox repo to 2023-04 Update the default branch used for MrChromebox's edk2 fork from 2022-07 to 2023-04. This updated branch has been rebased on the latest upstream stable tag (edk2-stable202302), and adds support for UEFI Secure Boot and TPM 1.2/2.0 management (though it does not currently support Google CR50/Ti50 TPMs). TEST=build/boot google boards link, panther, lulu,reef, ampton, akemi, and banshee with edk2 payload selected. Change-Id: I096eaa4e065db731a70ba238ba5a3bb49e5db867 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M payloads/external/edk2/Kconfig 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/74868/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I096eaa4e065db731a70ba238ba5a3bb49e5db867 Gerrit-Change-Number: 74868 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: cpu/intel/microcode: Implement microcode info caching inside cbmem
by build bot (Jenkins) (Code Review) 01 May '23

01 May '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74873 ) Change subject: cpu/intel/microcode: Implement microcode info caching inside cbmem ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175292): https://review.coreboot.org/c/coreboot/+/74873/comment/561cd730_fbd50745 PS1, Line 6: Possible long commit subject (prefer a maximum 65 characters) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175292): https://review.coreboot.org/c/coreboot/+/74873/comment/f4a832ef_1fc6f067 PS1, Line 34: microcode: Update skipped, already up-to-date Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I208a2e0e1dce96b2d4d63f882e8aaf4c25f77e3f Gerrit-Change-Number: 74873 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 May 2023 13:30:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/microcode: Implement microcode info caching inside cbmem
by Subrata Banik (Code Review) 01 May '23

01 May '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74873 ) Change subject: cpu/intel/microcode: Implement microcode info caching inside cbmem ...................................................................... cpu/intel/microcode: Implement microcode info caching inside cbmem This patch implements microcode info caching inside cbmem to avoid boot time penalty. Currently, locating ucode from cbfs is a continuous process in every boot hence, there are boot time penalties knowing typically `cpu_microcode_blob.bin` is consists of multiple microcodes as per different CPU steppings. Adding more microcode into `cpu_microcode_blob.bin` would increase the boot time cost. Hence, this patch enables caching of microcode related information inside cbmem that can be used to avoid microcode searching time during the warm resets. Additionally, use a tab to align `CBMEM_ID_CSE_PARTITION_VERSION` with other CBMEM ID macros. TEST=Build and boot google/rex with this patch which saves 11ms of boot time. Without this patch during warm reset: cbmem -c | grep microcode CBFS: Found 'cpu_microcode_blob.bin' @0x1e180 size 0x35400 in mcache @0x76add080 microcode: sig=0x906a4 pf=0x80 revision=0x423 microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date boot time: 954:calling FspSiliconInit 788,614 (5,414) 955:returning from FspSiliconInit 823,803 (35,188) With this patch during warm reset: cbmem -c | grep microcode microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date microcode: Update skipped, already up-to-date boot time: 954:calling FspSiliconInit 786,475 (5,390) 955:returning from FspSiliconInit 811,083 (24,608) Change-Id: I208a2e0e1dce96b2d4d63f882e8aaf4c25f77e3f Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/cpu/intel/microcode/microcode.c M src/include/cpu/intel/microcode.h 3 files changed, 96 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/74873/1 diff --git a/src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h b/src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h index 4162d84..11bfc5a 100644 --- a/src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h +++ b/src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h @@ -85,7 +85,8 @@ #define CBMEM_ID_MEM_CHIP_INFO 0x5048434D #define CBMEM_ID_AMD_STB 0x5f425453 #define CBMEM_ID_AMD_MP2 0x5f32504d -#define CBMEM_ID_CSE_PARTITION_VERSION 0x43535056 +#define CBMEM_ID_CSE_PARTITION_VERSION 0x43535056 +#define CBMEM_ID_MICROCODE_INFO 0x55434f44 #define CBMEM_ID_TO_NAME_TABLE \ { CBMEM_ID_ACPI, "ACPI " }, \ @@ -165,5 +166,6 @@ { CBMEM_ID_MEM_CHIP_INFO, "MEM CHIP INFO"},\ { CBMEM_ID_AMD_STB, "AMD STB"},\ { CBMEM_ID_AMD_MP2, "AMD MP2 BUFFER"},\ - { CBMEM_ID_CSE_PARTITION_VERSION, "CSE PARTITION VERSION"} + { CBMEM_ID_CSE_PARTITION_VERSION, "CSE PARTITION VERSION"}, \ + { CBMEM_ID_MICROCODE_INFO, "MICROCODE INFO"} #endif /* _CBMEM_ID_H_ */ diff --git a/src/cpu/intel/microcode/microcode.c b/src/cpu/intel/microcode/microcode.c index 6f6e2f1..87f122a 100644 --- a/src/cpu/intel/microcode/microcode.c +++ b/src/cpu/intel/microcode/microcode.c @@ -233,16 +233,21 @@ { static bool microcode_checked; static const void *ucode_update; + struct microcode_info *info; if (microcode_checked) return ucode_update; + info = cbmem_find(CBMEM_ID_MICROCODE_INFO); + if (info) + ucode_update = (void *)info->microcode_ptr; /* * Since this function caches the found microcode (NULL or a valid * microcode pointer), it is expected to be run from BSP before starting * any other APs. This sequence is not multithread safe otherwise. */ - ucode_update = find_cbfs_microcode(); + else + ucode_update = find_cbfs_microcode(); microcode_checked = true; return ucode_update; @@ -284,3 +289,18 @@ return 0; } #endif + +static void microcode_setup_cbmem_cache(int unused) +{ + struct microcode_info *info; + uint32_t cpu_id = cpu_get_cpuid(); + + info = cbmem_add(CBMEM_ID_MICROCODE_INFO, sizeof(struct microcode_info)); + if (info->cpu_id != cpu_id) { + info->cpu_id = cpu_id; + info->microcode_rev = get_current_microcode_rev(); + info->microcode_ptr = (uintptr_t)find_cbfs_microcode(); + } +} + +RAMSTAGE_CBMEM_INIT_HOOK(microcode_setup_cbmem_cache) diff --git a/src/include/cpu/intel/microcode.h b/src/include/cpu/intel/microcode.h index 5a6c27e..99de2f7 100644 --- a/src/include/cpu/intel/microcode.h +++ b/src/include/cpu/intel/microcode.h @@ -4,6 +4,12 @@ #include <stdint.h> +struct microcode_info { + uint32_t cpu_id; + uint32_t microcode_rev; + uintptr_t microcode_ptr; +} __packed; + /* Find the microcode and reload the microcode if SoC has RELOAD_MICROCODE_PATCH * config selected. */ void intel_reload_microcode(void); -- To view, visit https://review.coreboot.org/c/coreboot/+/74873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I208a2e0e1dce96b2d4d63f882e8aaf4c25f77e3f Gerrit-Change-Number: 74873 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[master]: vendorcode/intel/fsp/fsp2_0/alderlake: Remove unused headers
by Elyes Haouas (Code Review) 01 May '23

01 May '23

Attention is currently required from: Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74729 ) Change subject: vendorcode/intel/fsp/fsp2_0/alderlake: Remove unused headers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58eda4b2f48386c39c9258a4ceacf0d84280397c Gerrit-Change-Number: 74729 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 May 2023 13:08:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: SMBIOS: Group Kconfig dependency
by Elyes Haouas (Code Review) 01 May '23

01 May '23

Attention is currently required from: Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74451 ) Change subject: SMBIOS: Group Kconfig dependency ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a75a7230fd78c0a9926adc491059f55647cc9a3 Gerrit-Change-Number: 74451 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 12:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: SMBIOS: Group Kconfig dependency
by Paul Menzel (Code Review) 01 May '23

01 May '23

Attention is currently required from: Kyösti Mälkki. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74451 ) Change subject: SMBIOS: Group Kconfig dependency ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a75a7230fd78c0a9926adc491059f55647cc9a3 Gerrit-Change-Number: 74451 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 11:34:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Update default branch for MrChromebox repo
by Paul Menzel (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74868 ) Change subject: payloads/edk2: Update default branch for MrChromebox repo ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74868/comment/537bccae_e627e2d2 PS2, Line 7: payloads/edk2: Update default branch for MrChromebox repo … to 202304 Or: > Default to payload_202304 branch from McChromebox repo https://review.coreboot.org/c/coreboot/+/74868/comment/0b3504e7_12de7cb5 PS2, Line 11: SecureBoot Secure Boot https://review.coreboot.org/c/coreboot/+/74868/comment/d3e59856_033f6ed3 PS2, Line 15: TEST=build/boot various boards with edk2 payload selected. It’d be nice if you named at least one of these boards. ;-) -- To view, visit https://review.coreboot.org/c/coreboot/+/74868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I096eaa4e065db731a70ba238ba5a3bb49e5db867 Gerrit-Change-Number: 74868 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 May 2023 11:34:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023