coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[S] Change in coreboot[master]: mb/facebook/fbg1701/board_mboot.h: Remove config from mb_log_list
by Erik van den Bogaert (Code Review) 01 May '23

01 May '23

Attention is currently required from: Frans Hendriks, Paul Menzel, Angel Pons. Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74750 ) Change subject: mb/facebook/fbg1701/board_mboot.h: Remove config from mb_log_list ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Gerrit-Change-Number: 74750 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 08:09:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/mb/facebook/fbg1701: Add config to additional list
by Erik van den Bogaert (Code Review) 01 May '23

01 May '23

Attention is currently required from: Frans Hendriks, Angel Pons. Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74752 ) Change subject: src/mb/facebook/fbg1701: Add config to additional list ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4119bc3a01e11f14a091facf81964d1a71092c1 Gerrit-Change-Number: 74752 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 08:08:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: protectcli/vault_bsw: Drop USB power control bits in GNVS
by Arthur Heymans (Code Review) 01 May '23

01 May '23

Attention is currently required from: Michał Żygowski, Kyösti Mälkki, Piotr Król. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74859 ) Change subject: protectcli/vault_bsw: Drop USB power control bits in GNVS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7af2d608d95c6691f31ef1b8af72f96da20787c Gerrit-Change-Number: 74859 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Mon, 01 May 2023 07:34:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google,intel,samsung: Use common poweroff()
by Arthur Heymans (Code Review) 01 May '23

01 May '23

Attention is currently required from: Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74515 ) Change subject: mb/google,intel,samsung: Use common poweroff() ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74515 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3881c152663a038833d8126d7f24f2a6688426d1 Gerrit-Change-Number: 74515 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 07:34:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/link: Apply symmetry for EC events defines
by Arthur Heymans (Code Review) 01 May '23

01 May '23

Attention is currently required from: Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74602 ) Change subject: mb/google/link: Apply symmetry for EC events defines ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97d9d28963c97e780156d75b39deac069028866a Gerrit-Change-Number: 74602 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 07:34:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/*: Drop USB power control bits in GNVS
by Arthur Heymans (Code Review) 01 May '23

01 May '23

Attention is currently required from: Erik van den Bogaert, Kyösti Mälkki, Evgeny Zinoviev. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74858 ) Change subject: mainboard/*: Drop USB power control bits in GNVS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1bc5969804a7346caac4ae93336efd9f0240c87 Gerrit-Change-Number: 74858 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Mon, 01 May 2023 07:32:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common/gpio: Add open-drain GPIO macros
by Cliff Huang (Code Review) 01 May '23

01 May '23

Attention is currently required from: Nick Vaccaro. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74841 ) Change subject: soc/intel/common/gpio: Add open-drain GPIO macros ...................................................................... Patch Set 1: (3 comments) File src/soc/intel/common/block/gpio/gpio.c: https://review.coreboot.org/c/coreboot/+/74841/comment/1b1eeb76_4192c81c PS1, Line 724: ~(PAD_CFG0_TX_STATE & PAD_CFG0_TX_DISABLE), Since this change ensures that TX_DISBLE is not set when drive TX output, it can be added to gpio_set(). We don't need to introduce a new function here. File src/soc/intel/common/block/include/intelblocks/gpio_defs.h: https://review.coreboot.org/c/coreboot/+/74841/comment/f3bab930_f65fed81 PS1, Line 292: #define PAD_CFG_OD_GPO(pad, rst) \ Since TX is disabled. this can be changed to PAD_CFG_OD() https://review.coreboot.org/c/coreboot/+/74841/comment/b96b6875_836cc13c PS1, Line 299: #define PAD_CFG_OD_GPO_LOCK(pad, lock_action) \ Since TX is disabled. this can be changed to PAD_CFG_OD_LOCK() -- To view, visit https://review.coreboot.org/c/coreboot/+/74841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ca9915c7574e741c20af2e8dc91f6a07f7c0d26 Gerrit-Change-Number: 74841 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 01 May 2023 06:56:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/*: Drop USB power control bits in GNVS
by Frans Hendriks (Code Review) 01 May '23

01 May '23

Attention is currently required from: Erik van den Bogaert, Kyösti Mälkki, Evgeny Zinoviev. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74858 ) Change subject: mainboard/*: Drop USB power control bits in GNVS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1bc5969804a7346caac4ae93336efd9f0240c87 Gerrit-Change-Number: 74858 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Mon, 01 May 2023 06:47:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Enable/disable sleep states based on EC
by Lean Sheng Tan (Code Review) 01 May '23

01 May '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74421 ) Change subject: mb/prodrive/atlas: Enable/disable sleep states based on EC ...................................................................... mb/prodrive/atlas: Enable/disable sleep states based on EC With the profile ATLAS_PROF_REALTIME_PERFORMANCE it is desired to not have the option to be able to enter sleep. The reason is that Microsoft Windows goes to sleep after 30min of inactivity by default. TEST: See that Microsoft Windows 11 has no 'Sleep' option in the start menu. Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74421 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> --- M src/mainboard/prodrive/atlas/mainboard.c 1 file changed, 32 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved diff --git a/src/mainboard/prodrive/atlas/mainboard.c b/src/mainboard/prodrive/atlas/mainboard.c index db808ce..0128670 100644 --- a/src/mainboard/prodrive/atlas/mainboard.c +++ b/src/mainboard/prodrive/atlas/mainboard.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> #include <gpio.h> @@ -66,9 +67,19 @@ t->count = smbios_add_string(t->eos, get_formatted_pn()); } +static void mainboard_fill_ssdt(const struct device *dev) +{ + const struct emi_eeprom_vpd *eeprom = get_emi_eeprom_vpd(); + const bool sleep_enable = eeprom->profile != ATLAS_PROF_REALTIME_PERFORMANCE ? 1 : 0; + acpigen_ssdt_override_sleep_states(false, false, + CONFIG(HAVE_ACPI_RESUME) && sleep_enable, + sleep_enable); +} + static void mainboard_enable(struct device *dev) { dev->ops->get_smbios_strings = mainboard_smbios_strings; + dev->ops->acpi_fill_ssdt = mainboard_fill_ssdt; } struct chip_operations mainboard_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/74421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Gerrit-Change-Number: 74421 Gerrit-PatchSet: 21 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: acpigen: Add a runtime method to override exposed _Sx sleep states
by Lean Sheng Tan (Code Review) 01 May '23

01 May '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74762 ) Change subject: acpigen: Add a runtime method to override exposed _Sx sleep states ...................................................................... acpigen: Add a runtime method to override exposed _Sx sleep states This allows mainboards to override available sleep states at runtime. This is done by adding a IntObj in SSDT that DSDT consumes to override the available _Sx states. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74762 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Jakub Czapiga <jacz(a)semihalf.com> Reviewed-by: Jan Samek <jan.samek(a)siemens.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> --- M src/acpi/acpigen.c M src/include/acpi/acpigen.h M src/southbridge/intel/common/acpi/sleepstates.asl 3 files changed, 43 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved Jan Samek: Looks good to me, but someone else must approve Jakub Czapiga: Looks good to me, but someone else must approve diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index d613bec..94a6f90 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -2364,3 +2364,17 @@ acpigen_emit_byte(LOCAL7_OP); acpigen_pop_len(); /* While */ } + +void acpigen_ssdt_override_sleep_states(bool enable_s1, bool enable_s2, bool enable_s3, + bool enable_s4) +{ + assert(!(enable_s1 && CONFIG(ACPI_S1_NOT_SUPPORTED))); + assert(!(enable_s3 && !CONFIG(HAVE_ACPI_RESUME))); + assert(!(enable_s4 && CONFIG(DISABLE_ACPI_HIBERNATE))); + + acpigen_write_scope("\\"); + uint32_t sleep_enable = (enable_s1 << 0) | (enable_s2 << 1) + | (enable_s3 << 2) | (enable_s4 << 3); + acpigen_write_name_dword("OSFG", sleep_enable); + acpigen_pop_len(); +} diff --git a/src/include/acpi/acpigen.h b/src/include/acpi/acpigen.h index 180e937..fc1d01b 100644 --- a/src/include/acpi/acpigen.h +++ b/src/include/acpi/acpigen.h @@ -695,4 +695,8 @@ /* Emits Notify(namestr, value) */ void acpigen_notify(const char *namestr, int value); +/* Create a namespace \OSFG to override the enabled sleep states */ +void acpigen_ssdt_override_sleep_states(bool enable_s1, bool enable_s2, bool enable_s3, + bool enable_s4); + #endif /* __ACPI_ACPIGEN_H__ */ diff --git a/src/southbridge/intel/common/acpi/sleepstates.asl b/src/southbridge/intel/common/acpi/sleepstates.asl index 079ab1a..14ed86e 100644 --- a/src/southbridge/intel/common/acpi/sleepstates.asl +++ b/src/southbridge/intel/common/acpi/sleepstates.asl @@ -15,6 +15,11 @@ SSFG &= 0xf7 } +External (\OSFG, IntObj) +If (CondRefOf(\OSFG)) { + SSFG = \OSFG +} + /* Supported sleep states: */ Name(\_S0, Package () {0x00, 0x00, 0x00, 0x00} ) /* (S0) - working state */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998 Gerrit-Change-Number: 74762 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023