coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5261 discussions

[S] Change in coreboot[master]: payloads/edk2: Add Kconfig to enable UEFI SecureBoot support
by Paul Menzel (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74869 ) Change subject: payloads/edk2: Add Kconfig to enable UEFI SecureBoot support ...................................................................... Patch Set 2: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74869/comment/1cbc28e2_3180d9e7 PS2, Line 7: SecureBoot It’s spelled with a space: Secure Boot [1]. (Also several times below.) [1]: https://en.wikipedia.org/wiki/UEFI#Secure_Boot. https://review.coreboot.org/c/coreboot/+/74869/comment/70ded609_77bf2147 PS2, Line 14: payload, SecureBoot status reported properly by Linux/Windows. Does it work in QEMU and should such a run test be added to the build system somehow? Do you have documentation, what keys are used? Patchset: PS2: Nice work! File payloads/external/edk2/Kconfig: https://review.coreboot.org/c/coreboot/+/74869/comment/8f08f9e2_0038be49 PS2, Line 250: SecureBoot Secure Boot https://review.coreboot.org/c/coreboot/+/74869/comment/033a2c95_1a9260f7 PS2, Line 251: SecureBoot Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/74869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4be58c3315cabe08729d717c59203fdc6a3e2958 Gerrit-Change-Number: 74869 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 May 2023 11:32:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/reef: Disable Intel Trace Hub PCI device
by Paul Menzel (Code Review) 01 May '23

01 May '23

Attention is currently required from: Sean Rhodes, Matt DeVillier. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74890 ) Change subject: mb/google/reef: Disable Intel Trace Hub PCI device ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8ec46e2e07b6635bfe9766812ce08b866c71d66 Gerrit-Change-Number: 74890 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 11:29:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/reef: Disable unused devices in devicetrees
by Paul Menzel (Code Review) 01 May '23

01 May '23

Attention is currently required from: Sean Rhodes, Matt DeVillier. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74891 ) Change subject: mb/google/reef: Disable unused devices in devicetrees ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacdf93b4952cbc63fc465f07d440463106527b8d Gerrit-Change-Number: 74891 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 11:28:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Documentation/tutorial/part1.md: fix package name to install qemu on ...
by Paul Menzel (Code Review) 01 May '23

01 May '23

Attention is currently required from: Daniel Rosa Franzini. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74894 ) Change subject: Documentation/tutorial/part1.md: fix package name to install qemu on Debian. ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74894/comment/e49f8d28_287aa17a PS1, Line 6: > Subject line should not end with a period. Please fix. https://review.coreboot.org/c/coreboot/+/74894/comment/48a7849a_78c675b7 PS1, Line 9: Fix package name to install qemu on Debian. It used to be 'qemu' only but it is > Possible unwrapped commit description (prefer a maximum 72 chars per line) Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/74894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 Gerrit-Change-Number: 74894 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Comment-Date: Mon, 01 May 2023 11:27:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/mb/facebook/fbg1701: Add config to additional list
by Paul Menzel (Code Review) 01 May '23

01 May '23

Attention is currently required from: Frans Hendriks, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74752 ) Change subject: src/mb/facebook/fbg1701: Add config to additional list ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74752/comment/5a0a3378_4fb1f8b5 PS1, Line 7: src/ Please remove. https://review.coreboot.org/c/coreboot/+/74752/comment/82e2619f_ecf82d90 PS1, Line 15: booting boot https://review.coreboot.org/c/coreboot/+/74752/comment/ff640e18_e7168b0b PS1, Line 15: verify log What command do you use? -- To view, visit https://review.coreboot.org/c/coreboot/+/74752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4119bc3a01e11f14a091facf81964d1a71092c1 Gerrit-Change-Number: 74752 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 11:22:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: crossgcc: Upgrade GCC from 11.3.0 to 13.1.0
by Elyes Haouas (Code Review) 01 May '23

01 May '23

Attention is currently required from: Felix Singer, Nico Huber, Martin L Roth, Elyes Haouas. Hello Felix Singer, build bot (Jenkins), Nico Huber, Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70771 to look at the new patch set (#13). Change subject: crossgcc: Upgrade GCC from 11.3.0 to 13.1.0 ...................................................................... crossgcc: Upgrade GCC from 11.3.0 to 13.1.0 Change-Id: I4f2ed4de4811abaa13528906de71eee29a8f2910 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/lib/gnat/Makefile.inc M src/lib/gnat/a-unccon.ads M src/lib/gnat/ada.ads M src/lib/gnat/g-souinf.ads M src/lib/gnat/gnat.ads M src/lib/gnat/i-c.adb M src/lib/gnat/i-c.ads M src/lib/gnat/interfac.ads M src/lib/gnat/s-atacco.ads A src/lib/gnat/s-imen16.ads A src/lib/gnat/s-imen32.ads D src/lib/gnat/s-imenne.adb D src/lib/gnat/s-imenne.ads A src/lib/gnat/s-imenu8.ads M src/lib/gnat/s-maccod.ads M src/lib/gnat/s-parame.ads M src/lib/gnat/s-stoele.adb M src/lib/gnat/s-stoele.ads M src/lib/gnat/s-unstyp.ads M src/lib/gnat/system.ads M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-11.3.0_gnat.patch R util/crossgcc/patches/gcc-13.1.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-13.1.0_asan_shadow_offset_callback.patch A util/crossgcc/patches/gcc-13.1.0_gnat.patch R util/crossgcc/patches/gcc-13.1.0_libcpp.patch R util/crossgcc/patches/gcc-13.1.0_libgcc.patch D util/crossgcc/sum/gcc-11.3.0.tar.xz.cksum A util/crossgcc/sum/gcc-13.1.0.tar.xz.cksum 29 files changed, 2,167 insertions(+), 322 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/70771/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/70771 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f2ed4de4811abaa13528906de71eee29a8f2910 Gerrit-Change-Number: 70771 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: device/allocator: Allow for multiple domain resources of a type
by Nico Huber (Code Review) 01 May '23

01 May '23

Attention is currently required from: Jonathan Zhang, Arthur Heymans, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67018 ) Change subject: device/allocator: Allow for multiple domain resources of a type ...................................................................... Patch Set 6: (1 comment) File src/device/resource_allocator_v4.c: https://review.coreboot.org/c/coreboot/+/67018/comment/26e89480_966dd6fe PS6, Line 317: if (res->flags & IORESOURCE_FIXED) : continue; > haven't properly root-caused the behavior i've seen, but when having the IORESOURCE_FIXED flag set i […] All fixed resources are avoided during allocation. It is our way to tell the allocator that a resource range is already occupied (cf. constrain_ domain_resources()). The "windows" you open for allocation shoudn't be fixed, and I assume it's also not necessary to tag them subtractive. In ACPI terms, AIUI, one could say all our *non-fixed domain* resources are "ResourceProducer" while everything else is a "ResourceConsumer". And *non-fixed downstream* resources need allocation. -- To view, visit https://review.coreboot.org/c/coreboot/+/67018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d3a60c9a4438accdb06444e2b50cc9b0b2eb009 Gerrit-Change-Number: 67018 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 01 May 2023 09:11:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Documentation/tutorial/part1.md: fix package name to install qemu on ...
by Nico Huber (Code Review) 01 May '23

01 May '23

Attention is currently required from: Daniel Rosa Franzini. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74894 ) Change subject: Documentation/tutorial/part1.md: fix package name to install qemu on Debian. ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74894/comment/3523ac46_057a0583 PS1, Line 7: Documentation/tutorial/part1.md This prefix doesn't have to be a full path. It only should point into the direction and shouldn't be too long. e.g. doc/tutorial/part1: or even doc/tutorial: would do too. Patchset: PS1: Hi, grats for your first change! :) Please update the commit message according ot the comments (also those of the checkpatch script; it isn't always right but in this case is). You can do so either in Gerrit via the EDIT button, or with `git commit --amend` locally, then push again. Gerrit will recognize a new push as an update to the original change as long as the "ChangeId: " in the commit message is left intact. -- To view, visit https://review.coreboot.org/c/coreboot/+/74894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 Gerrit-Change-Number: 74894 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Comment-Date: Mon, 01 May 2023 08:52:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/*: Drop USB power control bits in GNVS
by Erik van den Bogaert (Code Review) 01 May '23

01 May '23

Attention is currently required from: Kyösti Mälkki, Evgeny Zinoviev. Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74858 ) Change subject: mainboard/*: Drop USB power control bits in GNVS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1bc5969804a7346caac4ae93336efd9f0240c87 Gerrit-Change-Number: 74858 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Mon, 01 May 2023 08:09:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/facebook/fbg1701/board_mboot.h: Remove config from mb_log_list
by Erik van den Bogaert (Code Review) 01 May '23

01 May '23

Attention is currently required from: Frans Hendriks, Paul Menzel, Angel Pons. Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74750 ) Change subject: mb/facebook/fbg1701/board_mboot.h: Remove config from mb_log_list ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacf023bc8b9c2ebc66137c4ea683589751a30d2f Gerrit-Change-Number: 74750 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 May 2023 08:09:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023