coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[S] Change in coreboot[master]: mb/google/myst: Inject SPD binaries to APCB
by Karthik Ramasubramanian (Code Review) 02 May '23

02 May '23

Attention is currently required from: Eric Lai, Martin Roth, Tim Van Patten. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74746 ) Change subject: mb/google/myst: Inject SPD binaries to APCB ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Will APCB include in the local build for factory? APCB should be part of CPFE firmware image. Usually it will be part of upstream blobs git submodule. -- To view, visit https://review.coreboot.org/c/coreboot/+/74746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic511cdc4fe0989c9abc0cd0531cc0cae40f8dc34 Gerrit-Change-Number: 74746 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Tue, 02 May 2023 21:35:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Add initial memory configuration
by Karthik Ramasubramanian (Code Review) 02 May '23

02 May '23

Attention is currently required from: Martin Roth, Tim Van Patten. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74745 ) Change subject: mb/google/myst: Add initial memory configuration ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/myst/variants/myst/memory/Makefile.inc: https://review.coreboot.org/c/coreboot/+/74745/comment/22dac321_164d21e0 PS1, Line 7: spd-2.hex > I mean it's fine for the build, but why is the first (and only) spd called spd-2? […] Skyrim and Myst programs are using the same SPDs and that parts were added a little later in Skyrim program. Hence spd-2.hex -- To view, visit https://review.coreboot.org/c/coreboot/+/74745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a4fe9a41f101ac10391756f1b815220c8b98612 Gerrit-Change-Number: 74745 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Tue, 02 May 2023 21:33:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: introduce the mainboard.asl for all rex variants
by Eran Mitrani (Code Review) 02 May '23

02 May '23

Eran Mitrani has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74886 ) Change subject: mb/google/rex: introduce the mainboard.asl for all rex variants ...................................................................... mb/google/rex: introduce the mainboard.asl for all rex variants This patch enables adding variant specific ASL code TEST=able to build for google/rex Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 --- M src/mainboard/google/rex/dsdt.asl A src/mainboard/google/rex/variants/rex0/include/variant/acpi/mainboard.asl A src/mainboard/google/rex/variants/screebo/include/variant/acpi/mainboard.asl 3 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/74886/1 diff --git a/src/mainboard/google/rex/dsdt.asl b/src/mainboard/google/rex/dsdt.asl index f914b3d..ed19ade 100644 --- a/src/mainboard/google/rex/dsdt.asl +++ b/src/mainboard/google/rex/dsdt.asl @@ -37,4 +37,6 @@ /* ACPI code for EC functions */ #include <ec/google/chromeec/acpi/ec.asl> } + /* Mainboard specific */ + #include "variant/acpi/mainboard.asl" } diff --git a/src/mainboard/google/rex/variants/rex0/include/variant/acpi/mainboard.asl b/src/mainboard/google/rex/variants/rex0/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..853b087 --- /dev/null +++ b/src/mainboard/google/rex/variants/rex0/include/variant/acpi/mainboard.asl @@ -0,0 +1 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ diff --git a/src/mainboard/google/rex/variants/screebo/include/variant/acpi/mainboard.asl b/src/mainboard/google/rex/variants/screebo/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..853b087 --- /dev/null +++ b/src/mainboard/google/rex/variants/screebo/include/variant/acpi/mainboard.asl @@ -0,0 +1 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 1 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: src/drivers/spi: add HID over SPI ACPI driver
by build bot (Jenkins) (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885 ) Change subject: src/drivers/spi: add HID over SPI ACPI driver ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175410): https://review.coreboot.org/c/coreboot/+/74885/comment/5b7db62d_75008480 PS2, Line 18: Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Duplicate signature -- To view, visit https://review.coreboot.org/c/coreboot/+/74885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 2 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 02 May 2023 21:05:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src/drivers/spi: add HID over SPI ACPI driver
by Eran Mitrani (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik. Hello Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74885 to look at the new patch set (#2). Change subject: src/drivers/spi: add HID over SPI ACPI driver ...................................................................... src/drivers/spi: add HID over SPI ACPI driver Add driver to support ELAN touchscreen using SPI * See "HID Over SPI Protocol Specification" section 5.2 - ACPI enum * https://www.microsoft.com/en-us/download/details.aspx?id=103325 BUG=b:278783755 TEST=waiting for HW to be available Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Signed-off-by: Eran Mitrani <mitrani(a)google.com> --- A src/drivers/spi/hid/elan/elan7b18uh.asl 1 file changed, 137 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/74885/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 2 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: src/drivers/spi: add HID over SPI ACPI driver
by Eran Mitrani (Code Review) 02 May '23

02 May '23

Eran Mitrani has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74885 ) Change subject: src/drivers/spi: add HID over SPI ACPI driver ...................................................................... src/drivers/spi: add HID over SPI ACPI driver Add driver to support ELAN touchscreen using SPI * See "HID Over SPI Protocol Specification" section 5.2 - ACPI enum * https://www.microsoft.com/en-us/download/details.aspx?id=103325 BUG=b:278783755 TEST=waiting for HW to be available Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 --- A src/drivers/spi/hid/elan/elan7b18uh.asl 1 file changed, 136 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/74885/1 diff --git a/src/drivers/spi/hid/elan/elan7b18uh.asl b/src/drivers/spi/hid/elan/elan7b18uh.asl new file mode 100644 index 0000000..e3aae01 --- /dev/null +++ b/src/drivers/spi/hid/elan/elan7b18uh.asl @@ -0,0 +1,118 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* +* ELAN7B18UH - HID over SPI +* See "HID Over SPI Protocol Specification" section 5.2 - ACPI enum +* https://www.microsoft.com/en-us/download/details.aspx?id=103325 + +* NOTES: +* 1. Make sure BOARD_TOUCH_GPIO_INDEX is defined according to the borad's schematics +* 2. Include this file under the scope for the correct SPI, e.g.: +* Scope (\_SB.PCI0.SPI0) +* { +* #include <drivers/spi/hid/elan/elan7b18uh.asl> +* } +*/ + +Device(TCSC) { + Name (_HID, "ELAN9006") /* VendorID + DeviceID - <VVVVdddd> */ + Name (_CID, "PNP0C51") /* Compatible ID - PNP0C51 */ + Name (_SUB, "ELAN0732") /* SubVendorID + SubSystemID - <VVVVssss> */ + Name (_HRV, 0x0001) /* Hardware Revision Number - 2 bytes */ + + Method (_STA, 0) + { + Return (0xf) + } + + Name (_CRS, ResourceTemplate () { + SpiSerialBusV2 ( + 0, /* DeviceSelection */ + PolarityLow, /* DeviceSelectionPolarity */ + FourWireMode, /* WireMode */ + 8, /* DataBitLength */ + ControllerInitiated, /* SlaveMode */ + 0x016E3600, /* ConnectionSpeed (24MHz) */ + ClockPolarityLow, /* ClockPolarity */ + ClockPhaseFirst, /* ClockPhase */ + "\\_SB.PCI0.SPI0", /* ResourceSource */ + 0, /* ResourceSourceIndex */ + ResourceConsumer, /* ResourceUsage */ + ) + GpioInt ( + Level, /* InterruptType */ + ActiveLow, /* InterruptLevel */ + Exclusive, /* ShareType */ + PullUp, /* PinConfig */ + 0x0000, /* DeBounceTime */ + "\\_SB.GPO0", /* ResourceSource */ + 0x00, /* ResourceSourceIndex */ + ResourceConsumer, /* ResourceUsage */ + ) + { + BOARD_TOUCH_GPIO_INDEX + } + }) + + /* _DSM - Device-Specific Method */ + /* Arg0: UUID Unique function identifier */ + /* Arg1: Integer Revision ID - Will be 3 for HidSpi V1 */ + /* Arg2: Integer Function Index (0 = Return Supported Functions) */ + /* Arg3: Package Parameters */ + + Method (_DSM, 4) { + /* HIDSPI UUID */ + If(LEqual(Arg0,ToUUID("6E2AC436-0FCF-41AF-A265-B32A220DCFAB"))) { + + /* Switch on the function index */ + switch(ToInteger(Arg2)) { + case(0) { + /* Switch on the revision level */ + switch(ToInteger(Arg1)) { + case (3) { + /* HidSpi v1: Functions 0-6 */ + Return(Buffer(One) { 0x7F }) + } + default { + /* Unsupported revision */ + Return(Buffer(One) { 0x00 }) + } + } + } + case(1) { + /* Elan Input Report Header address - 0x1000*/ + Return (0x1000) + } + case(2) { + /* Elan Input Report Body address - 0x1100*/ + Return (0x1100) + } + case(3) { + /* Elan Output Report Header address - 0x2000 */ + Return (0x2000) + } + case(4) { + /* Read opcode */ + Return (Buffer(1) {0x0B}) + } + case(5) { + /* Write opcode */ + Return (Buffer(1) {0x02}) + } + case(6) { + /* Flags */ + Return (0x0000) + } + default { + /* Unsupported function index */ + Return (Buffer() {0}) + } + } + } + else { + /* No functions are supported for this UUID. */ + return (Buffer() {0}) + } + } + Function(_RST) {} /* Placeholder for function-level device reset */ +} -- To view, visit https://review.coreboot.org/c/coreboot/+/74885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 1 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: ec/starlabs/merlin: Change the fallback value for fn_ctrl_swap
by Matt DeVillier (Code Review) 02 May '23

02 May '23

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74916 ) Change subject: ec/starlabs/merlin: Change the fallback value for fn_ctrl_swap ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76329ec59ba630c987a122bffb8045150facdf08 Gerrit-Change-Number: 74916 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 02 May 2023 20:47:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Nico Huber, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 ) Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... Patch Set 14: (1 comment) Patchset: PS11: > I'm missing the change, this looks like a rebase? Sorry, bad cherry-pick I guess :/ -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 20:40:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Hello build bot (Jenkins), Nico Huber, Subrata Banik, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74511 to look at the new patch set (#14). Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... soc/intel/common: Don't hardcode ramtop offset The `ramtop` can be obtained from the `option.h`, so remove the hardcoded value. Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/soc/intel/common/basecode/ramtop/ramtop.c 1 file changed, 24 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/74511/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/x86/reset16.S: Remove handcoded reset vector
by Lean Sheng Tan (Code Review) 02 May '23

02 May '23

Attention is currently required from: Nico Huber, Subrata Banik, Dinesh Gehlot, Angel Pons, Julius Werner, Maximilian Brune, Arthur Heymans, Werner Zeh, ron minnich. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74797 ) Change subject: cpu/x86/reset16.S: Remove handcoded reset vector ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > why not? […] no idea, ran out of brain power for an intellectual technical argument to defend byte by byte, maybe I will let the patch owner comment :) -- To view, visit https://review.coreboot.org/c/coreboot/+/74797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie371000c60d66c032a8dcccb98e7627df09d3aa4 Gerrit-Change-Number: 74797 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 02 May 2023 20:31:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023