coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[S] Change in coreboot[master]: ec/starlabs/merlin: Change the fallback value for fn_ctrl_swap
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74916 ) Change subject: ec/starlabs/merlin: Change the fallback value for fn_ctrl_swap ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/74916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76329ec59ba630c987a122bffb8045150facdf08 Gerrit-Change-Number: 74916 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 02 May 2023 20:22:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Nico Huber (Code Review) 02 May '23

02 May '23

Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 ) Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... Patch Set 13: (1 comment) Patchset: PS11: > You know what they say, 13th times the charm ;) I'm missing the change, this looks like a rebase? -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 20:13:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/reset16.S: Remove handcoded reset vector
by Nico Huber (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik, Dinesh Gehlot, Angel Pons, Julius Werner, Maximilian Brune, Arthur Heymans, Werner Zeh, ron minnich. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74797 ) Change subject: cpu/x86/reset16.S: Remove handcoded reset vector ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > why not? Because nothing changed? 20 years ago there were toolchains that could handle it. Now there's a toolchain too that can handle it. Doesn't say anything about the next toolchain. We didn't have to change it for 19 years; changing it now makes it more likely that we'll have to change it more often. > or maybe: after 19 years someone finally change it! > an improvement is an improvement ;) What is improved exactly? -- To view, visit https://review.coreboot.org/c/coreboot/+/74797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie371000c60d66c032a8dcccb98e7627df09d3aa4 Gerrit-Change-Number: 74797 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 02 May 2023 20:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Add an error for missing ramtop CMOS entry
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74920 ) Change subject: soc/intel/common: Add an error for missing ramtop CMOS entry ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/74920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie48f0766b29be8e1fb0c1f71c4b2ce6ed20e6207 Gerrit-Change-Number: 74920 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 02 May 2023 20:06:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/speedstep: Use acpigen_write_processor_device()
by Nico Huber (Code Review) 02 May '23

02 May '23

Attention is currently required from: Arthur Heymans, Kyösti Mälkki. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74441 ) Change subject: cpu/intel/speedstep: Use acpigen_write_processor_device() ...................................................................... Patch Set 4: (1 comment) File src/southbridge/intel/i82801gx/fadt.c: https://review.coreboot.org/c/coreboot/+/74441/comment/c6d34d4b_dd8c6436 PS4, Line 29: fadt->p_lvl3_lat = chip->c3_latency; > > I wouldn't say the current implementation is right. But if we want to drop > > Processor(), shouldn't we first have an alternative ready? > > Despite the removal of [WIP] I have no rush to get this in. Future OSPM still has to parse deprecated Processor(), right? If not, then this patch is better than nothing. I guess that finding an OS in the future that still has support for (now) 15 years old machines and a brand new OSPM might be difficult. Also, general purpose OS's would likely keep Processor() support as long as they want to support such old machines because most of them won't get firmware updates. IOW sometimes, not updating firmware can be more compatible. Because nobody expects it. But I'm not concerned about switching to _CST etc. That's been in OS's for a long time already. > > > In any case, we shouldn't leave dead code around. AFAICT, this was the only > > consumer of `c3_latency`. > > We also have _CST entries without C3, and _CST entries with C3 where latency does not match with the devicetree... Elsewhere I also popped the question, if it is valid to evaluate BSP MSR's to fill in AP _CST entries. Probably not unconditionally. There can be boards with broken, low-power c-states. So there should be an opt-out. And there's also a tradeoff question, on mobile devices we might want the lowest power states, but probably not on desktops. -- To view, visit https://review.coreboot.org/c/coreboot/+/74441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1950ceac7daf8d8e91c74f1090c7451cb92e100 Gerrit-Change-Number: 74441 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 02 May 2023 20:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Nico Huber, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 ) Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... Patch Set 13: (1 comment) Patchset: PS11: > Just realized there are multiple bit-vs-bytes issues here (probably also before […] You know what they say, 13th times the charm ;) -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 20:05:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade
by Sridhar Siricilla (Code Review) 02 May '23

02 May '23

Attention is currently required from: Anil Kumar K, Subrata Banik, Paul Menzel, Himanshu Sahdev. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577 ) Change subject: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade ...................................................................... Patch Set 29: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/74577/comment/a0a6dbed_39870553 PS29, Line 462: if (cse_data_clear_request(cse_bp_info) != CB_SUCCESS) In this sequence, can we ignore backing up the PSR data safely? -- To view, visit https://review.coreboot.org/c/coreboot/+/74577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8 Gerrit-Change-Number: 74577 Gerrit-PatchSet: 29 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Comment-Date: Tue, 02 May 2023 20:02:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook: Add ramtop to CMOS layout
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik, Nico Huber, Arthur Heymans. Hello build bot (Jenkins), Subrata Banik, Nico Huber, Arthur Heymans, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74432 to look at the new patch set (#10). Change subject: mb/starlabs/starbook: Add ramtop to CMOS layout ...................................................................... mb/starlabs/starbook: Add ramtop to CMOS layout Add `ramtop` to CMOS layout so SOC_INTEL_COMMON_BASECODE_RAMTOP can be used. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I88128d2c62bdc3246a3f30e768c353f0fe3faeb7 --- M src/mainboard/starlabs/starbook/cmos.layout M src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/74432/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/74432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88128d2c62bdc3246a3f30e768c353f0fe3faeb7 Gerrit-Change-Number: 74432 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Hello build bot (Jenkins), Nico Huber, Subrata Banik, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74511 to look at the new patch set (#12). Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... soc/intel/common: Don't hardcode ramtop offset The `ramtop` can be obtained from the `option.h`, so remove the hardcoded value. Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/soc/intel/common/basecode/ramtop/ramtop.c 1 file changed, 26 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/74511/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/x86/reset16.S: Remove handcoded reset vector
by Lean Sheng Tan (Code Review) 02 May '23

02 May '23

Attention is currently required from: Nico Huber, Subrata Banik, Dinesh Gehlot, Angel Pons, Julius Werner, Maximilian Brune, Arthur Heymans, Werner Zeh, ron minnich. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74797 ) Change subject: cpu/x86/reset16.S: Remove handcoded reset vector ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > So after 19 years change it, but why? Did somebody miss the 2 bytes? why not? or maybe: after 19 years someone finally change it! an improvement is an improvement ;) -- To view, visit https://review.coreboot.org/c/coreboot/+/74797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie371000c60d66c032a8dcccb98e7627df09d3aa4 Gerrit-Change-Number: 74797 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 02 May 2023 19:55:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023