coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[S] Change in coreboot[master]: cpu/x86/reset16.S: Remove handcoded reset vector
by Nico Huber (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik, Dinesh Gehlot, Angel Pons, Julius Werner, Maximilian Brune, Arthur Heymans, Werner Zeh, ron minnich. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74797 ) Change subject: cpu/x86/reset16.S: Remove handcoded reset vector ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: So after 19 years change it, but why? Did somebody miss the 2 bytes? -- To view, visit https://review.coreboot.org/c/coreboot/+/74797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie371000c60d66c032a8dcccb98e7627df09d3aa4 Gerrit-Change-Number: 74797 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 02 May 2023 19:49:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Remove superfluous cmos_offset from ramtop
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74516 to look at the new patch set (#4). Change subject: soc/intel/common: Remove superfluous cmos_offset from ramtop ...................................................................... soc/intel/common: Remove superfluous cmos_offset from ramtop Having `_cmos_offset` in a CMOS offset is superfluous; remove it so the CMOS entry is just `ramtop`. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ibc1e7d78d2e3ae04330d19e64c3437ff07060ea8 --- M src/soc/intel/common/basecode/ramtop/ramtop.c 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/74516/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74516 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc1e7d78d2e3ae04330d19e64c3437ff07060ea8 Gerrit-Change-Number: 74516 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Nico Huber (Code Review) 02 May '23

02 May '23

Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 ) Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... Patch Set 11: -Code-Review (1 comment) Patchset: PS11: Just realized there are multiple bit-vs-bytes issues here (probably also before the patch). Numbers in the cmos.layout are in bits. AFAICT, the struct is 10 Bytes long. The `/ 8` was lost between patchsets, but the length looks wrong from the beginning. Checking the alignment might not be necessary because nvramtool should handle that at build time. But please test to make sure in case you want to remove the check. -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 19:36:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Nico Huber (Code Review) 02 May '23

02 May '23

Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 ) Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... Patch Set 11: (1 comment) File src/soc/intel/common/basecode/ramtop/ramtop.c: https://review.coreboot.org/c/coreboot/+/74511/comment/ccf88c41_4bb45fc0 PS10, Line 19: */ > You mean to have this? […] Yes, something like this. Messages could be more precise, though. e.g. "Please add 8B `ramtop_cmos_offset` to your cmos.layout." "`ramtop_cmos_offset` needs to be byte aligned, checky your cmos.layout." (The #else shouldn't be necessary btw. after an #error.) -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 19:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmn/block/cse: Support sending EOP from payload
by Kapil Porwal (Code Review) 02 May '23

02 May '23

Attention is currently required from: Himanshu Sahdev, Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74765 to look at the new patch set (#4). Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ...................................................................... soc/intel/cmn/block/cse: Support sending EOP from payload It has been observed that CSE might be busy and might require more time to process the EOP command. Currently any boot time improvement in coreboot leads to increase in EOP processing time hence add support for sending EOP from payload in order to delay it as late as possible. This improves boot time by ~10ms milliseconds. BUG=b:279184514 TEST=Verify sending EOP from depthcharge Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 --- M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_eop.c 3 files changed, 38 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/74765/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 Gerrit-Change-Number: 74765 Gerrit-PatchSet: 4 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmn/block/cse: Support sending EOP from payload
by Kapil Porwal (Code Review) 02 May '23

02 May '23

Attention is currently required from: Himanshu Sahdev, Paul Menzel. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765 ) Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74765/comment/cc0dd6a6_0774c7c4 PS2, Line 9: Add support for sending EOP from payload > Please elaborate. Please state the problem, and explain the solution. Ack File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/74765/comment/1d48276a_842747ab PS2, Line 117: Use this config to send End Of Post (EOP) using payload. coreboot supplies a function : pointer, to send EOP, to payload via a coreboot table. > Please elaborate. […] Ack File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/74765/comment/a5b1b34d_e1ecd792 PS2, Line 1429: two > Update comment to have 3rd option for EOP by payload. Ack File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/74765/comment/3ad7e52e_457de8d4 PS2, Line 310: lb_ > What is lb_ used for? Ack. Removed the unused code. -- To view, visit https://review.coreboot.org/c/coreboot/+/74765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 Gerrit-Change-Number: 74765 Gerrit-PatchSet: 3 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 May 2023 19:14:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmn/block/cse: Support sending EOP from payload
by build bot (Jenkins) (Code Review) 02 May '23

02 May '23

Attention is currently required from: Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765 ) Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ...................................................................... Patch Set 3: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175376): https://review.coreboot.org/c/coreboot/+/74765/comment/ad07d3b8_2147a5e1 PS3, Line 13: 'miliseconds' may be misspelled - perhaps 'milliseconds'? -- To view, visit https://review.coreboot.org/c/coreboot/+/74765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 Gerrit-Change-Number: 74765 Gerrit-PatchSet: 3 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 02 May 2023 19:14:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/libpayload: Support sending EOP from payload
by Kapil Porwal (Code Review) 02 May '23

02 May '23

Attention is currently required from: Kapil Porwal. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74767 to look at the new patch set (#4). Change subject: payloads/libpayload: Support sending EOP from payload ...................................................................... payloads/libpayload: Support sending EOP from payload Add support for sending EOP from payload BUG=b:279184514 TEST=Verify sending EOP from depthcharge Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I6e52434b178ba2963c756241e588cb075f71ffa4 --- M payloads/libpayload/include/coreboot_tables.h M payloads/libpayload/include/sysinfo.h M payloads/libpayload/libc/coreboot.c 3 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/74767/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e52434b178ba2963c756241e588cb075f71ffa4 Gerrit-Change-Number: 74767 Gerrit-PatchSet: 4 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmn/block/cse: Support sending EOP from payload
by Kapil Porwal (Code Review) 02 May '23

02 May '23

Attention is currently required from: Kapil Porwal. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74765 to look at the new patch set (#3). Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ...................................................................... soc/intel/cmn/block/cse: Support sending EOP from payload It has been observed that CSE might be busy and might require more time to process the EOP command. Currently any boot time improvement in coreboot leads to increase in EOP processing time hence add support for sending EOP from payload in order to delay it as late as possible. This improves boot time by ~10ms miliseconds. BUG=b:279184514 TEST=Verify sending EOP from depthcharge Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 --- M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_eop.c 3 files changed, 38 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/74765/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523 Gerrit-Change-Number: 74765 Gerrit-PatchSet: 3 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Nico Huber, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 ) Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... Patch Set 11: (1 comment) File src/soc/intel/common/basecode/ramtop/ramtop.c: https://review.coreboot.org/c/coreboot/+/74511/comment/5ff61c04_df49e2e8 PS10, Line 19: */ > Didn't realize that you brought the comment back. To me that's alright. […] You mean to have this? ``` #ifndef CMOS_VSTART_ramptop_cmos_offset #error "CMOS entry for RAMTOP_CMOS does not exisit, check your cmos.layout" #else #if CMOS_VSTART_ramtop_cmos_offset % 8 != 0 #error "CMOS start for RAMTOP_CMOS is not correct, check your cmos.layout" #endif // CMOS_VSTART_ramtop_cmos_offset % 8 == 0 #endif // CMOS_VSTART_ramptop_cmos_offset ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 19:04:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023