coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[L] Change in coreboot[master]: ec/google/chromeec: Use host command API
by Caveh Jalali (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik, Nick Vaccaro, Yu-Ping Wu, Boris Mittelberg. Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73325 ) Change subject: ec/google/chromeec: Use host command API ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/73325/comment/81ce6f8f_25471347 PS1, Line 523: struct chromeec_command cmd = { > I see. […] the variable size param/response cases i'm referring to aren't implemented in ec_cmd_api.h, so this file isn't in an intermediate state. not sure if we can eliminate `struct chromeec_command`. i think it'll take a fair bit of refactoring of coreboot chromeec support. -- To view, visit https://review.coreboot.org/c/coreboot/+/73325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0317405b1ed0c58568078133c17c8cfbc7c21d80 Gerrit-Change-Number: 73325 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 03 May 2023 03:04:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: ec/google/chromeec: Use host command API
by Caveh Jalali (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik, Nick Vaccaro, Yu-Ping Wu, Boris Mittelberg. Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73325 ) Change subject: ec/google/chromeec: Use host command API ...................................................................... Patch Set 2: (2 comments) File src/ec/google/chromeec/ec.c: https://review.coreboot.org/c/coreboot/+/73325/comment/1a722d64_712cfdb0 PS1, Line 20: (h) == NULL > > callers would simply pass H (maybe choose a better name) instead of NULL? […] Done https://review.coreboot.org/c/coreboot/+/73325/comment/b4c645a7_1dd957ba PS1, Line 469: _v1 > > doing so exposes the caller to semantic changes because simply updating ec_commands. […] ya, `EC_VER_*` should not be used for aforementioned reasons. i'm not sure how to enforce an update of ec_cmd_api.h to track ec_commands.h... at least not without adding some pretty complex presubmit checks. hopefully, reviewers will comment and authors will notice that functions they're about to implement will be provided by updating ec_cmd_api.h. we do have some automated EC code coverage tests and metrics, so at least people will be reminded to update the unit tests when adding new code. it still won't ensure people update ec_cmd_api.h to track ec_commands.h, but there are many examples in the unit tests where ec_cmd_api.h is used as intended, so there should be plenty of good examples to follow. -- To view, visit https://review.coreboot.org/c/coreboot/+/73325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0317405b1ed0c58568078133c17c8cfbc7c21d80 Gerrit-Change-Number: 73325 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 03 May 2023 02:54:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/dedede/var/boxy: Update devicetree and GPIO table
by Kevin3 Yang (Code Review) 02 May '23

02 May '23

Attention is currently required from: Derek Huang. Kevin3 Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74626 ) Change subject: mb/google/dedede/var/boxy: Update devicetree and GPIO table ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: Boxy usb3 port config is same with baseboard devicetree.cb, it don't need to override it -- To view, visit https://review.coreboot.org/c/coreboot/+/74626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a155ebca50dbd5bdb046713ebabbee395361273 Gerrit-Change-Number: 74626 Gerrit-PatchSet: 9 Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Comment-Date: Wed, 03 May 2023 02:42:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: ec/google/chromeec: Use host command API
by Caveh Jalali (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik, Caveh Jalali, Nick Vaccaro, Boris Mittelberg. Hello build bot (Jenkins), Subrata Banik, Nick Vaccaro, Yu-Ping Wu, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73325 to look at the new patch set (#2). Change subject: ec/google/chromeec: Use host command API ...................................................................... ec/google/chromeec: Use host command API Update the chromeec driver to use the EC host command API. Large blocks of repetitive code to set up EC calls are replaced with single function calls to perform the same operation. BUG=b:258126464 BRANCH=none TEST=booted on rex Change-Id: I0317405b1ed0c58568078133c17c8cfbc7c21d80 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/ec/google/chromeec/ec.c 1 file changed, 106 insertions(+), 430 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/73325/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0317405b1ed0c58568078133c17c8cfbc7c21d80 Gerrit-Change-Number: 73325 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/google/dedede/var/boxy: Update devicetree and GPIO table
by Derek Huang (Code Review) 02 May '23

02 May '23

Attention is currently required from: Kevin3 Yang. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74626 ) Change subject: mb/google/dedede/var/boxy: Update devicetree and GPIO table ...................................................................... Patch Set 9: (1 comment) File src/mainboard/google/dedede/variants/boxy/overridetree.cb: https://review.coreboot.org/c/coreboot/+/74626/comment/0ce720dd_2b3df334 PS9, Line 56: USB Port Configuration No usb3 port? -- To view, visit https://review.coreboot.org/c/coreboot/+/74626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a155ebca50dbd5bdb046713ebabbee395361273 Gerrit-Change-Number: 74626 Gerrit-PatchSet: 9 Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Wed, 03 May 2023 01:59:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/boxy: Add EXT_VR for boxy
by Kevin3 Yang (Code Review) 02 May '23

02 May '23

Kevin3 Yang has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/74889 ) Change subject: mb/google/dedede/var/boxy: Add EXT_VR for boxy ...................................................................... mb/google/dedede/var/boxy: Add EXT_VR for boxy Add EXT_VR for boxy BUG=b:277529068 TEST=emerge-dedede coreboot Signed-off-by: kevin3.yang <kevin3.yang(a)lcfc.corp-partner.google.com> Change-Id: Ic6667e93de41e84f67363ab7554fe755fe50684a --- M src/mainboard/google/dedede/variants/boxy/MakeFile.inc A src/mainboard/google/dedede/variants/boxy/ramstage.c 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/74889/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6667e93de41e84f67363ab7554fe755fe50684a Gerrit-Change-Number: 74889 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/boxy: Add EXT_VR for boxy
by build bot (Jenkins) (Code Review) 02 May '23

02 May '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74889 ) Change subject: mb/google/dedede/var/boxy: Add EXT_VR for boxy ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/variants/boxy/ramstage.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175422): https://review.coreboot.org/c/coreboot/+/74889/comment/95140abb_30da0b8e PS1, Line 1: / SPDX-License-Identifier: GPL-2.0-or-later / spaces required around that ':' (ctx:VxW) -- To view, visit https://review.coreboot.org/c/coreboot/+/74889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6667e93de41e84f67363ab7554fe755fe50684a Gerrit-Change-Number: 74889 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 03 May 2023 00:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/boxy: Add EXT_VR for boxy
by Kevin3 Yang (Code Review) 02 May '23

02 May '23

Kevin3 Yang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74889 ) Change subject: mb/google/dedede/var/boxy: Add EXT_VR for boxy ...................................................................... mb/google/dedede/var/boxy: Add EXT_VR for boxy Add EXT_VR for boxy BUG=b:277529068 TEST=emerge-dedede coreboot Signed-off-by: kevin3.yang <kevin3.yang(a)lcfc.corp-partner.google.com> Change-Id: Ic6667e93de41e84f67363ab7554fe755fe50684a --- M src/mainboard/google/dedede/variants/boxy/MakeFile.inc A src/mainboard/google/dedede/variants/boxy/ramstage.c 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/74889/1 diff --git a/src/mainboard/google/dedede/variants/boxy/MakeFile.inc b/src/mainboard/google/dedede/variants/boxy/MakeFile.inc index eb2c9bc..66f0263 100644 --- a/src/mainboard/google/dedede/variants/boxy/MakeFile.inc +++ b/src/mainboard/google/dedede/variants/boxy/MakeFile.inc @@ -1,3 +1,4 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ramstage-y += gpio.c +ramstage-y += ramstage.c diff --git a/src/mainboard/google/dedede/variants/boxy/ramstage.c b/src/mainboard/google/dedede/variants/boxy/ramstage.c new file mode 100644 index 0000000..694f331 --- /dev/null +++ b/src/mainboard/google/dedede/variants/boxy/ramstage.c @@ -0,0 +1,16 @@ +/ SPDX-License-Identifier: GPL-2.0-or-later / + +#include <baseboard/variants.h> +#include <soc/soc_chip.h> + +static void ext_vr_update(void) +{ + struct soc_intel_jasperlake_config *cfg = config_of_soc(); + + cfg->disable_external_bypass_vr = 1; +} + +void variant_devtree_update(void) +{ + ext_vr_update(); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/74889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6667e93de41e84f67363ab7554fe755fe50684a Gerrit-Change-Number: 74889 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade
by Anil Kumar K (Code Review) 02 May '23

02 May '23

Attention is currently required from: Subrata Banik, Paul Menzel, Himanshu Sahdev, Sridhar Siricilla. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577 ) Change subject: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade ...................................................................... Patch Set 29: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/74577/comment/9040c060_20e9d058 PS29, Line 462: if (cse_data_clear_request(cse_bp_info) != CB_SUCCESS) > In this sequence, can we ignore backing up the PSR data safely? yes. during data failure error, we do not care about backing up of the PSR data . -- To view, visit https://review.coreboot.org/c/coreboot/+/74577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8 Gerrit-Change-Number: 74577 Gerrit-PatchSet: 29 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Tue, 02 May 2023 23:22:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: add fwconfig for touchscreen using SPI
by Eran Mitrani (Code Review) 02 May '23

02 May '23

Eran Mitrani has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74888 ) Change subject: mb/google/rex: add fwconfig for touchscreen using SPI ...................................................................... mb/google/rex: add fwconfig for touchscreen using SPI TEST=Waiting for hardware to be available BUG=b:278783755 Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: I7099cde14cff90ad63e9164769f9913a8284a805 --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74888/1 diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index ef517df..eeb70ac 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -42,6 +42,10 @@ option WIFI_CNVI 0 option WIFI_PCIE 1 end + field TOUCHSCREEN 19 + option TOUCHSCREEN_I2C 0 + option TOUCHSCREEN_I2C_SPI 1 + end end chip soc/intel/meteorlake @@ -75,7 +79,7 @@ }" register "serial_io_gspi_mode" = "{ - [PchSerialIoIndexGSPI0] = PchSerialIoDisabled, + [PchSerialIoIndexGSPI0] = PchSerialIoPci, [PchSerialIoIndexGSPI1] = PchSerialIoPci, [PchSerialIoIndexGSPI2] = PchSerialIoDisabled, }" @@ -695,6 +699,9 @@ end probe DB_SD SD_GL9755S end + device ref gspi0 on + probe TOUCHSCREEN TOUCHSCREEN_I2C_SPI + end device ref gspi1 on chip drivers/spi/acpi register "name" = ""CRFP"" -- To view, visit https://review.coreboot.org/c/coreboot/+/74888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7099cde14cff90ad63e9164769f9913a8284a805 Gerrit-Change-Number: 74888 Gerrit-PatchSet: 1 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023