coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/corsola: Enable STA mipi panel for Starmie
by Ruihai Zhou (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: cong yang. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74200 ) Change subject: mb/google/corsola: Enable STA mipi panel for Starmie ...................................................................... Patch Set 8: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/74200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/… [View More]

1 0

[M] Change in coreboot[master]: drivers/mipi: Add support for STA_HIMAX83102_J02 panel
by Ruihai Zhou (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Paul Menzel, Yidi Lin, cong yang. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74084 ) Change subject: drivers/mipi: Add support for STA_HIMAX83102_J02 panel ...................................................................... Patch Set 13: (2 comments) This change is ready for review. File src/drivers/mipi/Kconfig: https://review.coreboot.org/c/coreboot/+/74084/comment/1cdd6e13_09784e44 PS6, Line 45: … [View More]

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Enable/disable sleep states based on EC
by Lean Sheng Tan (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak, Christian Walter, Angel Pons, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74421 ) Change subject: mb/prodrive/atlas: Enable/disable sleep states based on EC ...................................................................... Patch Set 20: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74421 To unsubscribe, or for … [View More]

1 0

[S] Change in coreboot[master]: acpigen: Add a runtime method to override exposed _Sx sleep states
by Lean Sheng Tan (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak, Maximilian Brune, Arthur Heymans, Werner Zeh. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 ) Change subject: acpigen: Add a runtime method to override exposed _Sx sleep states ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74762 To unsubscribe, … [View More]

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by Ruihai Zhou (Code Review) 28 Apr '23

28 Apr '23

Ruihai Zhou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74871 ) Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... drivers/mipi: Add support for STA_ILI9882T panel Add STA_ILI9882T panel serializable data to cbfs. The panel datasheet: ILI9882T_Datasheet_20220428.pdf BUG=b:275470328 BRANCH=corsola TEST=build and check the cbfs include the panel Signed-off-by: Ruihai Zhou … [View More]<zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.inc A src/drivers/mipi/panel-STA_ILI9882T.c 3 files changed, 348 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/74871/1 diff --git a/src/drivers/mipi/Kconfig b/src/drivers/mipi/Kconfig index 5ef6b23..9ca3d4f 100644 --- a/src/drivers/mipi/Kconfig +++ b/src/drivers/mipi/Kconfig @@ -42,6 +42,9 @@ config MIPI_PANEL_STA_2081101QFH032011_53G bool +config MIPI_PANEL_STA_ILI9882T + bool + config MIPI_PANEL_STA_HIMAX83102_J02 bool diff --git a/src/drivers/mipi/Makefile.inc b/src/drivers/mipi/Makefile.inc index c8b194a..f9d00f2 100644 --- a/src/drivers/mipi/Makefile.inc +++ b/src/drivers/mipi/Makefile.inc @@ -21,6 +21,7 @@ panel-params-$(CONFIG_MIPI_PANEL_INX_P110ZZD_DF0) += panel-INX_P110ZZD_DF0 panel-params-$(CONFIG_MIPI_PANEL_STA_2081101QFH032011_53G) += panel-STA_2081101QFH032011_53G +panel-params-$(CONFIG_MIPI_PANEL_STA_ILI9882T) += panel-STA_ILI9882T panel-params-$(CONFIG_MIPI_PANEL_STA_HIMAX83102_J02) += panel-STA_HIMAX83102_J02 panel-params-$(CONFIG_MIPI_PANEL_VIS_RM69299) += panel-VIS_RM69299 diff --git a/src/drivers/mipi/panel-STA_ILI9882T.c b/src/drivers/mipi/panel-STA_ILI9882T.c new file mode 100644 index 0000000..f55c4da --- /dev/null +++ b/src/drivers/mipi/panel-STA_ILI9882T.c @@ -0,0 +1,327 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <mipi/panel.h> + +struct panel_serializable_data STA_ILI9882T = { + .edid = { + .ascii_string = "ILI9882T", + .manufacturer_name = "STA", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 165280, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 94, .hso = 32, .hspw = 30, + .va = 1920, .vbl = 80, .vso = 68, .vspw = 2, + .phsync = '-', .pvsync = '-', + .x_mm = 141, .y_mm = 226, + }, + }, + .init = { + PANEL_DCS(0xFF, 0x98, 0x82, 0x01), + PANEL_DCS(0x00, 0x42), + PANEL_DCS(0x01, 0x11), + PANEL_DCS(0x02, 0x00), + PANEL_DCS(0x03, 0x00), + PANEL_DCS(0x04, 0x01), + PANEL_DCS(0x05, 0x11), + PANEL_DCS(0x06, 0x00), + PANEL_DCS(0x07, 0x00), + PANEL_DCS(0x08, 0x80), + PANEL_DCS(0x09, 0x81), + PANEL_DCS(0x0A, 0x71), + PANEL_DCS(0x0B, 0x00), + PANEL_DCS(0x0C, 0x00), + PANEL_DCS(0x0E, 0x1A), + PANEL_DCS(0x24, 0x00), + PANEL_DCS(0x25, 0x00), + PANEL_DCS(0x26, 0x00), + PANEL_DCS(0x27, 0x00), + PANEL_DCS(0x2C, 0xD4), + PANEL_DCS(0xB9, 0x40), + PANEL_DCS(0xB0, 0x11), + PANEL_DCS(0xE6, 0x32), + PANEL_DCS(0xD1, 0x30), + PANEL_DCS(0xD6, 0x55), + PANEL_DCS(0xD0, 0x01), + PANEL_DCS(0xE3, 0x93), + PANEL_DCS(0xE4, 0x00), + PANEL_DCS(0xE5, 0x80), + PANEL_DCS(0x31, 0x07), + PANEL_DCS(0x32, 0x07), + PANEL_DCS(0x33, 0x07), + PANEL_DCS(0x34, 0x07), + PANEL_DCS(0x35, 0x07), + PANEL_DCS(0x36, 0x01), + PANEL_DCS(0x37, 0x00), + PANEL_DCS(0x38, 0x28), + PANEL_DCS(0x39, 0x29), + PANEL_DCS(0x3A, 0x11), + PANEL_DCS(0x3B, 0x13), + PANEL_DCS(0x3C, 0x15), + PANEL_DCS(0x3D, 0x17), + PANEL_DCS(0x3E, 0x09), + PANEL_DCS(0x3F, 0x0D), + PANEL_DCS(0x40, 0x02), + PANEL_DCS(0x41, 0x02), + PANEL_DCS(0x42, 0x02), + PANEL_DCS(0x43, 0x02), + PANEL_DCS(0x44, 0x02), + PANEL_DCS(0x45, 0x02), + PANEL_DCS(0x46, 0x02), + PANEL_DCS(0x47, 0x07), + PANEL_DCS(0x48, 0x07), + PANEL_DCS(0x49, 0x07), + PANEL_DCS(0x4A, 0x07), + PANEL_DCS(0x4B, 0x07), + PANEL_DCS(0x4C, 0x01), + PANEL_DCS(0x4D, 0x00), + PANEL_DCS(0x4E, 0x28), + PANEL_DCS(0x4F, 0x29), + PANEL_DCS(0x50, 0x10), + PANEL_DCS(0x51, 0x12), + PANEL_DCS(0x52, 0x14), + PANEL_DCS(0x53, 0x16), + PANEL_DCS(0x54, 0x08), + PANEL_DCS(0x55, 0x0C), + PANEL_DCS(0x56, 0x02), + PANEL_DCS(0x57, 0x02), + PANEL_DCS(0x58, 0x02), + PANEL_DCS(0x59, 0x02), + PANEL_DCS(0x5A, 0x02), + PANEL_DCS(0x5B, 0x02), + PANEL_DCS(0x5C, 0x02), + PANEL_DCS(0x61, 0x07), + PANEL_DCS(0x62, 0x07), + PANEL_DCS(0x63, 0x07), + PANEL_DCS(0x64, 0x07), + PANEL_DCS(0x65, 0x07), + PANEL_DCS(0x66, 0x01), + PANEL_DCS(0x67, 0x00), + PANEL_DCS(0x68, 0x28), + PANEL_DCS(0x69, 0x29), + PANEL_DCS(0x6A, 0x16), + PANEL_DCS(0x6B, 0x14), + PANEL_DCS(0x6C, 0x12), + PANEL_DCS(0x6D, 0x10), + PANEL_DCS(0x6E, 0x0C), + PANEL_DCS(0x6F, 0x08), + PANEL_DCS(0x70, 0x02), + PANEL_DCS(0x71, 0x02), + PANEL_DCS(0x72, 0x02), + PANEL_DCS(0x73, 0x02), + PANEL_DCS(0x74, 0x02), + PANEL_DCS(0x75, 0x02), + PANEL_DCS(0x76, 0x02), + PANEL_DCS(0x77, 0x07), + PANEL_DCS(0x78, 0x07), + PANEL_DCS(0x79, 0x07), + PANEL_DCS(0x7A, 0x07), + PANEL_DCS(0x7B, 0x07), + PANEL_DCS(0x7C, 0x01), + PANEL_DCS(0x7D, 0x00), + PANEL_DCS(0x7E, 0x28), + PANEL_DCS(0x7F, 0x29), + PANEL_DCS(0x80, 0x17), + PANEL_DCS(0x81, 0x15), + PANEL_DCS(0x82, 0x13), + PANEL_DCS(0x83, 0x11), + PANEL_DCS(0x84, 0x0D), + PANEL_DCS(0x85, 0x09), + PANEL_DCS(0x86, 0x02), + PANEL_DCS(0x87, 0x07), + PANEL_DCS(0x88, 0x07), + PANEL_DCS(0x89, 0x07), + PANEL_DCS(0x8A, 0x07), + PANEL_DCS(0x8B, 0x07), + PANEL_DCS(0x8C, 0x07), + PANEL_DCS(0xFF, 0x98, 0x82, 0x02), + PANEL_DCS(0x29, 0x3A), + PANEL_DCS(0x2A, 0x3B), + PANEL_DCS(0x06, 0x01), + PANEL_DCS(0x07, 0x01), + PANEL_DCS(0x08, 0x0C), + PANEL_DCS(0x09, 0x44), + PANEL_DCS(0x3C, 0x0A), + PANEL_DCS(0x39, 0x11), + PANEL_DCS(0x3D, 0x00), + PANEL_DCS(0x3A, 0x0C), + PANEL_DCS(0x3B, 0x44), + PANEL_DCS(0x53, 0x1F), + PANEL_DCS(0x5E, 0x40), + PANEL_DCS(0x84, 0x00), + PANEL_DCS(0xFF, 0x98, 0x82, 0x03), + PANEL_DCS(0x20, 0x01), + PANEL_DCS(0x21, 0x3C), + PANEL_DCS(0x22, 0xFA), + PANEL_DCS(0xFF, 0x98, 0x82, 0x0A), + PANEL_DCS(0xE0, 0x01), + PANEL_DCS(0xE2, 0x01), + PANEL_DCS(0xE5, 0x91), + PANEL_DCS(0xE6, 0x3C), + PANEL_DCS(0xE7, 0x00), + PANEL_DCS(0xE8, 0xFA), + PANEL_DCS(0xFF, 0x98, 0x82, 0x12), + PANEL_DCS(0x87, 0x2C), + PANEL_DCS(0xFF, 0x98, 0x82, 0x05), + PANEL_DCS(0x73, 0xE5), + PANEL_DCS(0x7F, 0x6B), + PANEL_DCS(0x6D, 0xA4), + PANEL_DCS(0x79, 0x54), + PANEL_DCS(0x69, 0x97), + PANEL_DCS(0x6A, 0x97), + PANEL_DCS(0xA5, 0x3F), + PANEL_DCS(0x61, 0xDA), + PANEL_DCS(0xA7, 0xF1), + PANEL_DCS(0x5F, 0x01), + PANEL_DCS(0x62, 0x3F), + PANEL_DCS(0x1D, 0x90), + PANEL_DCS(0x86, 0x87), + PANEL_DCS(0xFF, 0x98, 0x82, 0x06), + PANEL_DCS(0xC0, 0x80), + PANEL_DCS(0xC1, 0x07), + PANEL_DCS(0xCA, 0x58), + PANEL_DCS(0xCB, 0x02), + PANEL_DCS(0xCE, 0x58), + PANEL_DCS(0xCF, 0x02), + PANEL_DCS(0x67, 0x60), + PANEL_DCS(0x10, 0x00), + PANEL_DCS(0x92, 0x22), + PANEL_DCS(0xD3, 0x08), + PANEL_DCS(0xD6, 0x55), + PANEL_DCS(0xDC, 0x38), + PANEL_DCS(0xFF, 0x98, 0x82, 0x08), + PANEL_DCS(0xE0, 0x00, 0x10, 0x2A, 0x4D, 0x61, 0x56, 0x6A, 0x6E, + 0x79, 0x76, 0x8F, 0x95, 0x98, 0xAE, 0xAA, 0xB2, 0xBB, 0xCE, 0xC6, 0xBD, 0xD5, 0xE2, 0xE8), + PANEL_DCS(0xE1, 0x00, 0x10, 0x2A, 0x4D, 0x61, 0x56, 0x6A, 0x6E, + 0x79, 0x76, 0x8F, 0x95, 0x98, 0xAE, 0xAA, 0xB2, 0xBB, 0xCE, 0xC6, 0xBD, 0xD5, 0xE2, 0xE8), + PANEL_DCS(0xFF, 0x98, 0x82, 0x04), + PANEL_DCS(0xBA, 0x81), + PANEL_DCS(0xFF, 0x98, 0x82, 0x0C), + PANEL_DCS(0x00, 0x02), + PANEL_DCS(0x01, 0x00), + PANEL_DCS(0x02, 0x03), + PANEL_DCS(0x03, 0x01), + PANEL_DCS(0x04, 0x03), + PANEL_DCS(0x05, 0x02), + PANEL_DCS(0x06, 0x04), + PANEL_DCS(0x07, 0x03), + PANEL_DCS(0x08, 0x03), + PANEL_DCS(0x09, 0x04), + PANEL_DCS(0x0A, 0x04), + PANEL_DCS(0x0B, 0x05), + PANEL_DCS(0x0C, 0x04), + PANEL_DCS(0x0D, 0x06), + PANEL_DCS(0x0E, 0x05), + PANEL_DCS(0x0F, 0x07), + PANEL_DCS(0x10, 0x04), + PANEL_DCS(0x11, 0x08), + PANEL_DCS(0x12, 0x05), + PANEL_DCS(0x13, 0x09), + PANEL_DCS(0x14, 0x05), + PANEL_DCS(0x15, 0x0A), + PANEL_DCS(0x16, 0x06), + PANEL_DCS(0x17, 0x0B), + PANEL_DCS(0x18, 0x05), + PANEL_DCS(0x19, 0x0C), + PANEL_DCS(0x1A, 0x06), + PANEL_DCS(0x1B, 0x0D), + PANEL_DCS(0x1C, 0x06), + PANEL_DCS(0x1D, 0x0E), + PANEL_DCS(0x1E, 0x07), + PANEL_DCS(0x1F, 0x0F), + PANEL_DCS(0x20, 0x06), + PANEL_DCS(0x21, 0x10), + PANEL_DCS(0x22, 0x07), + PANEL_DCS(0x23, 0x11), + PANEL_DCS(0x24, 0x07), + PANEL_DCS(0x25, 0x12), + PANEL_DCS(0x26, 0x08), + PANEL_DCS(0x27, 0x13), + PANEL_DCS(0x28, 0x07), + PANEL_DCS(0x29, 0x14), + PANEL_DCS(0x2A, 0x08), + PANEL_DCS(0x2B, 0x15), + PANEL_DCS(0x2C, 0x08), + PANEL_DCS(0x2D, 0x16), + PANEL_DCS(0x2E, 0x09), + PANEL_DCS(0x2F, 0x17), + PANEL_DCS(0x30, 0x08), + PANEL_DCS(0x31, 0x18), + PANEL_DCS(0x32, 0x09), + PANEL_DCS(0x33, 0x19), + PANEL_DCS(0x34, 0x09), + PANEL_DCS(0x35, 0x1A), + PANEL_DCS(0x36, 0x0A), + PANEL_DCS(0x37, 0x1B), + PANEL_DCS(0x38, 0x0A), + PANEL_DCS(0x39, 0x1C), + PANEL_DCS(0x3A, 0x0A), + PANEL_DCS(0x3B, 0x1D), + PANEL_DCS(0x3C, 0x0A), + PANEL_DCS(0x3D, 0x1E), + PANEL_DCS(0x3E, 0x0A), + PANEL_DCS(0x3F, 0x1F), + PANEL_DCS(0xFF, 0x98, 0x82, 0x04), + PANEL_DCS(0xBA, 0x01), + PANEL_DCS(0xFF, 0x98, 0x82, 0x0E), + PANEL_DCS(0x02, 0x0C), + PANEL_DCS(0x20, 0x10), + PANEL_DCS(0x25, 0x16), + PANEL_DCS(0x26, 0xE0), + PANEL_DCS(0x27, 0x00), + PANEL_DCS(0x29, 0x71), + PANEL_DCS(0x2A, 0x46), + PANEL_DCS(0x2B, 0x1F), + PANEL_DCS(0x2D, 0xC7), + PANEL_DCS(0x31, 0x02), + PANEL_DCS(0x32, 0xDF), + PANEL_DCS(0x33, 0x5A), + PANEL_DCS(0x34, 0xC0), + PANEL_DCS(0x35, 0x5A), + PANEL_DCS(0x36, 0xC0), + PANEL_DCS(0x38, 0x65), + PANEL_DCS(0x80, 0x3E), + PANEL_DCS(0x81, 0xA0), + PANEL_DCS(0xB0, 0x01), + PANEL_DCS(0xB1, 0xCC), + PANEL_DCS(0xC0, 0x12), + PANEL_DCS(0xC2, 0xCC), + PANEL_DCS(0xC3, 0xCC), + PANEL_DCS(0xC4, 0xCC), + PANEL_DCS(0xC5, 0xCC), + PANEL_DCS(0xC6, 0xCC), + PANEL_DCS(0xC7, 0xCC), + PANEL_DCS(0xC8, 0xCC), + PANEL_DCS(0xC9, 0xCC), + PANEL_DCS(0x30, 0x00), + PANEL_DCS(0x00, 0x81), + PANEL_DCS(0x08, 0x02), + PANEL_DCS(0x09, 0x00), + PANEL_DCS(0x07, 0x21), + PANEL_DCS(0x04, 0x10), + PANEL_DCS(0xFF, 0x98, 0x82, 0x1E), + PANEL_DCS(0x60, 0x00), + PANEL_DCS(0x64, 0x00), + PANEL_DCS(0x6D, 0x00), + PANEL_DCS(0xFF, 0x98, 0x82, 0x0B), + PANEL_DCS(0xA6, 0x44), + PANEL_DCS(0xA7, 0xB6), + PANEL_DCS(0xA8, 0x03), + PANEL_DCS(0xA9, 0x03), + PANEL_DCS(0xAA, 0x51), + PANEL_DCS(0xAB, 0x51), + PANEL_DCS(0xAC, 0x04), + PANEL_DCS(0xBD, 0x92), + PANEL_DCS(0xBE, 0xA1), + PANEL_DCS(0xFF, 0x98, 0x82, 0x05), + PANEL_DCS(0x86, 0x87), + PANEL_DCS(0xFF, 0x98, 0x82, 0x06), + PANEL_DCS(0x92, 0x22), + PANEL_DCS(0xFF, 0x98, 0x82, 0x00), + PANEL_DCS(0x11), + PANEL_DELAY(120), + PANEL_DCS(0x29), + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 1 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange [View Less]

1 0

[M] Change in coreboot[master]: soc/intel/common: Introduce API to get the FSP Reset Status
by Eric Lai (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Subrata Banik, Derek Huang, Paul Menzel, Kapil Porwal, Andrey Petrov. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74783 ) Change subject: soc/intel/common: Introduce API to get the FSP Reset Status ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: nicer now. -- To view, visit https://review.coreboot.org/c/coreboot/+/74783 To … [View More]

1 0

[M] Change in coreboot[master]: [WIP] ACPI: Add usb_charge_mode_from_gnvs()
by Kyösti Mälkki (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Caveh Jalali, Matt DeVillier, Tim Wawrzynczak, Boris Mittelberg. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74524 ) Change subject: [WIP] ACPI: Add usb_charge_mode_from_gnvs() ...................................................................... Patch Set 6: (3 comments) File src/acpi/acpi_pm.c: https://review.coreboot.org/c/coreboot/+/74524/comment/b06c3fcb_8a094903 PS4, Line 69: *… [View More]usb0_disable, bool *usb1_disable) > these variable names make the functionality much more clear, I'd recommend using them throughout the […] Done File src/ec/google/chromeec/smihandler.c: https://review.coreboot.org/c/coreboot/+/74524/comment/9e673ea9_de879bc6 PS4, Line 48: chromeec_set_usb_charge_mode(bool u0disable, bool u1disable) : { : if (u0disable) : google_chromeec_set_usb_charge_mode(0, USB_CHARGE_MODE_DISABLED); : : if (u1disable) : google_chromeec_set_usb_charge_mode(1, USB_CHARGE_MODE_DISABLED); > any reason not to just pass in the sleep mode, and have chromeec_set_usb_charge_mode() get the disab […] Done File src/mainboard/google/auron/smihandler.c: https://review.coreboot.org/c/coreboot/+/74524/comment/4ea67350_e286d079 PS6, Line 39: chromeec_set_usb_charge_mode(slp_typ); But now we have this special case to deal with. I must be missing something here. The only platforms referencing S3U0, S3U1, S5U0 or S5U1 in ASL sources are the very first samsung/lumpy,stumpy and intel/emeraldlake2. Seems to me like these are all using GNVS for no reason at all, seems to be a static board customisation value that does not change runtime? -- To view, visit https://review.coreboot.org/c/coreboot/+/74524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e6f37a023b0e9317dcf0355dfa70e28d51cdad9 Gerrit-Change-Number: 74524 Gerrit-PatchSet: 6 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 03:28:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment [View Less]

1 0

[S] Change in coreboot[master]: mb/google/link: Apply symmetry for EC events defines
by build bot (Jenkins) (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Kyösti Mälkki. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74602 ) Change subject: mb/google/link: Apply symmetry for EC events defines ...................................................................... Patch Set 3: Verified+1 (1 comment) File src/mainboard/google/link/ec.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175257): https://review.coreboot.org/c/coreboot/+/… [View More]

1 0

[M] Change in coreboot[master]: [WIP] ACPI: Add usb_charge_mode_from_gnvs()
by Kyösti Mälkki (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Caveh Jalali, Tim Wawrzynczak, Kyösti Mälkki, Boris Mittelberg. Hello Lance Zhao, build bot (Jenkins), Caveh Jalali, Paul Menzel, Tim Wawrzynczak, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74524 to look at the new patch set (#6). Change subject: [WIP] ACPI: Add usb_charge_mode_from_gnvs() ...................................................................... [WIP] ACPI: … [View More]Add usb_charge_mode_from_gnvs() Used together with (old API?) of ChromeEC to control USB port power for S3/S5 sleep states. This changes adds USB power control for S4 behave the same as for S5. Change-Id: I7e6f37a023b0e9317dcf0355dfa70e28d51cdad9 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/acpi/Kconfig M src/acpi/acpi_pm.c M src/ec/google/chromeec/smihandler.c M src/ec/google/chromeec/smm.h M src/include/acpi/acpi_gnvs.h M src/mainboard/google/auron/Kconfig M src/mainboard/google/auron/smihandler.c M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/butterfly/smihandler.c M src/mainboard/google/cyan/Kconfig M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/link/Kconfig M src/mainboard/google/link/smihandler.c M src/mainboard/google/parrot/Kconfig M src/mainboard/google/parrot/smihandler.c M src/mainboard/google/rambi/Kconfig M src/mainboard/google/rambi/smihandler.c M src/mainboard/google/slippy/Kconfig M src/mainboard/google/slippy/smihandler.c M src/mainboard/google/stout/Kconfig M src/mainboard/google/stout/smihandler.c M src/mainboard/intel/strago/Kconfig M src/mainboard/intel/strago/smihandler.c M src/soc/intel/broadwell/include/soc/nvs.h 24 files changed, 109 insertions(+), 100 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/74524/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/74524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e6f37a023b0e9317dcf0355dfa70e28d51cdad9 Gerrit-Change-Number: 74524 Gerrit-PatchSet: 6 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset [View Less]

1 0

[S] Change in coreboot[master]: security/tpm: Add Kconfig to allow payload control of TPM1
by Matt DeVillier (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Christian Walter, Julius Werner. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74856 ) Change subject: security/tpm: Add Kconfig to allow payload control of TPM1 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > How is this practically different from just not enabling CONFIG_TPM1 at all (and letting the payload […] if CONFIG_TPM1 isn't … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023