coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
by Angel Pons (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Sean Rhodes, Christian Walter, Angel Pons, Maximilian Brune, Lean Sheng Tan. Hello build bot (Jenkins), Benjamin Doron, Christian Walter, Maximilian Brune, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74122 to look at the new patch set (#3). Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable ...................................................................... [WIP] mb/prodrive/atlas: Put options in CFR cbtable PLEASE REMOVE THE TESTONLY OPTIONS IF BUILDING THIS FOR PRODUCTION YOU HAVE BEEN WARNED Open questions: - What to do with payload-specific options? The payload needs to know about them anyway, so describing them in coreboot kind of defeats the purpose of avoiding duplication. In our case, we can handle the profile values in the payload, which coreboot can send through CFR. - Hook up options using the option API - Figure out the details for some options (e.g. LLC dead line alloc) - Figure out if any options are missing, and if the defaults are OK The plan is to avoid having to specify the options in both edk2 and coreboot. Change-Id: I47585a9a6f94ab5005f2ab63a0df267c0caef231 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/prodrive/atlas/Makefile.inc A src/mainboard/prodrive/atlas/cfr.c 3 files changed, 301 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/74122/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74122 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47585a9a6f94ab5005f2ab63a0df267c0caef231 Gerrit-Change-Number: 74122 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/common/block/lpc'lpc: simplify index handling in read resources
by Paul Menzel (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74849 ) Change subject: soc/amd/common/block/lpc'lpc: simplify index handling in read resources ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74849/comment/4df42f6b_a1ed230c PS1, Line 7: ' / -- To view, visit https://review.coreboot.org/c/coreboot/+/74849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5f1f001c622da2e31474b62832782f5f303a32 Gerrit-Change-Number: 74849 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 29 Apr 2023 07:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/corsola: Add support for mipi panel
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Yu-Ping Wu, Yidi Lin. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74051 ) Change subject: mb/google/corsola: Add support for mipi panel ...................................................................... Patch Set 19: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f079e54f0317ff2f685f0e3834ebd1ceb8e9fcb Gerrit-Change-Number: 74051 Gerrit-PatchSet: 19 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:59:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/corsola: Enable STA mipi panel for Starmie
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu, Yidi Lin. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74200 ) Change subject: mb/google/corsola: Enable STA mipi panel for Starmie ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dd696dd6a84d9606e4b9a2d4884dd70a6df9161 Gerrit-Change-Number: 74200 Gerrit-PatchSet: 10 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:58:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Ruihai Zhou, Yidi Lin, Yu-Ping Wu. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74871 ) Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:57:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by Ruihai Zhou (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: cong yang, Yidi Lin, Yu-Ping Wu. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74871 ) Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... Patch Set 3: (1 comment) File src/drivers/mipi/Kconfig: https://review.coreboot.org/c/coreboot/+/74871/comment/618b66a7_66ff1f47 PS1, Line 45: config MIPI_PANEL_STA_ILI9882T > sort in alphabetical order. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:55:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by Ruihai Zhou (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Ruihai Zhou. Hello build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74871 to look at the new patch set (#3). Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... drivers/mipi: Add support for STA_ILI9882T panel Add STA_ILI9882T panel serializable data to cbfs. The panel datasheet: ILI9882T_Datasheet_20220428.pdf BUG=b:275470328 BRANCH=corsola TEST=build and check the cbfs include the panel Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.inc A src/drivers/mipi/panel-STA_ILI9882T.c 3 files changed, 348 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/74871/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by Ruihai Zhou (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Ruihai Zhou. Hello build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74871 to look at the new patch set (#2). Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... drivers/mipi: Add support for STA_ILI9882T panel Add STA_ILI9882T panel serializable data to cbfs. The panel datasheet: ILI9882T_Datasheet_20220428.pdf BUG=b:275470328 BRANCH=corsola TEST=build and check the cbfs include the panel Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.inc A src/drivers/mipi/panel-STA_ILI9882T.c 3 files changed, 348 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/74871/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 2 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Ruihai Zhou. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74871 ) Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/drivers/mipi/Kconfig: https://review.coreboot.org/c/coreboot/+/74871/comment/1981bb44_d6412968 PS1, Line 45: config MIPI_PANEL_STA_ILI9882T sort in alphabetical order. -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 1 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:21:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/mipi: Add support for STA_HIMAX83102_J02 panel
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Paul Menzel, Ruihai Zhou, Yidi Lin. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74084 ) Change subject: drivers/mipi: Add support for STA_HIMAX83102_J02 panel ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I382bdc89e5a217fd1c28e677938f454dc09725cc Gerrit-Change-Number: 74084 Gerrit-PatchSet: 13 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023