coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/amd/common/block/lpc'lpc: simplify index handling in read resources
by Paul Menzel (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74849 ) Change subject: soc/amd/common/block/lpc'lpc: simplify index handling in read resources ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74849/comment/4df42f6b_a1ed230c PS1, Line 7: ' / -- To view, visit https://review.coreboot.org/c/coreboot/+/74849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5f1f001c622da2e31474b62832782f5f303a32 Gerrit-Change-Number: 74849 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 29 Apr 2023 07:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/corsola: Add support for mipi panel
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Yu-Ping Wu, Yidi Lin. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74051 ) Change subject: mb/google/corsola: Add support for mipi panel ...................................................................... Patch Set 19: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f079e54f0317ff2f685f0e3834ebd1ceb8e9fcb Gerrit-Change-Number: 74051 Gerrit-PatchSet: 19 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:59:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/corsola: Enable STA mipi panel for Starmie
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu, Yidi Lin. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74200 ) Change subject: mb/google/corsola: Enable STA mipi panel for Starmie ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dd696dd6a84d9606e4b9a2d4884dd70a6df9161 Gerrit-Change-Number: 74200 Gerrit-PatchSet: 10 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:58:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Ruihai Zhou, Yidi Lin, Yu-Ping Wu. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74871 ) Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:57:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by Ruihai Zhou (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: cong yang, Yidi Lin, Yu-Ping Wu. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74871 ) Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... Patch Set 3: (1 comment) File src/drivers/mipi/Kconfig: https://review.coreboot.org/c/coreboot/+/74871/comment/618b66a7_66ff1f47 PS1, Line 45: config MIPI_PANEL_STA_ILI9882T > sort in alphabetical order. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:55:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by Ruihai Zhou (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Ruihai Zhou. Hello build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74871 to look at the new patch set (#3). Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... drivers/mipi: Add support for STA_ILI9882T panel Add STA_ILI9882T panel serializable data to cbfs. The panel datasheet: ILI9882T_Datasheet_20220428.pdf BUG=b:275470328 BRANCH=corsola TEST=build and check the cbfs include the panel Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.inc A src/drivers/mipi/panel-STA_ILI9882T.c 3 files changed, 348 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/74871/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by Ruihai Zhou (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Ruihai Zhou. Hello build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74871 to look at the new patch set (#2). Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... drivers/mipi: Add support for STA_ILI9882T panel Add STA_ILI9882T panel serializable data to cbfs. The panel datasheet: ILI9882T_Datasheet_20220428.pdf BUG=b:275470328 BRANCH=corsola TEST=build and check the cbfs include the panel Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.inc A src/drivers/mipi/panel-STA_ILI9882T.c 3 files changed, 348 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/74871/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 2 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: drivers/mipi: Add support for STA_ILI9882T panel
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Ruihai Zhou. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74871 ) Change subject: drivers/mipi: Add support for STA_ILI9882T panel ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/drivers/mipi/Kconfig: https://review.coreboot.org/c/coreboot/+/74871/comment/1981bb44_d6412968 PS1, Line 45: config MIPI_PANEL_STA_ILI9882T sort in alphabetical order. -- To view, visit https://review.coreboot.org/c/coreboot/+/74871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a37c0659f0959fe7be01aba0f08d63119d139f Gerrit-Change-Number: 74871 Gerrit-PatchSet: 1 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:21:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/mipi: Add support for STA_HIMAX83102_J02 panel
by cong yang (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Paul Menzel, Ruihai Zhou, Yidi Lin. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74084 ) Change subject: drivers/mipi: Add support for STA_HIMAX83102_J02 panel ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I382bdc89e5a217fd1c28e677938f454dc09725cc Gerrit-Change-Number: 74084 Gerrit-PatchSet: 13 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/corsola: Add support for mipi panel
by Ruihai Zhou (Code Review) 29 Apr '23

29 Apr '23

Attention is currently required from: Paul Menzel, Yidi Lin, cong yang. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74051 ) Change subject: mb/google/corsola: Add support for mipi panel ...................................................................... Patch Set 17: (3 comments) This change is ready for review. File src/mainboard/google/corsola/display.c: https://review.coreboot.org/c/coreboot/+/74051/comment/82ef13ec_269445c1 PS11, Line 127: printk(BIOS_ERR, "Failed to read i2c: addr(%u)\n", addr); > add the function name and bus, do you think this is okay? Done File src/mainboard/google/corsola/display.c: https://review.coreboot.org/c/coreboot/+/74051/comment/be57fc6d_cd83d80d PS15, Line 138: /* Initialize I2C3 for PMIC TPS65132 */ > I2C6 Done File src/mainboard/google/corsola/panel_starmie.c: https://review.coreboot.org/c/coreboot/+/74051/comment/d0e72ec6_541c3dee PS15, Line 13: mainboard_set_regulator_voltage(MTK_ > You also need to enable the regulator. Done on CB:74341 -- To view, visit https://review.coreboot.org/c/coreboot/+/74051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f079e54f0317ff2f685f0e3834ebd1ceb8e9fcb Gerrit-Change-Number: 74051 Gerrit-PatchSet: 17 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Sat, 29 Apr 2023 06:14:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023