coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: mb/google/myst: First pass GPIO configuration for Myst
by Jon Murphy (Code Review) 04 Apr '23

04 Apr '23

1 0

[M] Change in coreboot[master]: mb/google/myst: First pass GPIO configuration for Myst
by Jon Murphy (Code Review) 04 Apr '23

04 Apr '23

Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 ) Change subject: mb/google/myst: First pass GPIO configuration for Myst ...................................................................... Patch Set 7: (10 comments) File src/mainboard/google/myst/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74095/comment/09e3917c_fbe3b5fc PS7, Line 17: GPIO_3 > GPIO_7 Done https://review.coreboot.org/c/coreboot/+/74095/comment/4b534e5e_5de1d8e4 PS7, Line 17: PAD_WAKE(GPIO_3, PULL_NONE, EDGE_LOW, S0i3), > As per the schematics, SOC_PEN_DETECT_ODL is in AGPIO7 and this is unused. Done https://review.coreboot.org/c/coreboot/+/74095/comment/47c7eba6_db5d4c0d PS7, Line 22: EN_PWR_WWAN_X > Leave it LOW so that on SKUs without WWAN module, we are not leaking power. […] Done https://review.coreboot.org/c/coreboot/+/74095/comment/1cda60e7_f7976723 PS7, Line 30: /* Unused */ : PAD_NC(GPIO_10), > Coreboot should not touch it. This is handled by SMU and should be left as is. Done https://review.coreboot.org/c/coreboot/+/74095/comment/29f30215_3004e344 PS7, Line 32: WWAN_RST_L > This is listed as just `WWAN_RST`, no `_L`. Done https://review.coreboot.org/c/coreboot/+/74095/comment/2a8486d5_d8e61c41 PS7, Line 33: HIGH > Update this to `LOW`, since this is not active low (assuming documentation is correct). Done https://review.coreboot.org/c/coreboot/+/74095/comment/88cec3fd_bc82c7e3 PS7, Line 39: EC_SOC_WAKE_R_L > `EC_SOC_WAKE_R_ODL` Done https://review.coreboot.org/c/coreboot/+/74095/comment/bcea0ee9_c8583bd1 PS7, Line 52: PULL_UP > There is an external pull-up in the schematics. So I dont think an internal pull-up is required. Done https://review.coreboot.org/c/coreboot/+/74095/comment/ce4a214f_e8fc0326 PS7, Line 80: /* ESPI1_DATA2 */ : PAD_NF(GPIO_68, SPI1_DAT2, PULL_NONE), : /* ESPI1_DATA3 */ : PAD_NF(GPIO_69, SPI1_DAT3, PULL_NONE), > These are not defined in go/myst-gpios. They are defined in go/myst-gpios as AGPIO68/AGPIO69 Cumulative GPIO's 31 and 32 https://review.coreboot.org/c/coreboot/+/74095/comment/c06464ba_11c8bc0b PS7, Line 116: /* SPI_SOC_DO_TCHSCR_DO_R */ : PAD_NF(GPIO_105, SPI2_DAT1, PULL_NONE), > Not defined in go/myst-gpios. Defined as EGPIO105 at cumulative GPIO 57 -- To view, visit https://review.coreboot.org/c/coreboot/+/74095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia019704c7b027f14d46281e0de0ffdbc4906a20b Gerrit-Change-Number: 74095 Gerrit-PatchSet: 7 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 17:10:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Add ACPI configuration for USB ports
by Tim Van Patten (Code Review) 04 Apr '23

04 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Paul Menzel, Karthik Ramasubramanian, Mark Hasemeyer. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74106 ) Change subject: mb/google/myst: Add ACPI configuration for USB ports ...................................................................... Patch Set 12: (2 comments) File src/mainboard/google/myst/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74106/comment/c291f711_206c3960 PS12, Line 9: device ref iommu on end ref1 https://review.coreboot.org/c/coreboot/+/74106/comment/90573791_05268722 PS12, Line 89: device ref iommu on end > It is on Skyrim? https://source.corp.google. […] You have it above already. See `ref1`. -- To view, visit https://review.coreboot.org/c/coreboot/+/74106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecb256cad7b2daea1fddfc8323e88ff5c38d1e51 Gerrit-Change-Number: 74106 Gerrit-PatchSet: 12 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 17:06:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: First pass GPIO configuration for Myst
by Karthik Ramasubramanian (Code Review) 04 Apr '23

04 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 ) Change subject: mb/google/myst: First pass GPIO configuration for Myst ...................................................................... Patch Set 7: (3 comments) File src/mainboard/google/myst/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74095/comment/3d5080b9_c6cbd415 PS7, Line 60: HIGH) Active High. So please leave it as LOW. https://review.coreboot.org/c/coreboot/+/74095/comment/b07eb643_276f6550 PS7, Line 64: HIGH Active High. So please leave it as LOW. https://review.coreboot.org/c/coreboot/+/74095/comment/7f47989b_00a5422c PS7, Line 75: /* SOC_MEM_VID_C1 */ : PAD_GPI(GPIO_42, PULL_NONE), This should also be configured by SMU and not touched by coreboot. -- To view, visit https://review.coreboot.org/c/coreboot/+/74095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia019704c7b027f14d46281e0de0ffdbc4906a20b Gerrit-Change-Number: 74095 Gerrit-PatchSet: 7 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 17:06:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Configure WLAN
by Jon Murphy (Code Review) 04 Apr '23

04 Apr '23

1 0

[M] Change in coreboot[master]: mb/google/myst: Add ACPI configuration for USB ports
by Jon Murphy (Code Review) 04 Apr '23

04 Apr '23

Attention is currently required from: Raul Rangel, Paul Menzel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74106 ) Change subject: mb/google/myst: Add ACPI configuration for USB ports ...................................................................... Patch Set 12: (1 comment) File src/mainboard/google/myst/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74106/comment/2f3943c2_95de2d85 PS12, Line 89: device ref iommu on end > Do we need this line also? Skyrim does not have it. It is on Skyrim? https://source.corp.google.com/chromeos_public/src/third_party/coreboot/src… You also asked about adding it? https://review.coreboot.org/c/coreboot/+/74112/8..16/src/mainboard/google/m… -- To view, visit https://review.coreboot.org/c/coreboot/+/74106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecb256cad7b2daea1fddfc8323e88ff5c38d1e51 Gerrit-Change-Number: 74106 Gerrit-PatchSet: 12 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 16:57:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Disable 3-strike error
by Kapil Porwal (Code Review) 04 Apr '23

04 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Ivy Jian, Eric Lai, Ronak Kanabar. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74159 ) Change subject: soc/intel/meteorlake: Disable 3-strike error ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c33a1fa2d7e27ec8ffdea876edbb86adc3b45b9 Gerrit-Change-Number: 74159 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 16:52:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Configure WLAN
by Tim Van Patten (Code Review) 04 Apr '23

04 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74113 ) Change subject: mb/google/myst: Configure WLAN ...................................................................... Patch Set 16: Code-Review+1 (1 comment) File src/mainboard/google/myst/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74113/comment/fdbdde70_4077dc5f PS16, Line 194: WLAN_AUX_RESET_L nit: `WLAN_AUX_RST_L` Match the spreadsheet naming for both comments. -- To view, visit https://review.coreboot.org/c/coreboot/+/74113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5059be0bc011978e74ab4245e6ae037aa177ef9b Gerrit-Change-Number: 74113 Gerrit-PatchSet: 16 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 16:51:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cpu: Add function to disable 3-strike CATERR
by Kapil Porwal (Code Review) 04 Apr '23

04 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Ivy Jian, Angel Pons, Eric Lai, Ronak Kanabar. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74158 ) Change subject: soc/intel/cmn/cpu: Add function to disable 3-strike CATERR ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/common/block/include/intelblocks/msr.h: https://review.coreboot.org/c/coreboot/+/74158/comment/c789711f_a7101adf PS4, Line 38: DISABLE_CPU_ERROR nit: how about `DISABLE_THREE_STRIKE_CNT`? -- To view, visit https://review.coreboot.org/c/coreboot/+/74158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I286037cb00603f5fbc434cd1facc5e906718ba2f Gerrit-Change-Number: 74158 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 16:48:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: First pass GPIO configuration for Myst
by Karthik Ramasubramanian (Code Review) 04 Apr '23

04 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 ) Change subject: mb/google/myst: First pass GPIO configuration for Myst ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/myst/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74095/comment/840b78cb_64c8b5f9 PS7, Line 52: PULL_UP There is an external pull-up in the schematics. So I dont think an internal pull-up is required. -- To view, visit https://review.coreboot.org/c/coreboot/+/74095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia019704c7b027f14d46281e0de0ffdbc4906a20b Gerrit-Change-Number: 74095 Gerrit-PatchSet: 7 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 16:44:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023