[M] Change in coreboot[master]: mb/google/myst: First pass GPIO configuration for Myst
Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 ) Change subject: mb/google/myst: First pass GPIO configuration for Myst ...................................................................... Patch Set 7: (3 comments) File src/mainboard/google/myst/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/74095/comment/1c6087f3_85a84e7e PS7, Line 60: HIGH)
Active High. So please leave it as LOW. Done
https://review.coreboot.org/c/coreboot/+/74095/comment/0bb73a4a_66b54522 PS7, Line 64: HIGH
Active High. So please leave it as LOW. Done
https://review.coreboot.org/c/coreboot/+/74095/comment/12f3cc69_2d51c1b1 PS7, Line 75: /* SOC_MEM_VID_C1 */ : PAD_GPI(GPIO_42, PULL_NONE),
This should also be configured by SMU and not touched by coreboot. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/74095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia019704c7b027f14d46281e0de0ffdbc4906a20b Gerrit-Change-Number: 74095 Gerrit-PatchSet: 7 Gerrit-Owner: Jon Murphy <jpmurphy@google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas@google.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Tim Van Patten <timvp@google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Attention: Mark Hasemeyer <markhas@google.com> Gerrit-Comment-Date: Tue, 04 Apr 2023 17:11:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub@google.com> Gerrit-MessageType: comment
participants (1)
-
Jon Murphy (Code Review)