[M] Change in coreboot[master]: mb/google/myst: First pass GPIO configuration for Myst

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Mark Hasemeyer.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 )

Change subject: mb/google/myst: First pass GPIO configuration for Myst
......................................................................


Patch Set 7:

(3 comments)

File src/mainboard/google/myst/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/74095/comment/3d5080b9_c6cbd415 
PS7, Line 60: HIGH)
Active High. So please leave it as LOW.


https://review.coreboot.org/c/coreboot/+/74095/comment/b07eb643_276f6550 
PS7, Line 64: HIGH
Active High. So please leave it as LOW.


https://review.coreboot.org/c/coreboot/+/74095/comment/7f47989b_00a5422c 
PS7, Line 75: 	/* SOC_MEM_VID_C1 */
            : 	PAD_GPI(GPIO_42, PULL_NONE),
This should also be configured by SMU and not touched by coreboot.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia019704c7b027f14d46281e0de0ffdbc4906a20b
Gerrit-Change-Number: 74095
Gerrit-PatchSet: 7
Gerrit-Owner: Jon Murphy <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Mark Hasemeyer <[e-mail]>
Gerrit-Reviewer: Raul Rangel <[e-mail]>
Gerrit-Reviewer: Tim Van Patten <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Raul Rangel <[e-mail]>
Gerrit-Attention: Jon Murphy <[e-mail]>
Gerrit-Attention: Tim Van Patten <[e-mail]>
Gerrit-Attention: Mark Hasemeyer <[e-mail]>
Gerrit-Comment-Date: Tue, 04 Apr 2023 17:06:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment