coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift
by build bot (Jenkins) (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Nico Huber, Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51292 ) Change subject: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift ...................................................................... Patch Set 2: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173832): https://review.coreboot.org/c/coreboot/+/51292/comment/2819f144_bdf92352 PS2, Line 19: Found-by: UBSAN Non-standard signature: Found-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173832): https://review.coreboot.org/c/coreboot/+/51292/comment/89dc1635_152862ec PS2, Line 19: Found-by: UBSAN Unrecognized email address: 'UBSAN' -- To view, visit https://review.coreboot.org/c/coreboot/+/51292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib05d225ab9f22078d765009b4ee6ef0c63231eed Gerrit-Change-Number: 51292 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 10 Apr 2023 19:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift
by Paul Menzel (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Nico Huber, Paul Menzel. Hello build bot (Jenkins), Nico Huber, Angel Pons, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51292 to look at the new patch set (#2). Change subject: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift ...................................................................... x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift Fix the error below when building coreboot with `CONFIG_UBSAN=y`. PCI: pci_scan_bus for bus 00 shift out of bounds src/arch/x86/include/arch/pci_io_cfg.h:13:20 ubsan: unrecoverable error. TEST=emulation/qemu-i440fx with `CONFIG_UBSAN=y` stops later with [ERROR] unaligned access src/lib/rmodule.c:152:27 [EMERG] ubsan: unrecoverable error. Change-Id: Ib05d225ab9f22078d765009b4ee6ef0c63231eed Found-by: UBSAN Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/arch/x86/include/arch/pci_io_cfg.h 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/51292/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib05d225ab9f22078d765009b4ee6ef0c63231eed Gerrit-Change-Number: 51292 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mainboard/google/skyrim: Fix MP2 FW naming
by Marshall Dawson (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Jason Nien, Martin Roth. Hello Jason Nien, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74327 to look at the new patch set (#2). Change subject: mainboard/google/skyrim: Fix MP2 FW naming ...................................................................... mainboard/google/skyrim: Fix MP2 FW naming Update the blob type for TypeId0x25_Mp2Fw_MDN_AD03.sbin to subprogram 0. Delete the extra MP2FW line. BUG=b:246770914 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Change-Id: I5418b1ed59e1916b971d2eece9f6a2fd0e51b1b3 --- M src/mainboard/google/skyrim/amdfw.cfg 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/74327/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5418b1ed59e1916b971d2eece9f6a2fd0e51b1b3 Gerrit-Change-Number: 74327 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mainboard/google/skyrim: Fix MP2 FW naming
by Marshall Dawson (Code Review) 10 Apr '23

10 Apr '23

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74327 ) Change subject: mainboard/google/skyrim: Fix MP2 FW naming ...................................................................... mainboard/google/skyrim: Fix MP2 FW naming Update the blob type for TypeId0x25_Mp2Fw_MDN_AD03.sbin to subprogram 0. Delete the extra MP2FW line. Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Change-Id: I5418b1ed59e1916b971d2eece9f6a2fd0e51b1b3 --- M src/mainboard/google/skyrim/amdfw.cfg 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/74327/1 diff --git a/src/mainboard/google/skyrim/amdfw.cfg b/src/mainboard/google/skyrim/amdfw.cfg index 9c83a3f..01e36ab 100644 --- a/src/mainboard/google/skyrim/amdfw.cfg +++ b/src/mainboard/google/skyrim/amdfw.cfg @@ -15,7 +15,6 @@ PSP_HW_IPCFG_FILE_SUB0 TypeId0x20_HwIpCfg_MDN.sbin PSP_IKEK_FILE TypeId0x21_PspiKek_MDN.bin PSP_SECG0_FILE TypeId0x24_SecPolicy_MDN.sbin -PSP_MP2FW0_FILE TypeId0x25_Mp2Fw_MDN.sbin AMD_DRIVER_ENTRIES TypeId0x28_PspSystemDriver_MDN.sbin PSP_S0I3_FILE TypeId0x2D_AgesaRunTimeDrv_MDN.sbin PSP_ABL0_FILE TypeId0x30_AgesaBootloaderU_MDN_LPDDR5.sbin @@ -30,7 +29,7 @@ DMCUB_FILE TypeId0x71_DmcubFw_MDN.sbin PSPBTLDR_AB_FILE TypeId0x73_PspBootLoader2_MDN.sbin TA_IKEK_FILE TypeId0x8D_IkekTa_MDN.bin -PSP_MP2FW2_FILE 3rdparty/blobs/mainboard/google/skyrim/TypeId0x25_Mp2Fw_MDN_AD03.sbin +PSP_MP2FW0_FILE 3rdparty/blobs/mainboard/google/skyrim/TypeId0x25_Mp2Fw_MDN_AD03.sbin # BDT PSP_PMUI_FILE_SUB0_INS1 TypeId0x64_Appb_MDN_Lpddr5Imem1.csbin -- To view, visit https://review.coreboot.org/c/coreboot/+/74327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5418b1ed59e1916b971d2eece9f6a2fd0e51b1b3 Gerrit-Change-Number: 74327 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel: Introduce ioapic_get_sci_pin()
by Kyösti Mälkki (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74326 ) Change subject: soc/intel: Introduce ioapic_get_sci_pin() ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74326/comment/60f2f7d0_3ec91b13 PS1, Line 14: larger than IRQ15. Section 5.2.15.5 needs follow-up work. No Mr. Gerrit, it's not an IP. File src/soc/intel/baytrail/acpi.c: https://review.coreboot.org/c/coreboot/+/74326/comment/104e72fc_3bbf458a PS1, Line 299: current += acpi_create_madt_irqoverride(irqovr, 0, irq, gsi, flags); In the case !ACPI_HAVE_PCAT_8259, assert irq==gsi since no redirection is desired ? -- To view, visit https://review.coreboot.org/c/coreboot/+/74326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I723c207f1dcbba5e6fc0452fe1dbd087fad290ee Gerrit-Change-Number: 74326 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 19:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree
by Sean Rhodes (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Sean Rhodes, Michał Żygowski, Jeremy Soller, Michał Kopeć. Hello Tim Crawford, build bot (Jenkins), Michał Żygowski, Jeremy Soller, Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71717 to look at the new patch set (#3). Change subject: mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree ...................................................................... mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Iae2dc0a934f0ea3ca59d8a811f1daeedb090a7bd --- M src/mainboard/msi/ms7d25/devicetree.cb M src/mainboard/msi/ms7d25/romstage_fsp_params.c M src/mainboard/system76/adl/devicetree.cb M src/mainboard/system76/adl/variants/darp8/romstage.c M src/mainboard/system76/adl/variants/galp6/romstage.c 5 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/71717/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/71717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae2dc0a934f0ea3ca59d8a811f1daeedb090a7bd Gerrit-Change-Number: 71717 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: payloads/edk2: Set max variable size to 0x8000 for SMMSTORE
by Sean Rhodes (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Martin L Roth, Benjamin Doron, Matt DeVillier, Stefan Reinauer, Arthur Heymans. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74176 ) Change subject: payloads/edk2: Set max variable size to 0x8000 for SMMSTORE ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > I hope upstream merges it at some point, possibly into edk2-platforms PlatformPayloadFeature if we m […] Yup - no platform specific parts (the patch for logging to cbmem was acceptable though). The suggestion was to put it into platforms, but even Guo gave up trying to get a patch there. -- To view, visit https://review.coreboot.org/c/coreboot/+/74176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10d2a5a0c1d729d83e0b62bb9430863317b883cc Gerrit-Change-Number: 74176 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 10 Apr 2023 19:32:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/starlabs/merlin/acpi: Don't attempt to change EC values
by Sean Rhodes (Code Review) 10 Apr '23

10 Apr '23

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74186 ) Change subject: ec/starlabs/merlin/acpi: Don't attempt to change EC values ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/74186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3cff0ac6a322018cbca33b5f90dd62b3475da25c Gerrit-Change-Number: 74186 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Apr 2023 19:26:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/starlabs/starbook: Add support for VBOOT
by Sean Rhodes (Code Review) 10 Apr '23

10 Apr '23

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74230 ) Change subject: mb/starlabs/starbook: Add support for VBOOT ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/74230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I842b79d8e144414ce42b3d0d9dfd2b5180ecf70d Gerrit-Change-Number: 74230 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Apr 2023 19:25:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Fix OC pin config
by Sean Rhodes (Code Review) 10 Apr '23

10 Apr '23

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73984 ) Change subject: mb/starlabs/starbook/adl: Fix OC pin config ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/73984/comment/7a8b5f9c_3e5e6331 PS2, Line 7: Adjust the OC pins > Fix USB OC pin config Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73984 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c4bdab44f0d73546f52614917dccbe71f0911a3 Gerrit-Change-Number: 73984 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Apr 2023 19:24:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023