coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift
by Paul Menzel (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Nico Huber, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51292 ) Change subject: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/51292/comment/a4a533b2_c6d9629b PS1, Line 9: building > Just noticed this. The error does not happen when *building* coreboot. […] Yes, it’s ambiguous. It’s happening when running an image *built* with that config option. I can make it unambiguous. File src/arch/x86/include/arch/pci_io_cfg.h: https://review.coreboot.org/c/coreboot/+/51292/comment/1db837ae_03291170 PS1, Line 13: 1UL > Uhm, no? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/51292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib05d225ab9f22078d765009b4ee6ef0c63231eed Gerrit-Change-Number: 51292 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 22:09:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift
by Paul Menzel (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Nico Huber, Paul Menzel. Hello build bot (Jenkins), Nico Huber, Angel Pons, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51292 to look at the new patch set (#3). Change subject: x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift ...................................................................... x86: pci_io_cfg: Make constant unsigned to fix out of bounds shift Fix the error below when running a coreboot image built with `CONFIG_UBSAN=y`. PCI: pci_scan_bus for bus 00 shift out of bounds src/arch/x86/include/arch/pci_io_cfg.h:13:20 ubsan: unrecoverable error. GCC with `-fsanitize=shift` also flags this: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' So, make the constant unsigned. TEST=emulation/qemu-i440fx with `CONFIG_UBSAN=y` stops later with [ERROR] unaligned access src/lib/rmodule.c:152:27 [EMERG] ubsan: unrecoverable error. Change-Id: Ib05d225ab9f22078d765009b4ee6ef0c63231eed Found-by: UBSAN Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/arch/x86/include/arch/pci_io_cfg.h 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/51292/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/51292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib05d225ab9f22078d765009b4ee6ef0c63231eed Gerrit-Change-Number: 51292 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/myst: Enable iommu
by Karthik Ramasubramanian (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74177 ) Change subject: mb/google/myst: Enable iommu ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94e93afe775b070253464a9d187ad6c028d1b811 Gerrit-Change-Number: 74177 Gerrit-PatchSet: 14 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 22:08:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/mainboard/hp: Add more about internal flashing
by Nicholas Chin (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Václav Straka. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74248 ) Change subject: Documentation/mainboard/hp: Add more about internal flashing ...................................................................... Patch Set 5: (24 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74248/comment/fdb7ef8b_06d03390 PS5, Line 12: Vesek As far as I know coreboot's current sign off policy requires a full, real name. File Documentation/mainboard/hp/compaq_8200_sff.md: PS5: Not critical but it might also be useful to add the PRx register values, similar to the Macbook tutorial, so that others could derive and check the values used here for the temporary layout https://review.coreboot.org/c/coreboot/+/74248/comment/f7733bf7_8ccf0f2a PS5, Line 36: ``` I would add a blank line here after the ``` at the end of the table and the Flash layout header https://review.coreboot.org/c/coreboot/+/74248/comment/b3f899c3_bd8b3ad9 PS5, Line 51: ``` Nit: add a blank line after this https://review.coreboot.org/c/coreboot/+/74248/comment/8e18b749_0e5ac291 PS5, Line 52: flash flash, (comma) https://review.coreboot.org/c/coreboot/+/74248/comment/2d1b09ec_88e2e4d2 PS5, Line 53: region Maybe add something like "due to SPI Protected Range settings" after this to describe why the bios region isn't writable. https://review.coreboot.org/c/coreboot/+/74248/comment/3621b5e1_a867dfd3 PS5, Line 56: Nit: Remove this blank line as the rendered output has a blank line between the caption and the image https://review.coreboot.org/c/coreboot/+/74248/comment/1022da9c_d28f7cc5 PS5, Line 61: [IFD Hack](https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/changes/7… You can use the `[reference]: url` syntax for links so that you don't need to have a long URL inline, similar to the syntax for the images. https://review.coreboot.org/c/coreboot/+/74248/comment/1281e4da_cbc165f9 PS5, Line 61: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/changes/70/3877… I don't really have an issue with the review.coreboot.org link as it should be persistent, but if you wanted you could instead link to Evgeny's original blog post which he based that patch on: https://ch1p.io/coreboot-macbook-internal-flashing/ https://review.coreboot.org/c/coreboot/+/74248/comment/76314a6d_8aecfdae PS5, Line 61: You can use a modified [IFD Hack](https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/changes/7… originally used on MacBooks, you will : need to read both guides. The wording of this sentence could be clearer. Maybe "To write to the bios region you can use an IFD Hack originally developed for MacBooks, but with modified values described in this guide. You should read both guides before attempting the procedure." https://review.coreboot.org/c/coreboot/+/74248/comment/c3f13330_91522be9 PS5, Line 64: write in the flash descriptor region you ...write in the flash descriptor region, (comma) you... Alternatively, "write to the flash descriptor, you..." as "flash descriptor" implicitly refers to that area on the flash, making region somewhat redundant. https://review.coreboot.org/c/coreboot/+/74248/comment/ae1cdc96_969f3ce8 PS5, Line 65: originaly Spelling: originally https://review.coreboot.org/c/coreboot/+/74248/comment/1ec6fc9b_1f7b4f7e PS5, Line 66: flash flash, (comma) https://review.coreboot.org/c/coreboot/+/74248/comment/eface641_6e8dddf6 PS5, Line 70: ME shrinked Maybe "trucated ME firmware" or "neutered ME firmware" to more closely match the Macbook instructions https://review.coreboot.org/c/coreboot/+/74248/comment/1ebed95b_819ca4eb PS5, Line 77: ``` Nit: Add a blank line after this https://review.coreboot.org/c/coreboot/+/74248/comment/3e0947f8_e30c2ad0 PS5, Line 78: brick Maybe add "and require external flashing" after this so that it's clear that it isn't a permanent brick https://review.coreboot.org/c/coreboot/+/74248/comment/5fc12ef6_4b466932 PS5, Line 79: got so far got this far https://review.coreboot.org/c/coreboot/+/74248/comment/9af90d40_03edc5eb PS5, Line 79: should be already should already be https://review.coreboot.org/c/coreboot/+/74248/comment/a022948d_62925af0 PS5, Line 80: The temporary flash size to set in coreboot is 2 MB, and you can fill It would be good to mention the CBFS size that should be used as well, just for clarity. The `0xd00000` used in the Macbook tutorial should still work as it fits in the bios region used for this board, though up to `0x1d0000` should work as that utilizes more of the temporary bios region. https://review.coreboot.org/c/coreboot/+/74248/comment/2b8ab0d6_5f392b4c PS5, Line 80: flash size Maybe "ROM chip size" to match the appropriate menuconfig option https://review.coreboot.org/c/coreboot/+/74248/comment/8158c3f9_3c442bcf PS5, Line 80: fill : the rest with zeros to get the matching size using I would replace this with "pad the ROM to the required 8MB with zeros using:" https://review.coreboot.org/c/coreboot/+/74248/comment/427b70ee_df881758 PS5, Line 87: The final flash layout after you already have the temporary coreboot : installation running should look like this: It's not clear that this layout should be used for Stage 2, and that it still is for continuing to use a truncated ME. https://review.coreboot.org/c/coreboot/+/74248/comment/9742b22f_643af86e PS5, Line 94: ``` Nit: Add a blank line after this https://review.coreboot.org/c/coreboot/+/74248/comment/cf513627_e05bca25 PS5, Line 95: More about flashing internally and getting the flash layout [here](../../tutorial/flashing_firmware/index.md). Please add a blank line between this and the "External programming" header -- To view, visit https://review.coreboot.org/c/coreboot/+/74248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53a697a2dd6c10fff8f287284f75d229c7c4b636 Gerrit-Change-Number: 74248 Gerrit-PatchSet: 5 Gerrit-Owner: Václav Straka Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Václav Straka Gerrit-Comment-Date: Mon, 10 Apr 2023 22:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Enable console UART
by Karthik Ramasubramanian (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74103 ) Change subject: mb/google/myst: Enable console UART ...................................................................... Patch Set 24: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c1b86c46907216d88f98917968b833af0d5d41 Gerrit-Change-Number: 74103 Gerrit-PatchSet: 24 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 22:04:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Add FW_CONFIG
by Karthik Ramasubramanian (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74102 ) Change subject: mb/google/myst: Add FW_CONFIG ...................................................................... Patch Set 24: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If74c3649d4e8d174d9fe00a4b896c2351ee3ab19 Gerrit-Change-Number: 74102 Gerrit-PatchSet: 24 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 22:01:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Use either EC or MB lid switch state
by Rob Barnes (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Raul Rangel, Martin L Roth, Subrata Banik, Caveh Jalali, Matt DeVillier, Nick Vaccaro, Eric Lai, Tim Van Patten, Karthik Ramasubramanian, Felix Held, Boris Mittelberg. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74332 ) Change subject: ec/google/chromeec: Use either EC or MB lid switch state ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I013574d7c21761f167ad38aeed27a419677b8000 Gerrit-Change-Number: 74332 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 21:59:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Enable eSPI SCI events
by Karthik Ramasubramanian (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74101 ) Change subject: mb/google/myst: Enable eSPI SCI events ...................................................................... Patch Set 22: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fd858c484f6fcf952bcb4f756ba2e4728091d8b Gerrit-Change-Number: 74101 Gerrit-PatchSet: 22 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 21:49:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Add smihandler
by Karthik Ramasubramanian (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74100 ) Change subject: mb/google/myst: Add smihandler ...................................................................... Patch Set 22: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92e5e6aef7ab0b84a96d976e29ebf96b56f6f1a1 Gerrit-Change-Number: 74100 Gerrit-PatchSet: 22 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 21:43:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/cbfstool: Add "Comp" column for "print -k"
by Julius Werner (Code Review) 10 Apr '23

10 Apr '23

Attention is currently required from: Eric Lai, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74317 ) Change subject: util/cbfstool: Add "Comp" column for "print -k" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: So, the reason I didn't do this in CB:41119 is because I was worried that changing the output might break scripts relying on the current behavior. The point of -k is that it can be parsed by a script, after all. My idea was to basically keep `cbfstool print -k` unchanged as the "legacy" machine-parseable output, and make `cbfstool print -k -v` (which was previously unused) the extensible format that allows an arbitrary amount of `<name>:<value>` tokens in each row behind the default column output. I'm not super against changing the legacy format if we want to do that, but that should probably be discussed on the mailing list first to make sure that everyone has a chance to adjust. (Also, if we do decide to break compatibility we might as well go all the way and change the whole output to something that's more extensible, e.g. using `<key>:<value>` tokens for all fields.) -- To view, visit https://review.coreboot.org/c/coreboot/+/74317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe3e23c58662fb7b9c5d704de93e2df28957528d Gerrit-Change-Number: 74317 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 21:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023