coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Benjamin Doron (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Angel Pons, Maximilian Brune. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Thanks for working on this, I've started implementing it for EDK2. Nothing to show yet, I'm currently implementing the processing of a CFR form's internal structure. File src/commonlib/include/commonlib/coreboot_tables.h: https://review.coreboot.org/c/coreboot/+/74121/comment/133cceda_71211be9 PS1, Line 99: LB_TAG_CFR_STRING = 0x0102, Unused? Is the CFR string structure intended to tag itself (as in, CFR implementation or service consumer could determine other data structures here), or are the major structures fixed enough this tag isn't needed? -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 23:54:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in qc_blobs[master]: sc7180/qtiseclib: Update qtiseclib blobs binaries and release notes f...
by Julius Werner (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Shelley Chen, Paul Menzel, Bharath N. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/73955 ) Change subject: sc7180/qtiseclib: Update qtiseclib blobs binaries and release notes from 50 to 69 ...................................................................... Patch Set 1: (1 comment) File sc7180/qtiseclib/Release_Notes.txt: https://review.coreboot.org/c/qc_blobs/+/73955/comment/ddc9f4d3_65a5f555 PS1, Line 5: Version : 00069 > All recent changes up to #68 are static analysis, version #69 is related to longsys device stability […] I'm not sure I'm aware of that last one (I might have missed something), can you please link internal bug number? -- To view, visit https://review.coreboot.org/c/qc_blobs/+/73955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I55506e35b6312a7d0d5b2e9da721a377f6e196bc Gerrit-Change-Number: 73955 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath N <quic_bharn(a)quicinc.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-CC: Name of user not set #1004463 Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bharath N <quic_bharn(a)quicinc.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 23:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Bharath N <quic_bharn(a)quicinc.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Enable PCIe devices in devicetree
by Jon Murphy (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74112 ) Change subject: mb/google/myst: Enable PCIe devices in devicetree ...................................................................... Patch Set 31: (5 comments) File src/mainboard/google/myst/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74112/comment/3fa30a4b_4d7d2c85 PS31, Line 12: .start_logical_lane = 13, : .end_logical_lane = 13, > https://ee-schematics.teams.x20web.corp.google. […] The actual schematic shows lane 13, not sure why the block diagram shows lane 12. I'll follow up with EE's. https://ee-schematics.teams.x20web.corp.google.com/myst/myst/proto0/referen… https://review.coreboot.org/c/coreboot/+/74112/comment/29d71499_eeddd34a PS31, Line 18: .link_aspm = ASPM_L1, : .link_aspm_L1_1 = true, : .link_aspm_L1_2 = true, > Considering all of the trouble we've had with ASPM in the past, I would suggest disabling it for all […] Done https://review.coreboot.org/c/coreboot/+/74112/comment/16668d6d_f79ad915 PS31, Line 44: GEN3 > GEN1 Done https://review.coreboot.org/c/coreboot/+/74112/comment/5b04655e_c1ae8e43 PS31, Line 59: GEN3 > GEN4 Done https://review.coreboot.org/c/coreboot/+/74112/comment/017011b0_97c019bd PS31, Line 101: *dxio_descs = myst_phx_dxio_descriptors; : *dxio_num = ARRAY_SIZE(myst_phx_dxio_descriptors); : *ddi_descs = myst_phx_ddi_descriptors; : *ddi_num = ARRAY_SIZE(myst_phx_ddi_descriptors); > I would expect them to keep working, but I think it's possible that there would be a delta. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icdad785bcb90de036095bcc4219c15f55f4277fe Gerrit-Change-Number: 74112 Gerrit-PatchSet: 31 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 23:50:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Use either EC or MB lid switch state
by Tim Van Patten (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Martin L Roth, Subrata Banik, Caveh Jalali, Matt DeVillier, Nick Vaccaro, Eric Lai, Karthik Ramasubramanian, Felix Held, Boris Mittelberg. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74332 ) Change subject: ec/google/chromeec: Use either EC or MB lid switch state ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I013574d7c21761f167ad38aeed27a419677b8000 Gerrit-Change-Number: 74332 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 23:47:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Enable USB controllers
by Jon Murphy (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Mark Hasemeyer. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74105 ) Change subject: mb/google/myst: Enable USB controllers ...................................................................... Patch Set 25: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74105/comment/4257cc24_268ddc6f PS25, Line 7: USB > Nit: XHCI Done File src/mainboard/google/myst/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74105/comment/4cd81a34_461b6bea PS25, Line 14: device ref xhci_1 on end > How about the ports under gpp_bridge_c? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05dc5bb157f0ef955e4b37e34d7b32678e42ebc8 Gerrit-Change-Number: 74105 Gerrit-PatchSet: 25 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 23:42:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Use either EC or MB lid switch state
by Karthik Ramasubramanian (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Martin L Roth, Subrata Banik, Caveh Jalali, Matt DeVillier, Nick Vaccaro, Eric Lai, Tim Van Patten, Felix Held, Boris Mittelberg. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74332 ) Change subject: ec/google/chromeec: Use either EC or MB lid switch state ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74332/comment/481356db_37ffb6c5 PS1, Line 19: TEST=Build Skyrim BIOS image and boot to OS. Trigger lid open/close : events and ensure that they are detected properly through : /proc/acpi/button/lid/LID0/state. : localhost ~ # cat /proc/acpi/button/lid/LID0/state : state: open : localhost ~ # cat /proc/acpi/button/lid/LID0/state : state: closed : : Ensure that the system behaves as expected based on powerd : configuration. After signin, system suspends/resumes for lid close/open. : On signin screen, system shuts down/boots for lid close/open. > Was `EC_ENABLE_LID_SWITCH` enabled or disabled for this testing? […] I have tested with both configuration. The system behavior is not impacted. The only thing with disabling EC_ENABLE_LID_SWITCH is /proc/acpi/button/lid/LID0/state will not be present since the mainboard does not implement Lid Switch in Skyrim. That has got nothing to do with this change though. -- To view, visit https://review.coreboot.org/c/coreboot/+/74332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I013574d7c21761f167ad38aeed27a419677b8000 Gerrit-Change-Number: 74332 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 22:32:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Enable USB controllers
by Karthik Ramasubramanian (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74105 ) Change subject: mb/google/myst: Enable USB controllers ...................................................................... Patch Set 25: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74105/comment/8954ea5b_68e6e623 PS25, Line 7: USB Nit: XHCI File src/mainboard/google/myst/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74105/comment/2b6a4283_fedcfad2 PS25, Line 14: device ref xhci_1 on end How about the ports under gpp_bridge_c? -- To view, visit https://review.coreboot.org/c/coreboot/+/74105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05dc5bb157f0ef955e4b37e34d7b32678e42ebc8 Gerrit-Change-Number: 74105 Gerrit-PatchSet: 25 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 22:14:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/mainboard/hp: Add more about internal flashing
by Nicholas Chin (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Václav Straka. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74248 ) Change subject: Documentation/mainboard/hp: Add more about internal flashing ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74248/comment/1fff82d1_62e07f49 PS5, Line 12: Vesek > As far as I know coreboot's current sign off policy requires a full, real name. https://coreboot.org/developers.html under Sign-off Procedure. There was some discussion about it before, and the Linux kernel has since clarified that pseudonyms/preferred names are allowed as long as it's something you are known by, though I don't think coreboot has followed up on the policy. -- To view, visit https://review.coreboot.org/c/coreboot/+/74248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53a697a2dd6c10fff8f287284f75d229c7c4b636 Gerrit-Change-Number: 74248 Gerrit-PatchSet: 5 Gerrit-Owner: Václav Straka Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Václav Straka Gerrit-Comment-Date: Mon, 10 Apr 2023 22:12:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Use either EC or MB lid switch state
by Tim Van Patten (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Martin L Roth, Subrata Banik, Caveh Jalali, Matt DeVillier, Nick Vaccaro, Eric Lai, Karthik Ramasubramanian, Felix Held, Boris Mittelberg. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74332 ) Change subject: ec/google/chromeec: Use either EC or MB lid switch state ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74332/comment/1ddbb477_abe760d9 PS1, Line 19: TEST=Build Skyrim BIOS image and boot to OS. Trigger lid open/close : events and ensure that they are detected properly through : /proc/acpi/button/lid/LID0/state. : localhost ~ # cat /proc/acpi/button/lid/LID0/state : state: open : localhost ~ # cat /proc/acpi/button/lid/LID0/state : state: closed : : Ensure that the system behaves as expected based on powerd : configuration. After signin, system suspends/resumes for lid close/open. : On signin screen, system shuts down/boots for lid close/open. Was `EC_ENABLE_LID_SWITCH` enabled or disabled for this testing? If it was enabled, can you also disable `EC_ENABLE_LID_SWITCH` and re-test, to validate this is working as intended? -- To view, visit https://review.coreboot.org/c/coreboot/+/74332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I013574d7c21761f167ad38aeed27a419677b8000 Gerrit-Change-Number: 74332 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 22:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/myst: Enable internal graphics
by Karthik Ramasubramanian (Code Review) 11 Apr '23

11 Apr '23

Attention is currently required from: Raul Rangel, Jon Murphy, Paul Menzel, Mark Hasemeyer. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74104 ) Change subject: mb/google/myst: Enable internal graphics ...................................................................... Patch Set 25: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6ef1ca07b9af491c7d937be5cef4f051852e486 Gerrit-Change-Number: 74104 Gerrit-PatchSet: 25 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 22:10:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023