coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/intel: Don't report _S1 state when unsupported
by Subrata Banik (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Arthur Heymans. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74760 ) Change subject: soc/intel: Don't report _S1 state when unsupported ...................................................................... Patch Set 7: (1 comment) File src/soc/intel/common/block/pmc/Kconfig: https://review.coreboot.org/c/coreboot/+/74760/comment/3ebdd370_68f056ce PS7, Line 7: select ACPI_S1_NOT_SUPPORTED can we move this at line #5 ? -- To view, visit https://review.coreboot.org/c/coreboot/+/74760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da Gerrit-Change-Number: 74760 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 27 Apr 2023 07:53:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/entry16.S: Move reset vector to this file
by Himanshu Sahdev (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Arthur Heymans. Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74800 ) Change subject: cpu/x86/entry16.S: Move reset vector to this file ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a4b7fe99875a1addf611f569990ff9a3beda3ba Gerrit-Change-Number: 74800 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 27 Apr 2023 07:28:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/entry16.S: Move reset vector to this file
by Arthur Heymans (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Himanshu Sahdev. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74800 to look at the new patch set (#2). Change subject: cpu/x86/entry16.S: Move reset vector to this file ...................................................................... cpu/x86/entry16.S: Move reset vector to this file This makes the code easier to follow. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I5a4b7fe99875a1addf611f569990ff9a3beda3ba --- M src/cpu/x86/Makefile.inc M src/cpu/x86/entry16.S D src/cpu/x86/reset16.S 3 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/74800/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a4b7fe99875a1addf611f569990ff9a3beda3ba Gerrit-Change-Number: 74800 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/x86/entry16.S: Move reset vector to this file
by Arthur Heymans (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Himanshu Sahdev. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74800 ) Change subject: cpu/x86/entry16.S: Move reset vector to this file ...................................................................... Patch Set 1: (2 comments) File src/cpu/x86/entry16.S: https://review.coreboot.org/c/coreboot/+/74800/comment/1947cba3_571b66fb PS1, Line 155: /* This is the first instruction the CPU runs when coming out of reset. */ : .section ".reset", "ax", %progbits : .globl _start > alignment Done https://review.coreboot.org/c/coreboot/+/74800/comment/14384e95_ac007ec3 PS1, Line 159: > maybe tab? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a4b7fe99875a1addf611f569990ff9a3beda3ba Gerrit-Change-Number: 74800 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Comment-Date: Thu, 27 Apr 2023 07:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/rex/var/screebo: Add initial setup for gpio config
by Subrata Banik (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal, Eric Lai, Kun Liu. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 ) Change subject: mb/google/rex/var/screebo: Add initial setup for gpio config ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib96e03f47bc1d6e5628ae459c3e1eb4dc18849c7 Gerrit-Change-Number: 74475 Gerrit-PatchSet: 7 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 27 Apr 2023 07:16:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add USB4 ANX7452 Rev 2 to USB_DB FW_CONFIG
by Subrata Banik (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tarun Tuli, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74775 ) Change subject: mb/google/rex: Add USB4 ANX7452 Rev 2 to USB_DB FW_CONFIG ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74775/comment/94bd20a9_487890dd PS1, Line 13: 2 > 1? mostly this is in preparation of proto 2 sku -- To view, visit https://review.coreboot.org/c/coreboot/+/74775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I878b591e5919d05d3c5fc2eefdeb492e95d4f7b5 Gerrit-Change-Number: 74775 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Thu, 27 Apr 2023 07:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add USB4 ANX7452 Rev 2 to USB_DB FW_CONFIG
by Kapil Porwal (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, YH Lin. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74775 ) Change subject: mb/google/rex: Add USB4 ANX7452 Rev 2 to USB_DB FW_CONFIG ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74775/comment/a080581a_fc014afe PS1, Line 13: 2 1? -- To view, visit https://review.coreboot.org/c/coreboot/+/74775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I878b591e5919d05d3c5fc2eefdeb492e95d4f7b5 Gerrit-Change-Number: 74775 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Thu, 27 Apr 2023 07:03:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add USB4 ANX7452 Rev 2 to USB_DB FW_CONFIG
by Kapil Porwal (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, YH Lin. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74775 ) Change subject: mb/google/rex: Add USB4 ANX7452 Rev 2 to USB_DB FW_CONFIG ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74775 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I878b591e5919d05d3c5fc2eefdeb492e95d4f7b5 Gerrit-Change-Number: 74775 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Thu, 27 Apr 2023 07:02:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ACPI,SMBIOS : Provide ACPI and SMBIOS supports for RISC-V
by Paul Menzel (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Lance Zhao, Philipp Hug, weidongwd, Tim Wawrzynczak, ron minnich. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74799 ) Change subject: ACPI,SMBIOS : Provide ACPI and SMBIOS supports for RISC-V ...................................................................... Patch Set 1: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74799/comment/ff7b38f5_1f78d450 PS1, Line 2: weidongwd Please configure your full name: $ git config --global user.name "…" $ git commit --amend --author="… <…>" -s https://review.coreboot.org/c/coreboot/+/74799/comment/a10087ba_c140bf22 PS1, Line 7: supports support https://review.coreboot.org/c/coreboot/+/74799/comment/2c590303_8edaa59c PS1, Line 8: > Possible unwrapped commit description (prefer a maximum 72 chars per line) Please fix. https://review.coreboot.org/c/coreboot/+/74799/comment/780b2483_691b0b16 PS1, Line 9: Adapts ACPI and SMBIOS related codes for RISC-V, and then passes their addresses to the OS via FDT. Please use imperative mood (present): > Adapt ACPI and SMBIOS related code for RISC-V, and then pass their addresses to the OS via FDT. https://review.coreboot.org/c/coreboot/+/74799/comment/50d399cb_1c122e5e PS1, Line 10: I guess you should also elaborate a little more on the implementation. What is the difference to x86 for example. https://review.coreboot.org/c/coreboot/+/74799/comment/0bac2a42_af90dbf7 PS1, Line 10: Please add a TEST= tag. https://review.coreboot.org/c/coreboot/+/74799/comment/b3997047_464280b0 PS1, Line 11: weidongwd Ditto. -- To view, visit https://review.coreboot.org/c/coreboot/+/74799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c47d22e8e383e8c90387caab82796b6b4d5eff5 Gerrit-Change-Number: 74799 Gerrit-PatchSet: 1 Gerrit-Owner: weidongwd <weidong.wd(a)bytedance.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: weidongwd <weidong.wd(a)bytedance.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 27 Apr 2023 06:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Select FSP MULTIPHASE SI INIT RETURN BROKEN config
by build bot (Jenkins) (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Subrata Banik, Derek Huang, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74785 ) Change subject: soc/intel/alderlake: Select FSP_MULTIPHASE_SI_INIT_RETURN_BROKEN config ...................................................................... Patch Set 3: Verified+1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175081): https://review.coreboot.org/c/coreboot/+/74785/comment/8b09d3e6_20bf3c99 PS3, Line 6: Possible long commit subject (prefer a maximum 65 characters) -- To view, visit https://review.coreboot.org/c/coreboot/+/74785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18a918cca7e19e03ed6020c55c86c64a94212963 Gerrit-Change-Number: 74785 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 27 Apr 2023 06:58:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023