coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: treewide: Add missing include guards to chip.h
by Mario Scheithauer (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tim Crawford, Jeremy Soller, Christian Walter, Arthur Heymans, Werner Zeh, Jan Samek. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74749 ) Change subject: treewide: Add missing include guards to chip.h ...................................................................... Patch Set 3: (1 comment) File src/drivers/i2c/rtd2132/chip.h: https://review.coreboot.org/c/coreboot/+/74749/comment/991462e3_8eabc680 PS3, Line 3: RTD_2132 maybe without underscore -- To view, visit https://review.coreboot.org/c/coreboot/+/74749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Gerrit-Change-Number: 74749 Gerrit-PatchSet: 3 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Thu, 27 Apr 2023 09:02:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: treewide: Add missing include guards to chip.h
by Jan Samek (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tim Crawford, Jeremy Soller, Christian Walter, Mario Scheithauer, Arthur Heymans, Werner Zeh. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74749 ) Change subject: treewide: Add missing include guards to chip.h ...................................................................... Patch Set 3: (1 comment) File src/drivers/i2c/cs35l53/chip.h: https://review.coreboot.org/c/coreboot/+/74749/comment/910db0f9_e6f68a9f PS2, Line 3: CS35L54 > CS35L53 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Gerrit-Change-Number: 74749 Gerrit-PatchSet: 3 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 27 Apr 2023 08:56:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: treewide: Add missing include guards to chip.h
by Jan Samek (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tim Crawford, Jeremy Soller, Christian Walter, Mario Scheithauer, Arthur Heymans, Jan Samek. Hello Tim Crawford, Jeremy Soller, Christian Walter, Mario Scheithauer, Arthur Heymans, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74749 to look at the new patch set (#3). Change subject: treewide: Add missing include guards to chip.h ...................................................................... treewide: Add missing include guards to chip.h Some of the chip.h files in the tree are missing the include guards. This patch adds them in order to avoid potential redefinions of symbols contained in these headers, when they are included multiple times in static.c generated by sconfig. Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Signed-off-by: Jan Samek <jan.samek(a)siemens.com> --- M src/cpu/intel/haswell/chip.h M src/cpu/intel/model_2065x/chip.h M src/cpu/intel/model_206ax/chip.h M src/drivers/generic/alc1015/chip.h M src/drivers/generic/bayhub/chip.h M src/drivers/generic/bayhub_lv2/chip.h M src/drivers/generic/max98357a/chip.h M src/drivers/generic/nau8315/chip.h M src/drivers/i2c/cs35l53/chip.h M src/drivers/i2c/cs42l42/chip.h M src/drivers/i2c/da7219/chip.h M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98390/chip.h M src/drivers/i2c/max98396/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/i2c/nau8825/chip.h M src/drivers/i2c/pca9538/chip.h M src/drivers/i2c/pcf8523/chip.h M src/drivers/i2c/ptn3460/chip.h M src/drivers/i2c/rt1011/chip.h M src/drivers/i2c/rt5663/chip.h M src/drivers/i2c/rtd2132/chip.h M src/drivers/i2c/rx6110sa/chip.h M src/drivers/i2c/tas5825m/chip.h M src/drivers/i2c/tpm/chip.h M src/drivers/intel/ish/chip.h M src/drivers/net/phy/m88e1512/chip.h 27 files changed, 151 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/74749/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Gerrit-Change-Number: 74749 Gerrit-PatchSet: 3 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: treewide: Add missing include guards to chip.h
by Werner Zeh (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tim Crawford, Jeremy Soller, Christian Walter, Mario Scheithauer, Arthur Heymans, Jan Samek. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74749 ) Change subject: treewide: Add missing include guards to chip.h ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/drivers/i2c/cs35l53/chip.h: https://review.coreboot.org/c/coreboot/+/74749/comment/cffa5183_9fd3e0f2 PS2, Line 3: CS35L54 CS35L53 -- To view, visit https://review.coreboot.org/c/coreboot/+/74749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Gerrit-Change-Number: 74749 Gerrit-PatchSet: 2 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Thu, 27 Apr 2023 08:55:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/variants/screebo: Generate RAM IDs
by Kapil Porwal (Code Review) 27 Apr '23

27 Apr '23

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74802 ) Change subject: mb/google/rex/variants/screebo: Generate RAM IDs ...................................................................... mb/google/rex/variants/screebo: Generate RAM IDs Generate RAM IDs for - MT62F512M32D2DR-031 WT:B (LP5) H9JCNNNBK3MLYR-N6E (LP5) MT62F1G32D2DS-026 WT:B(LP5x) H58G56BK7BX068 (LP5X) BUG=b:276814951 TEST=Run part_id_gen tool without any errors Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I0fb2e488c06ed74d3fd493e5ca0ab89a825a9349 --- M src/mainboard/google/rex/variants/screebo/memory/Makefile.inc M src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt M src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt 3 files changed, 37 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/74802/1 diff --git a/src/mainboard/google/rex/variants/screebo/memory/Makefile.inc b/src/mainboard/google/rex/variants/screebo/memory/Makefile.inc index eace2e4..c46681a 100644 --- a/src/mainboard/google/rex/variants/screebo/memory/Makefile.inc +++ b/src/mainboard/google/rex/variants/screebo/memory/Makefile.inc @@ -1,5 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! -# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. +# Generated by: +# ./util/spd_tools/bin/part_id_gen MTL lp5 src/mainboard/google/rex/variants/screebo/memory src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt -SPD_SOURCES = placeholder +SPD_SOURCES = +SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B, H9JCNNNBK3MLYR-N6E +SPD_SOURCES += spd/lp5/set-0/spd-7.hex # ID = 1(0b0001) Parts = MT62F1G32D2DS-026 WT:B, H58G56BK7BX068 diff --git a/src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt b/src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt index fa24790..be70745 100644 --- a/src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt +++ b/src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt @@ -1 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# ./util/spd_tools/bin/part_id_gen MTL lp5 src/mainboard/google/rex/variants/screebo/memory src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt + DRAM Part Name ID to assign +MT62F512M32D2DR-031 WT:B 0 (0000) +H9JCNNNBK3MLYR-N6E 0 (0000) +MT62F1G32D2DS-026 WT:B 1 (0001) +H58G56BK7BX068 1 (0001) diff --git a/src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt b/src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt index 9621137..8027588 100644 --- a/src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt +++ b/src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt @@ -9,3 +9,7 @@ # See util/spd_tools/README.md for more details and instructions. # Part Name +MT62F512M32D2DR-031 WT:B +H9JCNNNBK3MLYR-N6E +MT62F1G32D2DS-026 WT:B +H58G56BK7BX068 -- To view, visit https://review.coreboot.org/c/coreboot/+/74802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fb2e488c06ed74d3fd493e5ca0ab89a825a9349 Gerrit-Change-Number: 74802 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: treewide: Add missing include guards to chip.h
by Jan Samek (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Tim Crawford, Jeremy Soller, Christian Walter, Arthur Heymans. Hello Tim Crawford, Jeremy Soller, Christian Walter, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74749 to look at the new patch set (#2). Change subject: treewide: Add missing include guards to chip.h ...................................................................... treewide: Add missing include guards to chip.h Some of the chip.h files in the tree are missing the include guards. This patch adds them in order to avoid potential redefinions of symbols contained in these headers, when they are included multiple times in static.c generated by sconfig. Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Signed-off-by: Jan Samek <jan.samek(a)siemens.com> --- M src/cpu/intel/haswell/chip.h M src/cpu/intel/model_2065x/chip.h M src/cpu/intel/model_206ax/chip.h M src/drivers/generic/alc1015/chip.h M src/drivers/generic/bayhub/chip.h M src/drivers/generic/bayhub_lv2/chip.h M src/drivers/generic/max98357a/chip.h M src/drivers/generic/nau8315/chip.h M src/drivers/i2c/cs35l53/chip.h M src/drivers/i2c/cs42l42/chip.h M src/drivers/i2c/da7219/chip.h M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98390/chip.h M src/drivers/i2c/max98396/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/i2c/nau8825/chip.h M src/drivers/i2c/pca9538/chip.h M src/drivers/i2c/pcf8523/chip.h M src/drivers/i2c/ptn3460/chip.h M src/drivers/i2c/rt1011/chip.h M src/drivers/i2c/rt5663/chip.h M src/drivers/i2c/rtd2132/chip.h M src/drivers/i2c/rx6110sa/chip.h M src/drivers/i2c/tas5825m/chip.h M src/drivers/i2c/tpm/chip.h M src/drivers/intel/ish/chip.h M src/drivers/net/phy/m88e1512/chip.h 27 files changed, 151 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/74749/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Gerrit-Change-Number: 74749 Gerrit-PatchSet: 2 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: treewide: Add missing include guards to chip.h
by Jan Samek (Code Review) 27 Apr '23

27 Apr '23

Jan Samek has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74749 ) Change subject: treewide: Add missing include guards to chip.h ...................................................................... treewide: Add missing include guards to chip.h Some of the 'chip.h' files in the tree are missing the include guards. This patch adds them in order to avoid potential redefinions of symbols contained in these headers, when they are included multiple times in static.c generated by sconfig. Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Signed-off-by: Jan Samek <jan.samek(a)siemens.com> --- M src/cpu/intel/haswell/chip.h M src/cpu/intel/model_2065x/chip.h M src/cpu/intel/model_206ax/chip.h M src/drivers/generic/alc1015/chip.h M src/drivers/generic/bayhub/chip.h M src/drivers/generic/bayhub_lv2/chip.h M src/drivers/generic/max98357a/chip.h M src/drivers/generic/nau8315/chip.h M src/drivers/i2c/cs35l53/chip.h M src/drivers/i2c/cs42l42/chip.h M src/drivers/i2c/da7219/chip.h M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98390/chip.h M src/drivers/i2c/max98396/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/i2c/nau8825/chip.h M src/drivers/i2c/pca9538/chip.h M src/drivers/i2c/pcf8523/chip.h M src/drivers/i2c/ptn3460/chip.h M src/drivers/i2c/rt1011/chip.h M src/drivers/i2c/rt5663/chip.h M src/drivers/i2c/rtd2132/chip.h M src/drivers/i2c/rx6110sa/chip.h M src/drivers/i2c/tas5825m/chip.h M src/drivers/i2c/tpm/chip.h M src/drivers/intel/ish/chip.h M src/drivers/net/phy/m88e1512/chip.h 27 files changed, 151 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/74749/1 diff --git a/src/cpu/intel/haswell/chip.h b/src/cpu/intel/haswell/chip.h index 5f2324c..02f2f1c 100644 --- a/src/cpu/intel/haswell/chip.h +++ b/src/cpu/intel/haswell/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __CPU_INTEL_HASWELL_CHIP_H__ +#define __CPU_INTEL_HASWELL_CHIP_H__ + #include <stdbool.h> #include <stdint.h> @@ -35,3 +38,5 @@ /* Enable S0iX support */ bool s0ix_enable; }; + +#endif /* __CPU_INTEL_HASWELL_CHIP_H__ */ diff --git a/src/cpu/intel/model_2065x/chip.h b/src/cpu/intel/model_2065x/chip.h index 9e89793..90921f7 100644 --- a/src/cpu/intel/model_2065x/chip.h +++ b/src/cpu/intel/model_2065x/chip.h @@ -1,5 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __CPU_INTEL_MODEL_2065X_CHIP_H__ +#define __CPU_INTEL_MODEL_2065X_CHIP_H__ + struct cpu_intel_model_2065x_config { int tcc_offset; /* TCC Activation Offset */ }; + +#endif /* __CPU_INTEL_MODEL_2065X_CHIP_H__ */ diff --git a/src/cpu/intel/model_206ax/chip.h b/src/cpu/intel/model_206ax/chip.h index 13cf3163..57e145e 100644 --- a/src/cpu/intel/model_206ax/chip.h +++ b/src/cpu/intel/model_206ax/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __CPU_INTEL_MODEL_206AX_CHIP_H__ +#define __CPU_INTEL_MODEL_206AX_CHIP_H__ + /* Keep this in sync with acpi.c */ enum cpu_acpi_level { CPU_ACPI_DISABLED = 0, @@ -18,3 +21,5 @@ int tcc_offset; /* TCC Activation Offset */ }; + +#endif /* __CPU_INTEL_MODEL_206AX_CHIP_H__ */ diff --git a/src/drivers/generic/alc1015/chip.h b/src/drivers/generic/alc1015/chip.h index fa84177..16b0d22 100644 --- a/src/drivers/generic/alc1015/chip.h +++ b/src/drivers/generic/alc1015/chip.h @@ -1,8 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_ALC1015_CHIP_H__ +#define __DRIVERS_GENERIC_ALC1015_CHIP_H__ + #include <acpi/acpi_device.h> struct drivers_generic_alc1015_config { const char *hid; /* ACPI _HID */ struct acpi_gpio sdb; /* SDMODE GPIO */ }; + +#endif /* __DRIVERS_GENERIC_ALC1015_CHIP_H__ */ diff --git a/src/drivers/generic/bayhub/chip.h b/src/drivers/generic/bayhub/chip.h index 77b7512..82fe670 100644 --- a/src/drivers/generic/bayhub/chip.h +++ b/src/drivers/generic/bayhub/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_BAYHUB_CHIP_H__ +#define __DRIVERS_GENERIC_BAYHUB_CHIP_H__ + #include <acpi/acpi_device.h> /* @@ -15,3 +18,5 @@ /* CLK and DAT tuning values */ uint8_t vih_tuning_value; }; + +#endif /* __DRIVERS_GENERIC_BAYHUB_CHIP_H__ */ diff --git a/src/drivers/generic/bayhub_lv2/chip.h b/src/drivers/generic/bayhub_lv2/chip.h index aa8f3fd..ea5c55f 100644 --- a/src/drivers/generic/bayhub_lv2/chip.h +++ b/src/drivers/generic/bayhub_lv2/chip.h @@ -1,8 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_BAYHUB_LV2_CHIP_H__ +#define __DRIVERS_GENERIC_BAYHUB_LV2_CHIP_H__ + #include <stdbool.h> /* Bayhub LV2 PCIe to SD bridge */ struct drivers_generic_bayhub_lv2_config { bool enable_power_saving; }; + +#endif /* __DRIVERS_GENERIC_BAYHUB_LV2_CHIP_H__ */ diff --git a/src/drivers/generic/max98357a/chip.h b/src/drivers/generic/max98357a/chip.h index 66ebecf..3916b80 100644 --- a/src/drivers/generic/max98357a/chip.h +++ b/src/drivers/generic/max98357a/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_MAX98357A_CHIP_H__ +#define __DRIVERS_GENERIC_MAX98357A_CHIP_H__ + #include <acpi/acpi_device.h> struct drivers_generic_max98357a_config { @@ -16,3 +19,5 @@ unsigned int device_present_gpio; unsigned int device_present_gpio_invert; }; + +#endif /* __DRIVERS_GENERIC_MAX98357A_CHIP_H__ */ diff --git a/src/drivers/generic/nau8315/chip.h b/src/drivers/generic/nau8315/chip.h index 45cb412..550f11e 100644 --- a/src/drivers/generic/nau8315/chip.h +++ b/src/drivers/generic/nau8315/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_GENERIC_NAU8315_CHIP_H__ +#define __DRIVERS_GENERIC_NAU8315_CHIP_H__ + #include <acpi/acpi_device.h> struct drivers_generic_nau8315_config { @@ -12,3 +15,5 @@ /* ENABLE GPIO */ struct acpi_gpio enable_gpio; }; + +#endif /* __DRIVERS_GENERIC_NAU8315_CHIP_H__ */ diff --git a/src/drivers/i2c/cs35l53/chip.h b/src/drivers/i2c/cs35l53/chip.h index 8631666..af83424 100644 --- a/src/drivers/i2c/cs35l53/chip.h +++ b/src/drivers/i2c/cs35l53/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_CS35L54_CHIP_H__ +#define __DRIVERS_I2C_CS35L54_CHIP_H__ + #include <acpi/acpi_device.h> #define CS35L53_MAX_GPIOS 2 @@ -153,3 +156,5 @@ */ enum cs35l53_gpio2_src gpio2_src_select; }; + +#endif /* __DRIVERS_I2C_CS35L54_CHIP_H__ */ diff --git a/src/drivers/i2c/cs42l42/chip.h b/src/drivers/i2c/cs42l42/chip.h index 1adffe7..61e0213 100644 --- a/src/drivers/i2c/cs42l42/chip.h +++ b/src/drivers/i2c/cs42l42/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_CS42L42_CHIP_H__ +#define __DRIVERS_I2C_CS42L42_CHIP_H__ + #include <acpi/acpi_device.h> enum cs42l42_ts_dbnc_rise { @@ -117,3 +120,5 @@ */ bool hs_bias_sense_disable; }; + +#endif /* __DRIVERS_I2C_CS42L42_CHIP_H__ */ diff --git a/src/drivers/i2c/da7219/chip.h b/src/drivers/i2c/da7219/chip.h index 203bd8f..5ca787c 100644 --- a/src/drivers/i2c/da7219/chip.h +++ b/src/drivers/i2c/da7219/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_DA7219_CHIP_H__ +#define __DRIVERS_I2C_DA7219_CHIP_H__ + #include <acpi/acpi_device.h> /* @@ -115,3 +118,5 @@ */ const char *mclk_name; }; + +#endif /* __DRIVERS_I2C_DA7219_CHIP_H__ */ diff --git a/src/drivers/i2c/max98373/chip.h b/src/drivers/i2c/max98373/chip.h index c184531..aea5226 100644 --- a/src/drivers/i2c/max98373/chip.h +++ b/src/drivers/i2c/max98373/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_MAX98373_CHIP_H__ +#define __DRIVERS_I2C_MAX98373_CHIP_H__ + /* * Maxim MAX98373 audio codec devicetree bindings */ @@ -22,3 +25,5 @@ /* slot number where current feedback will be received */ uint32_t imon_slot_no; }; + +#endif /* __DRIVERS_I2C_MAX98373_CHIP_H__ */ diff --git a/src/drivers/i2c/max98390/chip.h b/src/drivers/i2c/max98390/chip.h index c60b44c..6744c73 100644 --- a/src/drivers/i2c/max98390/chip.h +++ b/src/drivers/i2c/max98390/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef __DRIVERS_I2C_MAX98390_CHIP_H__ +#define __DRIVERS_I2C_MAX98390_CHIP_H__ + /* * MAXIM MAX98390 audio codec devicetree bindings */ @@ -19,3 +22,5 @@ /* slot number where current feedback will be received */ uint32_t imon_slot_no; }; + +#endif /* __DRIVERS_I2C_MAX98390_CHIP_H__ */ diff --git a/src/drivers/i2c/max98396/chip.h b/src/drivers/i2c/max98396/chip.h index 63a2440..7a1c118 100644 --- a/src/drivers/i2c/max98396/chip.h +++ b/src/drivers/i2c/max98396/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_MAX98396_CHIP_H__ +#define __DRIVERS_I2C_MAX98396_CHIP_H__ + /* * Maxim MAX98396 audio codec devicetree bindings */ @@ -24,3 +27,5 @@ /* Use GPIO based reset gpio */ struct acpi_gpio reset_gpio; }; + +#endif /* __DRIVERS_I2C_MAX98396_CHIP_H__ */ diff --git a/src/drivers/i2c/max98927/chip.h b/src/drivers/i2c/max98927/chip.h index fcdb9e0..9311487 100644 --- a/src/drivers/i2c/max98927/chip.h +++ b/src/drivers/i2c/max98927/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_MAX98927_CHIP_H__ +#define __DRIVERS_I2C_MAX98927_CHIP_H__ + /* * Maxim MAX98927 audio codec devicetree bindings */ @@ -19,3 +22,5 @@ /* slot number where current feedback will be received */ unsigned int imon_slot_no; }; + +#endif /* __DRIVERS_I2C_MAX98927_CHIP_H__ */ diff --git a/src/drivers/i2c/nau8825/chip.h b/src/drivers/i2c/nau8825/chip.h index ce17d3f..e47f466 100644 --- a/src/drivers/i2c/nau8825/chip.h +++ b/src/drivers/i2c/nau8825/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_NAU8825_CHIP_H__ +#define __DRIVERS_I2C_NAU8825_CHIP_H__ + #include <acpi/acpi_device.h> #define NAU8825_MAX_BUTTONS 8 @@ -102,3 +105,5 @@ */ bool adcout_ds; }; + +#endif /* __DRIVERS_I2C_NAU8825_CHIP_H__ */ diff --git a/src/drivers/i2c/pca9538/chip.h b/src/drivers/i2c/pca9538/chip.h index 96fd02f..c9254a4 100644 --- a/src/drivers/i2c/pca9538/chip.h +++ b/src/drivers/i2c/pca9538/chip.h @@ -1,7 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_PCA9538_CHIP_H__ +#define __DRIVERS_I2C_PCA9538_CHIP_H__ + struct drivers_i2c_pca9538_config { unsigned char in_out; /* Use bit as input(1) or output (0). */ unsigned char invert; /* If a bit is 1, the input will be inverted. */ unsigned char out_val; /* Initial output value to drive. */ }; + +#endif /* __DRIVERS_I2C_PCA9538_CHIP_H__ */ diff --git a/src/drivers/i2c/pcf8523/chip.h b/src/drivers/i2c/pcf8523/chip.h index b318da3..3c32599 100644 --- a/src/drivers/i2c/pcf8523/chip.h +++ b/src/drivers/i2c/pcf8523/chip.h @@ -2,6 +2,9 @@ #include "pcf8523.h" +#ifndef __DRIVERS_I2C_PCF8523_CHIP_H__ +#define __DRIVERS_I2C_PCF8523_CHIP_H__ + struct drivers_i2c_pcf8523_config { unsigned char cap_sel; /* Internal capacitor selection */ unsigned char second_int_en; /* Enable IRQ for seconds */ @@ -29,3 +32,5 @@ unsigned char user_day; /* User day to set */ unsigned char user_weekday; /* User weekday to set */ }; + +#endif /* __DRIVERS_I2C_PCF8523_CHIP_H__ */ diff --git a/src/drivers/i2c/ptn3460/chip.h b/src/drivers/i2c/ptn3460/chip.h index 2bf7e5e..0ec26ca 100644 --- a/src/drivers/i2c/ptn3460/chip.h +++ b/src/drivers/i2c/ptn3460/chip.h @@ -1,5 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_PTN3460_CHIP_H__ +#define __DRIVERS_I2C_PTN3460_CHIP_H__ + struct drivers_i2c_ptn3460_config { }; + +#endif /* __DRIVERS_I2C_PTN3460_CHIP_H__ */ diff --git a/src/drivers/i2c/rt1011/chip.h b/src/drivers/i2c/rt1011/chip.h index 84a73dc..b4e9fc4 100644 --- a/src/drivers/i2c/rt1011/chip.h +++ b/src/drivers/i2c/rt1011/chip.h @@ -4,6 +4,9 @@ * Realtek RT1011 audio codec devicetree bindings */ +#ifndef __DRIVERS_I2C_RT1011_CHIP_H__ +#define __DRIVERS_I2C_RT1011_CHIP_H__ + struct drivers_i2c_rt1011_config { const char *name; /* ACPI Device Name */ const char *desc; /* Device Description */ @@ -14,3 +17,5 @@ /* The VPD key of temperature during speaker calibration. */ const char *temperature_calib_key; }; + +#endif /* __DRIVERS_I2C_RT1011_CHIP_H__ */ diff --git a/src/drivers/i2c/rt5663/chip.h b/src/drivers/i2c/rt5663/chip.h index 49b107c..1c177b3 100644 --- a/src/drivers/i2c/rt5663/chip.h +++ b/src/drivers/i2c/rt5663/chip.h @@ -4,6 +4,9 @@ * Realtek RT5663 audio codec devicetree bindings */ +#ifndef __DRIVERS_I2C_RT5663_CHIP_H__ +#define __DRIVERS_I2C_RT5663_CHIP_H__ + #include <acpi/acpi_device.h> #include <stdint.h> @@ -23,3 +26,5 @@ uint32_t dc_offset_l_manual_mic; uint32_t dc_offset_r_manual_mic; }; + +#endif /* __DRIVERS_I2C_RT5663_CHIP_H__ */ diff --git a/src/drivers/i2c/rtd2132/chip.h b/src/drivers/i2c/rtd2132/chip.h index 7b02248..4a5fb19 100644 --- a/src/drivers/i2c/rtd2132/chip.h +++ b/src/drivers/i2c/rtd2132/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_RTD_2132_CHIP_H__ +#define __DRIVERS_I2C_RTD_2132_CHIP_H__ + struct drivers_i2c_rtd2132_config { /* Panel Power Sequencing. All units in ms. */ u16 t1; /* Delay from panel Vcc enable to LVDS output enable. */ @@ -32,3 +35,5 @@ */ u8 sscg_percent; }; + +#endif /* __DRIVERS_I2C_RTD_2132_CHIP_H__ */ diff --git a/src/drivers/i2c/rx6110sa/chip.h b/src/drivers/i2c/rx6110sa/chip.h index 1c0abe8..2b18426 100644 --- a/src/drivers/i2c/rx6110sa/chip.h +++ b/src/drivers/i2c/rx6110sa/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_RX6110SA_CHIP_H__ +#define __DRIVERS_I2C_RX6110SA_CHIP_H__ + #include "rx6110sa.h" struct drivers_i2c_rx6110sa_config { @@ -25,3 +28,5 @@ unsigned char bks_off; unsigned char iocut_en; /* Disable backup of I/O circuit. */ }; + +#endif /* __DRIVERS_I2C_RX6110SA_CHIP_H__ */ diff --git a/src/drivers/i2c/tas5825m/chip.h b/src/drivers/i2c/tas5825m/chip.h index 23af491..34f75cc 100644 --- a/src/drivers/i2c/tas5825m/chip.h +++ b/src/drivers/i2c/tas5825m/chip.h @@ -1,6 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_TAS5825M_CHIP_H__ +#define __DRIVERS_I2C_TAS5825M_CHIP_H__ + struct drivers_i2c_tas5825m_config { // Used to uniquely identify the AMP int id; }; + +#endif /* __DRIVERS_I2C_TAS5825M_CHIP_H__ */ diff --git a/src/drivers/i2c/tpm/chip.h b/src/drivers/i2c/tpm/chip.h index 4eac7e1..1117e37 100644 --- a/src/drivers/i2c/tpm/chip.h +++ b/src/drivers/i2c/tpm/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_I2C_TPM_CHIP_H__ +#define __DRIVERS_I2C_TPM_CHIP_H__ + #include <acpi/acpi_device.h> #include <device/i2c_simple.h> @@ -18,3 +21,5 @@ struct acpi_gpio irq_gpio; /* GPIO interrupt */ enum tpm_power_managed_mode power_managed_mode; /* TPM power managed mode */ }; + +#define /* __DRIVERS_I2C_TPM_CHIP_H__ */ diff --git a/src/drivers/intel/ish/chip.h b/src/drivers/intel/ish/chip.h index e7bb8f8..69f3253 100644 --- a/src/drivers/intel/ish/chip.h +++ b/src/drivers/intel/ish/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_INTEL_ISH_CHIP_H__ +#define __DRIVERS_INTEL_ISH_CHIP_H__ + /* * Intel Integrated Sensor Hub (ISH) */ @@ -10,3 +13,5 @@ /* Add `DmaProperty` in _DSD */ bool add_acpi_dma_property; }; + +#endif /* __DRIVERS_INTEL_ISH_CHIP_H__ */ diff --git a/src/drivers/net/phy/m88e1512/chip.h b/src/drivers/net/phy/m88e1512/chip.h index f1e313b..4af3b4d 100644 --- a/src/drivers/net/phy/m88e1512/chip.h +++ b/src/drivers/net/phy/m88e1512/chip.h @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __DRIVERS_NET_PHY_M88E1512_CHIP_H__ +#define __DRIVERS_NET_PHY_M88E1512_CHIP_H__ + #include "m88e1512.h" struct drivers_net_phy_m88e1512_config { @@ -15,3 +18,5 @@ unsigned char pmos_val; /* Set PMOS calibration value */ unsigned char nmos_val; /* Set NMOS calibration value */ }; + +#endif /* __DRIVERS_NET_PHY_M88E1512_CHIP_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3 Gerrit-Change-Number: 74749 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin
by Werner Zeh (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Werner Zeh. Hello Jan Samek, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74801 to look at the new patch set (#2). Change subject: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin ...................................................................... mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin The support for a spd.bin from CBFS was removed for all mc_ehl boards in commit 833bb448c5213 (mb/siemens/mc_ehl: Remove spd.bin from CBFS). There is still a remaining comment in romstage_fsp_params.c referring to the removed capability. This fix removes the spd.bin related part of the comment to stay consistent with the code. Change-Id: I669ee1c33d1d1c47764640982f71129195e63f14 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/mainboard/siemens/mc_ehl/romstage_fsp_params.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/74801/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I669ee1c33d1d1c47764640982f71129195e63f14 Gerrit-Change-Number: 74801 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin
by Jan Samek (Code Review) 27 Apr '23

27 Apr '23

Attention is currently required from: Werner Zeh. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74801 ) Change subject: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I669ee1c33d1d1c47764640982f71129195e63f14 Gerrit-Change-Number: 74801 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 27 Apr 2023 08:32:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin
by build bot (Jenkins) (Code Review) 27 Apr '23

27 Apr '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74801 ) Change subject: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175087): https://review.coreboot.org/c/coreboot/+/74801/comment/e4013738_2f8102ef PS1, Line 9: The support for a spd.bin from CBFS was removed for all mc_ehl boards in Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 833bb448c521 ("mb/siemens/mc_ehl: Remove spd.bin from CBFS")' -- To view, visit https://review.coreboot.org/c/coreboot/+/74801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I669ee1c33d1d1c47764640982f71129195e63f14 Gerrit-Change-Number: 74801 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Apr 2023 08:31:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023