Attention is currently required from: Arthur Heymans.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74760 )
Change subject: soc/intel: Don't report _S1 state when unsupported
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/pmc/Kconfig:
https://review.coreboot.org/c/coreboot/+/74760/comment/7400d874_459ab73f
PS7, Line 7: select ACPI_S1_NOT_SUPPORTED
> can we move this at line #5 ?
CB:74810
--
To view, visit https://review.coreboot.org/c/coreboot/+/74760
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da
Gerrit-Change-Number: 74760
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 27 Apr 2023 11:33:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74810 )
Change subject: soc/intel/common/block/pmc: Sort Kconfig in alphabetical order
......................................................................
soc/intel/common/block/pmc: Sort Kconfig in alphabetical order
Change-Id: I7392ede4226a940896c805fc0b0bc0dd615a964c
Signed-off-by: Christian Walter <christian.walter(a)9elements.com>
---
M src/soc/intel/common/block/pmc/Kconfig
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/74810/1
diff --git a/src/soc/intel/common/block/pmc/Kconfig b/src/soc/intel/common/block/pmc/Kconfig
index 181ad81..44dc2aa 100644
--- a/src/soc/intel/common/block/pmc/Kconfig
+++ b/src/soc/intel/common/block/pmc/Kconfig
@@ -2,9 +2,9 @@
depends on SOC_INTEL_COMMON_BLOCK_GPIO
depends on ACPI_INTEL_HARDWARE_SLEEP_VALUES
bool
+ select ACPI_S1_NOT_SUPPORTED
select HAVE_POWER_STATE_AFTER_FAILURE
select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE
- select ACPI_S1_NOT_SUPPORTED
help
Intel Processor common code for Power Management controller(PMC)
subsystem
--
To view, visit https://review.coreboot.org/c/coreboot/+/74810
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7392ede4226a940896c805fc0b0bc0dd615a964c
Gerrit-Change-Number: 74810
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-MessageType: newchange
Attention is currently required from: Derek Huang, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74785 )
Change subject: soc/intel/alderlake: Select FSP_MULTIPHASE_SI_INIT_RETURN_BROKEN config
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
> nice work! Can we have decode for the reset type from FSP instead 40000003 something like this.
are u asking how to decode 0x40000003 inside FSP.
It's part of the FSP inegration guide and per soc select the applicable reset type (for example: MTL does select FSP_STATUS_GLOBAL_RESET_REQUIRED_3)
config FSP_STATUS_GLOBAL_RESET
hex
depends on SOC_INTEL_COMMON_FSP_RESET
default 0x40000003 if FSP_STATUS_GLOBAL_RESET_REQUIRED_3
default 0x40000004 if FSP_STATUS_GLOBAL_RESET_REQUIRED_4
default 0x40000005 if FSP_STATUS_GLOBAL_RESET_REQUIRED_5
default 0x40000006 if FSP_STATUS_GLOBAL_RESET_REQUIRED_6
default 0x40000007 if FSP_STATUS_GLOBAL_RESET_REQUIRED_7
default 0x40000008 if FSP_STATUS_GLOBAL_RESET_REQUIRED_8
default 0xffffffff
help
If global reset is supported by SoC then select the correct status value for global
reset type from SoC Kconfig based on available Kconfig options
FSP_STATUS_GLOBAL_RESET_REQUIRED_X. Default is unsupported.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18a918cca7e19e03ed6020c55c86c64a94212963
Gerrit-Change-Number: 74785
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 11:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes, Benjamin Doron, Christian Walter, Maximilian Brune, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 )
Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> We discussed this in the parent change. […]
There's a horrendously long comment somewhere in CB:74121 describing a potential future approach, where options are described in the chipset devicetree.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74122
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47585a9a6f94ab5005f2ab63a0df267c0caef231
Gerrit-Change-Number: 74122
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 11:05:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kapil Porwal, Kun Liu.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kun Liu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74802
to look at the new patch set (#3).
Change subject: mb/google/rex/variants/screebo: Generate RAM IDs
......................................................................
mb/google/rex/variants/screebo: Generate RAM IDs
Generate RAM IDs for -
MT62F512M32D2DR-031 WT:B (LP5)
H9JCNNNBK3MLYR-N6E (LP5)
MT62F1G32D2DS-026 WT:B(LP5x)
H58G56BK7BX068 (LP5X)
BUG=b:276814951
TEST=Run part_id_gen tool without any errors
Signed-off-by: Kapil Porwal <kapilporwal(a)google.com>
Change-Id: I0fb2e488c06ed74d3fd493e5ca0ab89a825a9349
---
M src/mainboard/google/rex/variants/screebo/memory/Makefile.inc
M src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt
M src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt
3 files changed, 37 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/74802/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/74802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fb2e488c06ed74d3fd493e5ca0ab89a825a9349
Gerrit-Change-Number: 74802
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Subrata Banik, Maximilian Brune, Arthur Heymans, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74797 )
Change subject: cpu/x86/reset16.S: Remove handcoded reset vector
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74797/comment/08e21a76_5848a954
PS1, Line 13: Qemu Q35 still boots fine.
siemens/mc_ehl3 as well
--
To view, visit https://review.coreboot.org/c/coreboot/+/74797
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie371000c60d66c032a8dcccb98e7627df09d3aa4
Gerrit-Change-Number: 74797
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 10:27:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Subrata Banik, Maximilian Brune, Arthur Heymans, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74797 )
Change subject: cpu/x86/reset16.S: Remove handcoded reset vector
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/74797
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie371000c60d66c032a8dcccb98e7627df09d3aa4
Gerrit-Change-Number: 74797
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 10:19:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment