Attention is currently required from: Tarun Tuli, Kapil Porwal, Kun Liu.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kun Liu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74802
to look at the new patch set (#2).
Change subject: mb/google/rex/variants/screebo: Generate RAM IDs
......................................................................
mb/google/rex/variants/screebo: Generate RAM IDs
Generate RAM IDs for -
MT62F512M32D2DR-031 WT:B (LP5)
H9JCNNNBK3MLYR-N6E (LP5)
MT62F1G32D2DS-026 WT:B(LP5x)
H58G56BK7BX068 (LP5X)
BUG=b:276814951
TEST=Run part_id_gen tool without any errors
Signed-off-by: Kapil Porwal <kapilporwal(a)google.com>
Change-Id: I0fb2e488c06ed74d3fd493e5ca0ab89a825a9349
---
M src/mainboard/google/rex/variants/screebo/memory/Makefile.inc
M src/mainboard/google/rex/variants/screebo/memory/dram_id.generated.txt
M src/mainboard/google/rex/variants/screebo/memory/mem_parts_used.txt
3 files changed, 39 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/74802/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fb2e488c06ed74d3fd493e5ca0ab89a825a9349
Gerrit-Change-Number: 74802
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Kevin3 Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74626 )
Change subject: mb/google/dedede/var/boxy: Update devicetree and GPIO table
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/74626
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a155ebca50dbd5bdb046713ebabbee395361273
Gerrit-Change-Number: 74626
Gerrit-PatchSet: 9
Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 09:34:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74803 )
Change subject: vc/intel/fsp/mtl: Update header files from 3084_85 to 3143_80
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175093):
https://review.coreboot.org/c/coreboot/+/74803/comment/4f29fd83_99eedfcc
PS1, Line 8:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175093):
https://review.coreboot.org/c/coreboot/+/74803/comment/5fc486ca_6f9ebab5
PS1, Line 12: 1. Name change of UPD from 'GtExtraTurboVoltage' to 'GtAdaptiveVoltage'
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175093):
https://review.coreboot.org/c/coreboot/+/74803/comment/355aa19e_a8cd06f4
PS1, Line 13: 2. Name change of UPD from 'CoreVoltageAdaptive' to 'CoreAdaptiveVoltage'
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/74803
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67939ecf71166fca4f3d2d6cd4622215bebc5718
Gerrit-Change-Number: 74803
Gerrit-PatchSet: 1
Gerrit-Owner: Kilari Raasi <kilari.raasi(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 27 Apr 2023 09:33:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Jeremy Soller, Christian Walter, Mario Scheithauer, Arthur Heymans, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74749 )
Change subject: treewide: Add missing include guards to chip.h
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/i2c/rtd2132/chip.h:
https://review.coreboot.org/c/coreboot/+/74749/comment/ec0e7708_7a2355eb
PS3, Line 3: RTD_2132
> maybe without underscore
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3
Gerrit-Change-Number: 74749
Gerrit-PatchSet: 4
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 09:07:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Jeremy Soller, Christian Walter, Arthur Heymans, Werner Zeh, Jan Samek.
Hello Tim Crawford, Jeremy Soller, Christian Walter, Mario Scheithauer, Arthur Heymans, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74749
to look at the new patch set (#4).
Change subject: treewide: Add missing include guards to chip.h
......................................................................
treewide: Add missing include guards to chip.h
Some of the chip.h files in the tree are missing the include guards.
This patch adds them in order to avoid potential redefinions of symbols
contained in these headers, when they are included multiple times in
static.c generated by sconfig.
Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3
Signed-off-by: Jan Samek <jan.samek(a)siemens.com>
---
M src/cpu/intel/haswell/chip.h
M src/cpu/intel/model_2065x/chip.h
M src/cpu/intel/model_206ax/chip.h
M src/drivers/generic/alc1015/chip.h
M src/drivers/generic/bayhub/chip.h
M src/drivers/generic/bayhub_lv2/chip.h
M src/drivers/generic/max98357a/chip.h
M src/drivers/generic/nau8315/chip.h
M src/drivers/i2c/cs35l53/chip.h
M src/drivers/i2c/cs42l42/chip.h
M src/drivers/i2c/da7219/chip.h
M src/drivers/i2c/max98373/chip.h
M src/drivers/i2c/max98390/chip.h
M src/drivers/i2c/max98396/chip.h
M src/drivers/i2c/max98927/chip.h
M src/drivers/i2c/nau8825/chip.h
M src/drivers/i2c/pca9538/chip.h
M src/drivers/i2c/pcf8523/chip.h
M src/drivers/i2c/ptn3460/chip.h
M src/drivers/i2c/rt1011/chip.h
M src/drivers/i2c/rt5663/chip.h
M src/drivers/i2c/rtd2132/chip.h
M src/drivers/i2c/rx6110sa/chip.h
M src/drivers/i2c/tas5825m/chip.h
M src/drivers/i2c/tpm/chip.h
M src/drivers/intel/ish/chip.h
M src/drivers/net/phy/m88e1512/chip.h
27 files changed, 151 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/74749/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/74749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I550a514e72a8dd4db602e7ceffccd81aa36446e3
Gerrit-Change-Number: 74749
Gerrit-PatchSet: 4
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Kapil Porwal, Kun Liu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74802 )
Change subject: mb/google/rex/variants/screebo: Generate RAM IDs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fb2e488c06ed74d3fd493e5ca0ab89a825a9349
Gerrit-Change-Number: 74802
Gerrit-PatchSet: 1
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 27 Apr 2023 09:03:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment