coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
by Fabian Groffen (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Kevin Keijzer, Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin. Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73451 ) Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: confirmed it works on my board -- To view, visit https://review.coreboot.org/c/coreboot/+/73451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40822f2f7b013b7ac0658d66d7972b447066d593 Gerrit-Change-Number: 73451 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Comment-Date: Sat, 04 Mar 2023 17:14:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/asrock/b75m-itx: Fix S3 suspend to RAM
by Fabian Groffen (Code Review) 04 Mar '23

04 Mar '23

Fabian Groffen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/73357 ) Change subject: mb/asrock/b75m-itx: Fix S3 suspend to RAM ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/73357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6bb0002943a2697b35d3ae05a0d848df3fce6 Gerrit-Change-Number: 73357 Gerrit-PatchSet: 1 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Keijzer Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Fabian Groffen (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Kevin Keijzer, Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin, Elyes Haouas. Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: Just tried this out, and indeed it makes it all work, which is much nicer than my original port! -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 5 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 04 Mar 2023 17:08:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Kevin Keijzer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas. Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: One more addition: because the B75 Pro3-M port, on which this is based, lacks `cmos.default`, `cmos.layout` and `data.vbt`, those were missing from this port as well. I've pushed the changes for the b75pro3-m in commit ac95089641b1, and this patchset incorporates them for the b75m-itx as well. This pretty much completes it. -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 5 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 04 Mar 2023 16:59:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Kevin Keijzer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas. Kevin Keijzer has uploaded a new patch set (#5) to the change originally created by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX This board is based off b75pro3-m, which is very similar. Compared to it, it just lacks a COM1 header, and the secondary ASMedia SATA3 controller. Tested with: CPUs: - Core i5-3330 - Core i5-3470 - Core i7-3770 RAM: - single bank 4GB CL11 - two banks 4+4GB CL9 - two banks 8+8GB CL10 OS: - Gentoo Linux LiveUSB, KDE desktop (Linux 5.15.72) Working: - GRUB2 payload with embedded default config for boot from USB, disk - UEFI EDK2 payload - Intel ME stripped - Native raminit - Integrated graphics with libgfxinit (HDMI, DVI and VGA) - (boot from) SATA2, SATA3, ports - Rear USB 2 and 3 ports (supports boot) - Internal USB 3.0 ports - Realtek GbE NIC - 2.0 channel audio via lineout jack output - ACPI (power button triggers OS event) Untested: - Internal USB 2.0 ports - eSATA port - 7.1 channel audio Signed-off-by: Fabian Groffen <grobian(a)gentoo.org> Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb --- A src/mainboard/asrock/b75m-itx/Kconfig A src/mainboard/asrock/b75m-itx/Kconfig.name A src/mainboard/asrock/b75m-itx/Makefile.inc A src/mainboard/asrock/b75m-itx/acpi/ec.asl A src/mainboard/asrock/b75m-itx/acpi/platform.asl A src/mainboard/asrock/b75m-itx/acpi/superio.asl A src/mainboard/asrock/b75m-itx/board_info.txt A src/mainboard/asrock/b75m-itx/cmos.default A src/mainboard/asrock/b75m-itx/cmos.layout A src/mainboard/asrock/b75m-itx/data.vbt A src/mainboard/asrock/b75m-itx/devicetree.cb A src/mainboard/asrock/b75m-itx/dsdt.asl A src/mainboard/asrock/b75m-itx/early_init.c A src/mainboard/asrock/b75m-itx/gma-mainboard.ads A src/mainboard/asrock/b75m-itx/gpio.c A src/mainboard/asrock/b75m-itx/hda_verb.c A src/mainboard/asrock/b75m-itx/mainboard.c 17 files changed, 644 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/73097/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 5 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
by Kevin Keijzer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Kevin Keijzer. Hello Kevin Keijzer, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/73451 to review the following change. Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ...................................................................... mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin The ASRock B75 Pro3-M port was lacking a cmos.default and cmos.layout, which means nvramtool could not be used to change any nvram values, and the defaults were always being used. I have "borrowed" the files from the similar h77pro4-m port, which work fine for the b75pro3-m. I can now adjust things like gfx_uma_size and power_on_after_fail, which are quite useful to be able to modify. Additionally, this board did not have a data.vbt, so I extracted vbt.bin from the VGABIOS and added it. Change-Id: I40822f2f7b013b7ac0658d66d7972b447066d593 Signed-off-by: Kevin Keijzer <kevin(a)quietlife.nl> --- M src/mainboard/asrock/b75pro3-m/Kconfig A src/mainboard/asrock/b75pro3-m/cmos.default A src/mainboard/asrock/b75pro3-m/cmos.layout A src/mainboard/asrock/b75pro3-m/data.vbt 4 files changed, 127 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/73451/1 diff --git a/src/mainboard/asrock/b75pro3-m/Kconfig b/src/mainboard/asrock/b75pro3-m/Kconfig index 8f568ff..d371bff 100644 --- a/src/mainboard/asrock/b75pro3-m/Kconfig +++ b/src/mainboard/asrock/b75pro3-m/Kconfig @@ -8,6 +8,9 @@ select DRIVERS_ASMEDIA_ASPM_BLACKLIST select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select INTEL_GMA_HAVE_VBT select INTEL_INT15 select MAINBOARD_HAS_LIBGFXINIT select NORTHBRIDGE_INTEL_SANDYBRIDGE diff --git a/src/mainboard/asrock/b75pro3-m/cmos.default b/src/mainboard/asrock/b75pro3-m/cmos.default new file mode 100644 index 0000000..23386fb --- /dev/null +++ b/src/mainboard/asrock/b75pro3-m/cmos.default @@ -0,0 +1,7 @@ +boot_option=Fallback +debug_level=Debug +nmi=Disable +power_on_after_fail=Disable +sata_mode=AHCI +gfx_uma_size=64M +cpu_fan_tach_src=CPU_FAN1 diff --git a/src/mainboard/asrock/b75pro3-m/cmos.layout b/src/mainboard/asrock/b75pro3-m/cmos.layout new file mode 100644 index 0000000..ac88ee9 --- /dev/null +++ b/src/mainboard/asrock/b75pro3-m/cmos.layout @@ -0,0 +1,96 @@ +## SPDX-License-Identifier: GPL-2.0-only + +# ----------------------------------------------------------------- +entries + +# ----------------------------------------------------------------- +0 120 r 0 reserved_memory + +# ----------------------------------------------------------------- +# RTC_BOOT_BYTE (coreboot hardcoded) +384 1 e 2 boot_option +388 4 h 0 reboot_counter + +# ----------------------------------------------------------------- +# coreboot config options: console +395 4 e 3 debug_level + +# coreboot config options: southbridge +408 1 e 1 nmi + +409 2 e 4 power_on_after_fail +411 2 e 5 sata_mode + +# coreboot config options: northbridge +416 5 e 6 gfx_uma_size + +# coreboot config options: mainboard-specific +421 2 e 7 cpu_fan_tach_src + +# coreboot config options: check sums +984 16 h 0 check_sum + +# ----------------------------------------------------------------- + +enumerations +#ID value text + +# Generic on/off enum +1 0 Disable +1 1 Enable + +# boot_option +2 0 Fallback +2 1 Normal + +# debug_level +3 0 Emergency +3 1 Alert +3 2 Critical +3 3 Error +3 4 Warning +3 5 Notice +3 6 Info +3 7 Debug +3 8 Spew + +# power_on_after_fail +4 0 Disable +4 1 Enable +4 2 Keep + +# sata_mode +5 0 AHCI +5 1 Compatible +5 2 Legacy + +# gfx_uma_size (Intel IGP Video RAM size) +6 0 32M +6 1 64M +6 2 96M +6 3 128M +6 4 160M +6 5 192M +6 6 224M +6 7 256M +6 8 288M +6 9 320M +6 10 352M +6 11 384M +6 12 416M +6 13 448M +6 14 480M +6 15 512M +6 16 1024M + +# cpu_fan_header (select which header provides the tachometer +# signal to the Super I/O on its CPUFANIN input) +7 0 None +7 1 CPU_FAN1 +7 2 CPU_FAN2 +7 3 Both + +# ----------------------------------------------------------------- +checksums + +checksum 392 423 984 diff --git a/src/mainboard/asrock/b75pro3-m/data.vbt b/src/mainboard/asrock/b75pro3-m/data.vbt new file mode 100644 index 0000000..52a8268 --- /dev/null +++ b/src/mainboard/asrock/b75pro3-m/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/73451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40822f2f7b013b7ac0658d66d7972b447066d593 Gerrit-Change-Number: 73451 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Kevin Keijzer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas. Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Patchset: PS4: I've added the fix for S3 and hardware monitoring, similar to the changes for the B75 Pro3-M. I've been using the board like this as an HTPC for five days now, and everything is working perfectly fine. I think the port is in well enough shape to be added like this. File src/mainboard/asrock/b75m-itx/devicetree.cb: https://review.coreboot.org/c/coreboot/+/73097/comment/1ae6c776_ea03b93f PS3, Line 122: device pnp 2e.b off end # HWM, front panel > Change this as follows to enable hardware monitoring from Linux: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 4 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 04 Mar 2023 11:53:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kevin Keijzer Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Kevin Keijzer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas. Kevin Keijzer has uploaded a new patch set (#4) to the change originally created by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX This board is based off b75pro3-m, which is very similar. Compared to it, it just lacks a COM1 header, and the secondary ASMedia SATA3 controller. Tested with: CPUs: - Core i5-3330 - Core i5-3470 - Core i7-3770 RAM: - single bank 4GB CL11 - two banks 4+4GB CL9 - two banks 8+8GB CL10 OS: - Gentoo Linux LiveUSB, KDE desktop (Linux 5.15.72) Working: - GRUB2 payload with embedded default config for boot from USB, disk - UEFI EDK2 payload - Intel ME stripped - Native raminit - Integrated graphics with libgfxinit (HDMI, DVI and VGA) - (boot from) SATA2, SATA3, ports - Rear USB 2 and 3 ports (supports boot) - Internal USB 2.0 ports - Realtek GbE NIC - 2.0 channel audio via lineout jack output - ACPI (power button triggers OS event) Untested: - Internal USB 2.0 ports - eSATA port - 7.1 channel audio Signed-off-by: Fabian Groffen <grobian(a)gentoo.org> Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb --- A src/mainboard/asrock/b75m-itx/Kconfig A src/mainboard/asrock/b75m-itx/Kconfig.name A src/mainboard/asrock/b75m-itx/Makefile.inc A src/mainboard/asrock/b75m-itx/acpi/ec.asl A src/mainboard/asrock/b75m-itx/acpi/platform.asl A src/mainboard/asrock/b75m-itx/acpi/superio.asl A src/mainboard/asrock/b75m-itx/board_info.txt A src/mainboard/asrock/b75m-itx/devicetree.cb A src/mainboard/asrock/b75m-itx/dsdt.asl A src/mainboard/asrock/b75m-itx/early_init.c A src/mainboard/asrock/b75m-itx/gma-mainboard.ads A src/mainboard/asrock/b75m-itx/gpio.c A src/mainboard/asrock/b75m-itx/hda_verb.c A src/mainboard/asrock/b75m-itx/mainboard.c 14 files changed, 538 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/73097/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 4 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/asrock/b75pro3-m: Fix S3 resume and hardware monitoring
by Kevin Keijzer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Felix Singer, Arthur Heymans, Nicholas Chin. Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73450 ) Change subject: mb/asrock/b75pro3-m: Fix S3 resume and hardware monitoring ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73450/comment/25f61051_daefb32e PS1, Line 7: b75-pro3-m > nit: b75pro3-m Done https://review.coreboot.org/c/coreboot/+/73450/comment/4995549b_d2b9c8e1 PS1, Line 10: cb:20227 > Please reference the commit hash, i.e.: […] Done Patchset: PS2: Is it okay like this? -- To view, visit https://review.coreboot.org/c/coreboot/+/73450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e504fe4b60da1d7b9830bea5029101bb8cebcb5 Gerrit-Change-Number: 73450 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Mar 2023 11:49:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/asrock/b75pro3-m: Fix S3 resume and hardware monitoring
by Kevin Keijzer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Kevin Keijzer, Felix Singer, Arthur Heymans, Nicholas Chin. Hello Felix Singer, build bot (Jenkins), Angel Pons, Arthur Heymans, Nicholas Chin, Fabian Groffen, Kevin Keijzer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73450 to look at the new patch set (#2). Change subject: mb/asrock/b75pro3-m: Fix S3 resume and hardware monitoring ...................................................................... mb/asrock/b75pro3-m: Fix S3 resume and hardware monitoring On the ASRock B75 Pro3-M, resuming from S3 has always been broken; see commit 928c6c6336f2 (mainboard/asrock: add ASRock B75 Pro3-M). This was because 3VSBSW# was not enabled during S3, causing the board to reboot instead of resume. This change enables 3VSBSW# during S3, which leads to S3 resume working normally. Another issue with this board was that hardware monitoring was not working. The nct6775 Linux kernel module could not be loaded, due to the device having a base I/O port of 0. This change also enables the Super I/O properly, so that sensors-detect can find the sensor and the kernel module can be used. Change-Id: I6e504fe4b60da1d7b9830bea5029101bb8cebcb5 Signed-off-by: Kevin Keijzer <kevin(a)quietlife.nl> --- M src/mainboard/asrock/b75pro3-m/devicetree.cb 1 file changed, 28 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/73450/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e504fe4b60da1d7b9830bea5029101bb8cebcb5 Gerrit-Change-Number: 73450 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023