coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[S] Change in coreboot[master]: soc/intel/alderlake: Hook up ucode for RPL-P/H/U
by Felix Singer (Code Review) 04 Mar '23

04 Mar '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73436 ) Change subject: soc/intel/alderlake: Hook up ucode for RPL-P/H/U ...................................................................... soc/intel/alderlake: Hook up ucode for RPL-P/H/U Hook up microcode from 3rdparty repo for: - 06-ba-02 (CPUID signature: 0xb06a2) Change-Id: Icb2fc9350ebc33ef150f1ab5df1006ed956478d6 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/73436 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/alderlake/Makefile.inc 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/soc/intel/alderlake/Makefile.inc b/src/soc/intel/alderlake/Makefile.inc index 5c2b9dc..9580419 100644 --- a/src/soc/intel/alderlake/Makefile.inc +++ b/src/soc/intel/alderlake/Makefile.inc @@ -86,6 +86,8 @@ cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-9a-03 # ADL-P R0 and ADL-M R0 cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-9a-04 +# RPL-P/H J0, RPL-U Q0 +cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-ba-02 endif endif -- To view, visit https://review.coreboot.org/c/coreboot/+/73436 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb2fc9350ebc33ef150f1ab5df1006ed956478d6 Gerrit-Change-Number: 73436 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: mb/google/skyrim: Allow port descriptors to be overridden
by Martin L Roth (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Jason Nien, Matt DeVillier, Arthur Heymans, Martin Roth. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73294 ) Change subject: mb/google/skyrim: Allow port descriptors to be overridden ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/skyrim/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/73294/comment/e41bb208_d44762ad PS2, Line 97: if (!*dxio_num || !*dxio_descs) : { : *dxio_descs = skyrim_mdn_dxio_descriptors; : *dxio_num = ARRAY_SIZE(skyrim_mdn_dxio_descriptors); : } > Does the compiler optimizes this out? If not, you might want a Kconfig override for DXIO overrides w […] No, it the compiler won't optimize it out and it won't drop the table above either which is a bigger issue. The reason I did it this way though was to be as consistent as possible with other variant entries, such as the GPIO tables. Using weak functions is *definitely* not my preference, but it's consistent. If there's a preference to drop the weak functions and just use a Kconfig variable instead, I can do it that way, but I expect the google preference will be the weak functions so that the code can just be dropped into the variant directory. Personally, I agree with Arthur, and would rather use a Kconfig variable to determine if we're overriding the PCIe descriptors. -- To view, visit https://review.coreboot.org/c/coreboot/+/73294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cff44f5b39d130a7191a69970cae8a88bb5d475 Gerrit-Change-Number: 73294 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Sun, 05 Mar 2023 02:07:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Felix Singer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Kevin Keijzer, Angel Pons, Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... Patch Set 5: (13 comments) Patchset: PS5: Thanks! Mostly some style comments. File src/mainboard/asrock/b75m-itx/Kconfig: https://review.coreboot.org/c/coreboot/+/73097/comment/091e5ea2_34803ea0 PS5, Line 20: select MAINBOARD_HAS_LIBGFXINIT Please put it before NORTHBRIDGE_INTEL_SANDYBRIDGE to keep the options sorted. File src/mainboard/asrock/b75m-itx/Makefile.inc: https://review.coreboot.org/c/coreboot/+/73097/comment/4a7fed2c_7f53d538 PS5, Line 6: ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads : bootblock-y += early_init.c : romstage-y += early_init.c Please order by the stages. bootblock, romstage, ramstage File src/mainboard/asrock/b75m-itx/devicetree.cb: https://review.coreboot.org/c/coreboot/+/73097/comment/f139d427_163f6bdd PS5, Line 4: register "gfx.use_spread_spectrum_clock" = "0" : register "gpu_cpu_backlight" = "0x00000000" : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" : register "gpu_panel_port_select" = "PANEL_PORT_LVDS" : register "gpu_panel_power_backlight_off_delay" = "0" : register "gpu_panel_power_backlight_on_delay" = "0" : register "gpu_panel_power_cycle_delay" = "4" : register "gpu_panel_power_down_delay" = "0" : register "gpu_panel_power_up_delay" = "0" : register "gpu_pch_backlight" = "0x00000000 The zeroed options can be removed. Unset options are zero by default. https://review.coreboot.org/c/coreboot/+/73097/comment/05d44373_ac5f4ec4 PS5, Line 47: device pci 16.1 off # Management Engine Interface 2 : end Please move the end-keyword in the lines before if the device scope doesn't contain anything. File src/mainboard/asrock/b75m-itx/dsdt.asl: https://review.coreboot.org/c/coreboot/+/73097/comment/34741798_bca125b3 PS5, Line 10: // OEM revision Remove comment https://review.coreboot.org/c/coreboot/+/73097/comment/79fe1c9f_5072f855 PS5, Line 17: /* global NVS and variables. */ Remove comment https://review.coreboot.org/c/coreboot/+/73097/comment/d75e4cf1_79b2dee4 PS5, Line 21: Scope (\_SB) { : Device (PCI0) Simplify to `Device (\_SB.PCI0) {` File src/mainboard/asrock/b75m-itx/early_init.c: https://review.coreboot.org/c/coreboot/+/73097/comment/390a7711_ce705aa3 PS5, Line 12: void bootblock_mainboard_early_init(void) : { : /* no COM1 header installed, do not enable UART */ : } Can be removed. There is a weak function which is called instead. File src/mainboard/asrock/b75m-itx/gpio.c: https://review.coreboot.org/c/coreboot/+/73097/comment/3f2274c1_8f48e63d PS5, Line 157: }, Remove one tab https://review.coreboot.org/c/coreboot/+/73097/comment/aaa0e1a4_14a8bf99 PS5, Line 163: }, Remove one tab https://review.coreboot.org/c/coreboot/+/73097/comment/b94ad2ff_fff4a8e1 PS5, Line 169: }, Remove one tab File src/mainboard/asrock/b75m-itx/hda_verb.c: https://review.coreboot.org/c/coreboot/+/73097/comment/1820d3a1_a3c13780 PS5, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ Some files are already licensed under GPL-2.0-or-later. Would you mind licensing the others this way as well? -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 5 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 05 Mar 2023 01:28:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp: add function declarations in ramstage for SPR-SP
by David Hendricks (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Jonathan Zhang, TimLiu-SMCI, Johnny Lin, Christian Walter, Jian-Ming Wang, Arthur Heymans, Tim Chu. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72618 ) Change subject: soc/intel/xeon_sp: add function declarations in ramstage for SPR-SP ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can this be squashed into CB:72443? -- To view, visit https://review.coreboot.org/c/coreboot/+/72618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I345ec6269bd47046cc704986c6fcaff1e9678ff3 Gerrit-Change-Number: 72618 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 05 Mar 2023 00:28:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp: Add PM definition for SPR-SP
by David Hendricks (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, David Hendricks, Arthur Heymans, Tim Chu. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72613 ) Change subject: soc/intel/xeon_sp: Add PM definition for SPR-SP ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Should we move the differences to {lbg|ebg}/include/soc/pmc. […] Good idea, I went ahead and implemented that in PS2. -- To view, visit https://review.coreboot.org/c/coreboot/+/72613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13ed156a1b967e87fa30b1867feed03c3d17b992 Gerrit-Change-Number: 72613 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 05 Mar 2023 00:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp: Add PM definition for SPR-SP
by David Hendricks (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Johnny Lin, David Hendricks, Christian Walter, Arthur Heymans, Tim Chu. David Hendricks has uploaded a new patch set (#2) to the change originally created by Jonathan Zhang. ( https://review.coreboot.org/c/coreboot/+/72613 ) Change subject: soc/intel/xeon_sp: Add PM definition for SPR-SP ...................................................................... soc/intel/xeon_sp: Add PM definition for SPR-SP Change-Id: I13ed156a1b967e87fa30b1867feed03c3d17b992 Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com> Signed-off-by: David Hendricks <ddaveh(a)amazon.com> --- A src/soc/intel/xeon_sp/ebg/include/soc/soc_pm.h M src/soc/intel/xeon_sp/include/soc/pm.h A src/soc/intel/xeon_sp/lbg/include/soc/soc_pm.h 3 files changed, 38 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/72613/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13ed156a1b967e87fa30b1867feed03c3d17b992 Gerrit-Change-Number: 72613 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp: Add P2SB definition for SPR-SP
by David Hendricks (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Jonathan Zhang, TimLiu-SMCI, Johnny Lin, Christian Walter, Jian-Ming Wang, Arthur Heymans, Tim Chu. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72612 ) Change subject: soc/intel/xeon_sp: Add P2SB definition for SPR-SP ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/soc/intel/xeon_sp/include/soc/p2sb.h: https://review.coreboot.org/c/coreboot/+/72612/comment/5d81b8a6_eea7e518 PS1, Line 14: #define P2SBC 0xe0 : #define SBILOCK (1 << 31) > Can you double-check these? The closest thing I can find is "Device Hide(HIDE)" bit 8 in the P2SBC C […] Nevermind, I see how it's used now. The thing I mentioned earlier is functionally equivalent, though perhaps better documented. -- To view, visit https://review.coreboot.org/c/coreboot/+/72612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ece7aac4339266068d4fc8fb1c58d0573eb2895 Gerrit-Change-Number: 72612 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sat, 04 Mar 2023 23:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Documentation/sbom: Add SBOM Documentation
by Maximilian Brune (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Felix Singer, Patrick Rudolph, Richard Hughes, Paul Menzel, Angel Pons, Eric Lai, Felix Held. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68995 ) Change subject: Documentation/sbom: Add SBOM Documentation ...................................................................... Patch Set 12: (1 comment) File Documentation/sbom/sbom.md: https://review.coreboot.org/c/coreboot/+/68995/comment/554a3099_1010702b PS9, Line 10: CoSWID > I am not listing formats Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39fbcba60a0fbdbed9f662119ed7692c0a0fd30e Gerrit-Change-Number: 68995 Gerrit-PatchSet: 12 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 04 Mar 2023 22:09:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: lint/lint-stable-003-whitespace: Fix excludelist
by Elyes Haouas (Code Review) 04 Mar '23

04 Mar '23

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73396 ) Change subject: lint/lint-stable-003-whitespace: Fix excludelist ...................................................................... lint/lint-stable-003-whitespace: Fix excludelist Remove the last slash '/' from directories in excludelist, so that they will be correctly filtered by grep. Fixes: grep: util/goswid: Is a directory grep: util/nvidia/cbootimage: Is a directory Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I90cc2cff9a98bbd0af344156332b970bfd6430b9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73396 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/lint-stable-003-whitespace 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/lint/lint-stable-003-whitespace b/util/lint/lint-stable-003-whitespace index 838ea93..82b46b0 100755 --- a/util/lint/lint-stable-003-whitespace +++ b/util/lint/lint-stable-003-whitespace @@ -11,7 +11,7 @@ # shellcheck source=helper_functions.sh . "${LINTDIR}/helper_functions.sh" -EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage/|^util/goswid/|__pycache__|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' +EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage|^util/goswid|__pycache__|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' INCLUDELIST="src util payloads Makefile* toolchain.inc tests" # shellcheck disable=SC2086,SC2046 -- To view, visit https://review.coreboot.org/c/coreboot/+/73396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90cc2cff9a98bbd0af344156332b970bfd6430b9 Gerrit-Change-Number: 73396 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
by Felix Singer (Code Review) 04 Mar '23

04 Mar '23

Attention is currently required from: Kevin Keijzer, Angel Pons, Arthur Heymans, Nicholas Chin. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73451 ) Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40822f2f7b013b7ac0658d66d7972b447066d593 Gerrit-Change-Number: 73451 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Comment-Date: Sat, 04 Mar 2023 17:36:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023