coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[L] Change in coreboot[master]: util/ifdtool/ifdtool.c: Clean up
by Maximilian Brune (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Paul Menzel, Stefan Reinauer. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73448 ) Change subject: util/ifdtool/ifdtool.c: Clean up ...................................................................... Patch Set 12: (1 comment) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/73448/comment/04330cc2_ce50d92e PS10, Line 7: Cleanup and Error printing > Please make it a statement by adding a verb (in imperative mood). Done I hope it's imperative enough. -- To view, visit https://review.coreboot.org/c/coreboot/+/73448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7bbce63ecb2e920530394766f58b5ea6f72852e9 Gerrit-Change-Number: 73448 Gerrit-PatchSet: 12 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Mar 2023 01:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/cbfstool: Add usage information
by Maximilian Brune (Code Review) 05 Mar '23

05 Mar '23

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73488 ) Change subject: util/cbfstool: Add usage information ...................................................................... util/cbfstool: Add usage information Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ica512d21d1cef8ccffbc093016c7a3bfcf901b14 --- M util/cbfstool/cbfstool.c M util/cbfstool/ifittool.c 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/73488/1 diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index a883dda..c825a13 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -1948,7 +1948,7 @@ " -F Force action\n" " -g Generate position and alignment arguments\n" " -U Unprocessed; don't decompress or make ELF\n" - " -v Provide verbose output\n" + " -v Provide verbose output (-v=INFO -vv=DEBUG output)\n" " -h Display this help message\n\n" " --ext-win-base Base of extended decode window in host address\n" " space(x86 only)\n" diff --git a/util/cbfstool/ifittool.c b/util/cbfstool/ifittool.c index 9ea3149..d0d9431 100644 --- a/util/cbfstool/ifittool.c +++ b/util/cbfstool/ifittool.c @@ -50,7 +50,7 @@ "\tOPTIONAL ARGUMENTS:\n" "\t\t-h|--help : Display this text\n" "\t\t-H|--header-offset : Do not search for header, use this offset\n" - "\t\t-v|--verbose : Be verbose\n" + "\t\t-v|--verbose : Be verbose (-v=INFO -vv=DEBUG output)\n" "\t\t-D|--dump : Dump FIT table (at end of operation)\n" "\t\t-c|--clear-table : Remove all existing entries (do not update)\n" "\t\t-j|--topswap-size : Use second FIT table if non zero\n" -- To view, visit https://review.coreboot.org/c/coreboot/+/73488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica512d21d1cef8ccffbc093016c7a3bfcf901b14 Gerrit-Change-Number: 73488 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/brya/variant/bb/{brya,hades}/include/ec: Add EC_HOST_EVENT_GPU
by Eric Lai (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Daisuke Nojiri, Tarun Tuli, Caveh Jalali, Nick Vaccaro. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73217 ) Change subject: mb/brya/variant/bb/{brya,hades}/include/ec: Add EC_HOST_EVENT_GPU ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h: https://review.coreboot.org/c/coreboot/+/73217/comment/4283eab6_ee0925e5 PS8, Line 19: EC_HOST_EVENT_GPU > For sure we could wrap this mask in another ifdef here if we feel its absolutely needed. […] You can guard with Kconfig for brya? -- To view, visit https://review.coreboot.org/c/coreboot/+/73217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d7bf52efa9572e1bbd2f307420e09a7398a1ca9 Gerrit-Change-Number: 73217 Gerrit-PatchSet: 8 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 00:40:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
by Kevin Keijzer (Code Review) 05 Mar '23

05 Mar '23

1 0

[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
by Felix Singer (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Kevin Keijzer. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73451 ) Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/73451/comment/f0e1ce85_7d179438 PS2, Line 13: I have "borrowed" the files from the similar h77pro4-m port, which : work fine for the b75pro3-m. I can now adjust things like gfx_uma_size : and power_on_after_fail, which are quite useful to be able to modify. > I can change this, but like I said, it's already merged, so is it still useful to do this? (Feel fre […] It's merged, yes. I think these are just comments to do better next time :) -- To view, visit https://review.coreboot.org/c/coreboot/+/73451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40822f2f7b013b7ac0658d66d7972b447066d593 Gerrit-Change-Number: 73451 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Kevin Keijzer Gerrit-Comment-Date: Mon, 06 Mar 2023 00:33:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Keijzer Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: intelblocks/vtd: Add VT-d block with DMA protection API
by Eric Lai (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Michał Żygowski, Angel Pons. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68449 ) Change subject: intelblocks/vtd: Add VT-d block with DMA protection API ...................................................................... Patch Set 9: (1 comment) File src/soc/intel/common/block/vtd/Makefile.inc: https://review.coreboot.org/c/coreboot/+/68449/comment/d09219d8_8fdaf101 PS9, Line 4: # could be enabled in bootblock already nit:add . in the end -- To view, visit https://review.coreboot.org/c/coreboot/+/68449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7edf982457c1139624e5cd383788eda41d6a948 Gerrit-Change-Number: 68449 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Elias Souza <eliascontato(a)protonmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 00:24:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/*/acpi: drop unneeded mon_alrm FADT assignment
by Eric Lai (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73418 ) Change subject: soc/amd/*/acpi: drop unneeded mon_alrm FADT assignment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73418 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabb5fc7367f1e4e7acea1a58abdb643fc46ca776 Gerrit-Change-Number: 73418 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 00:18:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/*/acpi: drop unneeded pstate_cnt FADT assignment
by Eric Lai (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73419 ) Change subject: soc/amd/*/acpi: drop unneeded pstate_cnt FADT assignment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73419 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3ddb466de1d437361d811e45e328a1dbff02fcc Gerrit-Change-Number: 73419 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 00:17:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
by Kevin Keijzer (Code Review) 05 Mar '23

05 Mar '23

Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73451 ) Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73451/comment/698a385f_5b84719b PS2, Line 9: was lacking > It’d use present tense to describe the current situation: lacks. Well, it's already merged, right? So if you want me to describe the current situation, I should not make this change then. https://review.coreboot.org/c/coreboot/+/73451/comment/8979fed9_556e564b PS2, Line 10: could not > Ditto. Ditto. https://review.coreboot.org/c/coreboot/+/73451/comment/23480ed0_f317375b PS2, Line 13: I have "borrowed" the files from the similar h77pro4-m port, which : work fine for the b75pro3-m. I can now adjust things like gfx_uma_size : and power_on_after_fail, which are quite useful to be able to modify. > I’d write: Borrow the files from …. Now it’s possible to adjust …. I can change this, but like I said, it's already merged, so is it still useful to do this? (Feel free to modify the commit message however you want though.) https://review.coreboot.org/c/coreboot/+/73451/comment/b3381ca1_eecaf366 PS2, Line 18: VGABIOS > Which version. According to `strings`: ``` Intel(R) Sandybridge/Ivybridge PCI Accelerated SVGA BIOS Build Number: 2137 PC 14.34 03/14/2012 20:08:25 ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/73451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40822f2f7b013b7ac0658d66d7972b447066d593 Gerrit-Change-Number: 73451 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 05 Mar 2023 21:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
by Paul Menzel (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Kevin Keijzer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73451 ) Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ...................................................................... Patch Set 2: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73451/comment/9cd05163_d5e627cd PS2, Line 9: was lacking It’d use present tense to describe the current situation: lacks. https://review.coreboot.org/c/coreboot/+/73451/comment/d2e93963_6cb8a8ef PS2, Line 10: could not Ditto. https://review.coreboot.org/c/coreboot/+/73451/comment/6afd23eb_2d8d064a PS2, Line 13: I have "borrowed" the files from the similar h77pro4-m port, which : work fine for the b75pro3-m. I can now adjust things like gfx_uma_size : and power_on_after_fail, which are quite useful to be able to modify. I’d write: Borrow the files from …. Now it’s possible to adjust …. https://review.coreboot.org/c/coreboot/+/73451/comment/505a8154_1b69b47a PS2, Line 18: VGABIOS Which version. Patchset: PS2: Thank you for this improvements. I only have some commit message nit picks. -- To view, visit https://review.coreboot.org/c/coreboot/+/73451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40822f2f7b013b7ac0658d66d7972b447066d593 Gerrit-Change-Number: 73451 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Keijzer Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Kevin Keijzer Gerrit-Comment-Date: Sun, 05 Mar 2023 21:16:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023