coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[S] Change in coreboot[master]: [test]configs: Build test x86_64 on 945G-M4
by build bot (Jenkins) (Code Review) 05 Mar '23

05 Mar '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67924 ) Change subject: [test]configs: Build test x86_64 on 945G-M4 ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide8dbee336ca87eb636c5108ac753f388d2d9ab5 Gerrit-Change-Number: 67924 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Mar 2023 06:10:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/xeon_sp/spr: Add Sapphire Rapids ramstage code
by Johnny Lin (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: TimLiu-SMCI, Johnny Lin, Paul Menzel, Christian Walter, Angel Pons, Jian-Ming Wang, Arthur Heymans, Srinidhi N Kaushik. Johnny Lin has uploaded a new patch set (#10) to the change originally created by Jonathan Zhang. ( https://review.coreboot.org/c/coreboot/+/72443 ) Change subject: soc/intel/xeon_sp/spr: Add Sapphire Rapids ramstage code ...................................................................... soc/intel/xeon_sp/spr: Add Sapphire Rapids ramstage code It implements SPR ramstage including silicon initialization, MSR programming, MP init and certain registers locking before booting to payload. Change-Id: I128fdc6e58c49fb5abf911d6ffa91e7411f6d1e2 Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com> Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/soc/intel/xeon_sp/include/soc/ramstage.h A src/soc/intel/xeon_sp/spr/Makefile.inc A src/soc/intel/xeon_sp/spr/chip.c A src/soc/intel/xeon_sp/spr/chip.h M src/soc/intel/xeon_sp/spr/chipset.cb A src/soc/intel/xeon_sp/spr/cpu.c A src/soc/intel/xeon_sp/spr/crashlog.c A src/soc/intel/xeon_sp/spr/numa.c A src/soc/intel/xeon_sp/spr/ramstage.c A src/soc/intel/xeon_sp/spr/reset.c A src/soc/intel/xeon_sp/spr/xhci.c 11 files changed, 880 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/72443/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/72443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I128fdc6e58c49fb5abf911d6ffa91e7411f6d1e2 Gerrit-Change-Number: 72443 Gerrit-PatchSet: 10 Gerrit-Owner: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: nb/intel/i945: Check if channel 0 and 1 are populated
by build bot (Jenkins) (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68781 ) Change subject: nb/intel/i945: Check if channel 0 and 1 are populated ...................................................................... Patch Set 2: Verified+1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171468): https://review.coreboot.org/c/coreboot/+/68781/comment/810a4ae3_cf6120e0 PS2, Line 10: to true only if channel 0 and 1 are populated. Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/68781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia77861e5f44501b5d92707977597e143b439e9d4 Gerrit-Change-Number: 68781 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 06 Mar 2023 06:09:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [test]: Add 945g-m4 mainboard suport
by Elyes Haouas (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65247 to look at the new patch set (#7). Change subject: [test]: Add 945g-m4 mainboard suport ...................................................................... [test]: Add 945g-m4 mainboard suport Change-Id: I53d47afc971cfb7eda8caf3151fc2450a83943d2 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- A src/mainboard/nec/945g-m4/Kconfig A src/mainboard/nec/945g-m4/Kconfig.name A src/mainboard/nec/945g-m4/Makefile.inc A src/mainboard/nec/945g-m4/acpi/ec.asl A src/mainboard/nec/945g-m4/acpi/ich7_pci_irqs.asl A src/mainboard/nec/945g-m4/acpi/mainboard.asl A src/mainboard/nec/945g-m4/acpi/superio.asl A src/mainboard/nec/945g-m4/board_info.txt A src/mainboard/nec/945g-m4/cmos.default A src/mainboard/nec/945g-m4/cmos.layout A src/mainboard/nec/945g-m4/cstates.c A src/mainboard/nec/945g-m4/devicetree.cb A src/mainboard/nec/945g-m4/dsdt.asl A src/mainboard/nec/945g-m4/early_init.c A src/mainboard/nec/945g-m4/gpio.c A src/mainboard/nec/945g-m4/hda_verb.c A src/mainboard/nec/Kconfig A src/mainboard/nec/Kconfig.name M src/northbridge/intel/i945/raminit.c 19 files changed, 793 insertions(+), 54 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/65247/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/65247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53d47afc971cfb7eda8caf3151fc2450a83943d2 Gerrit-Change-Number: 65247 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: test]: Add intel CPUID F6x support
by Elyes Haouas (Code Review) 05 Mar '23

05 Mar '23

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68782 to look at the new patch set (#2). Change subject: test]: Add intel CPUID F6x support ...................................................................... test]: Add intel CPUID F6x support Change-Id: Iaacb856a0064ea57cdcec11a76fab1cd340e2ed8 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/cpu/intel/Kconfig A src/cpu/intel/model_f6x/Kconfig A src/cpu/intel/model_f6x/Makefile.inc A src/cpu/intel/model_f6x/model_f6x_init.c M src/cpu/intel/socket_LGA775/Kconfig M src/cpu/intel/socket_LGA775/Makefile.inc M src/cpu/intel/speedstep/speedstep.c 7 files changed, 121 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/68782/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaacb856a0064ea57cdcec11a76fab1cd340e2ed8 Gerrit-Change-Number: 68782 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [TestMe]nb/intel/i945: Add support for x86_64
by Elyes Haouas (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Patrick Rudolph, Elyes Haouas. Hello Petr Cvek, build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59758 to look at the new patch set (#13). Change subject: [TestMe]nb/intel/i945: Add support for x86_64 ...................................................................... [TestMe]nb/intel/i945: Add support for x86_64 Change-Id: Idf8fe129d56a95f68d7a9a53ef2dbd37d124aefb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/Kconfig 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/59758/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/59758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8fe129d56a95f68d7a9a53ef2dbd37d124aefb Gerrit-Change-Number: 59758 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in qc_blobs[master]: sc7180/boot: Update qclib blobs binaries from 50 to 53
by Sudheer Amrabadi (Code Review) 05 Mar '23

05 Mar '23

Sudheer Amrabadi has uploaded this change for review. ( https://review.coreboot.org/c/qc_blobs/+/73458 ) Change subject: sc7180/boot: Update qclib blobs binaries from 50 to 53 ...................................................................... sc7180/boot: Update qclib blobs binaries from 50 to 53 TEST=Validated on qualcomm sc7180 development board Signed-off-by: Sudheer Kumar Amrabadi <samrabad(a)codeaurora.org> Change-Id: Id70415361d2de5a2c8e7d215f95675e93a670962 --- M sc7180/boot/QcLib.elf M sc7180/boot/Release_Notes.txt 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/58/73458/1 diff --git a/sc7180/boot/QcLib.elf b/sc7180/boot/QcLib.elf index 0955d75..add1166 100644 --- a/sc7180/boot/QcLib.elf +++ b/sc7180/boot/QcLib.elf Binary files differ diff --git a/sc7180/boot/Release_Notes.txt b/sc7180/boot/Release_Notes.txt index 0f0098e..0066635 100644 --- a/sc7180/boot/Release_Notes.txt +++ b/sc7180/boot/Release_Notes.txt @@ -1,3 +1,25 @@ +=================== Release 00053 ================================ +This Release Notes file covers these blobs: + * QcLib.elf + +Version : 00053 + +Release Date : Mar, 2023 + +Supported Silicon : SC7180 + +No special instructions, requirements or dependencies, files must be +present in this folder to be pulled in during coreboot build + +Changes since last version : + * Fix for QSIP Gen2 Hynix failures over Factory test at mission mode + +Errata : Nothing to report + +Toolchain Version : LLVM 12.0.0 + +ABI Info : see qclib-interface.txt + =================== Release 00050 ================================ This Release Notes file covers these blobs: * QcLib.elf -- To view, visit https://review.coreboot.org/c/qc_blobs/+/73458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: Id70415361d2de5a2c8e7d215f95675e93a670962 Gerrit-Change-Number: 73458 Gerrit-PatchSet: 1 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
by Yidi Lin (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: cong yang, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73443 ) Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/73443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948 Gerrit-Change-Number: 73443 Gerrit-PatchSet: 4 Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 06:04:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
by Rex-BC Chen (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: cong yang, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73443 ) Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/73443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948 Gerrit-Change-Number: 73443 Gerrit-PatchSet: 4 Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 05:45:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
by cong yang (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73443 ) Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM ...................................................................... Patch Set 4: (2 comments) File src/mainboard/google/geralt/display.c: https://review.coreboot.org/c/coreboot/+/73443/comment/64279735_74c4e2ff PS3, Line 41: > remove one blank line Done https://review.coreboot.org/c/coreboot/+/73443/comment/ab9e92bf_63fac1c3 PS3, Line 42: printk(BIOS_INFO, "Just set AVDD AVEE 5.7V to EEPROM Data in first time.\n"); > one blank line below Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948 Gerrit-Change-Number: 73443 Gerrit-PatchSet: 4 Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 05:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023